Rev 1 | Ir a la última revisión | Autoría | Comparar con el anterior | Ultima modificación | Ver Log |
<?php// This file is part of Moodle - http://moodle.org///// Moodle is free software: you can redistribute it and/or modify// it under the terms of the GNU General Public License as published by// the Free Software Foundation, either version 3 of the License, or// (at your option) any later version.//// Moodle is distributed in the hope that it will be useful,// but WITHOUT ANY WARRANTY; without even the implied warranty of// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the// GNU General Public License for more details.//// You should have received a copy of the GNU General Public License// along with Moodle. If not, see <http://www.gnu.org/licenses/>.namespace core_question;use question_bank;use question_hint;use question_test_recordset;use question_usage_by_activity;use testable_question_engine_unit_of_work;defined('MOODLE_INTERNAL') || die();global $CFG;require_once(__DIR__ . '/../lib.php');require_once(__DIR__ . '/helpers.php');/*** Unit tests for the {@link question_engine_unit_of_work} class.** @package core_question* @category test* @copyright 2012 The Open University* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later*/class unitofwork_test extends \data_loading_method_test_base {/** @var question_usage_by_activity the test question usage. */protected $quba;/** @var int the slot number of the one qa in the test usage.*/protected $slot;/** @var testable_question_engine_unit_of_work the unit of work we are testing. */protected $observer;protected function setUp(): void {// Create a usage in an initial state, with one shortanswer question added,// and attempted in interactive mode submitted responses 'toad' then 'frog'.// Then set it to use a new unit of work for any subsequent changes.// Create a short answer question.$question = \test_question_maker::make_question('shortanswer');$question->hints = array(new question_hint(0, 'This is the first hint.', FORMAT_HTML),new question_hint(0, 'This is the second hint.', FORMAT_HTML),);$question->id = -1;question_bank::start_unit_test();question_bank::load_test_question_data($question);$this->setup_initial_test_state($this->get_test_data());}public function tearDown(): void {question_bank::end_unit_test();}protected function setup_initial_test_state($testdata) {$records = new question_test_recordset($testdata);$this->quba = question_usage_by_activity::load_from_records($records, 1);$this->slot = 1;$this->observer = new testable_question_engine_unit_of_work($this->quba);$this->quba->set_observer($this->observer);}protected function get_test_data() {return array(array('qubaid', 'contextid', 'component', 'preferredbehaviour','questionattemptid', 'contextid', 'questionusageid', 'slot','behaviour', 'questionid', 'variant', 'maxmark', 'minfraction', 'maxfraction', 'flagged','questionsummary', 'rightanswer', 'responsesummary', 'timemodified','attemptstepid', 'sequencenumber', 'state', 'fraction','timecreated', 'userid', 'name', 'value'),array(1, 1, 'unit_test', 'interactive', 1, 123, 1, 1, 'interactive', -1, 1, 1.0000000, 0.0000000, 1.0000000, 0, '', '', '', 1256233790, 1, 0, 'todo', null, 1256233700, 1, '-_triesleft', 3),array(1, 1, 'unit_test', 'interactive', 1, 123, 1, 1, 'interactive', -1, 1, 1.0000000, 0.0000000, 1.0000000, 0, '', '', '', 1256233790, 2, 1, 'todo', null, 1256233720, 1, 'answer', 'toad'),array(1, 1, 'unit_test', 'interactive', 1, 123, 1, 1, 'interactive', -1, 1, 1.0000000, 0.0000000, 1.0000000, 0, '', '', '', 1256233790, 2, 1, 'todo', null, 1256233720, 1, '-submit', 1),array(1, 1, 'unit_test', 'interactive', 1, 123, 1, 1, 'interactive', -1, 1, 1.0000000, 0.0000000, 1.0000000, 0, '', '', '', 1256233790, 2, 1, 'todo', null, 1256233720, 1, '-_triesleft', 1),array(1, 1, 'unit_test', 'interactive', 1, 123, 1, 1, 'interactive', -1, 1, 1.0000000, 0.0000000, 1.0000000, 0, '', '', '', 1256233790, 3, 2, 'todo', null, 1256233740, 1, '-tryagain', 1),array(1, 1, 'unit_test', 'interactive', 1, 123, 1, 1, 'interactive', -1, 1, 1.0000000, 0.0000000, 1.0000000, 0, '', '', '', 1256233790, 5, 3, 'gradedright', 0.6666667, 1256233790, 1, 'answer', 'frog'),array(1, 1, 'unit_test', 'interactive', 1, 123, 1, 1, 'interactive', -1, 1, 1.0000000, 0.0000000, 1.0000000, 0, '', '', '', 1256233790, 5, 3, 'gradedright', 0.6666667, 1256233790, 1, '-submit', 1),);}public function test_initial_state(): void {$this->assertFalse($this->observer->get_modified());$this->assertEquals(0, count($this->observer->get_attempts_added()));$this->assertEquals(0, count($this->observer->get_attempts_modified()));$this->assertEquals(0, count($this->observer->get_steps_added()));$this->assertEquals(0, count($this->observer->get_steps_modified()));$this->assertEquals(0, count($this->observer->get_steps_deleted()));$this->assertEquals(0, count($this->observer->get_metadata_added()));$this->assertEquals(0, count($this->observer->get_metadata_modified()));}public function test_update_usage(): void {$this->quba->set_preferred_behaviour('deferredfeedback');$this->assertTrue($this->observer->get_modified());}public function test_add_question(): void {$slot = $this->quba->add_question(\test_question_maker::make_question('truefalse'));$newattempts = $this->observer->get_attempts_added();$this->assertEquals(1, count($newattempts));$this->assertTrue($this->quba->get_question_attempt($slot) === reset($newattempts));$this->assertSame($slot, key($newattempts));$this->assertEquals(0, count($this->observer->get_metadata_added()));$this->assertEquals(0, count($this->observer->get_metadata_modified()));}public function test_add_and_start_question(): void {$slot = $this->quba->add_question(\test_question_maker::make_question('truefalse'));$this->quba->start_question($slot);// The point here is that, although we have added a step, it is not listed// separately becuase it is part of a newly added attempt, and all steps// for a newly added attempt are automatically added to the DB, so it does// not need to be tracked separately.$newattempts = $this->observer->get_attempts_added();$this->assertEquals(1, count($newattempts));$this->assertTrue($this->quba->get_question_attempt($slot) === reset($newattempts));$this->assertSame($slot, key($newattempts));$this->assertEquals(0, count($this->observer->get_steps_added()));$this->assertEquals(0, count($this->observer->get_metadata_added()));$this->assertEquals(0, count($this->observer->get_metadata_modified()));}public function test_process_action(): void {$this->quba->manual_grade($this->slot, 'Actually, that is not quite right', 0.5, FORMAT_HTML);// Here, however, were we are adding a step to an existing qa, we do need to track that.$this->assertEquals(0, count($this->observer->get_attempts_added()));$updatedattempts = $this->observer->get_attempts_modified();$this->assertEquals(1, count($updatedattempts));$updatedattempt = reset($updatedattempts);$this->assertTrue($this->quba->get_question_attempt($this->slot) === $updatedattempt);$this->assertSame($this->slot, key($updatedattempts));$newsteps = $this->observer->get_steps_added();$this->assertEquals(1, count($newsteps));list($newstep, $qaid, $seq) = reset($newsteps);$this->assertSame($this->quba->get_question_attempt($this->slot)->get_last_step(), $newstep);$this->assertEquals(0, count($this->observer->get_metadata_added()));$this->assertEquals(0, count($this->observer->get_metadata_modified()));}public function test_regrade_same_steps(): void {// Change the question in a minor way and regrade.$this->quba->get_question($this->slot, false)->answers[14]->fraction = 0.5;$this->quba->regrade_all_questions();// Here, the qa, and all the steps, should be marked as updated.// Here, however, were we are adding a step to an existing qa, we do need to track that.$this->assertEquals(0, count($this->observer->get_attempts_added()));$this->assertEquals(0, count($this->observer->get_steps_added()));$this->assertEquals(0, count($this->observer->get_steps_deleted()));$updatedattempts = $this->observer->get_attempts_modified();$this->assertEquals(1, count($updatedattempts));$updatedattempt = reset($updatedattempts);$this->assertTrue($this->quba->get_question_attempt($this->slot) === $updatedattempt);$updatedsteps = $this->observer->get_steps_modified();$this->assertEquals($updatedattempt->get_num_steps(), count($updatedsteps));foreach ($updatedattempt->get_step_iterator() as $seq => $step) {$this->assertSame(array($step, $updatedattempt->get_database_id(), $seq),$updatedsteps[$seq]);}$this->assertEquals(0, count($this->observer->get_metadata_added()));$this->assertEquals(0, count($this->observer->get_metadata_modified()));}public function test_regrade_losing_steps(): void {// Change the question so that 'toad' is also right, and regrade. This// will mean that the try again, and second try states are no longer// needed, so they should be dropped.$this->quba->get_question($this->slot, false)->answers[14]->fraction = 1;$this->quba->regrade_all_questions();$this->assertEquals(0, count($this->observer->get_attempts_added()));$this->assertEquals(0, count($this->observer->get_steps_added()));$updatedattempts = $this->observer->get_attempts_modified();$this->assertEquals(1, count($updatedattempts));$updatedattempt = reset($updatedattempts);$this->assertTrue($this->quba->get_question_attempt($this->slot) === $updatedattempt);$updatedsteps = $this->observer->get_steps_modified();$this->assertEquals($updatedattempt->get_num_steps(), count($updatedsteps));foreach ($updatedattempt->get_step_iterator() as $seq => $step) {$this->assertSame(array($step, $updatedattempt->get_database_id(), $seq),$updatedsteps[$seq]);}$deletedsteps = $this->observer->get_steps_deleted();$this->assertEquals(2, count($deletedsteps));$firstdeletedstep = reset($deletedsteps);$this->assertEquals(array('-tryagain' => 1), $firstdeletedstep->get_all_data());$seconddeletedstep = end($deletedsteps);$this->assertEquals(array('answer' => 'frog', '-submit' => 1),$seconddeletedstep->get_all_data());$this->assertEquals(0, count($this->observer->get_metadata_added()));$this->assertEquals(0, count($this->observer->get_metadata_modified()));}public function test_tricky_regrade(): void {// The tricky thing here is that we take a half-complete question-attempt,// and then as one transaction, we submit some more responses, and then// change the question attempt as in test_regrade_losing_steps, and regrade// before the steps are even written to the database the first time.$somedata = $this->get_test_data();$somedata = array_slice($somedata, 0, 5);$this->setup_initial_test_state($somedata);$this->quba->process_action($this->slot, array('-tryagain' => 1));$this->quba->process_action($this->slot, array('answer' => 'frog', '-submit' => 1));$this->quba->finish_all_questions();$this->quba->get_question($this->slot, false)->answers[14]->fraction = 1;$this->quba->regrade_all_questions();$this->assertEquals(0, count($this->observer->get_attempts_added()));$updatedattempts = $this->observer->get_attempts_modified();$this->assertEquals(1, count($updatedattempts));$updatedattempt = reset($updatedattempts);$this->assertTrue($this->quba->get_question_attempt($this->slot) === $updatedattempt);$this->assertEquals(0, count($this->observer->get_steps_added()));$updatedsteps = $this->observer->get_steps_modified();$this->assertEquals($updatedattempt->get_num_steps(), count($updatedsteps));foreach ($updatedattempt->get_step_iterator() as $seq => $step) {$this->assertSame(array($step, $updatedattempt->get_database_id(), $seq),$updatedsteps[$seq]);}$this->assertEquals(0, count($this->observer->get_steps_deleted()));$this->assertEquals(0, count($this->observer->get_metadata_added()));$this->assertEquals(0, count($this->observer->get_metadata_modified()));}public function test_move_question(): void {$q = \test_question_maker::make_question('truefalse');$newslot = $this->quba->add_question_in_place_of_other($this->slot, $q);$this->quba->start_question($this->slot);$addedattempts = $this->observer->get_attempts_added();$this->assertEquals(1, count($addedattempts));$addedattempt = reset($addedattempts);$this->assertSame($this->quba->get_question_attempt($this->slot), $addedattempt);$updatedattempts = $this->observer->get_attempts_modified();$this->assertEquals(1, count($updatedattempts));$updatedattempt = reset($updatedattempts);$this->assertSame($this->quba->get_question_attempt($newslot), $updatedattempt);$this->assertEquals(0, count($this->observer->get_steps_added()));$this->assertEquals(0, count($this->observer->get_steps_modified()));$this->assertEquals(0, count($this->observer->get_steps_deleted()));$this->assertEquals(0, count($this->observer->get_metadata_added()));$this->assertEquals(0, count($this->observer->get_metadata_modified()));}public function test_move_question_then_modify(): void {$q = \test_question_maker::make_question('truefalse');$newslot = $this->quba->add_question_in_place_of_other($this->slot, $q);$this->quba->start_question($this->slot);$this->quba->process_action($this->slot, array('answer' => 'frog', '-submit' => 1));$this->quba->manual_grade($newslot, 'Test', 0.5, FORMAT_HTML);$addedattempts = $this->observer->get_attempts_added();$this->assertEquals(1, count($addedattempts));$addedattempt = reset($addedattempts);$this->assertSame($this->quba->get_question_attempt($this->slot), $addedattempt);$updatedattempts = $this->observer->get_attempts_modified();$this->assertEquals(1, count($updatedattempts));$updatedattempt = reset($updatedattempts);$this->assertSame($this->quba->get_question_attempt($newslot), $updatedattempt);$newsteps = $this->observer->get_steps_added();$this->assertEquals(1, count($newsteps));list($newstep, $qaid, $seq) = reset($newsteps);$this->assertSame($this->quba->get_question_attempt($newslot)->get_last_step(), $newstep);$this->assertEquals(0, count($this->observer->get_steps_modified()));$this->assertEquals(0, count($this->observer->get_steps_deleted()));$this->assertEquals(0, count($this->observer->get_metadata_added()));$this->assertEquals(0, count($this->observer->get_metadata_modified()));}public function test_move_question_then_move_again(): void {$originalqa = $this->quba->get_question_attempt($this->slot);$q1 = \test_question_maker::make_question('truefalse');$newslot = $this->quba->add_question_in_place_of_other($this->slot, $q1);$this->quba->start_question($this->slot);$q2 = \test_question_maker::make_question('truefalse');$newslot2 = $this->quba->add_question_in_place_of_other($newslot, $q2);$this->quba->start_question($newslot);$addedattempts = $this->observer->get_attempts_added();$this->assertEquals(2, count($addedattempts));$updatedattempts = $this->observer->get_attempts_modified();$this->assertEquals(1, count($updatedattempts));$updatedattempt = reset($updatedattempts);$this->assertSame($originalqa, $updatedattempt);$this->assertEquals(0, count($this->observer->get_steps_added()));$this->assertEquals(0, count($this->observer->get_steps_modified()));$this->assertEquals(0, count($this->observer->get_steps_deleted()));$this->assertEquals(0, count($this->observer->get_metadata_added()));$this->assertEquals(0, count($this->observer->get_metadata_modified()));}public function test_set_max_mark(): void {$this->quba->set_max_mark($this->slot, 6.0);$this->assertEqualsWithDelta(4.0, $this->quba->get_total_mark(), 0.0000005);$this->assertEquals(0, count($this->observer->get_attempts_added()));$updatedattempts = $this->observer->get_attempts_modified();$this->assertEquals(1, count($updatedattempts));$updatedattempt = reset($updatedattempts);$this->assertSame($this->quba->get_question_attempt($this->slot), $updatedattempt);$this->assertEquals(0, count($this->observer->get_steps_added()));$this->assertEquals(0, count($this->observer->get_steps_modified()));$this->assertEquals(0, count($this->observer->get_steps_deleted()));$this->assertEquals(0, count($this->observer->get_metadata_added()));$this->assertEquals(0, count($this->observer->get_metadata_modified()));}public function test_set_question_attempt_metadata(): void {$this->quba->set_question_attempt_metadata($this->slot, 'metathingy', 'a value');$this->assertEquals('a value', $this->quba->get_question_attempt_metadata($this->slot, 'metathingy'));$this->assertEquals(0, count($this->observer->get_attempts_added()));$this->assertEquals(0, count($this->observer->get_attempts_modified()));$this->assertEquals(0, count($this->observer->get_steps_added()));$this->assertEquals(0, count($this->observer->get_steps_modified()));$this->assertEquals(0, count($this->observer->get_steps_deleted()));$this->assertEquals(array($this->slot => array('metathingy' => $this->quba->get_question_attempt($this->slot))),$this->observer->get_metadata_added());$this->assertEquals(0, count($this->observer->get_metadata_modified()));}public function test_set_question_attempt_metadata_then_change(): void {$this->quba->set_question_attempt_metadata($this->slot, 'metathingy', 'a value');$this->quba->set_question_attempt_metadata($this->slot, 'metathingy', 'different value');$this->assertEquals('different value', $this->quba->get_question_attempt_metadata($this->slot, 'metathingy'));$this->assertEquals(0, count($this->observer->get_attempts_added()));$this->assertEquals(0, count($this->observer->get_attempts_modified()));$this->assertEquals(0, count($this->observer->get_steps_added()));$this->assertEquals(0, count($this->observer->get_steps_modified()));$this->assertEquals(0, count($this->observer->get_steps_deleted()));$this->assertEquals(array($this->slot => array('metathingy' => $this->quba->get_question_attempt($this->slot))),$this->observer->get_metadata_added());$this->assertEquals(0, count($this->observer->get_metadata_modified()));}public function test_set_metadata_previously_set_but_dont_actually_change(): void {$this->quba->set_question_attempt_metadata($this->slot, 'metathingy', 'a value');$this->observer = new testable_question_engine_unit_of_work($this->quba);$this->quba->set_observer($this->observer);$this->quba->set_question_attempt_metadata($this->slot, 'metathingy', 'a value');$this->assertEquals('a value', $this->quba->get_question_attempt_metadata($this->slot, 'metathingy'));$this->assertEquals(0, count($this->observer->get_attempts_added()));$this->assertEquals(0, count($this->observer->get_attempts_modified()));$this->assertEquals(0, count($this->observer->get_steps_added()));$this->assertEquals(0, count($this->observer->get_steps_modified()));$this->assertEquals(0, count($this->observer->get_steps_deleted()));$this->assertEquals(0, count($this->observer->get_metadata_added()));$this->assertEquals(0, count($this->observer->get_metadata_modified()));}public function test_set_metadata_previously_set(): void {$this->quba->set_question_attempt_metadata($this->slot, 'metathingy', 'a value');$this->observer = new testable_question_engine_unit_of_work($this->quba);$this->quba->set_observer($this->observer);$this->quba->set_question_attempt_metadata($this->slot, 'metathingy', 'different value');$this->assertEquals('different value', $this->quba->get_question_attempt_metadata($this->slot, 'metathingy'));$this->assertEquals(0, count($this->observer->get_attempts_added()));$this->assertEquals(0, count($this->observer->get_attempts_modified()));$this->assertEquals(0, count($this->observer->get_steps_added()));$this->assertEquals(0, count($this->observer->get_steps_modified()));$this->assertEquals(0, count($this->observer->get_steps_deleted()));$this->assertEquals(0, count($this->observer->get_metadata_added()));$this->assertEquals(array($this->slot => array('metathingy' => $this->quba->get_question_attempt($this->slot))),$this->observer->get_metadata_modified());}public function test_set_metadata_in_new_question(): void {$newslot = $this->quba->add_question(\test_question_maker::make_question('truefalse'));$this->quba->start_question($newslot);$this->quba->set_question_attempt_metadata($newslot, 'metathingy', 'a value');$this->assertEquals('a value', $this->quba->get_question_attempt_metadata($newslot, 'metathingy'));$this->assertEquals(array($newslot => $this->quba->get_question_attempt($newslot)),$this->observer->get_attempts_added());$this->assertEquals(0, count($this->observer->get_attempts_modified()));$this->assertEquals(0, count($this->observer->get_steps_added()));$this->assertEquals(0, count($this->observer->get_steps_modified()));$this->assertEquals(0, count($this->observer->get_steps_deleted()));$this->assertEquals(0, count($this->observer->get_metadata_added()));$this->assertEquals(0, count($this->observer->get_metadata_modified()));}public function test_set_metadata_then_move(): void {$this->quba->set_question_attempt_metadata($this->slot, 'metathingy', 'a value');$q = \test_question_maker::make_question('truefalse');$newslot = $this->quba->add_question_in_place_of_other($this->slot, $q);$this->quba->start_question($this->slot);$this->assertEquals('a value', $this->quba->get_question_attempt_metadata($newslot, 'metathingy'));$this->assertEquals(array($this->slot => $this->quba->get_question_attempt($this->slot)),$this->observer->get_attempts_added());$this->assertEquals(array($newslot => $this->quba->get_question_attempt($newslot)),$this->observer->get_attempts_modified());$this->assertEquals(0, count($this->observer->get_steps_added()));$this->assertEquals(0, count($this->observer->get_steps_modified()));$this->assertEquals(0, count($this->observer->get_steps_deleted()));$this->assertEquals(array($newslot => array('metathingy' => $this->quba->get_question_attempt($newslot))),$this->observer->get_metadata_added());$this->assertEquals(0, count($this->observer->get_metadata_modified()));}public function test_move_then_set_metadata(): void {$q = \test_question_maker::make_question('truefalse');$newslot = $this->quba->add_question_in_place_of_other($this->slot, $q);$this->quba->start_question($this->slot);$this->quba->set_question_attempt_metadata($newslot, 'metathingy', 'a value');$this->assertEquals('a value', $this->quba->get_question_attempt_metadata($newslot, 'metathingy'));$this->assertEquals(array($this->slot => $this->quba->get_question_attempt($this->slot)),$this->observer->get_attempts_added());$this->assertEquals(array($newslot => $this->quba->get_question_attempt($newslot)),$this->observer->get_attempts_modified());$this->assertEquals(0, count($this->observer->get_steps_added()));$this->assertEquals(0, count($this->observer->get_steps_modified()));$this->assertEquals(0, count($this->observer->get_steps_deleted()));$this->assertEquals(array($newslot => array('metathingy' => $this->quba->get_question_attempt($newslot))),$this->observer->get_metadata_added());}/*** Test add_question_in_place_of_other function.** @covers ::add_question_in_place_of_other*/public function test_replace_old_attempt(): void {// Create a new question.$q = \test_question_maker::make_question('truefalse');$currentquestion = $this->quba->get_question_attempt($this->slot)->get_question();// Replace the current question in the slot with a new one.$slot = $this->quba->add_question_in_place_of_other($this->slot, $q, null, false);$newquestion = $this->quba->get_question_attempt($slot)->get_question();$this->assertEquals($this->slot, $slot);$this->assertEquals($q->name, $newquestion->name);$this->assertCount(4, $this->observer->get_steps_deleted());$this->assertCount(1, $this->observer->get_attempts_modified());$this->assertCount(0, $this->observer->get_attempts_added());$this->assertNotEquals($currentquestion->id, $newquestion->id);}}