WebSVN – Moodle – Diff – /user/tests/reportbuilder/datasource/users_test.php

 declare(strict_types=1);
 namespace core_user\reportbuilder\datasource;
+namespace core_user\reportbuilder\datasource;
-use core_reportbuilder_testcase;
-use core_reportbuilder_generator;
-use core_reportbuilder\local\filters\boolean_select;
-use core_reportbuilder\local\filters\date;
-use core_reportbuilder\local\filters\select;
-use core_reportbuilder\local\filters\tags;
-use core_reportbuilder\local\filters\text;
-use core_reportbuilder\local\filters\user as user_filter;
-defined('MOODLE_INTERNAL') || die();
 use core_reportbuilder_generator;
-global $CFG;
+use core_reportbuilder\local\filters\{boolean_select, date, select, tags, text, user as user_filter};
-require_once("{$CFG->dirroot}/reportbuilder/tests/helpers.php");
+use core_reportbuilder\tests\core_reportbuilder_testcase;
 /**
  * Unit tests for users datasource
+ *
  * @package     core_user
  * @covers      \core_user\reportbuilder\datasource\users
  * @copyright   2022 Paul Holden <paulh@moodle.com>
  * @license     http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class users_test extends core_reportbuilder_testcase {
+final class users_test extends core_reportbuilder_testcase {
         $user = $this->getDataGenerator()->create_user([
             'firstname' => 'Zoe',
             'idnumber' => 'U0001',
             'city' => 'London',
             'country' => 'GB',
+            'lang' => 'en',
+            'timezone' => 'Europe/London',
             'theme' => 'boost',
             'interests' => ['Horses'],
         ]);
         $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:picture']);
         $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:firstname']);
         $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:lastname']);
         $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:city']);
         $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:country']);
+        $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:lang']);
+        $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:timezone']);
         $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:description']);
         $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:firstnamephonetic']);
         $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:lastnamephonetic']);
         $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:middlename']);
         $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:alternatename']);
             $picture,
             $firstname,
             $lastname,
             $city,
             $country,
+            $lang,
+            $timezone,
             $description,
             $firstnamephonetic,
             $lastnamephonetic,
             $middlename,
             $alternatename,
         $this->assertNotEmpty($picture);
         $this->assertEquals($user->firstname, $firstname);
         $this->assertEquals($user->lastname, $lastname);
         $this->assertEquals($user->city, $city);
         $this->assertEquals('United Kingdom', $country);
+        $this->assertEquals('English â€Ž(en)â€Ž', $lang);
+        $this->assertEquals('Europe/London', $timezone);
         $this->assertEquals($user->description, $description);
         $this->assertEquals($user->firstnamephonetic, $firstnamephonetic);
         $this->assertEquals($user->lastnamephonetic, $lastnamephonetic);
         $this->assertEquals($user->middlename, $middlename);
         $this->assertEquals($user->alternatename, $alternatename);
         $this->assertEquals('Horses', $tag);
         $this->assertEquals($cohort->name, $cohortname);
+    }
+    /**
+     * Test fullname columns when alternative fullname format is configured
+     */
+    public function test_datasource_alternative_fullname_columns(): void {
+        $this->resetAfterTest();
+        $this->setAdminUser();
+        set_config('alternativefullnameformat', '(alternatename) firstname lastname');
+        $this->getDataGenerator()->create_user(['firstname' => 'John', 'lastname' => 'Smith', 'alternatename' => 'JS']);
+        /** @var core_reportbuilder_generator $generator */
+        $generator = $this->getDataGenerator()->get_plugin_generator('core_reportbuilder');
+        $report = $generator->create_report(['name' => 'Users', 'source' => users::class, 'default' => 0]);
+        $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:fullname', 'sortenabled' => 1]);
+        $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:fullnamewithlink']);
+        $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:fullnamewithpicture']);
+        $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:fullnamewithpicturelink']);
+        $content = $this->get_custom_report_content($report->get('id'));
+        $this->assertCount(2, $content);
+        // Admin row.
+        [
+            $fullname,
+            $fullnamewithlink,
+            $fullnamewithpicture,
+            $fullnamewithpicturelink
+        ] = array_values($content[0]);
+        $this->assertEquals('Admin User', $fullname);
+        $this->assertStringContainsString('Admin User', $fullnamewithlink);
+        $this->assertStringContainsString('Admin User', $fullnamewithpicture);
+        $this->assertStringContainsString('Admin User', $fullnamewithpicturelink);
+        // User row.
+        [
+            $fullname,
+            $fullnamewithlink,
+            $fullnamewithpicture,
+            $fullnamewithpicturelink
+        ] = array_values($content[1]);
+        $this->assertEquals('(JS) John Smith', $fullname);
+        $this->assertStringContainsString('(JS) John Smith', $fullnamewithlink);
+        $this->assertStringContainsString('(JS) John Smith', $fullnamewithpicture);
+        $this->assertStringContainsString('(JS) John Smith', $fullnamewithpicturelink);
+    }
     /**
      * Data provider for {@see test_datasource_filters}
+     *
      * @return array[]
      */
-    public function datasource_filters_provider(): array {
+    public static function datasource_filters_provider(): array {
         return [
             // User.
             'Filter user' => ['user:userselect', [
                 'user:userselect_operator' => user_filter::USER_SELECT,
             ], true],
             'Filter fullname (no match)' => ['user:fullname', [
                 'user:fullname_operator' => text::CONTAINS,
                 'user:fullname_value' => 'Alfie',
             ], false],
+            'Filter picture' => ['user:picture', [
+                'user:picture_operator' => boolean_select::NOT_CHECKED,
+            ], true],
+            'Filter picture (no match)' => ['user:picture', [
+                'user:picture_operator' => boolean_select::CHECKED,
+            ], false],
             'Filter firstname' => ['user:firstname', [
                 'user:firstname_operator' => text::IS_EQUAL_TO,
                 'user:firstname_value' => 'Zoe',
             ], true],
             'Filter firstname (no match)' => ['user:firstname', [
             ], true],
             'Filter country (no match)' => ['user:country', [
                 'user:country_operator' => select::EQUAL_TO,
                 'user:country_value' => 'AU',
             ], false],
+            'Filter lang' => ['user:lang', [
+                'user:lang_operator' => select::EQUAL_TO,
+                'user:lang_value' => 'en',
+            ], true],
+            'Filter lang (no match)' => ['user:lang', [
+                'user:lang_operator' => select::NOT_EQUAL_TO,
+                'user:lang_value' => 'en',
+            ], false],
+            'Filter timezone' => ['user:timezone', [
+                'user:timezone_operator' => select::EQUAL_TO,
+                'user:timezone_value' => 'Europe/Barcelona',
+            ], true],
+            'Filter timezone (no match)' => ['user:timezone', [
+                'user:timezone_operator' => select::EQUAL_TO,
+                'user:timezone_value' => 'Australia/Perth',
+            ], false],
             'Filter theme' => ['user:theme', [
                 'user:theme_operator' => select::EQUAL_TO,
                 'user:theme_value' => 'boost',
             ], true],
             'Filter theme (no match)' => ['user:theme', [
             'phone1' => '111',
             'phone2' => '222',
             'address' => 'Big Farm',
             'city' => 'Barcelona',
             'country' => 'ES',
+            'lang' => 'en',
+            'timezone' => 'Europe/Barcelona',
             'theme' => 'boost',
             'description' => 'Hello there',
             'moodlenetprofile' => '@zoe1@example.com',
             'interests' => ['Horses'],
             'lastip' => '0.0.0.0',
         /** @var core_reportbuilder_generator $generator */
         $generator = $this->getDataGenerator()->get_plugin_generator('core_reportbuilder');
         // Create report containing single column, and given filter.
-        $report = $generator->create_report(['name' => 'Tasks', 'source' => users::class, 'default' => 0]);
+        $report = $generator->create_report(['name' => 'Users', 'source' => users::class, 'default' => 0]);
         $generator->create_column(['reportid' => $report->get('id'), 'uniqueidentifier' => 'user:username']);

Proyectos de Subversion Moodle

(root)/user/tests/reportbuilder/datasource/users_test.php – Rev 1 → 1441