WebSVN – Moodle – Diff – /search/tests/manager_test.php

  * @package     core_search
  * @category    phpunit
  * @copyright   2015 David Monllao {@link http://www.davidmonllao.com}
  * @license     http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class manager_test extends \advanced_testcase {
+final class manager_test extends \advanced_testcase {
     /**
      * Forum area id.
+     *
      * @var string
      */
     protected $coursesareaid = null;
+    public function setUp(): void {
-    public function setUp(): void {
+        parent::setUp();
         $this->forumpostareaid = \core_search\manager::generate_areaid('mod_forum', 'post');
         $this->coursesareaid = \core_search\manager::generate_areaid('core_course', 'course');
+    }
     /**
      * Data for the test_course_search_url test.
+     *
      * @return array[]
      */
-    public function data_course_search_url(): array {
+    public static function data_course_search_url(): array {
         return [
             'defaults' => [null, null, null, '/course/search.php'],
             'enabled' => [true, true, true, '/search/index.php'],
             'no all courses, no search area' => [true, false, false, '/course/search.php'],
             'no search area' => [true, true, false, '/course/search.php'],
     /**
      * Data for the test_can_replace_course_search test.
+     *
      * @return array[]
      */
-    public function data_can_replace_course_search(): array {
+    public static function data_can_replace_course_search(): array {
         return [
             'defaults' => [null, null, null, false],
             'enabled' => [true, true, true, true],
             'no all courses, no search area' => [true, false, false, false],
             'no search area' => [true, true, false, false],
     /**
      * Test data for test_parse_areaid test fucntion.
+     *
      * @return array
      */
-    public function parse_search_area_id_data_provider() {
+    public static function parse_search_area_id_data_provider(): array {
         return [
             ['mod_book-chapter', ['mod_book', 'search_chapter']],
             ['mod_customcert-activity', ['mod_customcert', 'search_activity']],
             ['core_course-mycourse', ['core_search', 'core_course_mycourse']],
         ];
             ['context', $usercontext->id],
             ['context', $context5->id]
         ];
         $this->assertEquals($expected, $search->get_engine()->get_and_clear_deletes());
+    }
+    /**
+     * Tests the indexing delay (used to avoid race conditions) in {@see manager::index()}.
+     *
+     * @covers \core_search\manager::index
+     */
+    public function test_indexing_delay(): void {
+        global $USER, $CFG;
+        $this->resetAfterTest();
+        // Normally the indexing delay is turned off for test scripts because we don't want to have
+        // to wait 5 seconds after creating anything to index it and it's not like there will be a
+        // race condition (indexing doesn't run at same time as adding). This turns it on.
+        $CFG->searchindexingdelayfortestscript = true;
+        $this->setAdminUser();
+        // Create a course and a forum.
+        $generator = $this->getDataGenerator();
+        $course = $generator->create_course();
+        $forum = $generator->create_module('forum', ['course' => $course->id]);
+        // Skip ahead 5 seconds so everything gets indexed.
+        $now = time();
+        $now += manager::INDEXING_DELAY;
+        $search = \testable_core_search::instance();
+        $search->fake_current_time($now);
+        $search->index();
+        $search->get_engine()->get_and_clear_added_documents();
+        // Basic discussion data.
+        $basicdata = [
+            'course' => $course->id,
+            'forum' => $forum->id,
+            'userid' => $USER->id,
+        ];
+        // Discussion so old it's prior to indexing delay (not realistic).
+        $generator->get_plugin_generator('mod_forum')->create_discussion(array_merge($basicdata,
+            ['timemodified' => $now - manager::INDEXING_DELAY, 'name' => 'Frog']));
+        // Discussion just within indexing delay (simulates if it took a while to add to database).
+        $generator->get_plugin_generator('mod_forum')->create_discussion(array_merge($basicdata,
+            ['timemodified' => $now - (manager::INDEXING_DELAY - 1), 'name' => 'Toad']));
+        // Move time along a bit.
+        $now += 100;
+        $search->fake_current_time($now);
+        // Discussion that happened 5 seconds before the new now.
+        $generator->get_plugin_generator('mod_forum')->create_discussion(array_merge($basicdata,
+            ['timemodified' => $now - (manager::INDEXING_DELAY), 'name' => 'Zombie']));
+        // This one only happened 4 seconds before so it shouldn't be indexed yet.
+        $generator->get_plugin_generator('mod_forum')->create_discussion(array_merge($basicdata,
+            ['timemodified' => $now - (manager::INDEXING_DELAY - 1), 'name' => 'Werewolf']));
+        // Reindex and check that it added the middle two discussions.
+        $search->index();
+        $added = $search->get_engine()->get_and_clear_added_documents();
+        $this->assertCount(2, $added);
+        $this->assertEquals('Toad', $added[0]->get('title'));
+        $this->assertEquals('Zombie', $added[1]->get('title'));
+        // Move time forwards a couple of seconds and now the last one will get indexed.
+        $now += 2;
+        $search->fake_current_time($now);
+        $search->index();
+        $added = $search->get_engine()->get_and_clear_added_documents();
+        $this->assertCount(1, $added);
+        $this->assertEquals('Werewolf', $added[0]->get('title'));
+    }
+}

Proyectos de Subversion Moodle

(root)/search/tests/manager_test.php – Rev 11 → 1441