WebSVN – Moodle – Diff – /reportbuilder/tests/local/entities/base_test.php

  * @package     core_reportbuilder
  * @covers      \core_reportbuilder\local\entities\base
  * @copyright   2021 David Matamoros <davidmc@moodle.com>
  * @license     http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class base_test extends advanced_testcase {
+final class base_test extends advanced_testcase {
     /**
      * Test entity table alias
      */
         $this->assertEquals($mytablealias, $entity->get_table_alias('mytable'));
         $this->assertEquals($myothertablealias, $entity->get_table_alias('myothertable'));
+    }
+    /**
+     * Test for deprecated get table alias
+     */
+    public function test_get_table_alias_deprecated(): void {
+        $entity = new base_test_entity();
+        $entity->get_table_alias('mydeprecatedtable');
+        // Debugging called twice, as get_table_alias internally calls set_table_alias for undefined alias.
+        $this->assertDebuggingCalledCount(2, [
+            'The table \'mydeprecatedtable\' is deprecated, please do not use it any more.',
+            'The table \'mydeprecatedtable\' is deprecated, please do not use it any more.',
+        ]);
+    }
+    /**
+     * Test for deprecated get table alias replacement
+     */
+    public function test_get_table_alias_deprecated_replacement(): void {
+        $entity = new base_test_entity_second();
+        $mydeprecatedtable = $entity->get_table_alias('mydeprecatedtable');
+        $this->assertDebuggingCalled();
+        // We should get back the same alias for the replacement table.
+        $this->assertEquals($mydeprecatedtable, $entity->get_table_alias('mytable'));
+    }
     /**
      * Test for invalid get table alias
      */
     public function test_get_table_alias_invalid(): void {
         $entity->set_table_alias('mytable', 'newalias');
         $this->assertEquals('newalias', $entity->get_table_alias('mytable'));
+    }
+    /**
+     * Test for deprecated set table alias
+     */
+    public function test_set_table_alias_deprecated(): void {
+        $entity = new base_test_entity();
+        $entity->set_table_alias('mydeprecatedtable', 'newalias');
+        $this->assertEquals('newalias', $entity->get_table_alias('mydeprecatedtable'));
+        // Debugging called twice, once for set_table_alias and once for subsequent get_table_alias.
+        $this->assertDebuggingCalledCount(2, [
+            'The table \'mydeprecatedtable\' is deprecated, please do not use it any more.',
+            'The table \'mydeprecatedtable\' is deprecated, please do not use it any more.',
+        ]);
+    }
+    /**
+     * Test for deprecated get table alias replacement
+     */
+    public function test_set_table_alias_deprecated_replacement(): void {
+        $entity = new base_test_entity_second();
+        $entity->set_table_alias('mydeprecatedtable', 'newalias');
+        $this->assertDebuggingCalled();
+        // We should get back the same alias for the replacement table.
+        $this->assertEquals('newalias', $entity->get_table_alias('mytable'));
+    }
     /**
      * Test invalid entity set table alias
      */
     public function test_set_table_alias_invalid(): void {
         $entity->set_entity_title($newtitle);
         $this->assertEquals($newtitle, $entity->get_entity_title());
+    }
-    /**
-     * Test adding single join
-     */
-    public function test_add_join(): void {
-        $entity = new base_test_entity();
-        $tablejoin = "JOIN {course} c2 ON c2.id = c1.id";
-        $entity->add_join($tablejoin);
-        $this->assertEquals([$tablejoin], $entity->get_joins());
-    }
-    /**
-     * Test adding multiple joins
-     */
-    public function test_add_joins(): void {
-        $entity = new base_test_entity();
-        $tablejoins = [
-            "JOIN {course} c2 ON c2.id = c1.id",
-            "JOIN {course} c3 ON c3.id = c1.id",
-        ];
-        $entity->add_joins($tablejoins);
-        $this->assertEquals($tablejoins, $entity->get_joins());
-    }
-    /**
-     * Test adding duplicate joins
-     */
-    public function test_add_duplicate_joins(): void {
-        $entity = new base_test_entity();
-        $tablejoins = [
-            "JOIN {course} c2 ON c2.id = c1.id",
-            "JOIN {course} c3 ON c3.id = c1.id",
-        ];
-        $entity
-            ->add_joins($tablejoins)
-            ->add_joins($tablejoins);
-        $this->assertEquals($tablejoins, $entity->get_joins());
-    }
     /**
      * Test getting column
      */
     public function test_get_column(): void {
  * Simple implementation of the base entity
  */
 class base_test_entity extends base {
     /**
-     * Table aliases
+     * Database tables that this entity uses
      *
-     * @return array
+     * @return string[]
      */
     protected function get_default_tables(): array {
         return [
             'mytable',
             'myothertable',
         ];
+    }
+    /**
+     * Database tables that this entity no longer uses
+     *
+     * @return string[]
+     */
+    protected function get_deprecated_tables(): array {
+        return [
+            'mydeprecatedtable',
+        ];
+    }
     /**
      * Entity title
+     *
      * @return lang_string
             ->add_column($column)
             ->add_filter($filter)
             ->add_condition($filter);
+    }
+}
+/**
+ * Another simple implementation of the base entity
+ */
+class base_test_entity_second extends base_test_entity {
+    /**
+     * Database tables that this entity no longer uses
+     *
+     * @return string[]
+     */
+    protected function get_deprecated_tables(): array {
+        return [
+            'mytable' => 'mydeprecatedtable',
+        ];
+    }
+}

Proyectos de Subversion Moodle

(root)/reportbuilder/tests/local/entities/base_test.php – Rev 1 → 1441