WebSVN – Moodle – Diff – /question/tests/local/statistics/statistics_bulk_loader_test.php

 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-namespace core_question\local\statistics;
-defined('MOODLE_INTERNAL') || die();
+namespace core_question\local\statistics;
 use advanced_testcase;
 use context;
 use context_module;
 use mod_quiz\quiz_attempt;
 use mod_quiz\quiz_settings;
 use question_engine;
 use ReflectionMethod;
-global $CFG;
-require_once($CFG->dirroot . '/mod/quiz/tests/quiz_question_helper_test_trait.php');
 /**
  * Tests for question statistics.
+ *
  * @package   core_question
  * @copyright 2021 Catalyst IT Australia Pty Ltd
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  * @covers \core_question\local\statistics\statistics_bulk_loader
  */
-class statistics_bulk_loader_test extends advanced_testcase {
+final class statistics_bulk_loader_test extends advanced_testcase {
-    use \quiz_question_helper_test_trait;
+    use \mod_quiz\tests\question_helper_test_trait;
     /** @var float Delta used when comparing statistics values out-of 1. */
         // Create three quizzes.
         $quizgenerator = $this->getDataGenerator()->get_plugin_generator('mod_quiz');
         $quiz1 = $quizgenerator->create_instance([
             'course' => $course->id,
             'grade' => 100.0, 'sumgrades' => 2,
-            'layout' => '1,2,0'
+            'layout' => '1,2,0',
         ]);
         $quiz1context = context_module::instance($quiz1->cmid);
         $quiz2 = $quizgenerator->create_instance([
             'course' => $course->id,
             'grade' => 100.0, 'sumgrades' => 2,
-            'layout' => '1,2,0'
+            'layout' => '1,2,0',
         ]);
         $quiz2context = context_module::instance($quiz2->cmid);
         $quiz3 = $quizgenerator->create_instance([
             'course' => $course->id,
             'grade' => 100.0, 'sumgrades' => 2,
-            'layout' => '1,2,0'
+            'layout' => '1,2,0',
         ]);
         $quiz3context = context_module::instance($quiz3->cmid);
         $quizgenerator = $this->getDataGenerator()->get_plugin_generator('mod_quiz');
         $layout = '1,2,0,3,4,0';
         $quiz1 = $quizgenerator->create_instance([
             'course' => $course->id,
             'grade' => 100.0, 'sumgrades' => 2,
-            'layout' => $layout
+            'layout' => $layout,
         ]);
         $quiz2 = $quizgenerator->create_instance([
             'course' => $course->id,
             'grade' => 100.0, 'sumgrades' => 2,
-            'layout' => $layout
+            'layout' => $layout,
         ]);
         /** @var core_question_generator $questiongenerator */
         quiz_start_new_attempt($quizobj, $quba, $attempt, 1, $timenow);
         quiz_attempt_save_started($quizobj, $quba, $attempt);
         // Submit attempt.
         $attemptobj = quiz_attempt::create($attempt->id);
         $attemptobj->process_submitted_actions($timenow, false, $answers);
-        $attemptobj->process_finish($timenow, false);
+        $attemptobj->process_submit($timenow, false);
+        $attemptobj->process_grade_submission($timenow);
+    }
     /**
      * Generate attempt answers.
      * 1 : generate correct answer
      * 0 : generate wrong answer
+     *
      * @return array
      */
-    private function generate_attempt_answers(array $correctanswerflags): array {
+    private static function generate_attempt_answers(array $correctanswerflags): array {
         $attempt = [];
         for ($i = 1; $i <= 4; $i++) {
             if (isset($correctanswerflags) && $correctanswerflags[$i - 1] == 1) {
                 // Correct answer.
                 $attempt[$i] = ['answer' => 'frog'];
      * @param array $quiz2attempts quiz 2 attempts
+     *
      * @return array
      */
     private function prepare_and_submit_quizzes(array $quiz1attempts, array $quiz2attempts): array {
-        list($quiz1, $quiz2, $questions) = $this->prepare_quizzes();
+        [$quiz1, $quiz2, $questions] = $this->prepare_quizzes();
         // Submit attempts of quiz1.
         foreach ($quiz1attempts as $attempt) {
             $this->submit_quiz($quiz1, $attempt);
+        }
         // Submit attempts of quiz2.
      * @param all_calculated_for_qubaid_condition $statistics the batch of statistics.
      * @param int $questionid a question id.
      * @param string $item one of the field names in all_calculated_for_qubaid_condition, e.g. 'facility'.
      * @return float|null the required value.
      */
+    private function extract_item_value(
-    private function extract_item_value(all_calculated_for_qubaid_condition $statistics,
+        all_calculated_for_qubaid_condition $statistics,
-                                        int $questionid, string $item): ?float {
+        int $questionid,
+        string $item
+    ): ?float {
         $rcm = new ReflectionMethod(statistics_bulk_loader::class, 'extract_item_value');
         return $rcm->invoke(null, $statistics, $questionid, $item);
+    }
     /**
      * Data provider for {@see test_load_question_facility()}.
+     *
      * @return Generator
      */
-    public function load_question_facility_provider(): Generator {
+    public static function load_question_facility_provider(): Generator {
         yield 'Facility case 1' => [
-            'Quiz 1 attempts' => [
+            // Quiz 1 attempts.
+            [
-                $this->generate_attempt_answers([1, 0, 0, 0]),
+                self::generate_attempt_answers([1, 0, 0, 0]),
             ],
-            'Expected quiz 1 facilities' => [1.0, 0.0, 0.0, 0.0],
+            // Expected quiz 1 facilities.
+            [1.0, 0.0, 0.0, 0.0],
-            'Quiz 2 attempts' => [
+            // Quiz 2 attempts.
+            [
-                $this->generate_attempt_answers([1, 0, 0, 0]),
+                self::generate_attempt_answers([1, 0, 0, 0]),
-                $this->generate_attempt_answers([1, 1, 0, 0]),
+                self::generate_attempt_answers([1, 1, 0, 0]),
             ],
-            'Expected quiz 2 facilities' => [1.0, 0.5, 0.0, 0.0],
+            // Expected quiz 2 facilities.
+            [1.0, 0.5, 0.0, 0.0],
-            'Expected average facilities' => [1.0, 0.25, 0.0, 0.0],
+            // Expected average facilities.
+            [1.0, 0.25, 0.0, 0.0],
         ];
         yield 'Facility case 2' => [
-            'Quiz 1 attempts' => [
+            // Quiz 1 attempts.
+            [
-                $this->generate_attempt_answers([1, 0, 0, 0]),
+                self::generate_attempt_answers([1, 0, 0, 0]),
-                $this->generate_attempt_answers([1, 1, 0, 0]),
+                self::generate_attempt_answers([1, 1, 0, 0]),
-                $this->generate_attempt_answers([1, 1, 1, 0]),
+                self::generate_attempt_answers([1, 1, 1, 0]),
             ],
+            // Expected quiz 1 facilities.
-            'Expected quiz 1 facilities' => [1.0, 0.6667, 0.3333, 0.0],
+            [1.0, 0.6667, 0.3333, 0.0],
-            'Quiz 2 attempts' => [
+            // Quiz 2 attempts.
+            [
-                $this->generate_attempt_answers([1, 0, 0, 0]),
+                self::generate_attempt_answers([1, 0, 0, 0]),
-                $this->generate_attempt_answers([1, 1, 0, 0]),
+                self::generate_attempt_answers([1, 1, 0, 0]),
-                $this->generate_attempt_answers([1, 1, 1, 0]),
+                self::generate_attempt_answers([1, 1, 1, 0]),
-                $this->generate_attempt_answers([1, 1, 1, 1]),
+                self::generate_attempt_answers([1, 1, 1, 1]),
             ],
-            'Expected quiz 2 facilities' => [1.0, 0.75, 0.5, 0.25],
+            // Expected quiz 2 facilities.
+            [1.0, 0.75, 0.5, 0.25],
+            // Expected average facilities.
-            'Expected average facilities' => [1.0, 0.7083, 0.4167, 0.1250],
+            [1.0, 0.7083, 0.4167, 0.1250],
         ];
+    }
     /**
         array $expectedquiz2facilities,
         array $expectedaveragefacilities
     ): void {
         $this->resetAfterTest();
-        list($quiz1, $quiz2, $questions) = $this->prepare_and_submit_quizzes($quiz1attempts, $quiz2attempts);
+        [$quiz1, $quiz2, $questions] = $this->prepare_and_submit_quizzes($quiz1attempts, $quiz2attempts);
         // Quiz 1 facilities.
         $stats = $this->load_quiz_statistics_for_place(context_module::instance($quiz1->cmid));
         $stats = statistics_bulk_loader::load_aggregate_statistics(
             [$questions[1]->id, $questions[2]->id, $questions[3]->id, $questions[4]->id],
             ['facility']
         );
+        $this->assertEqualsWithDelta(
-        $this->assertEqualsWithDelta($expectedaveragefacilities[0],
+            $expectedaveragefacilities[0],
+            $stats[$questions[1]->id]['facility'],
+            self::DELTA
+        );
-            $stats[$questions[1]->id]['facility'], self::DELTA);
+        $this->assertEqualsWithDelta(
-        $this->assertEqualsWithDelta($expectedaveragefacilities[1],
+            $expectedaveragefacilities[1],
+            $stats[$questions[2]->id]['facility'],
+            self::DELTA
+        );
-            $stats[$questions[2]->id]['facility'], self::DELTA);
+        $this->assertEqualsWithDelta(
-        $this->assertEqualsWithDelta($expectedaveragefacilities[2],
+            $expectedaveragefacilities[2],
+            $stats[$questions[3]->id]['facility'],
+            self::DELTA
+        );
-            $stats[$questions[3]->id]['facility'], self::DELTA);
+        $this->assertEqualsWithDelta(
-        $this->assertEqualsWithDelta($expectedaveragefacilities[3],
+            $expectedaveragefacilities[3],
+            $stats[$questions[4]->id]['facility'],
+            self::DELTA
-            $stats[$questions[4]->id]['facility'], self::DELTA);
+        );
+    }
     /**
      * Data provider for {@see test_load_question_discriminative_efficiency()}.
      * @return Generator
      */
-    public function load_question_discriminative_efficiency_provider(): Generator {
+    public static function load_question_discriminative_efficiency_provider(): Generator {
+        yield 'Discriminative efficiency' => [
-        yield 'Discriminative efficiency' => [
+            // Quiz 1 attempts.
-            'Quiz 1 attempts' => [
+            [
-                $this->generate_attempt_answers([1, 0, 0, 0]),
+                self::generate_attempt_answers([1, 0, 0, 0]),
-                $this->generate_attempt_answers([1, 1, 0, 0]),
+                self::generate_attempt_answers([1, 1, 0, 0]),
-                $this->generate_attempt_answers([1, 0, 1, 0]),
+                self::generate_attempt_answers([1, 0, 1, 0]),
-                $this->generate_attempt_answers([1, 1, 1, 1]),
+                self::generate_attempt_answers([1, 1, 1, 1]),
+            ],
-            ],
+            // Expected quiz 1 discriminative efficiency.
+            [null, 33.33, 33.33, 100.00],
-            'Expected quiz 1 discriminative efficiency' => [null, 33.33, 33.33, 100.00],
+            // Quiz 2 attempts.
-            'Quiz 2 attempts' => [
+            [
-                $this->generate_attempt_answers([1, 1, 1, 1]),
+                self::generate_attempt_answers([1, 1, 1, 1]),
-                $this->generate_attempt_answers([0, 0, 0, 0]),
+                self::generate_attempt_answers([0, 0, 0, 0]),
-                $this->generate_attempt_answers([1, 0, 0, 1]),
+                self::generate_attempt_answers([1, 0, 0, 1]),
-                $this->generate_attempt_answers([0, 1, 1, 0]),
+                self::generate_attempt_answers([0, 1, 1, 0]),
+            ],
-            ],
+            // Expected quiz 2 discriminative efficiency.
+            [50.00, 50.00, 50.00, 50.00],
-            'Expected quiz 2 discriminative efficiency' => [50.00, 50.00, 50.00, 50.00],
+            // Expected average discriminative efficiency.
-            'Expected average discriminative efficiency' => [50.00, 41.67, 41.67, 75.00],
+            [50.00, 41.67, 41.67, 75.00],
         ];
+    }
         array $expectedquiz2discriminativeefficiency,
         array $expectedaveragediscriminativeefficiency
     ): void {
         $this->resetAfterTest();
-        list($quiz1, $quiz2, $questions) = $this->prepare_and_submit_quizzes($quiz1attempts, $quiz2attempts);
+        [$quiz1, $quiz2, $questions] = $this->prepare_and_submit_quizzes($quiz1attempts, $quiz2attempts);
         // Quiz 1 discriminative efficiency.
         $stats = $this->load_quiz_statistics_for_place(context_module::instance($quiz1->cmid));
         $discriminativeefficiency1 = $this->extract_item_value($stats, $questions[1]->id, 'discriminativeefficiency');
         $discriminativeefficiency2 = $this->extract_item_value($stats, $questions[2]->id, 'discriminativeefficiency');
+        $discriminativeefficiency3 = $this->extract_item_value($stats, $questions[3]->id, 'discriminativeefficiency');
-        $discriminativeefficiency3 = $this->extract_item_value($stats, $questions[3]->id, 'discriminativeefficiency');
+        $discriminativeefficiency4 = $this->extract_item_value($stats, $questions[4]->id, 'discriminativeefficiency');
-        $discriminativeefficiency4 = $this->extract_item_value($stats, $questions[4]->id, 'discriminativeefficiency');
+        $this->assertEqualsWithDelta(
+            $expectedquiz1discriminativeefficiency[0],
+            $discriminativeefficiency1,
+            self::PERCENT_DELTA
-        $this->assertEqualsWithDelta($expectedquiz1discriminativeefficiency[0],
+        );
+        $this->assertEqualsWithDelta(
+            $expectedquiz1discriminativeefficiency[1],
+            $discriminativeefficiency2,
-                $discriminativeefficiency1, self::PERCENT_DELTA);
+            self::PERCENT_DELTA
-        $this->assertEqualsWithDelta($expectedquiz1discriminativeefficiency[1],
+        );
+        $this->assertEqualsWithDelta(
+            $expectedquiz1discriminativeefficiency[2],
+            $discriminativeefficiency3,
-                $discriminativeefficiency2, self::PERCENT_DELTA);
+            self::PERCENT_DELTA
-        $this->assertEqualsWithDelta($expectedquiz1discriminativeefficiency[2],
+        );
+        $this->assertEqualsWithDelta(
+            $expectedquiz1discriminativeefficiency[3],
-                $discriminativeefficiency3, self::PERCENT_DELTA);
+            $discriminativeefficiency4,
-        $this->assertEqualsWithDelta($expectedquiz1discriminativeefficiency[3],
+            self::PERCENT_DELTA
-                $discriminativeefficiency4, self::PERCENT_DELTA);
+        );
         // Quiz 2 discriminative efficiency.
         $stats = $this->load_quiz_statistics_for_place(context_module::instance($quiz2->cmid));
+        $discriminativeefficiency1 = $this->extract_item_value($stats, $questions[1]->id, 'discriminativeefficiency');
-        $discriminativeefficiency1 = $this->extract_item_value($stats, $questions[1]->id, 'discriminativeefficiency');
+        $discriminativeefficiency2 = $this->extract_item_value($stats, $questions[2]->id, 'discriminativeefficiency');
-        $discriminativeefficiency2 = $this->extract_item_value($stats, $questions[2]->id, 'discriminativeefficiency');
+        $discriminativeefficiency3 = $this->extract_item_value($stats, $questions[3]->id, 'discriminativeefficiency');
+        $discriminativeefficiency4 = $this->extract_item_value($stats, $questions[4]->id, 'discriminativeefficiency');
+        $this->assertEqualsWithDelta(
-        $discriminativeefficiency3 = $this->extract_item_value($stats, $questions[3]->id, 'discriminativeefficiency');
+            $expectedquiz2discriminativeefficiency[0],
-        $discriminativeefficiency4 = $this->extract_item_value($stats, $questions[4]->id, 'discriminativeefficiency');
+            $discriminativeefficiency1,
+            self::PERCENT_DELTA
+        );
+        $this->assertEqualsWithDelta(
+            $expectedquiz2discriminativeefficiency[1],
-        $this->assertEqualsWithDelta($expectedquiz2discriminativeefficiency[0],
+            $discriminativeefficiency2,
+            self::PERCENT_DELTA
+        );
+        $this->assertEqualsWithDelta(
-                $discriminativeefficiency1, self::PERCENT_DELTA);
+            $expectedquiz2discriminativeefficiency[2],
-        $this->assertEqualsWithDelta($expectedquiz2discriminativeefficiency[1],
+            $discriminativeefficiency3,
+            self::PERCENT_DELTA
+        );
-                $discriminativeefficiency2, self::PERCENT_DELTA);
+        $this->assertEqualsWithDelta(
-        $this->assertEqualsWithDelta($expectedquiz2discriminativeefficiency[2],
+            $expectedquiz2discriminativeefficiency[3],
-                $discriminativeefficiency3, self::PERCENT_DELTA);
+            $discriminativeefficiency4,
-        $this->assertEqualsWithDelta($expectedquiz2discriminativeefficiency[3],
+            self::PERCENT_DELTA
-                $discriminativeefficiency4, self::PERCENT_DELTA);
+        );
+        // Average question discriminative efficiency.
-        // Average question discriminative efficiency.
+        $stats = statistics_bulk_loader::load_aggregate_statistics(
+            [$questions[1]->id, $questions[2]->id, $questions[3]->id, $questions[4]->id],
+            ['discriminativeefficiency']
+        );
-        $stats = statistics_bulk_loader::load_aggregate_statistics(
-            [$questions[1]->id, $questions[2]->id, $questions[3]->id, $questions[4]->id],
+        $this->assertEqualsWithDelta(
+            $expectedaveragediscriminativeefficiency[0],
+            $stats[$questions[1]->id]['discriminativeefficiency'],
+            self::PERCENT_DELTA
-            ['discriminativeefficiency']
+        );
-        );
+        $this->assertEqualsWithDelta(
+            $expectedaveragediscriminativeefficiency[1],
+            $stats[$questions[2]->id]['discriminativeefficiency'],
+            self::PERCENT_DELTA
+        );
-        $this->assertEqualsWithDelta($expectedaveragediscriminativeefficiency[0],
+        $this->assertEqualsWithDelta(
+            $expectedaveragediscriminativeefficiency[2],
+            $stats[$questions[3]->id]['discriminativeefficiency'],
-            $stats[$questions[1]->id]['discriminativeefficiency'], self::PERCENT_DELTA);
+            self::PERCENT_DELTA
-        $this->assertEqualsWithDelta($expectedaveragediscriminativeefficiency[1],
+        );
-            $stats[$questions[2]->id]['discriminativeefficiency'], self::PERCENT_DELTA);
+        $this->assertEqualsWithDelta(
-        $this->assertEqualsWithDelta($expectedaveragediscriminativeefficiency[2],
+            $expectedaveragediscriminativeefficiency[3],
-            $stats[$questions[3]->id]['discriminativeefficiency'], self::PERCENT_DELTA);
+            $stats[$questions[4]->id]['discriminativeefficiency'],
-        $this->assertEqualsWithDelta($expectedaveragediscriminativeefficiency[3],
+            self::PERCENT_DELTA
-            $stats[$questions[4]->id]['discriminativeefficiency'], self::PERCENT_DELTA);
+        );
     }
+    /**
-    /**
+     * Data provider for {@see test_load_question_discrimination_index()}.
-     * Data provider for {@see test_load_question_discrimination_index()}.
+     * @return Generator
-     * @return Generator
+     */
-     */
+    public static function load_question_discrimination_index_provider(): Generator {
-    public function load_question_discrimination_index_provider(): Generator {
+        yield 'Discrimination Index' => [
+            // Quiz 1 attempts.
-        yield 'Discrimination Index' => [
+            [
+                self::generate_attempt_answers([1, 0, 0, 0]),
-            'Quiz 1 attempts' => [
+                self::generate_attempt_answers([1, 1, 0, 0]),
-                $this->generate_attempt_answers([1, 0, 0, 0]),
+                self::generate_attempt_answers([1, 0, 1, 0]),
-                $this->generate_attempt_answers([1, 1, 0, 0]),
+                self::generate_attempt_answers([1, 1, 1, 1]),
-                $this->generate_attempt_answers([1, 0, 1, 0]),
+            ],
-                $this->generate_attempt_answers([1, 1, 1, 1]),
+            // Expected quiz 1 Discrimination Index.
-            ],
+            [null, 30.15, 30.15, 81.65],
+            // Quiz 2 attempts.
-            'Expected quiz 1 Discrimination Index' => [null, 30.15, 30.15, 81.65],
+            [
+                self::generate_attempt_answers([1, 1, 1, 1]),
-            'Quiz 2 attempts' => [
+                self::generate_attempt_answers([0, 0, 0, 0]),
-                $this->generate_attempt_answers([1, 1, 1, 1]),
+                self::generate_attempt_answers([1, 0, 0, 1]),
-                $this->generate_attempt_answers([0, 0, 0, 0]),
+                self::generate_attempt_answers([0, 1, 1, 0]),
-                $this->generate_attempt_answers([1, 0, 0, 1]),
+            ],
         array $expectedquiz2discriminationindex,
         array $expectedaveragediscriminationindex
     ): void {
         $this->resetAfterTest();
-        list($quiz1, $quiz2, $questions) = $this->prepare_and_submit_quizzes($quiz1attempts, $quiz2attempts);
+        [$quiz1, $quiz2, $questions] = $this->prepare_and_submit_quizzes($quiz1attempts, $quiz2attempts);
         // Quiz 1 discrimination index.
         $stats = $this->load_quiz_statistics_for_place(context_module::instance($quiz1->cmid));
         $discriminationindex1 = $this->extract_item_value($stats, $questions[1]->id, 'discriminationindex');
         $discriminationindex2 = $this->extract_item_value($stats, $questions[2]->id, 'discriminationindex');
+        $discriminationindex3 = $this->extract_item_value($stats, $questions[3]->id, 'discriminationindex');
-        $discriminationindex3 = $this->extract_item_value($stats, $questions[3]->id, 'discriminationindex');
+        $discriminationindex4 = $this->extract_item_value($stats, $questions[4]->id, 'discriminationindex');
-        $discriminationindex4 = $this->extract_item_value($stats, $questions[4]->id, 'discriminationindex');
+        $this->assertEqualsWithDelta(
+            $expectedquiz1discriminationindex[0],
+            $discriminationindex1,
+            self::PERCENT_DELTA
-        $this->assertEqualsWithDelta($expectedquiz1discriminationindex[0],
+        );
+        $this->assertEqualsWithDelta(
+            $expectedquiz1discriminationindex[1],
+            $discriminationindex2,
-            $discriminationindex1, self::PERCENT_DELTA);
+            self::PERCENT_DELTA
-        $this->assertEqualsWithDelta($expectedquiz1discriminationindex[1],
+        );
+        $this->assertEqualsWithDelta(
+            $expectedquiz1discriminationindex[2],
+            $discriminationindex3,
-            $discriminationindex2, self::PERCENT_DELTA);
+            self::PERCENT_DELTA
-        $this->assertEqualsWithDelta($expectedquiz1discriminationindex[2],
+        );
+        $this->assertEqualsWithDelta(
+            $expectedquiz1discriminationindex[3],
-            $discriminationindex3, self::PERCENT_DELTA);
+            $discriminationindex4,
-        $this->assertEqualsWithDelta($expectedquiz1discriminationindex[3],
+            self::PERCENT_DELTA
-            $discriminationindex4, self::PERCENT_DELTA);
+        );
         // Quiz 2 discrimination index.
         $stats = $this->load_quiz_statistics_for_place(context_module::instance($quiz2->cmid));
+        $discriminationindex1 = $this->extract_item_value($stats, $questions[1]->id, 'discriminationindex');
-        $discriminationindex1 = $this->extract_item_value($stats, $questions[1]->id, 'discriminationindex');
+        $discriminationindex2 = $this->extract_item_value($stats, $questions[2]->id, 'discriminationindex');
-        $discriminationindex2 = $this->extract_item_value($stats, $questions[2]->id, 'discriminationindex');
+        $discriminationindex3 = $this->extract_item_value($stats, $questions[3]->id, 'discriminationindex');
+        $discriminationindex4 = $this->extract_item_value($stats, $questions[4]->id, 'discriminationindex');
+        $this->assertEqualsWithDelta(
-        $discriminationindex3 = $this->extract_item_value($stats, $questions[3]->id, 'discriminationindex');
+            $expectedquiz2discriminationindex[0],
-        $discriminationindex4 = $this->extract_item_value($stats, $questions[4]->id, 'discriminationindex');
+            $discriminationindex1,
+            self::PERCENT_DELTA
+        );
+        $this->assertEqualsWithDelta(
+            $expectedquiz2discriminationindex[1],
-        $this->assertEqualsWithDelta($expectedquiz2discriminationindex[0],
+            $discriminationindex2,
+            self::PERCENT_DELTA
+        );
+        $this->assertEqualsWithDelta(
-            $discriminationindex1, self::PERCENT_DELTA);
+            $expectedquiz2discriminationindex[2],
-        $this->assertEqualsWithDelta($expectedquiz2discriminationindex[1],
+            $discriminationindex3,
+            self::PERCENT_DELTA
+        );
-            $discriminationindex2, self::PERCENT_DELTA);
+        $this->assertEqualsWithDelta(
-        $this->assertEqualsWithDelta($expectedquiz2discriminationindex[2],
+            $expectedquiz2discriminationindex[3],
-            $discriminationindex3, self::PERCENT_DELTA);
+            $discriminationindex4,
-        $this->assertEqualsWithDelta($expectedquiz2discriminationindex[3],
+            self::PERCENT_DELTA
-            $discriminationindex4, self::PERCENT_DELTA);
+        );
+        // Average question discrimination index.
-        // Average question discrimination index.
+        $stats = statistics_bulk_loader::load_aggregate_statistics(
+            [$questions[1]->id, $questions[2]->id, $questions[3]->id, $questions[4]->id],
+            ['discriminationindex']
+        );
-        $stats = statistics_bulk_loader::load_aggregate_statistics(
-            [$questions[1]->id, $questions[2]->id, $questions[3]->id, $questions[4]->id],
+        $this->assertEqualsWithDelta(
+            $expectedaveragediscriminationindex[0],
+            $stats[$questions[1]->id]['discriminationindex'],
+            self::PERCENT_DELTA
-            ['discriminationindex']
+        );
-        );
+        $this->assertEqualsWithDelta(
+            $expectedaveragediscriminationindex[1],
+            $stats[$questions[2]->id]['discriminationindex'],
+            self::PERCENT_DELTA
+        );
-        $this->assertEqualsWithDelta($expectedaveragediscriminationindex[0],
+        $this->assertEqualsWithDelta(
+            $expectedaveragediscriminationindex[2],
+            $stats[$questions[3]->id]['discriminationindex'],
-            $stats[$questions[1]->id]['discriminationindex'], self::PERCENT_DELTA);
+            self::PERCENT_DELTA
-        $this->assertEqualsWithDelta($expectedaveragediscriminationindex[1],
+        );
-            $stats[$questions[2]->id]['discriminationindex'], self::PERCENT_DELTA);
+        $this->assertEqualsWithDelta(
-        $this->assertEqualsWithDelta($expectedaveragediscriminationindex[2],
+            $expectedaveragediscriminationindex[3],
-            $stats[$questions[3]->id]['discriminationindex'], self::PERCENT_DELTA);
+            $stats[$questions[4]->id]['discriminationindex'],
-        $this->assertEqualsWithDelta($expectedaveragediscriminationindex[3],
+            self::PERCENT_DELTA
-            $stats[$questions[4]->id]['discriminationindex'], self::PERCENT_DELTA);
+        );
     }
     /**
      * Test with question statistics disabled
      */
     public function test_statistics_disabled(): void {

Proyectos de Subversion Moodle

(root)/question/tests/local/statistics/statistics_bulk_loader_test.php – Rev 1 → 1441