WebSVN – Moodle – Diff – /question/format.php

      */
     public function setCategory($category) {
         if (count($this->questions)) {
             debugging('You shouldn\'t call setCategory after setQuestions');
+        }
+        $context = context::instance_by_id($category->contextid);
+        if ($context->contextlevel !== CONTEXT_MODULE) {
+            throw new \core\exception\moodle_exception('Invalid contextlevel for target category, must be CONTEXT_MODULE');
+        }
         $this->category = $category;
-        $this->importcontext = context::instance_by_id($this->category->contextid);
+        $this->importcontext = $context;
+    }
     /**
      * Set the specific questions to export. Should not include questions with
         // loop through installed questiontypes checking for
         // function to handle this question
         foreach (question_bank::get_all_qtypes() as $qtype) {
             if (method_exists($qtype, $methodname)) {
-                if ($question = $qtype->$methodname($data, $question, $this, $extra)) {
+                if ($importedquestion = $qtype->$methodname($data, $question, $this, $extra)) {
-                    return $question;
+                    return $importedquestion;
+                }
+            }
+        }
         return false;
             if (isset($question->questiontextitemid)) {
                 $question->questiontext = file_save_draft_area_files($question->questiontextitemid,
                         $this->importcontext->id, 'question', 'questiontext', $question->id,
+                        $fileoptions, $question->questiontext);
-                        $fileoptions, $question->questiontext);
+                file_clear_draft_area($question->questiontextitemid);
             } else if (isset($question->questiontextfiles)) {
                 foreach ($question->questiontextfiles as $file) {
                     question_bank::get_qtype($question->qtype)->import_file(
                             $this->importcontext, 'question', 'questiontext', $question->id, $file);
+                }
+            }
             if (isset($question->generalfeedbackitemid)) {
                 $question->generalfeedback = file_save_draft_area_files($question->generalfeedbackitemid,
                         $this->importcontext->id, 'question', 'generalfeedback', $question->id,
+                        $fileoptions, $question->generalfeedback);
-                        $fileoptions, $question->generalfeedback);
+                file_clear_draft_area($question->generalfeedbackitemid);
             } else if (isset($question->generalfeedbackfiles)) {
                 foreach ($question->generalfeedbackfiles as $file) {
                     question_bank::get_qtype($question->qtype)->import_file(
                             $this->importcontext, 'question', 'generalfeedback', $question->id, $file);
             $result = question_bank::get_qtype($question->qtype)->save_question_options($question);
             $event = \core\event\question_created::create_from_question_instance($question, $this->importcontext);
             $event->trigger();
             if (core_tag_tag::is_enabled('core_question', 'question')) {
-                // Is the current context we're importing in a course context?
-                $importingcontext = $this->importcontext;
-                $importingcoursecontext = $importingcontext->get_course_context(false);
-                $isimportingcontextcourseoractivity = !empty($importingcoursecontext);
-                if (!empty($question->coursetags)) {
-                    if ($isimportingcontextcourseoractivity) {
+                // Course tags on question now deprecated so merge them into the question tags.
-                        $mergedtags = array_merge($question->coursetags, $question->tags);
+                $mergedtags = array_merge($question->coursetags ?? [], $question->tags ?? []);
-                        core_tag_tag::set_item_tags('core_question', 'question', $question->id,
-                            $question->context, $mergedtags);
+                core_tag_tag::set_item_tags('core_question',
-                    } else {
-                        core_tag_tag::set_item_tags('core_question', 'question', $question->id,
-                            context_course::instance($this->course->id), $question->coursetags);
+                    'question',
-                        if (!empty($question->tags)) {
-                            core_tag_tag::set_item_tags('core_question', 'question', $question->id,
-                                $importingcontext, $question->tags);
+                    $question->id,
-                        }
+                    $question->context,
-                    }
-                } else if (!empty($question->tags)) {
-                    core_tag_tag::set_item_tags('core_question', 'question', $question->id,
-                        $question->context, $question->tags);
+                    $mergedtags
                 );
+            }
             if (!empty($result->error)) {
             $context = context::instance_by_id($contextid);
             require_capability('moodle/question:add', $context);
         } else {
             $context = context::instance_by_id($this->category->contextid);
+        }
+        // If the file had categories in a deprecated context then the categories need to be applied to a default system type
+        // mod_qbank instance on the course instead.
+        if ($context->contextlevel !== CONTEXT_MODULE) {
+            $qbank = \core_question\local\bank\question_bank_helper::get_default_open_instance_system_type($this->course, true);
+            $context = context_module::instance($qbank->id);
+        }
         $this->importcontext = $context;
         // Now create any categories that need to be created.
         foreach ($catnames as $key => $catname) {
             $questionbankentry = question_bank::load_question($question->id);
             $qcategory = $questionbankentry->category;
             $contextid = $DB->get_field('question_categories', 'contextid', ['id' => $qcategory]);
             $question->contextid = $contextid;
             $question->idnumber = $questionbankentry->idnumber;
+            // Do not export hidden questions.
+            if ($question->status === \core_question\local\bank\question_version_status::QUESTION_STATUS_HIDDEN) {
+                continue;
+            }
             if ($question->status === \core_question\local\bank\question_version_status::QUESTION_STATUS_READY) {
                 $question->status = 0;
             } else {
                 $question->status = 1;
+            }
-            // do not export hidden questions
-            if (!empty($question->hidden)) {
-                continue;
-            }
             // do not export random questions
             if ($question->qtype == 'random') {
                 continue;
                     $count++;
+                }
+            }
+        }
-        // continue path for following error checks
-        $course = $this->course;
-        $continuepath = "{$CFG->wwwroot}/question/bank/exportquestions/export.php?courseid={$course->id}";
-        // did we actually process anything
+        // Did we actually process anything? Then continue path for following error checks.
+        if ($count==0) {
+            $contextid = $DB->get_field('question_categories', 'contextid', ['id' => $this->category->id]);
+            $context = context::instance_by_id($contextid);
-        if ($count==0) {
+            $continuepath = "{$CFG->wwwroot}/question/bank/exportquestions/export.php?cmid={$context->instanceid}";
             throw new \moodle_exception('noquestions', 'question', $continuepath);
+        }

Proyectos de Subversion Moodle

(root)/question/format.php – Rev 1 → 1441