WebSVN – Moodle – Diff – /question/classes/local/bank/view.php

 defined('MOODLE_INTERNAL') || die();
 require_once($CFG->dirroot . '/question/editlib.php');
 use coding_exception;
-use core\plugininfo\qbank;
-use core\output\datafilter;
+use coding_exception;
-use core_plugin_manager;
+use core\output\datafilter;
 use core_question\local\bank\condition;
 use core_question\local\statistics\statistics_bulk_loader;
-use core_question\output\question_bank_filter_ui;
-use core_question\local\bank\column_manager_base;
-use qbank_deletequestion\hidden_condition;
+use core_question\output\question_bank_filter_ui;
-use qbank_editquestion\editquestion_helper;
+use core_question\local\bank\column_manager_base;
 use qbank_managecategories\category_condition;
      * @var string url of the new question page.
      */
     public $returnurl;
     /**
-     * @var array $bulkactions to identify the bulk actions for the api.
+     * @var bulk_action_base[] $bulkactions bulk actions for the api.
      */
     public $bulkactions = [];
         $this->baseurl = $pageurl;
         $this->course = $course;
         $this->cm = $cm;
         $this->extraparams = $extraparams;
+        // Add the default qperpage to extra params array so we can switch back and forth between it and "all".
+        $this->extraparams['defaultqperpage'] = $this->pagesize;
+        $this->extraparams['maxqperpage'] = MAXIMUM_QUESTIONS_PER_PAGE;
+        if ($cm === null) {
+            debugging('Passing $cm to the view constructor is now required.', DEBUG_DEVELOPER);
+        }
         // Default filter condition.
-        if (!isset($params['filter']) && isset($params['cat'])) {
-            $params['filter']  = [];
+        if (!isset($params['filter']) && isset($params['cat'])) {
-            [$categoryid, $contextid] = category_condition::validate_category_param($params['cat']);
-            if (!is_null($categoryid)) {
-                $category = category_condition::get_category_record($categoryid, $contextid);
-                $params['filter']['category'] = [
-                    'jointype' => category_condition::JOINTYPE_DEFAULT,
-                    'values' => [$category->id],
-                    'filteroptions' => ['includesubcategories' => false],
-                ];
-            }
-            $params['filter']['hidden'] = [
-                'jointype' => hidden_condition::JOINTYPE_DEFAULT,
-                'values' => [0],
-            ];
+            $params['filter']  = filter_condition_manager::get_default_filter($params['cat']);
             $params['jointype'] = datafilter::JOINTYPE_ALL;
+        }
         if (!empty($params['filter'])) {
             $params['filter'] = filter_condition_manager::unpack_filteroptions_param($params['filter']);
+        }
         // Create the url of the new question page to forward to.
         $this->returnurl = $pageurl->out_as_local_url(false);
-        $this->editquestionurl = new \moodle_url('/question/bank/editquestion/question.php', ['returnurl' => $this->returnurl]);
-        if ($this->cm !== null) {
+        $this->editquestionurl = new \moodle_url('/question/bank/editquestion/question.php', ['returnurl' => $this->returnurl]);
-            $this->editquestionurl->param('cmid', $this->cm->id);
-        } else {
-            $this->editquestionurl->param('courseid', $this->course->id);
         $this->editquestionurl->param('cmid', $this->cm->id);
         $this->lastchangedid = clean_param($pageurl->param('lastchanged'), PARAM_INT);
         $this->set_pagevars($params);
         $this->init_columns($this->wanted_columns(), $this->heading_column());
         $this->init_question_actions();
         $this->init_sort();
         $this->init_bulk_actions();
+        // Record that this question bank has been used.
+        question_bank_helper::add_bank_context_to_recently_viewed($contexts->lowest());
+    }
     /**
      * Get an array of plugin features objects for all enabled qbank plugins.
     /**
      * Initialize bulk actions.
      */
     protected function init_bulk_actions(): void {
         foreach ($this->plugins as $componentname => $plugin) {
-            $bulkactions = $plugin->get_bulk_actions();
+            $bulkactions = $plugin->get_bulk_actions($this);
             if (!is_array($bulkactions)) {
                 debugging("The method {$componentname}::get_bulk_actions() must return an " .
                     "array of bulk actions instead of a single bulk action. " .
                     "Please update your implementation of get_bulk_actions() to return an array. " .
                     "Check out the qbank_bulkmove plugin for a working example.", DEBUG_DEVELOPER);
                 $bulkactions = [$bulkactions];
+            }
             foreach ($bulkactions as $bulkactionobject) {
-                $this->bulkactions[$bulkactionobject->get_key()] = [
-                    'title' => $bulkactionobject->get_bulk_action_title(),
-                    'url' => $bulkactionobject->get_bulk_action_url(),
-                    'capabilities' => $bulkactionobject->get_bulk_action_capabilities()
-                ];
+                $this->bulkactions[$bulkactionobject->get_key()] = $bulkactionobject;
+            }
+        }
+    }
-    /**
-     * Initialize search conditions from plugins
-     * local_*_get_question_bank_search_conditions() must return an array of
      * \core_question\bank\search\condition objects.
-     *
-     * @deprecated Since Moodle 4.3
+    /**
+     * @deprecated Since Moodle 4.3
+     */
+    #[\core\attribute\deprecated(
+        'create a qbank plugin and implement a filter object',
+        since: '4.3',
+        mdl: 'MDL-72321',
-     * @todo Final deprecation on Moodle 4.7 MDL-78090
+        final: true
-     */
-    protected function init_search_conditions(): void {
-        debugging(
-            'Function init_search_conditions() has been deprecated, please create a qbank plugin' .
-                'and implement a filter object instead.',
-            DEBUG_DEVELOPER
-        );
-        $searchplugins = get_plugin_list_with_function('local', 'get_question_bank_search_conditions');
+    )]
-        foreach ($searchplugins as $component => $function) {
-            foreach ($function($this) as $searchobject) {
-                $this->add_searchcondition($searchobject);
     protected function init_search_conditions(): void {
         \core\deprecation::emit_deprecation([self::class, __FUNCTION__]);
+    }
      * @return array [$colname, $subsort].
      */
     protected function parse_subsort($sort): array {
         // Do the parsing.
         if (strpos($sort, '-') !== false) {
-            list($colname, $subsort) = explode('-', $sort, 2);
+            [$colname, $subsort] = explode('-', $sort, 2);
         } else {
             $colname = $sort;
             $subsort = '';
+        }
         $colname = str_replace('__', '\\', $colname);
+        }
         return $params;
+    }
     /**
+     * Get the default sort columns for this view of the question bank.
+     *
+     * The array keys in the return value need be the standard keys used
+     * to represent sorts. That is [plugin_frankenstyle]__[class_name] and then
+     * and optional bit like '-name' if the column supports muliple ways of sorting.
+     *
+     * The array values should be one of the constants SORT_ASC or SORT_DESC for the default order.
+     *
+     * Therefore, the default implementation below is a good example.
-     * Default sort for question data.
+     *
-     * @return int[]
+     * @return int[] sort key => SORT_ASC or SORT_DESC.
      */
     protected function default_sort(): array {
         $defaultsort = [];
         if (class_exists('\\qbank_viewquestiontype\\question_type_column')) {
         $sorts = [];
         foreach ($this->sort as $sortname => $sortorder) {
             [$colname, $subsort] = $this->parse_subsort($sortname);
             $sorts[] = $this->requiredcolumns[$colname]->sort_expression($sortorder == SORT_DESC, $subsort);
+        }
-        // Build the where clause.
-        $latestversion = 'qv.version = (SELECT MAX(v.version)
-                                          FROM {question_versions} v
-                                          JOIN {question_bank_entries} be
-                                            ON be.id = v.questionbankentryid
-                                         WHERE be.id = qbe.id)';
         $this->sqlparams = [];
         $conditions = [];
+        $showhiddenquestion = true;
+        // Build the where clause.
         foreach ($this->searchconditions as $searchcondition) {
+            // This is nasty hack to check if the filter is using "Show hidden question" option.
+            if (array_key_exists('hidden_condition', $searchcondition->params())) {
+                $showhiddenquestion = false;
+            }
             if ($searchcondition->where()) {
                 $conditions[] = '((' . $searchcondition->where() .'))';
+            }
             if ($searchcondition->params()) {
                 $this->sqlparams = array_merge($this->sqlparams, $searchcondition->params());
+            }
+        }
+        $extracondition = '';
+        if (!$showhiddenquestion) {
+            // If Show hidden question option is off, then we need get the latest version that is not hidden.
+            $extracondition = ' AND v.status <> :hiddenstatus';
+            $this->sqlparams = array_merge($this->sqlparams, ['hiddenstatus' => question_version_status::QUESTION_STATUS_HIDDEN]);
+        }
+        $latestversion = "qv.version = (SELECT MAX(v.version)
+                                          FROM {question_versions} v
+                                          JOIN {question_bank_entries} be
+                                            ON be.id = v.questionbankentryid
+                                         WHERE be.id = qbe.id $extracondition)";
         // Get higher level filter condition.
         $jointype = isset($this->pagevars['jointype']) ? (int)$this->pagevars['jointype'] : condition::JOINTYPE_DEFAULT;
         $nonecondition = ($jointype === datafilter::JOINTYPE_NONE) ? ' NOT ' : '';
         $separator = ($jointype === datafilter::JOINTYPE_ALL) ? ' AND ' : ' OR ';
         // Build the SQL.
+     *
      * @return \moodle_recordset questionid => data about each question.
      */
     protected function load_page_questions(): \moodle_recordset {
         global $DB;
+        // Load the questions based on the page we are on.
         $questions = $DB->get_recordset_sql($this->loadsql, $this->sqlparams,
-            (int)$this->pagevars['qpage'] * (int)$this->pagevars['qperpage'], $this->pagevars['qperpage']);
+            (int)$this->pagevars['qpage'] * (int)$this->pagevars['qperpage'], (int)$this->pagevars['qperpage']);
-        if (empty($questions)) {
+        if (!$questions->valid()) {
             $questions->close();
-            // No questions on this page. Reset to page 0.
+            // No questions on this page. Reset to the nearest page that contains questions.
+            $this->pagevars['qpage'] = max(0,
+                ceil($this->totalcount / (int)$this->pagevars['qperpage']) - 1);
-            $questions = $DB->get_recordset_sql($this->loadsql, $this->sqlparams, 0, $this->pagevars['qperpage']);
+            $questions = $DB->get_recordset_sql($this->loadsql, $this->sqlparams,
+                (int)$this->pagevars['qpage'] * (int)$this->pagevars['qperpage'], (int)$this->pagevars['qperpage']);
+        }
         return $questions;
+    }
     public function get_most_specific_context(): \context {
         return $this->contexts->lowest();
+    }
-    /**
-     * @deprecated since Moodle 4.0
-     */
-    public function preview_question_url() {
-        throw new coding_exception(__FUNCTION__ . '() has been removed.');
-    }
     /**
      * Get fields from the pagevars array.
+     *
      * If a field is specified, that particlar pagevars field will be returned. Otherwise the entire array will be returned.
+     *
                 $this->extraparams);
         echo $OUTPUT->render($filter);
+    }
-    /**
-     * Print the text if category id not available.
     /**
-     * @deprecated since Moodle 4.3 MDL-72321
-     * @todo Final deprecation on Moodle 4.7 MDL-78090
+     * @deprecated since Moodle 4.3 MDL-72321
+     */
+    #[\core\attribute\deprecated(
+        'question/bank/managecategories/classes/category_confition.php',
+        since: '4.3',
+        mdl: 'MDL-72321',
+        final: true
-     */
+    )]
-    protected function print_choose_category_message(): void {
-        debugging(
-            'Function print_choose_category_message() is deprecated, all the features for this method is currently ' .
-                'handled by the qbank filter api, please have a look at ' .
-                'question/bank/managecategories/classes/category_confition.php for more information.',
-            DEBUG_DEVELOPER
-        );
-        echo \html_writer::start_tag('p', ['style' => "\"text-align:center;\""]);
+    protected function print_choose_category_message(): void {
-        echo \html_writer::tag('b', get_string('selectcategoryabove', 'question'));
-        echo \html_writer::end_tag('p');
+        \core\deprecation::emit_deprecation([self::class, __FUNCTION__]);
+    }
-    /**
-     * Gets current selected category.
-     * @param string $categoryandcontext
      * @return false|mixed|\stdClass
-     *
-     * @deprecated since Moodle 4.3 MDL-72321
+    /**
+     * @deprecated since Moodle 4.3 MDL-72321
+     */
+    #[\core\attribute\deprecated(
+        'question/bank/managecategories/classes/category_confition.php',
+        since: '4.3',
+        mdl: 'MDL-72321',
-     * @todo Final deprecation on Moodle 4.7 MDL-78090
+        final: true
-     */
-    protected function get_current_category($categoryandcontext) {
-        debugging(
-            'Function get_current_category() is deprecated, all the features for this method is currently handled by ' .
-            'the qbank filter api, please have a look at question/bank/managecategories/classes/category_confition.php ' .
-            'for more information.',
-            DEBUG_DEVELOPER
-        );
-        global $DB, $OUTPUT;
-        list($categoryid, $contextid) = explode(',', $categoryandcontext);
-        if (!$categoryid) {
-            $this->print_choose_category_message();
-            return false;
-        }
-        if (!$category = $DB->get_record('question_categories',
-            ['id' => $categoryid, 'contextid' => $contextid])) {
+    )]
-            echo $OUTPUT->box_start('generalbox questionbank');
-            echo $OUTPUT->notification('Category not found!');
-            echo $OUTPUT->box_end();
-            return false;
-        }
     protected function get_current_category($categoryandcontext) {
-        return $category;
+        \core\deprecation::emit_deprecation([self::class, __FUNCTION__]);
-    }
-    /**
      * Display the form with options for which questions are displayed and how they are displayed.
-     *
      * @param bool $showquestiontext Display the text of the question within the list.
+    /**
      * @deprecated since Moodle 4.3 MDL-72321
-     * @todo Final deprecation on Moodle 4.7 MDL-78090
-     */
-    protected function display_options_form($showquestiontext): void {
-        debugging(
-            'Function display_options_form() is deprecated, this method has been replaced with mustaches in filters, ' .
-                'please use filtering objects',
-            DEBUG_DEVELOPER
-        );
-        global $PAGE;
-        // The html will be refactored in the filter feature implementation.
-        echo \html_writer::start_tag('form', ['method' => 'get',
-            'action' => new \moodle_url($this->baseurl), 'id' => 'displayoptions']);
-        echo \html_writer::start_div();
-        $excludes = ['recurse', 'showhidden', 'qbshowtext'];
-        // If the URL contains any tags then we need to prevent them
-        // being added to the form as hidden elements because the tags
-        // are managed separately.
-        if ($this->baseurl->param('qtagids[0]')) {
-            $index = 0;
-            while ($this->baseurl->param("qtagids[{$index}]")) {
-                $excludes[] = "qtagids[{$index}]";
-                $index++;
+     */
-            }
-        }
-        echo \html_writer::input_hidden_params($this->baseurl, $excludes);
-        $advancedsearch = [];
-        foreach ($this->searchconditions as $searchcondition) {
-            if ($searchcondition->display_options_adv()) {
-                $advancedsearch[] = $searchcondition;
-            }
-        }
-        if (!empty($advancedsearch)) {
-            $this->display_advanced_search_form($advancedsearch);
-        }
-        $go = \html_writer::empty_tag('input', ['type' => 'submit', 'value' => get_string('go')]);
-        echo \html_writer::tag('noscript', \html_writer::div($go), ['class' => 'inline']);
-        echo \html_writer::end_div();
+    #[\core\attribute\deprecated('filtering objects', since: '4.3', mdl: 'MDL-72321', final: true)]
-        echo \html_writer::end_tag('form');
+    protected function display_options_form($showquestiontext): void {
-        $PAGE->requires->yui_module('moodle-question-searchform', 'M.question.searchform.init');
-    }
-    /**
+        \core\deprecation::emit_deprecation([self::class, __FUNCTION__]);
-     * Print the "advanced" UI elements for the form to select which questions. Hidden by default.
+    }
-     * @param array $advancedsearch
+    /**
-     * @deprecated since Moodle 4.3 MDL-72321
-     * @todo Final deprecation on Moodle 4.7 MDL-78090
-     */
-    protected function display_advanced_search_form($advancedsearch): void {
-        debugging(
-            'Function display_advanced_search_form() is deprecated, this method has been replaced with mustaches in ' .
-            'filters, please use filtering objects',
-            DEBUG_DEVELOPER
-        );
-        print_collapsible_region_start('', 'advancedsearch',
+     * @deprecated since Moodle 4.3 MDL-72321
-            get_string('advancedsearchoptions', 'question'),
-            'question_bank_advanced_search');
-        foreach ($advancedsearch as $searchcondition) {
+     */
-            echo $searchcondition->display_options_adv();
+    #[\core\attribute\deprecated('filtering objects', since: '4.3', mdl: 'MDL-72321', final: true)]
-        }
-        print_collapsible_region_end();
     protected function display_advanced_search_form($advancedsearch): void {
-    /**
+        \core\deprecation::emit_deprecation([self::class, __FUNCTION__]);
+    }
      * Display the checkbox UI for toggling the display of the question text in the list.
-     * @param bool $showquestiontext the current or default value for whether to display the text.
-     * @deprecated since Moodle 4.3 MDL-72321
-     * @todo Final deprecation on Moodle 4.7 MDL-78090
-     */
-    protected function display_showtext_checkbox($showquestiontext): void {
-        debugging('Function display_showtext_checkbox() is deprecated, please use filtering objects', DEBUG_DEVELOPER);
+    /**
-        global $PAGE;
-        $displaydata = [
-            'checked' => $showquestiontext
-        ];
-        if (class_exists('qbank_viewquestiontext\\question_text_row')) {
+     * @deprecated since Moodle 4.3 MDL-72321
-            if (\core\plugininfo\qbank::is_plugin_enabled('qbank_viewquestiontext')) {
+     */
-                echo $PAGE->get_renderer('core_question', 'bank')->render_showtext_checkbox($displaydata);
+    #[\core\attribute\deprecated('filtering objects', since: '4.3', mdl: 'MDL-72321', final: true)]
     protected function display_showtext_checkbox($showquestiontext): void {
     public function display_question_list(): void {
         // This function can be moderately slow with large question counts and may time out.
         // We probably do not want to raise it to unlimited, so randomly picking 5 minutes.
         // Note: We do not call this in the loop because quiz ob_ captures this function (see raise() PHP doc).
         \core_php_time_limit::raise(300);
+        raise_memory_limit(MEMORY_EXTRA);
         [$categoryid, $contextid] = category_condition::validate_category_param($this->pagevars['cat']);
+        $catcontext = \context::instance_by_id($contextid);
+        // Update the question in the list with correct category context when we have selected category filter.
+        if (isset($this->pagevars['filter']['category']['values'])) {
+            $categoryid = $this->pagevars['filter']['category']['values'][0];
+            foreach ($this->contexts->all() as $context) {
+                if ((int) $context->instanceid === (int) $categoryid) {
+                    $catcontext = $context;
+                    break;
+                }
+            }
         $catcontext = \context::instance_by_id($contextid);
         echo \html_writer::start_tag(
             'div',
                 'data-contextid' => $this->get_most_specific_context()->id,
+            ]
         );
         echo $this->get_plugin_controls($catcontext, $categoryid);
-        $this->build_query();
-        $questionsrs = $this->load_page_questions();
-        $totalquestions = $this->get_question_count();
-        $questions = [];
-        foreach ($questionsrs as $question) {
-            if (!empty($question->id)) {
-                $questions[$question->id] = $question;
-            }
-        }
-        $questionsrs->close();
+        $questions = $this->load_questions();
         // This html will be refactored in the bulk actions implementation.
         echo \html_writer::start_tag('form', ['action' => $this->baseurl, 'method' => 'post', 'id' => 'questionsubmit']);
+        echo \html_writer::start_tag('fieldset', ['class' => 'invisiblefieldset', 'style' => "display: block;"]);
-        echo \html_writer::start_tag('fieldset', ['class' => 'invisiblefieldset', 'style' => "display: block;"]);
+        echo \html_writer::empty_tag('input', ['type' => 'hidden', 'name' => 'sesskey', 'value' => sesskey()]);
-        echo \html_writer::empty_tag('input', ['type' => 'hidden', 'name' => 'sesskey', 'value' => sesskey()]);
+        echo \html_writer::empty_tag('input', ['type' => 'hidden', 'name' => 'addonpage']);
         echo \html_writer::input_hidden_params($this->baseurl);
         $filtercondition = json_encode($this->get_pagevars());
         // Embeded filterconditon into the div.
         echo \html_writer::start_tag('div',
             ['class' => 'categoryquestionscontainer', 'data-filtercondition' => $filtercondition]);
-        if ($totalquestions > 0) {
+        if ($this->totalcount > 0) {
             // Bulk load any required statistics.
             $returnurl = new \moodle_url($this->base_url(), ['filter' => json_encode($this->pagevars['filter'])]);
             $params['returnurl'] = $returnurl;
             foreach ($this->bulkactions as $key => $action) {
                 // Check capabilities.
                 $capcount = 0;
-                foreach ($action['capabilities'] as $capability) {
+                foreach ($action->get_bulk_action_capabilities() as $capability) {
                     if (has_capability($capability, $catcontext)) {
                         $capcount ++;
+                    }
+                }
                 // At least one cap need to be there.
                 if ($capcount === 0) {
                     unset($this->bulkactions[$key]);
                     continue;
+                }
                 $actiondata = new \stdClass();
-                $actiondata->actionname = $action['title'];
+                $actiondata->actionname = $action->get_bulk_action_title();
                 $actiondata->actionkey = $key;
-                $actiondata->actionurl = new \moodle_url($action['url'], $params);
+                $actiondata->actionurl = new \moodle_url($action->get_bulk_action_url(), $params);
                 $bulkactiondata[] = $actiondata;
                 $bulkactiondatas ['bulkactionitems'] = $bulkactiondata;
+            }
+            }
+        }
+    }
+    /**
+     * Give each bulk action a chance to load its own javascript module.
+     * @return void
+     */
+    public function init_bulk_actions_js(): void {
+        foreach ($this->bulkactions as $action) {
+            $action->initialise_javascript();
+        }
+    }
     /**
      * Display the questions.
+     *
      * @param array $questions
      */
+     *
      * @return array
      */
     public function load_questions() {
         $this->build_query();
+        $this->get_question_count();
         $questionsrs = $this->load_page_questions();
         $questions = [];
         foreach ($questionsrs as $question) {
             if (!empty($question->id)) {
                 $questions[$question->id] = $question;
      */
     protected function print_table($questions): void {
         // Start of the table.
         echo \html_writer::start_tag('table', [
             'id' => 'categoryquestions',
-            'class' => 'question-bank-table generaltable',
+            'class' => 'question-bank-table table generaltable',
             'data-defaultsort' => json_encode($this->sort),
         ]);
         // Prints the table header.
         // End of the table.
         echo \html_writer::end_tag('table');
+    }
-    /**
-     * Start of the table html.
-     *
-     * @see print_table()
+    /**
-     * @deprecated since Moodle 4.3 MDL-72321
-     * @todo Final deprecation on Moodle 4.7 MDL-78090
+     * @deprecated since Moodle 4.3 MDL-72321
+     */
-     */
+    #[\core\attribute\deprecated('print_table()', since: '4.3', mdl: 'MDL-72321', final: true)]
-    protected function start_table() {
-        debugging('Function start_table() is deprecated, please use print_table() instead.', DEBUG_DEVELOPER);
+    protected function start_table() {
-        echo '<table id="categoryquestions" class="table table-responsive">' . "\n";
-        echo "<thead>\n";
-        $this->print_table_headers();
-        echo "</thead>\n";
-        echo "<tbody>\n";
+        \core\deprecation::emit_deprecation([self::class, __FUNCTION__]);
+    }
-    /**
-     * End of the table html.
-     * @see print_table()
-     * @deprecated since Moodle 4.3 MDL-72321
+    /**
+     * @deprecated since Moodle 4.3 MDL-72321
-     * @todo Final deprecation on Moodle 4.7 MDL-78090
+     */
-     */
+    #[\core\attribute\deprecated('print_table()', since: '4.3', mdl: 'MDL-72321', final: true)]
-    protected function end_table() {
-        debugging('Function end_table() is deprecated, please use print_table() instead.', DEBUG_DEVELOPER);
-        echo "</tbody>\n";
+    protected function end_table() {
-        echo "</table>\n";
+        \core\deprecation::emit_deprecation([self::class, __FUNCTION__]);
+    }
      * @param int $rowcount
      */
     public function print_table_row($question, $rowcount): void {
         $rowclasses = implode(' ', $this->get_row_classes($question, $rowcount));
         $attributes = [];
+        // If the question type is invalid we highlight it red.
+        if (!\question_bank::is_qtype_usable($question->qtype)) {
+            $rowclasses .= ' table-danger';
+        }
         if ($rowclasses) {
             $attributes['class'] = $rowclasses;
+        }
         echo \html_writer::start_tag('tr', $attributes);
         foreach ($this->visiblecolumns as $column) {
             $row->display($question, $rowclasses);
+        }
+    }
-    /**
-     * @deprecated since Moodle 4.0
-     */
-    public function process_actions(): void {
-        throw new coding_exception(__FUNCTION__ . '() has been removed.');
-    }
-    /**
-     * @deprecated since Moodle 4.0
-     */
-    public function process_actions_needing_ui() {
-        throw new coding_exception(__FUNCTION__ . '() has been removed.');
-    }
     /**
      * Add another search control to this view.
      * @param condition $searchcondition the condition to add.
      * @param string|null $fieldname
      */
      * @return string HTML for the question table
      */
     public function display_questions_table(): string {
         $this->add_standard_search_conditions();
         $questions = $this->load_questions();
-        $totalquestions = $this->get_question_count();
         $questionhtml = '';
-        if ($totalquestions > 0) {
+        if ($this->get_question_count() > 0) {
             $this->load_required_statistics($questions);
             ob_start();
             $this->display_questions($questions, $this->pagevars['qpage'], $this->pagevars['qperpage']);
             $questionhtml = ob_get_clean();
+        }

Proyectos de Subversion Moodle

(root)/question/classes/local/bank/view.php – Rev 11 → 1441