WebSVN – Moodle – Diff – /question/bank/editquestion/question.php

 // Read URL parameters telling us which question to edit.
 $id = optional_param('id', 0, PARAM_INT); // Question id.
 $makecopy = optional_param('makecopy', 0, PARAM_BOOL);
 $qtype = optional_param('qtype', '', PARAM_COMPONENT);
 $categoryid = optional_param('category', 0, PARAM_INT);
-$cmid = optional_param('cmid', 0, PARAM_INT);
+$cmid = required_param('cmid', PARAM_INT);
-$courseid = optional_param('courseid', 0, PARAM_INT);
 $wizardnow = optional_param('wizardnow', '', PARAM_ALPHA);
 $originalreturnurl = optional_param('returnurl', 0, PARAM_LOCALURL);
 $appendqnumstring = optional_param('appendqnumstring', '', PARAM_ALPHA);
 $inpopup = optional_param('inpopup', 0, PARAM_BOOL);
 $mdlscrollto = optional_param('mdlscrollto', 0, PARAM_INT);
     $url->param('category', $categoryid);
+}
 if ($cmid !== 0) {
     $url->param('cmid', $cmid);
+}
-if ($courseid !== 0) {
-    $url->param('courseid', $courseid);
-}
 if ($wizardnow !== '') {
     $url->param('wizardnow', $wizardnow);
+}
 if ($originalreturnurl !== 0) {
     $url->param('returnurl', $originalreturnurl);
 if ($mdlscrollto) {
     $url->param('mdlscrollto', $mdlscrollto);
+}
 $PAGE->set_url($url);
-if ($cmid) {
-    $questionbankurl = new moodle_url('/question/edit.php', array('cmid' => $cmid));
-} else {
-    $questionbankurl = new moodle_url('/question/edit.php', array('courseid' => $courseid));
+$questionbankurl = new moodle_url('/question/edit.php', ['cmid' => $cmid]);
 navigation_node::override_active_url($questionbankurl);
 if ($originalreturnurl) {
+}
 if ($mdlscrollto) {
     $returnurl->param('mdlscrollto', $mdlscrollto);
+}
-if ($cmid) {
-    list($module, $cm) = get_module_from_cmid($cmid);
+list($module, $cm) = get_module_from_cmid($cmid);
-    require_login($cm->course, false, $cm);
+require_login($cm->course, false, $cm);
-    $thiscontext = context_module::instance($cmid);
-} else if ($courseid) {
-    require_login($courseid, false);
-    $thiscontext = context_course::instance($courseid);
-    $module = null;
-    $cm = null;
-} else {
-    throw new moodle_exception('missingcourseorcmid', 'question');
+$thiscontext = context_module::instance($cmid);
 $contexts = new core_question\local\bank\question_edit_contexts($thiscontext);
 $PAGE->set_pagelayout('admin');
 if ($id) {
     if (!$question = $DB->get_record('question', array('id' => $id))) {
         throw new moodle_exception('questiondoesnotexist', 'question', $returnurl);
-    }
-    // We can use $COURSE here because it's been initialised as part of the
-    // require_login above. Passing it as the third parameter tells the function
-    // to filter the course tags by that course.
+    }
-    get_question_options($question, true, [$COURSE]);
+    get_question_options($question, true);
 } else if ($categoryid && $qtype) { // Only for creating new questions.
     $question = new stdClass();
 } else {
     throw new moodle_exception('notenoughdatatoeditaquestion', 'question', $returnurl);
+}
+// If we get to the editing page from somewhere outside the question bank (such as the quiz) while migration is still
+// pending, redirect back with a warning.
+if (!\core_question\local\bank\question_bank_helper::has_bank_migration_task_completed_successfully()) {
+    $defaultactivityname = \core_question\local\bank\question_bank_helper::get_default_question_bank_activity_name();
+    redirect(
+        $returnurl,
+        get_string('transfernotfinished', 'mod_' . $defaultactivityname),
+        messagetype: \core\output\notification::NOTIFY_WARNING,
+    );
+}
 $qtypeobj = question_bank::get_qtype($question->qtype);
         if (!empty($fromform->makecopy) && !$question->formoptions->cansaveasnew) {
             throw new moodle_exception('nopermissions', '', '', 'edit');
+        }
+    }
-    // If this is a new question, save defaults for user in user_preferences table.
+    // If this is a new question and question defaults save is enabled, save defaults for user in user_preferences table.
-    if (empty($question->id)) {
+    if (empty($question->id) && !empty($CFG->questiondefaultssave)) {
         $qtypeobj->save_defaults_for_new_questions($fromform);
+    }
     $question = $qtypeobj->save_question($question, $fromform);
     if (isset($fromform->tags)) {
             if ($appendqnumstring) {
                 $returnurl->param($appendqnumstring, $question->id);
                 $returnurl->param('sesskey', sesskey());
                 $returnurl->param('cmid', $cmid);
+            }
+            // Update the filter param to the updated category if the return have any.
+            if (!empty($returnurl->param('filter'))) {
+                $filter = json_decode($returnurl->param('filter'), true);
+                if (isset($filter['category']['values'])) {
+                    $filter['category']['values'][0] = $question->category;
+                    $returnurl->param('filter', json_encode($filter));
+                }
+            }
             redirect($returnurl);
+        }
     } else {
         if ($cmid) {
             $nexturl->param('cmid', $cmid);
         } else {
             $nexturl->param('courseid', $COURSE->id);
+        }
+        // Update the filter param to the updated category if the return url have any.
+        if (!empty($nexturl->param('filter'))) {
+            $filter = json_decode($nexturl->param('filter'), true);
+            if (isset($filter['category']['values'])) {
+                $filter['category']['values'][0] = $question->category;
+                $nexturl->param('filter', json_encode($filter));
+            }
+        }
         redirect($nexturl);
+    }

Proyectos de Subversion Moodle

(root)/question/bank/editquestion/question.php – Rev 1 → 1441