WebSVN – Moodle – Diff – /mod/quiz/tests/quiz_notify_attempt_manual_grading_completed_test.php

  */
 namespace mod_quiz;
 use advanced_testcase;
+use advanced_testcase;
-use context_course;
+use context_module;
-use context_module;
+use core\context;
 use mod_quiz\task\quiz_notify_attempt_manual_grading_completed;
 use question_engine;
-use mod_quiz\quiz_settings;
-use stdClass;
 use question_usage_by_activity;
-defined('MOODLE_INTERNAL') || die();
+use stdClass;
 /**
  * Class containing unit tests for the quiz notify attempt manual grading completed cron task.
+ *
  * @package mod_quiz
  * @copyright 2021 The Open University
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class quiz_notify_attempt_manual_grading_completed_test extends advanced_testcase {
-    /** @var \stdClass $course Test course to contain quiz. */
+    /** @var stdClass $course Test course to contain quiz. */
-    protected $course;
+    protected stdClass $course;
-    /** @var \stdClass $quiz A test quiz. */
+    /** @var stdClass $quiz A test quiz. */
-    protected $quiz;
+    protected stdClass $quiz;
     /** @var context The quiz context. */
-    protected $context;
+    protected context $context;
     /** @var stdClass The course_module. */
-    protected $cm;
+    protected stdClass $cm;
     /** @var stdClass The student test. */
-    protected $student;
+    protected stdClass $student;
-    /** @var stdClass The teacher test. */
+    /** @var stdClass The student role. */
-    protected $teacher;
+    protected stdClass $studentrole;
     /** @var quiz_settings Object containing the quiz settings. */
-    protected $quizobj;
+    protected quiz_settings $quizobj;
     /** @var question_usage_by_activity The question usage for this quiz attempt. */
         $this->resetAfterTest();
         $this->setAdminUser();
         // Setup test data.
-        $this->course = $this->getDataGenerator()->create_course();
-        $this->quiz = $this->getDataGenerator()->create_module('quiz', ['course' => $this->course->id]);
-        $this->context = context_module::instance($this->quiz->cmid);
-        $this->cm = get_coursemodule_from_instance('quiz', $this->quiz->id);
+        $this->course = $this->getDataGenerator()->create_course();
-        // Create users.
-        $this->student = self::getDataGenerator()->create_user();
-        $this->teacher = self::getDataGenerator()->create_user();
+        // Create a user enrolled as a student.
-        // Users enrolments.
-        $studentrole = $DB->get_record('role', ['shortname' => 'student']);
-        $teacherrole = $DB->get_record('role', ['shortname' => 'editingteacher']);
-        // Allow student to receive messages.
-        $coursecontext = context_course::instance($this->course->id);
-        assign_capability('mod/quiz:emailnotifyattemptgraded', CAP_ALLOW, $studentrole->id, $coursecontext, true);
+        $this->student = self::getDataGenerator()->create_user();
-        $this->getDataGenerator()->enrol_user($this->student->id, $this->course->id, $studentrole->id);
+        $this->studentrole = $DB->get_record('role', ['shortname' => 'student']);
-        $this->getDataGenerator()->enrol_user($this->teacher->id, $this->course->id, $teacherrole->id);
+        $this->getDataGenerator()->enrol_user($this->student->id, $this->course->id, $this->studentrole->id);
         // Make a quiz.
+        $quizgenerator = $this->getDataGenerator()->get_plugin_generator('mod_quiz');
+        $this->quiz = $quizgenerator->create_instance(['course' => $this->course->id, 'questionsperpage' => 0,
-        $quizgenerator = $this->getDataGenerator()->get_plugin_generator('mod_quiz');
+            'grade' => 100.0, 'sumgrades' => 2]);
+        $this->context = context_module::instance($this->quiz->cmid);
-        $this->quiz = $quizgenerator->create_instance(['course' => $this->course->id, 'questionsperpage' => 0,
+        $this->cm = get_coursemodule_from_instance('quiz', $this->quiz->id);
             'grade' => 100.0, 'sumgrades' => 2]);
         // Create a truefalse question and an essay question.
-        // Create a truefalse question and an essay question.
+        /** @var \core_question_generator $questiongenerator */
+    }
     /**
      * Test SQL querry get list attempt in condition.
      */
-    public function test_get_list_of_attempts_within_conditions() {
+    public function test_get_list_of_attempts_within_conditions(): void {
         global $DB;
         $timenow = time();
         // Create an attempt to be completely graded (one hour ago).
-        $attempt1 = quiz_create_attempt($this->quizobj, 1, null, $timenow - HOURSECS, false, $this->student->id);
+        $attempt1 = quiz_create_attempt($this->quizobj, 1, false, $timenow - HOURSECS, false, $this->student->id);
         quiz_start_new_attempt($this->quizobj, $this->quba, $attempt1, 1, $timenow - HOURSECS);
         $update = new stdClass();
         $update->id = $attemptobj1->get_attemptid();
         $update->timemodified = $timenow;
+        $update->sumgrades = $attemptobj1->get_question_usage()->get_total_mark();
+        $update->gradednotificationsenttime = null; // Processfinish detects the notification is not required, so sets this.
-        $update->sumgrades = $attemptobj1->get_question_usage()->get_total_mark();
+        // Unset to allow testing of our logic.
         $DB->update_record('quiz_attempts', $update);
         $attemptobj1->get_quizobj()->get_grade_calculator()->recompute_final_grade();
+    }
     /**
      * Test SQL query does not return attempts if the grading is not complete yet.
      */
-    public function test_get_list_of_attempts_without_manual_graded() {
+    public function test_get_list_of_attempts_without_manual_graded(): void {
         $timenow = time();
         // Create an attempt which won't be graded (1 hour ago).
-        $attempt2 = quiz_create_attempt($this->quizobj, 2, null, $timenow - HOURSECS, false, $this->student->id);
+        $attempt2 = quiz_create_attempt($this->quizobj, 2, false, $timenow - HOURSECS, false, $this->student->id);
         quiz_start_new_attempt($this->quizobj, $this->quba, $attempt2, 2, $timenow - HOURSECS);
+    }
     /**
      * Test notify manual grading completed task which the user attempt has not capability.
      */
-    public function test_notify_manual_grading_completed_task_without_capability() {
+    public function test_notify_manual_grading_completed_task_without_capability(): void {
         global $DB;
         // Create an attempt for a user without the capability.
         $timenow = time();
-        $attempt = quiz_create_attempt($this->quizobj, 3, null, $timenow, false, $this->teacher->id);
+        $attempt = quiz_create_attempt($this->quizobj, 3, false, $timenow, false, $this->student->id);
         quiz_start_new_attempt($this->quizobj, $this->quba, $attempt, 3, $timenow - HOURSECS);
         quiz_attempt_save_started($this->quizobj, $this->quba, $attempt);
         // Process some responses and submit.
         $attemptobj = quiz_attempt::create($attempt->id);
-        $tosubmit = [2 => ['answer' => 'Answer of teacher.', 'answerformat' => FORMAT_HTML]];
+        $tosubmit = [2 => ['answer' => 'Essay answer.', 'answerformat' => FORMAT_HTML]];
         $attemptobj->process_submitted_actions($timenow - 30 * MINSECS, false, $tosubmit);
         $update = new stdClass();
         $update->id = $attemptobj->get_attemptid();
         $update->timemodified = $timenow;
+        $update->sumgrades = $attemptobj->get_question_usage()->get_total_mark();
+        $update->gradednotificationsenttime = null; // Processfinish detects the notification is not required, so sets this.
-        $update->sumgrades = $attemptobj->get_question_usage()->get_total_mark();
+        // Unset to allow testing of our logic.
         $DB->update_record('quiz_attempts', $update);
         $attemptobj->get_quizobj()->get_grade_calculator()->recompute_final_grade();
         // Run the quiz notify attempt manual graded task.
-        ob_start();
+        $this->expectOutputRegex("~Not sending an email because user does not have mod/quiz:emailnotifyattemptgraded capability.~");
         $task = new quiz_notify_attempt_manual_grading_completed();
-        $task->set_time_for_testing($timenow + 5 * HOURSECS + 1);
-        $task->execute();
+        $task->set_time_for_testing($timenow + 5 * HOURSECS + 1);
-        ob_get_clean();
+        $task->execute();
         $attemptobj = quiz_attempt::create($attempt->id);
         $this->assertEquals($attemptobj->get_attempt()->timefinish, $attemptobj->get_attempt()->gradednotificationsenttime);
+    }
     /**
+     * Test notify manual grading completed task which the user attempt has capability.
+     */
+    public function test_notify_manual_grading_completed_task_with_capability(): void {
-     * Test notify manual grading completed task which the user attempt has capability.
+        global $DB;
      */
-    public function test_notify_manual_grading_completed_task_with_capability() {
+        // Allow student to receive messages.
-        global $DB;
+        assign_capability('mod/quiz:emailnotifyattemptgraded', CAP_ALLOW, $this->studentrole->id, $this->context, true);
         // Create an attempt with capability.
         $timenow = time();
         $update->sumgrades = $attemptobj->get_question_usage()->get_total_mark();
         $DB->update_record('quiz_attempts', $update);
         $attemptobj->get_quizobj()->get_grade_calculator()->recompute_final_grade();
         // Run the quiz notify attempt manual graded task.
-        ob_start();
+        $this->expectOutputRegex("~Sending email to user {$this->student->id}~");
         $task = new quiz_notify_attempt_manual_grading_completed();
         $task->set_time_for_testing($timenow + 5 * HOURSECS + 1);
-        $task->execute();
-        ob_get_clean();
+        $task->execute();
         $attemptobj = quiz_attempt::create($attempt->id);

Proyectos de Subversion Moodle

(root)/mod/quiz/tests/quiz_notify_attempt_manual_grading_completed_test.php – Rev 1 → 11