WebSVN – Moodle – Diff – /mod/quiz/tests/external/external_test.php

  * @copyright  2016 Juan Leyva <juan@moodle.com>
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  * @since      Moodle 3.1
  * @covers \mod_quiz_external
  */
-class external_test extends externallib_advanced_testcase {
+final class external_test extends externallib_advanced_testcase {
     use \quiz_question_helper_test_trait;
     /**
      * Set up for every test
      */
     public function setUp(): void {
         global $DB;
+        parent::setUp();
         $this->resetAfterTest();
         $this->setAdminUser();
         // Setup test data.
                 // Process some responses from the student.
                 $tosubmit = [1 => ['answer' => '3.14']];
                 $attemptobj->process_submitted_actions(time(), false, $tosubmit);
                 // Finish the attempt.
+                $attemptobj->process_submit(time(), false);
-                $attemptobj->process_finish(time(), false);
+                $attemptobj->process_grade_submission(time());
+            }
             return [$quiz, $context, $quizobj, $attempt, $attemptobj, $quba];
         } else {
             return [$quiz, $context, $quizobj];
         // Second quiz.
         $record = new \stdClass();
         $record->course = $course2->id;
+        $record->intro = '<button>Test with HTML allowed.</button>';
+        $timeopen = time() - 1;
+        $record->timeopen = $timeopen;
-        $record->intro = '<button>Test with HTML allowed.</button>';
+        $record->precreateattempts = 1;
         $quiz2 = self::getDataGenerator()->create_module('quiz', $record);
         // Execute real Moodle enrolment as we'll call unenrol() method on the instance later.
                                         'reviewspecificfeedback', 'reviewgeneralfeedback', 'reviewrightanswer',
                                         'reviewoverallfeedback', 'questionsperpage', 'navmethod',
                                         'browsersecurity', 'delay1', 'delay2', 'showuserpicture', 'showblocks',
                                         'completionattemptsexhausted', 'completionpass', 'autosaveperiod', 'hasquestions',
                                         'overduehandling', 'graceperiod', 'canredoquestions', 'allowofflineattempts'];
-        $managerfields = ['shuffleanswers', 'timecreated', 'timemodified', 'password', 'subnet'];
+        $managerfields = ['shuffleanswers', 'timecreated', 'timemodified', 'password', 'subnet', 'precreateattempts'];
         // Add expected coursemodule and other data.
         $quiz1 = $this->quiz;
         $quiz1->coursemodule = $quiz1->cmid;
             $this->assertEquals('requireloginerror', $e->errorcode);
+        }
+    }
+    /**
+     * Test get_user_attempts
+     *
      * @todo Remove in Moodle 6.0 as part of MDL-80956 final deprecations.
      */
     public function test_get_user_attempts(): void {
         // Create a quiz with one attempt finished.
+        [$quiz, $context, $quizobj, $attempt, $attemptobj] = $this->create_quiz_with_questions(true, true);
         [$quiz, $context, $quizobj, $attempt, $attemptobj] = $this->create_quiz_with_questions(true, true);
         $this->setUser($this->student);
-        $this->setUser($this->student);
+        $result = mod_quiz_external::get_user_attempts($quiz->id);
-        $result = mod_quiz_external::get_user_attempts($quiz->id);
+        $this->assertDebuggingCalled();
         $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
         $this->assertCount(1, $result['attempts']);
         $this->assertEquals($attempt->id, $result['attempts'][0]['id']);
+        $this->assertEquals($quiz->id, $result['attempts'][0]['quiz']);
-        $this->assertEquals($quiz->id, $result['attempts'][0]['quiz']);
+        $this->assertEquals($this->student->id, $result['attempts'][0]['userid']);
+        $this->assertEquals(1, $result['attempts'][0]['attempt']);
-        $this->assertEquals($this->student->id, $result['attempts'][0]['userid']);
+        $this->assertArrayHasKey('sumgrades', $result['attempts'][0]);
-        $this->assertEquals(1, $result['attempts'][0]['attempt']);
+        $this->assertEquals(1.0, $result['attempts'][0]['sumgrades']);
+        $this->assertEquals(quiz_attempt::FINISHED, $result['attempts'][0]['state']);
         $this->assertArrayHasKey('sumgrades', $result['attempts'][0]);
-        $this->assertEquals(1.0, $result['attempts'][0]['sumgrades']);
+        // Test filters. Only finished.
         $this->resetDebugging();
+        $result = mod_quiz_external::get_user_attempts($quiz->id, 0, 'finished', false);
-        // Test filters. Only finished.
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
-        $result = mod_quiz_external::get_user_attempts($quiz->id, 0, 'finished', false);
+        $this->assertDebuggingCalled();
-        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
+        $this->assertCount(1, $result['attempts']);
         $this->assertEquals($attempt->id, $result['attempts'][0]['id']);
         $this->assertCount(1, $result['attempts']);
+        // Test filters. All attempts.
-        $this->assertEquals($attempt->id, $result['attempts'][0]['id']);
+        $this->resetDebugging();
         $result = mod_quiz_external::get_user_attempts($quiz->id, 0, 'all', false);
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
-        // Test filters. All attempts.
+        $this->assertDebuggingCalled();
         $result = mod_quiz_external::get_user_attempts($quiz->id, 0, 'all', false);
-        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
+        $this->assertCount(1, $result['attempts']);
         quiz_start_new_attempt($quizobj, $quba, $attempt, 1, $timenow);
         quiz_attempt_save_started($quizobj, $quba, $attempt);
         // Test filters. All attempts.
-        // Test filters. All attempts.
+        $this->resetDebugging();
+        $result = mod_quiz_external::get_user_attempts($quiz->id, 0, 'all', false);
-        $result = mod_quiz_external::get_user_attempts($quiz->id, 0, 'all', false);
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
-        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
+        $this->assertDebuggingCalled();
         $this->assertCount(2, $result['attempts']);
         $this->assertCount(2, $result['attempts']);
+        // Test filters. Unfinished.
         $this->resetDebugging();
-        // Test filters. Unfinished.
+        $result = mod_quiz_external::get_user_attempts($quiz->id, 0, 'unfinished', false);
-        $result = mod_quiz_external::get_user_attempts($quiz->id, 0, 'unfinished', false);
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
+        $this->assertDebuggingCalled();
         $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
         $this->assertCount(1, $result['attempts']);
-        $this->assertCount(1, $result['attempts']);
+        // Test manager can see user attempts.
         $this->setUser($this->teacher);
+        $this->resetDebugging();
-        // Test manager can see user attempts.
+        $result = mod_quiz_external::get_user_attempts($quiz->id, $this->student->id);
-        $this->setUser($this->teacher);
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
+        $this->assertDebuggingCalled();
         $result = mod_quiz_external::get_user_attempts($quiz->id, $this->student->id);
-        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
+        $this->assertCount(1, $result['attempts']);
         $this->assertEquals($this->student->id, $result['attempts'][0]['userid']);
         $this->assertCount(1, $result['attempts']);
+        $this->resetDebugging();
-        $this->assertEquals($this->student->id, $result['attempts'][0]['userid']);
+        $result = mod_quiz_external::get_user_attempts($quiz->id, $this->student->id, 'all');
         $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
-        $result = mod_quiz_external::get_user_attempts($quiz->id, $this->student->id, 'all');
+        $this->assertDebuggingCalled();
-        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
+        $this->assertCount(2, $result['attempts']);
         $this->assertEquals($this->student->id, $result['attempts'][0]['userid']);
         $this->assertCount(2, $result['attempts']);
+        // Invalid parameters.
+        try {
+            $this->resetDebugging();
+            mod_quiz_external::get_user_attempts($quiz->id, $this->student->id, 'INVALID_PARAMETER');
+            $this->fail('Exception expected due to missing capability.');
-        $this->assertEquals($this->student->id, $result['attempts'][0]['userid']);
+        } catch (\invalid_parameter_exception $e) {
             $this->assertDebuggingCalled();
-        // Invalid parameters.
+            $this->assertEquals('invalidparameter', $e->errorcode);
         try {
         $structure = $attemptobj->get_quizobj()->get_structure();
         $structure->update_slot_grade_item($structure->get_slot_by_number(1), $listeninggrade->id);
         $structure->update_slot_grade_item($structure->get_slot_by_number(2), $readinggrade->id);
+        $this->setUser($this->student);
-        $this->setUser($this->student);
+        $this->resetDebugging();
         $result = mod_quiz_external::get_user_attempts($quiz->id);
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
-        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
+        $this->assertDebuggingCalled();
         $this->assertCount(1, $result['attempts']);
         $this->assertEquals($attempt->id, $result['attempts'][0]['id']);
         // Verify additional grades.
         $this->assertEquals(['name' => 'Listening', 'grade' => 1, 'maxgrade' => 1], $result['attempts'][0]['gradeitemmarks'][0]);
+        $this->assertEquals(['name' => 'Reading', 'grade' => 0, 'maxgrade' => 1], $result['attempts'][0]['gradeitemmarks'][1]);
         $this->assertEquals(['name' => 'Reading', 'grade' => 0, 'maxgrade' => 1], $result['attempts'][0]['gradeitemmarks'][1]);
         // Now change the review options, so marks are not displayed, and check the result.
+        $DB->set_field('quiz', 'reviewmarks', 0, ['id' => $quiz->id]);
-        // Now change the review options, so marks are not displayed, and check the result.
+        $this->resetDebugging();
-        $DB->set_field('quiz', 'reviewmarks', 0, ['id' => $quiz->id]);
+        $result = mod_quiz_external::get_user_attempts($quiz->id);
-        $result = mod_quiz_external::get_user_attempts($quiz->id);
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
-        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
+        $this->assertDebuggingCalled();
         $this->assertCount(1, $result['attempts']);
+        $this->assertEquals($attempt->id, $result['attempts'][0]['id']);
+        $this->assertArrayNotHasKey('gradeitemmarks', $result['attempts'][0]);
         $this->assertEquals($attempt->id, $result['attempts'][0]['id']);
         $this->assertArrayNotHasKey('gradeitemmarks', $result['attempts'][0]);
     /**
      * Test get_user_attempts with marks hidden
     /**
-     * Test get_user_attempts with marks hidden
+     * @todo Remove in Moodle 6.0 as part of MDL-80956 final deprecations.
      */
     public function test_get_user_attempts_with_marks_hidden(): void {
+        // Create quiz with one attempt finished and hide the mark.
-        // Create quiz with one attempt finished and hide the mark.
+        list($quiz, $context, $quizobj, $attempt, $attemptobj) = $this->create_quiz_with_questions(
-        list($quiz, $context, $quizobj, $attempt, $attemptobj) = $this->create_quiz_with_questions(
+                true, true, 'deferredfeedback', false,
+                ['marksduring' => 0, 'marksimmediately' => 0, 'marksopen' => 0, 'marksclosed' => 0]);
                 true, true, 'deferredfeedback', false,
-                ['marksduring' => 0, 'marksimmediately' => 0, 'marksopen' => 0, 'marksclosed' => 0]);
+        // Student cannot see the grades.
         $this->setUser($this->student);
-        // Student cannot see the grades.
+        $this->resetDebugging();
         $this->assertArrayHasKey('sumgrades', $result['attempts'][0]);
         $this->assertEquals(null, $result['attempts'][0]['sumgrades']);
         // Test manager can see user grades.
+        $this->setUser($this->teacher);
-        $this->setUser($this->teacher);
+        $this->resetDebugging();
         $result = mod_quiz_external::get_user_attempts($quiz->id, $this->student->id);
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
+        $this->assertDebuggingCalled();
+        $this->assertCount(1, $result['attempts']);
+        $this->assertEquals($attempt->id, $result['attempts'][0]['id']);
+        $this->assertEquals($quiz->id, $result['attempts'][0]['quiz']);
+        $this->assertEquals($this->student->id, $result['attempts'][0]['userid']);
+        $this->assertEquals(1, $result['attempts'][0]['attempt']);
+        $this->assertArrayHasKey('sumgrades', $result['attempts'][0]);
+        $this->assertEquals(1.0, $result['attempts'][0]['sumgrades']);
+    }
+    /**
+     * Test get_user_attempts when the attempt is in 'submitted' state.
+     *
+     * @todo Remove in Moodle 6.0 as part of MDL-80956 final deprecations.
+     * @covers \mod_quiz_external::get_user_attempts
+     */
+    public function test_get_user_attempts_submitted(): void {
+        // Create a quiz with one attempt.
+        [$quiz, , , $attempt, $attemptobj] = $this->create_quiz_with_questions(true);
+        // Submit the attempt but do not finish it.
+        // Process some responses from the student.
+        $tosubmit = [1 => ['answer' => '3.14']];
+        $attemptobj->process_submitted_actions(time(), false, $tosubmit);
+        $attemptobj->process_submit(time(), false);
+        $this->setUser($this->student);
+        $result = mod_quiz_external::get_user_attempts($quiz->id);
+        $this->assertDebuggingCalled();
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
+        $this->assertCount(1, $result['attempts']);
+        $this->assertEquals($attempt->id, $result['attempts'][0]['id']);
+        $this->assertEquals($quiz->id, $result['attempts'][0]['quiz']);
+        $this->assertEquals($this->student->id, $result['attempts'][0]['userid']);
+        $this->assertEquals(1, $result['attempts'][0]['attempt']);
+        $this->assertArrayHasKey('sumgrades', $result['attempts'][0]);
+        $this->assertNull($result['attempts'][0]['sumgrades']); // No grades.
+        $this->assertEquals(quiz_attempt::FINISHED, $result['attempts'][0]['state']); // State is returned as finished.
+    }
+    /**
+     * Test get_user_attempts when the attempt is in 'notstarted' state. The attempt should not be returned.
+     *
+     * @todo Remove in Moodle 6.0 as part of MDL-80956 final deprecations.
+     * @covers \mod_quiz_external::get_user_attempts
+     */
+    public function test_get_user_attempts_notstarted(): void {
+        // Create a quiz.
+        [$quiz, , $quizobj, , ] = $this->create_quiz_with_questions();
+        // Create an attempt but do not start it.
+        // Now, do one attempt.
+        $quba = \question_engine::make_questions_usage_by_activity('mod_quiz', $quizobj->get_context());
+        $quba->set_preferred_behaviour($quizobj->get_quiz()->preferredbehaviour);
+        $timenow = time();
+        $attempt = quiz_create_attempt($quizobj, 1, false, $timenow, false, $this->student->id);
+        quiz_start_new_attempt($quizobj, $quba, $attempt, 1, $timenow);
+        quiz_attempt_save_not_started($quba, $attempt);
+        $this->setUser($this->student);
+        $result = mod_quiz_external::get_user_attempts($quiz->id, $this->student->id, 'all');
+        $this->assertDebuggingCalled();
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
+        $this->assertCount(0, $result['attempts']);
+    }
+    /**
+     * Test get_quiz_user_attempts
+     *
+     * @covers \mod_quiz_external::get_user_quiz_attempts
+     */
+    public function test_get_user_quiz_attempts(): void {
+        // Create a quiz with one attempt finished.
+        [$quiz, , $quizobj, $attempt, ] = $this->create_quiz_with_questions(true, true);
+        $this->setUser($this->student);
+        $result = mod_quiz_external::get_user_quiz_attempts($quiz->id);
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_quiz_attempts_returns(), $result);
+        $this->assertCount(1, $result['attempts']);
+        $this->assertEquals($attempt->id, $result['attempts'][0]['id']);
+        $this->assertEquals($quiz->id, $result['attempts'][0]['quiz']);
+        $this->assertEquals($this->student->id, $result['attempts'][0]['userid']);
+        $this->assertEquals(1, $result['attempts'][0]['attempt']);
+        $this->assertArrayHasKey('sumgrades', $result['attempts'][0]);
+        $this->assertEquals(1.0, $result['attempts'][0]['sumgrades']);
+        $this->assertEquals(quiz_attempt::FINISHED, $result['attempts'][0]['state']);
+        // Test filters. Only finished.
+        $result = mod_quiz_external::get_user_quiz_attempts($quiz->id, 0, 'finished', false);
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_quiz_attempts_returns(), $result);
+        $this->assertCount(1, $result['attempts']);
+        $this->assertEquals($attempt->id, $result['attempts'][0]['id']);
+        // Test filters. All attempts.
+        $result = mod_quiz_external::get_user_quiz_attempts($quiz->id, 0, 'all', false);
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_quiz_attempts_returns(), $result);
+        $this->assertCount(1, $result['attempts']);
+        $this->assertEquals($attempt->id, $result['attempts'][0]['id']);
+        // Test filters. Unfinished.
+        $result = mod_quiz_external::get_user_quiz_attempts($quiz->id, 0, 'unfinished', false);
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_quiz_attempts_returns(), $result);
+        $this->assertCount(0, $result['attempts']);
+        // Start a new attempt, but not finish it.
+        $timenow = time();
+        $attempt = quiz_create_attempt($quizobj, 2, false, $timenow, false, $this->student->id);
+        $quba = \question_engine::make_questions_usage_by_activity('mod_quiz', $quizobj->get_context());
+        $quba->set_preferred_behaviour($quizobj->get_quiz()->preferredbehaviour);
+        quiz_start_new_attempt($quizobj, $quba, $attempt, 1, $timenow);
+        quiz_attempt_save_started($quizobj, $quba, $attempt);
+        // Test filters. All attempts.
+        $result = mod_quiz_external::get_user_quiz_attempts($quiz->id, 0, 'all', false);
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_quiz_attempts_returns(), $result);
+        $this->assertCount(2, $result['attempts']);
+        // Test filters. Unfinished.
+        $result = mod_quiz_external::get_user_quiz_attempts($quiz->id, 0, 'unfinished', false);
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_quiz_attempts_returns(), $result);
+        $this->assertCount(1, $result['attempts']);
+        // Test manager can see user attempts.
+        $this->setUser($this->teacher);
+        $result = mod_quiz_external::get_user_quiz_attempts($quiz->id, $this->student->id);
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_quiz_attempts_returns(), $result);
+        $this->assertCount(1, $result['attempts']);
+        $this->assertEquals($this->student->id, $result['attempts'][0]['userid']);
+        $result = mod_quiz_external::get_user_quiz_attempts($quiz->id, $this->student->id, 'all');
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_quiz_attempts_returns(), $result);
+        $this->assertCount(2, $result['attempts']);
+        $this->assertEquals($this->student->id, $result['attempts'][0]['userid']);
+        // Invalid parameters.
+        try {
+            mod_quiz_external::get_user_quiz_attempts($quiz->id, $this->student->id, 'INVALID_PARAMETER');
+            $this->fail('Exception expected due to missing capability.');
+        } catch (\invalid_parameter_exception $e) {
+            $this->assertEquals('invalidparameter', $e->errorcode);
+        }
+    }
+    /**
+     * Test get_user_quiz_attempts with extra grades
+     */
+    public function test_get_user_quiz_attempts_with_extra_grades(): void {
+        global $DB;
+        // Create a quiz with one attempt finished.
+        [$quiz, , , $attempt, $attemptobj] = $this->create_quiz_with_questions(true, true);
+        // Add some extra grade items.
+        $quizgenerator = $this->getDataGenerator()->get_plugin_generator('mod_quiz');
+        $listeninggrade = $quizgenerator->create_grade_item(['quizid' => $attemptobj->get_quizid(), 'name' => 'Listening']);
+        $readinggrade = $quizgenerator->create_grade_item(['quizid' => $attemptobj->get_quizid(), 'name' => 'Reading']);
+        $structure = $attemptobj->get_quizobj()->get_structure();
+        $structure->update_slot_grade_item($structure->get_slot_by_number(1), $listeninggrade->id);
+        $structure->update_slot_grade_item($structure->get_slot_by_number(2), $readinggrade->id);
+        $this->setUser($this->student);
+        $result = mod_quiz_external::get_user_quiz_attempts($quiz->id);
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_quiz_attempts_returns(), $result);
+        $this->assertCount(1, $result['attempts']);
+        $this->assertEquals($attempt->id, $result['attempts'][0]['id']);
+        // Verify additional grades.
+        $this->assertEquals(['name' => 'Listening', 'grade' => 1, 'maxgrade' => 1], $result['attempts'][0]['gradeitemmarks'][0]);
+        $this->assertEquals(['name' => 'Reading', 'grade' => 0, 'maxgrade' => 1], $result['attempts'][0]['gradeitemmarks'][1]);
+        // Now change the review options, so marks are not displayed, and check the result.
+        $DB->set_field('quiz', 'reviewmarks', 0, ['id' => $quiz->id]);
+        $result = mod_quiz_external::get_user_quiz_attempts($quiz->id);
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_quiz_attempts_returns(), $result);
+        $this->assertCount(1, $result['attempts']);
+        $this->assertEquals($attempt->id, $result['attempts'][0]['id']);
+        $this->assertArrayNotHasKey('gradeitemmarks', $result['attempts'][0]);
+    }
+    /**
+     * Test get_user_quiz_attempts with marks hidden
+     *
+     * @covers \mod_quiz_external::get_user_quiz_attempts
+     */
+    public function test_get_user_quiz_attempts_with_marks_hidden(): void {
+        // Create quiz with one attempt finished and hide the mark.
+        [$quiz, , , $attempt, ] = $this->create_quiz_with_questions(
+                true, true, 'deferredfeedback', false,
+                ['marksduring' => 0, 'marksimmediately' => 0, 'marksopen' => 0, 'marksclosed' => 0]);
+        // Student cannot see the grades.
+        $this->setUser($this->student);
+        $result = mod_quiz_external::get_user_quiz_attempts($quiz->id);
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_quiz_attempts_returns(), $result);
+        $this->assertCount(1, $result['attempts']);
+        $this->assertEquals($attempt->id, $result['attempts'][0]['id']);
+        $this->assertEquals($quiz->id, $result['attempts'][0]['quiz']);
+        $this->assertEquals($this->student->id, $result['attempts'][0]['userid']);
+        $this->assertEquals(1, $result['attempts'][0]['attempt']);
+        $this->assertArrayHasKey('sumgrades', $result['attempts'][0]);
+        $this->assertEquals(null, $result['attempts'][0]['sumgrades']);
+        // Test manager can see user grades.
+        $this->setUser($this->teacher);
+        $result = mod_quiz_external::get_user_quiz_attempts($quiz->id, $this->student->id);
-        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_attempts_returns(), $result);
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_quiz_attempts_returns(), $result);
         $this->assertCount(1, $result['attempts']);
         $this->assertEquals($attempt->id, $result['attempts'][0]['id']);
         $this->assertArrayHasKey('sumgrades', $result['attempts'][0]);
         $this->assertEquals(1.0, $result['attempts'][0]['sumgrades']);
+    }
+    /**
+     * Test get_user_quiz_attempts when the attempt is in 'submitted' state.
+     *
+     * @covers \mod_quiz_external::get_user_quiz_attempts
+     */
+    public function test_get_user_quiz_attempts_submitted(): void {
+        // Create a quiz with one attempt.
+        [$quiz, , , $attempt, $attemptobj] = $this->create_quiz_with_questions(true);
+        // Submit the attempt but do not finish it.
+        // Process some responses from the student.
+        $tosubmit = [1 => ['answer' => '3.14']];
+        $attemptobj->process_submitted_actions(time(), false, $tosubmit);
+        $attemptobj->process_submit(time(), false);
+        $this->setUser($this->student);
+        $result = mod_quiz_external::get_user_quiz_attempts($quiz->id);
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_quiz_attempts_returns(), $result);
+        $this->assertCount(1, $result['attempts']);
+        $this->assertEquals($attempt->id, $result['attempts'][0]['id']);
+        $this->assertEquals($quiz->id, $result['attempts'][0]['quiz']);
+        $this->assertEquals($this->student->id, $result['attempts'][0]['userid']);
+        $this->assertEquals(1, $result['attempts'][0]['attempt']);
+        $this->assertArrayHasKey('sumgrades', $result['attempts'][0]);
+        $this->assertNull($result['attempts'][0]['sumgrades']); // No grades.
+        $this->assertEquals(quiz_attempt::SUBMITTED, $result['attempts'][0]['state']);
+    }
+    /**
+     * Test get_user_quiz_attempts when the attempt is in 'notstarted' state.
+     *
+     * @covers \mod_quiz_external::get_user_quiz_attempts
+     */
+    public function test_get_user_quiz_attempts_notstarted(): void {
+        // Create a quiz.
+        [$quiz, , $quizobj, , ] = $this->create_quiz_with_questions();
+        // Create an attempt but do not start it.
+        // Now, do one attempt.
+        $quba = \question_engine::make_questions_usage_by_activity('mod_quiz', $quizobj->get_context());
+        $quba->set_preferred_behaviour($quizobj->get_quiz()->preferredbehaviour);
+        $timenow = time();
+        $attempt = quiz_create_attempt($quizobj, 1, false, $timenow, false, $this->student->id);
+        quiz_start_new_attempt($quizobj, $quba, $attempt, 1, $timenow);
+        quiz_attempt_save_not_started($quba, $attempt);
+        $this->setUser($this->student);
+        $result = mod_quiz_external::get_user_quiz_attempts($quiz->id, $this->student->id, 'all');
+        $result = external_api::clean_returnvalue(mod_quiz_external::get_user_quiz_attempts_returns(), $result);
+        $this->assertCount(1, $result['attempts']);
+        $this->assertEquals($attempt->id, $result['attempts'][0]['id']);
+        $this->assertEquals($quiz->id, $result['attempts'][0]['quiz']);
+        $this->assertEquals($this->student->id, $result['attempts'][0]['userid']);
+        $this->assertEquals(1, $result['attempts'][0]['attempt']);
+        $this->assertArrayHasKey('sumgrades', $result['attempts'][0]);
+        $this->assertNull($result['attempts'][0]['sumgrades']);
+        $this->assertEquals(quiz_attempt::NOT_STARTED, $result['attempts'][0]['state']);
+    }
     /**
      * Test get_user_best_grade
      */
     public function test_get_user_best_grade(): void {
         $quizgenerator = $this->getDataGenerator()->get_plugin_generator('mod_quiz');
         // Process some responses from the student.
         $attemptobj = quiz_attempt::create($attempt->id);
         $attemptobj->process_submitted_actions($timenow, false, [1 => ['answer' => '3.14']]);
         // Finish the attempt.
+        $attemptobj->process_submit($timenow, false);
-        $attemptobj->process_finish($timenow, false);
+        $attemptobj->process_grade_submission($timenow);
         $result = mod_quiz_external::get_user_best_grade($quizapi1->id);
         // Process some responses from the student.
         $attemptobj = quiz_attempt::create($attempt->id);
         $attemptobj->process_submitted_actions($timenow, false, [1 => ['answer' => '3.14']]);
         // Finish the attempt.
+        $attemptobj->process_submit($timenow, false);
-        $attemptobj->process_finish($timenow, false);
+        $attemptobj->process_grade_submission($timenow);
         $result = mod_quiz_external::get_user_best_grade($quizapi2->id);
         $this->assertEquals($expected, $result);
         // Now, finish the attempt.
+        $attemptobj = quiz_attempt::create($attempt->id);
-        $attemptobj = quiz_attempt::create($attempt->id);
+        $attemptobj->process_submit($timenow, false);
-        $attemptobj->process_finish($timenow, false);
+        $attemptobj->process_grade_submission($timenow);
         $expected = [
         $attemptobj->process_submitted_actions($timenow, false, $tosubmit);
         // Finish the attempt.
         $attemptobj = quiz_attempt::create($attemptid);
         $this->assertTrue($attemptobj->has_response_to_at_least_one_graded_question());
+        $attemptobj->process_submit($timenow, false);
-        $attemptobj->process_finish($timenow, false);
+        $attemptobj->process_grade_submission($timenow);
         // We should be able to start a new attempt.
             $this->assertEquals('attempterror', $e->errorcode);
+        }
         // Finish the attempt.
         $attemptobj = quiz_attempt::create($attempt->id);
+        $attemptobj->process_submit(time(), false);
-        $attemptobj->process_finish(time(), false);
+        $attemptobj->process_grade_submission(time());
         try {
             testable_mod_quiz_external::validate_attempt($params, false);
         $this->assertFalse($result['questions'][0]['flagged']);
         $this->assertEquals(0, $result['questions'][0]['page']);
         $this->assertEmpty($result['questions'][0]['mark']);
         $this->assertEquals(1, $result['questions'][0]['maxmark']);
         $this->assertEquals(1, $result['questions'][0]['sequencecheck']);
-        $this->assertGreaterThanOrEqual($timenow, $result['questions'][0]['lastactiontime']);
+        $this->assertEquals(\question_attempt_step::TIMECREATED_ON_FIRST_RENDER, $result['questions'][0]['lastactiontime']);
         $this->assertEquals(false, $result['questions'][0]['hasautosavedstep']);
         // Now try the last page.
         $result = mod_quiz_external::get_attempt_data($attempt->id, 1);
         $this->assertArrayNotHasKey('state', $result['questions'][0]);  // We don't receive the state yet.
         $this->assertEquals(get_string('notyetanswered', 'question'), $result['questions'][0]['status']);
         $this->assertFalse($result['questions'][0]['flagged']);
         $this->assertEquals(1, $result['questions'][0]['page']);
         $this->assertEquals(1, $result['questions'][0]['sequencecheck']);
-        $this->assertGreaterThanOrEqual($timenow, $result['questions'][0]['lastactiontime']);
+        $this->assertEquals(\question_attempt_step::TIMECREATED_ON_FIRST_RENDER, $result['questions'][0]['lastactiontime']);
         $this->assertEquals(false, $result['questions'][0]['hasautosavedstep']);
         // Finish previous attempt.
+        $attemptobj->process_submit(time(), false);
-        $attemptobj->process_finish(time(), false);
+        $attemptobj->process_grade_submission(time());
         // Now we should receive the question state.
         $result = mod_quiz_external::get_attempt_review($attempt->id, 1);
         $this->assertFalse($result['questions'][1]['flagged']);
         $this->assertEmpty($result['questions'][0]['mark']);
         $this->assertEmpty($result['questions'][1]['mark']);
         $this->assertEquals(1, $result['questions'][0]['sequencecheck']);
         $this->assertEquals(1, $result['questions'][1]['sequencecheck']);
-        $this->assertGreaterThanOrEqual($timenow, $result['questions'][0]['lastactiontime']);
+        $this->assertEquals(\question_attempt_step::TIMECREATED_ON_FIRST_RENDER, $result['questions'][0]['lastactiontime']);
-        $this->assertGreaterThanOrEqual($timenow, $result['questions'][1]['lastactiontime']);
+        $this->assertEquals(\question_attempt_step::TIMECREATED_ON_FIRST_RENDER, $result['questions'][1]['lastactiontime']);
         $this->assertEquals(false, $result['questions'][0]['hasautosavedstep']);
         $this->assertEquals(false, $result['questions'][1]['hasautosavedstep']);
         // Check question options.
         $this->assertEmpty($result['questions'][0]['mark']);
         $this->assertEmpty($result['questions'][1]['mark']);
         $this->assertEquals(1, $result['questions'][0]['sequencecheck']);
         $this->assertEquals(1, $result['questions'][1]['sequencecheck']);
         $this->assertGreaterThanOrEqual($timenow, $result['questions'][0]['lastactiontime']);
-        $this->assertGreaterThanOrEqual($timenow, $result['questions'][1]['lastactiontime']);
+        $this->assertEquals(\question_attempt_step::TIMECREATED_ON_FIRST_RENDER, $result['questions'][1]['lastactiontime']);
         $this->assertEquals(true, $result['questions'][0]['hasautosavedstep']);
         $this->assertEquals(false, $result['questions'][1]['hasautosavedstep']);
         // Now, second slot.
         $attemptobj->process_submitted_actions($timenow, false, $tosubmit);
         // Finish the attempt.
         $attemptobj = quiz_attempt::create($attempt->id);
         $this->assertTrue($attemptobj->has_response_to_at_least_one_graded_question());
+        $attemptobj->process_submit($timenow, false);
-        $attemptobj->process_finish($timenow, false);
+        $attemptobj->process_grade_submission($timenow);
         // Can we start a new attempt? We shall not!

Proyectos de Subversion Moodle

(root)/mod/quiz/tests/external/external_test.php – Rev 11 → 1441