WebSVN – Moodle – Diff – /mod/quiz/tests/attempt_walkthrough_test.php

 namespace mod_quiz;
 use moodle_url;
 use question_bank;
 use question_engine;
-use mod_quiz\question\bank\qbank_helper;
-defined('MOODLE_INTERNAL') || die();
-global $CFG;
-require_once($CFG->dirroot . '/mod/quiz/locallib.php');
-require_once($CFG->dirroot . '/mod/quiz/tests/quiz_question_helper_test_trait.php');
+use mod_quiz\tests\question_helper_test_trait;
 /**
  * Quiz attempt walk through.
  * @copyright 2013 The Open University
  * @author    Jamie Pratt <me@jamiep.org>
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  * @covers \mod_quiz\quiz_attempt
  */
-class attempt_walkthrough_test extends \advanced_testcase {
+final class attempt_walkthrough_test extends \advanced_testcase {
+    use question_helper_test_trait;
+    #[\Override]
+    public static function setUpBeforeClass(): void {
+        global $CFG;
+        parent::setUpBeforeClass();
+        require_once($CFG->dirroot . '/mod/quiz/locallib.php');
     use \quiz_question_helper_test_trait;
     /**
      * Create a quiz with questions and walk through a quiz attempt.
         $tosubmit = [
 => [
                 'frog' => 'amphibian',
                 'cat' => 'mammal',
-                'newt' => ''
+                'newt' => '',
             ],
         ];
         $attemptobj->process_submitted_actions($timenow, false, $tosubmit);
         // The student has answered three questions but one is invalid, so there is still one remaining.
         $this->assertEquals(1, $attemptobj->get_number_of_unanswered_questions());
         $tosubmit = [
 => [
                 'frog' => 'amphibian',
                 'cat' => 'mammal',
-                'newt' => 'amphibian'
+                'newt' => 'amphibian',
             ],
         ];
         $attemptobj->process_submitted_actions($timenow, false, $tosubmit);
         // The student has answered three questions, so there are no remaining.
         $this->assertEquals(0, $attemptobj->get_number_of_unanswered_questions());
         // Finish the attempt.
         $attemptobj = quiz_attempt::create($attempt->id);
         $this->assertTrue($attemptobj->has_response_to_at_least_one_graded_question());
-        $attemptobj->process_finish($timenow, false);
+        $attemptobj->process_submit($timenow, false);
         // Re-load quiz attempt data.
-        $attemptobj = quiz_attempt::create($attempt->id);
+        // Re-load quiz attempt data.
         $attemptobj = quiz_attempt::create($attempt->id);
         // Check that results are stored as expected.
+        // Check that results are stored as expected.
+        $this->assertEquals(1, $attemptobj->get_attempt_number());
+        $this->assertEquals(false, $attemptobj->is_finished());
+        $this->assertEquals($timenow, $attemptobj->get_submitted_date());
+        $this->assertEquals($user1->id, $attemptobj->get_userid());
+        $this->assertTrue($attemptobj->has_response_to_at_least_one_graded_question());
+        $this->assertEquals(0, $attemptobj->get_number_of_unanswered_questions());
-        $this->assertEquals(1, $attemptobj->get_attempt_number());
+        // Check we don't have grades yet.
+        $this->assertEmpty(quiz_get_user_grades($quiz, $user1->id));
+        $this->assertNull($attemptobj->get_sum_marks());
-        $this->assertEquals(3, $attemptobj->get_sum_marks());
+        // Now grade the submission.
-        $this->assertEquals(true, $attemptobj->is_finished());
+        $attemptobj->process_grade_submission($timenow);
-        $this->assertEquals($timenow, $attemptobj->get_submitted_date());
+        $attemptobj = quiz_attempt::create($attempt->id);
         $this->assertEquals($user1->id, $attemptobj->get_userid());
         $gradebookitem = array_shift($gradebookgrades->items);
         $gradebookgrade = array_shift($gradebookitem->grades);
         $this->assertEquals(100, $gradebookgrade->grade);
         // Update question in quiz.
+        $newsa = $questiongenerator->update_question(
+            $saq,
-        $newsa = $questiongenerator->update_question($saq, null,
+            null,
+            ['name' => 'This is the second version of shortanswer']
-            ['name' => 'This is the second version of shortanswer']);
+        );
+        $newnumbq = $questiongenerator->update_question(
+            $numq,
-        $newnumbq = $questiongenerator->update_question($numq, null,
+            null,
+            ['name' => 'This is the second version of numerical']
-            ['name' => 'This is the second version of numerical']);
+        );
+        $newmatch = $questiongenerator->update_question(
+            $matchq,
-        $newmatch = $questiongenerator->update_question($matchq, null,
+            null,
+            ['name' => 'This is the second version of match']
-            ['name' => 'This is the second version of match']);
+        );
+        $newdescription = $questiongenerator->update_question(
+            $description,
-        $newdescription = $questiongenerator->update_question($description, null,
+            null,
+            ['name' => 'This is the second version of description']
-            ['name' => 'This is the second version of description']);
+        );
         // Update the attempt to use this questions.
         // Make a quiz.
         $timeclose = time() + HOURSECS;
         $quizgenerator = $this->getDataGenerator()->get_plugin_generator('mod_quiz');
         $quiz = $quizgenerator->create_instance(
-                ['course' => $SITE->id, 'timeclose' => $timeclose,
+            ['course' => $SITE->id, 'timeclose' => $timeclose,
+            'overduehandling' => $overduehandling,
+            'graceperiod' => HOURSECS]
-                        'overduehandling' => $overduehandling, 'graceperiod' => HOURSECS]);
+        );
         // Create a question.
         /** @var \core_question_generator $questiongenerator */
             // Finish the attempt.
             $attemptobj = quiz_attempt::create($attempt->id);
             $this->assertTrue($attemptobj->has_response_to_at_least_one_graded_question());
             $this->assertEquals(0, $attemptobj->get_number_of_unanswered_questions());
-            $attemptobj->process_finish($timenow, false);
+            $attemptobj->process_submit($timenow, false);
             // Re-load quiz attempt data.
             $attemptobj = quiz_attempt::create($attempt->id);
-            // Check that results are stored as expected.
-            $this->assertEquals(1, $attemptobj->get_attempt_number());
+            // Check that results are stored as expected.
-            $this->assertEquals(4, $attemptobj->get_sum_marks());
+            $this->assertEquals(1, $attemptobj->get_attempt_number());
-            $this->assertEquals(true, $attemptobj->is_finished());
+            $this->assertEquals(false, $attemptobj->is_finished());
             $this->assertEquals($timenow, $attemptobj->get_submitted_date());
+            $this->assertEquals($user1->id, $attemptobj->get_userid());
+            $this->assertTrue($attemptobj->has_response_to_at_least_one_graded_question());
+            $this->assertEquals(0, $attemptobj->get_number_of_unanswered_questions());
+            // Check we don't have grades yet.
+            $this->assertEmpty(quiz_get_user_grades($quiz, $user1->id));
+            $this->assertNull($attemptobj->get_sum_marks());
+            // Now grade the submission.
+            $attemptobj->process_grade_submission($timenow);
+            $attemptobj = quiz_attempt::create($attempt->id);
-            $this->assertEquals($user1->id, $attemptobj->get_userid());
+            // Check quiz grades.
-            $this->assertTrue($attemptobj->has_response_to_at_least_one_graded_question());
+            $this->assertEquals(true, $attemptobj->is_finished());
-            $this->assertEquals(0, $attemptobj->get_number_of_unanswered_questions());
+            $this->assertEquals(4, $attemptobj->get_sum_marks());
             $gradebookgrade = array_shift($gradebookitem->grades);
             $this->assertEquals(100, $gradebookgrade->grade);
+        }
+    }
+    /**
+     * Get the correct response for variants.
+     *
+     * @return array
+     */
-    public function get_correct_response_for_variants() {
+    public static function get_correct_response_for_variants(): array {
         return [[1, 9.9], [2, 8.5], [5, 14.2], [10, 6.8, true]];
+    }
     /** @var ?\quiz A quiz with variants */
     protected $quizwithvariants = null;
         // Finish the attempt.
         $attemptobj = quiz_attempt::create($attempt->id);
         $this->assertTrue($attemptobj->has_response_to_at_least_one_graded_question());
         $this->assertEquals(0, $attemptobj->get_number_of_unanswered_questions());
-        $attemptobj->process_finish($timenow, false);
+        $attemptobj->process_submit($timenow, false);
         // Re-load quiz attempt data.
         $attemptobj = quiz_attempt::create($attempt->id);
-        // Check that results are stored as expected.
-        $this->assertEquals(1, $attemptobj->get_attempt_number());
+        // Check that results are stored as expected.
-        $this->assertEquals(1, $attemptobj->get_sum_marks());
+        $this->assertEquals(1, $attemptobj->get_attempt_number());
-        $this->assertEquals(true, $attemptobj->is_finished());
+        $this->assertEquals(false, $attemptobj->is_finished());
         $this->assertEquals($timenow, $attemptobj->get_submitted_date());
+        $this->assertEquals($user1->id, $attemptobj->get_userid());
+        $this->assertTrue($attemptobj->has_response_to_at_least_one_graded_question());
+        $this->assertEquals(0, $attemptobj->get_number_of_unanswered_questions());
+        // Check we don't have grades yet.
+        $this->assertEmpty(quiz_get_user_grades($this->quizwithvariants, $user1->id));
+        $this->assertNull($attemptobj->get_sum_marks());
+        // Now grade the submission.
+        $attemptobj->process_grade_submission($timenow);
+        $attemptobj = quiz_attempt::create($attempt->id);
         $this->assertEquals($user1->id, $attemptobj->get_userid());
-        $this->assertTrue($attemptobj->has_response_to_at_least_one_graded_question());
+        // Check quiz grades.
-        $this->assertEquals(0, $attemptobj->get_number_of_unanswered_questions());
+        $this->assertEquals(true, $attemptobj->is_finished());
         $this->assertEquals(1, $attemptobj->get_sum_marks());
         $this->assertEquals(1, $attemptobj->get_attempt_number());
         $this->assertFalse($attemptobj->is_finished());
         $this->assertEquals(quiz_attempt::IN_PROGRESS, $attemptobj->get_state());
         $this->assertEquals(0, $attemptobj->get_submitted_date());
         $this->assertEquals($user->id, $attemptobj->get_userid());
+        $this->assertEquals(
-        $this->assertEquals($overriddentimeclose,
+            $overriddentimeclose,
-                $attemptobj->get_access_manager($reopentime)->get_end_time($attemptobj->get_attempt()));
+            $attemptobj->get_access_manager($reopentime)->get_end_time($attemptobj->get_attempt())
+        );
         // Verify this was logged correctly.
         $events = $sink->get_events();
         $this->assertCount(1, $events);
         $reopenedevent = array_shift($events);
+        $this->assertInstanceOf('\mod_quiz\event\attempt_reopened', $reopenedevent);
-        $this->assertInstanceOf('\mod_quiz\event\attempt_reopened', $reopenedevent);
+        $this->assertEquals($attemptobj->get_context(), $reopenedevent->get_context());
-        $this->assertEquals($attemptobj->get_context(), $reopenedevent->get_context());
+        $this->assertEquals(
+            new moodle_url('/mod/quiz/review.php', ['attempt' => $attemptobj->get_attemptid()]),
-        $this->assertEquals(new moodle_url('/mod/quiz/review.php', ['attempt' => $attemptobj->get_attemptid()]),
+            $reopenedevent->get_url()
-                $reopenedevent->get_url());
+        );
+    }
         $this->assertEquals($user->id, $attemptobj->get_userid());
         $this->assertEquals(1, $attemptobj->get_sum_marks());
         // Verify this was logged correctly - there are some gradebook events between the two we want to check.
         $events = $sink->get_events();
+        $this->assertGreaterThanOrEqual(3, $events);
+        $attempturl = new moodle_url(
+            '/mod/quiz/review.php',
-        $this->assertGreaterThanOrEqual(2, $events);
+            ['attempt' => $attemptobj->get_attemptid()],
         );
         $reopenedevent = array_shift($events);
-        $this->assertInstanceOf('\mod_quiz\event\attempt_reopened', $reopenedevent);
-        $this->assertEquals($attemptobj->get_context(), $reopenedevent->get_context());
+        $this->assertInstanceOf('\mod_quiz\event\attempt_reopened', $reopenedevent);
+        $this->assertEquals($attemptobj->get_context(), $reopenedevent->get_context());
-        $this->assertEquals(new moodle_url('/mod/quiz/review.php', ['attempt' => $attemptobj->get_attemptid()]),
-                $reopenedevent->get_url());
+        $this->assertEquals($attempturl, $reopenedevent->get_url());
+        $submittedevent = array_shift($events);
+        $this->assertInstanceOf('\mod_quiz\event\attempt_submitted', $submittedevent);
+        $this->assertEquals($attemptobj->get_context(), $submittedevent->get_context());
+        $this->assertEquals($attempturl, $submittedevent->get_url());
-        $submittedevent = array_pop($events);
+        $gradedevent = array_pop($events);
+        $this->assertInstanceOf('\mod_quiz\event\attempt_graded', $gradedevent);
+        $this->assertEquals($attemptobj->get_context(), $gradedevent->get_context());
+        $this->assertEquals($attempturl, $gradedevent->get_url());
+    }
+    /**
+     * Create a quiz with questions, pre-create an attempt, edit a question, then begin the attempt.
+     */
+    public function test_quiz_attempt_walkthrough_update_question_after_precreate(): void {
+        global $SITE;
+        $this->resetAfterTest(true);
+        // Make a quiz.
+        $quizgenerator = $this->getDataGenerator()->get_plugin_generator('mod_quiz');
-        $this->assertInstanceOf('\mod_quiz\event\attempt_submitted', $submittedevent);
+        $quiz = $quizgenerator->create_instance(
+            [
+                'course' => $SITE->id,
+                'questionsperpage' => 0,
+                'grade' => 100.0,
+                'sumgrades' => 3,
+            ],
+        );
+        // Create a couple of questions.
+        $questiongenerator = $this->getDataGenerator()->get_plugin_generator('core_question');
+        $cat = $questiongenerator->create_question_category();
+        $saq = $questiongenerator->create_question('shortanswer', null, ['category' => $cat->id]);
+        $numq = $questiongenerator->create_question('numerical', null, ['category' => $cat->id]);
+        $matchq = $questiongenerator->create_question('match', null, ['category' => $cat->id]);
+        $description = $questiongenerator->create_question('description', null, ['category' => $cat->id]);
+        // Add them to the quiz.
+        quiz_add_quiz_question($saq->id, $quiz);
+        quiz_add_quiz_question($numq->id, $quiz);
+        quiz_add_quiz_question($matchq->id, $quiz);
+        quiz_add_quiz_question($description->id, $quiz);
+        // Make a user to do the quiz.
+        $user1 = $this->getDataGenerator()->create_user();
+        $quizobj = quiz_settings::create($quiz->id, $user1->id);
+        // Start the attempt.
+        $quba = question_engine::make_questions_usage_by_activity('mod_quiz', $quizobj->get_context());
+        $quba->set_preferred_behaviour($quizobj->get_quiz()->preferredbehaviour);
+        $timenow = time();
+        $attempt = quiz_create_attempt($quizobj, 1, false, $timenow, false, $user1->id);
+        quiz_start_new_attempt($quizobj, $quba, $attempt, 1, $timenow);
+        $this->assertEquals('1,2,3,4,0', $attempt->layout);
+        quiz_attempt_save_not_started($quba, $attempt);
+        $attemptobj = quiz_attempt::create($attempt->id);
+        // Update question in quiz.
+        $newsa = $questiongenerator->update_question($saq, null,
+            ['name' => 'This is the second version of shortanswer']);
+        $newnumbq = $questiongenerator->update_question($numq, null,
+            ['name' => 'This is the second version of numerical']);
+        $newmatch = $questiongenerator->update_question($matchq, null,
+            ['name' => 'This is the second version of match']);
+        $newdescription = $questiongenerator->update_question($description, null,
+            ['name' => 'This is the second version of description']);
+        $this->assertEquals($saq->id, $attemptobj->get_question_attempt(1)->get_question_id());
+        $this->assertEquals($numq->id, $attemptobj->get_question_attempt(2)->get_question_id());
+        $this->assertEquals($matchq->id, $attemptobj->get_question_attempt(3)->get_question_id());
+        $this->assertEquals($description->id, $attemptobj->get_question_attempt(4)->get_question_id());
+        quiz_attempt_save_started($quizobj, $quba, $attempt);
+        // Verify that the started attempt contains the new questions.
+        $attemptobj = quiz_attempt::create($attempt->id);
+        $this->assertEquals($newsa->id, $attemptobj->get_question_attempt(1)->get_question_id());
-        $this->assertEquals($attemptobj->get_context(), $submittedevent->get_context());
+        $this->assertEquals($newnumbq->id, $attemptobj->get_question_attempt(2)->get_question_id());
-        $this->assertEquals(new moodle_url('/mod/quiz/review.php', ['attempt' => $attemptobj->get_attemptid()]),
+        $this->assertEquals($newmatch->id, $attemptobj->get_question_attempt(3)->get_question_id());

Proyectos de Subversion Moodle

(root)/mod/quiz/tests/attempt_walkthrough_test.php – Rev 11 → 1441