WebSVN – Moodle – Diff – /mod/quiz/locallib.php

+        }
         $attempt = $lastattempt;
+    }
-    $attempt->attempt = $attemptnumber;
-    $attempt->timestart = $timenow;
+    $attempt->attempt = $attemptnumber;
     $attempt->timefinish = 0;
     $attempt->timemodified = $timenow;
-    $attempt->timemodifiedoffline = 0;
-    $attempt->state = quiz_attempt::IN_PROGRESS;
+    $attempt->timemodifiedoffline = 0;
     $attempt->currentpage = 0;
     $attempt->sumgrades = null;
+    $attempt->gradednotificationsenttime = null;
-    $attempt->gradednotificationsenttime = null;
+    $attempt->timecheckstate = null;
     // If this is a preview, mark it as such.
     if ($ispreview) {
-        $attempt->preview = 1;
-    }
-    $timeclose = $quizobj->get_access_manager($timenow)->get_end_time($attempt);
-    if ($timeclose === false || $ispreview) {
-        $attempt->timecheckstate = null;
-    } else {
-        $attempt->timecheckstate = $timeclose;
-    }
         $attempt->preview = 1;
     di::get(hook\manager::class)->dispatch(new attempt_state_changed(null, $attempt));
     return $attempt;
+}
             $forcedvariantsbyslot, $quba);
         $variantstrategy = new question_variant_forced_choices_selection_strategy(
             $forcedvariantsbyseed, $variantstrategy);
+    }
-    $quba->start_all_questions($variantstrategy, $timenow, $attempt->userid);
+    $quba->start_all_questions($variantstrategy, question_attempt_step::TIMECREATED_ON_FIRST_RENDER, $attempt->userid);
     // Work out the attempt layout.
     $sections = $quizobj->get_sections();
     $attempt->layout = implode(',', $newlayout);
     return $attempt;
+}
 /**
+ * Create or update the quiz attempt record, and the question usage.
+ *
+ * If the attempt already exists in the database with the NOT_STARTED state, it will be transitioned
+ * to IN_PROGRESS and the timestart updated. If it does not already exist, a new record will be created
- * The save started question usage and quiz attempt in db and log the started attempt.
+ * already in the IN_PROGRESS state.
+ *
  * @param quiz_settings $quizobj
  * @param question_usage_by_activity $quba
+ * @param stdClass                     $attempt
- * @param stdClass                     $attempt
+ * @param ?int $timenow The time to use for the attempt's timestart property. Defaults to time().
  * @return stdClass                    attempt object with uniqueid and id set.
  */
+function quiz_attempt_save_started(
+    quiz_settings $quizobj,
+    question_usage_by_activity $quba,
+    \stdClass $attempt,
+    ?int $timenow = null,
-function quiz_attempt_save_started($quizobj, $quba, $attempt) {
+): stdClass {
+    global $DB;
+    $attempt->timestart = $timenow ?? time();
+    $timeclose = $quizobj->get_access_manager($attempt->timestart)->get_end_time($attempt);
+    if ($timeclose === false || $attempt->preview) {
+        $attempt->timecheckstate = null;
+    } else {
+        $attempt->timecheckstate = $timeclose;
+    }
+    $originalattempt = null;
+    if (isset($attempt->id) && $attempt->state === quiz_attempt::NOT_STARTED) {
+        $originalattempt = clone $attempt;
+        // In case questions have been edited since attempts were pre-created, update questions now.
+        quiz_attempt::create($attempt->id)->update_questions_to_new_version_if_changed();
+        // Update the attempt's state.
+        $attempt->state = quiz_attempt::IN_PROGRESS;
+        $DB->update_record('quiz_attempts', $attempt);
-    global $DB;
+    } else {
-    // Save the attempt in the database.
+        // Save the attempt in the database.
-    question_engine::save_questions_usage_by_activity($quba);
+        question_engine::save_questions_usage_by_activity($quba);
+        $attempt->uniqueid = $quba->get_id();
-    $attempt->uniqueid = $quba->get_id();
+        $attempt->state = quiz_attempt::IN_PROGRESS;
+        $attempt->id = $DB->insert_record('quiz_attempts', $attempt);
     $attempt->id = $DB->insert_record('quiz_attempts', $attempt);
     // Params used by the events below.
     $params = [
     // Trigger the event.
     $event->add_record_snapshot('quiz', $quizobj->get_quiz());
     $event->add_record_snapshot('quiz_attempts', $attempt);
     $event->trigger();
+    di::get(hook\manager::class)->dispatch(new attempt_state_changed($originalattempt, $attempt));
+    return $attempt;
+}
+/**
+ * Create the quiz attempt record, and the question usage.
+ *
+ * This saves an attempt in the NOT_STARTED state, and is designed for use when pre-creating attempts
+ * ahead of the quiz start time to spread out the processing load.
+ *
+ * @param question_usage_by_activity $quba
+ * @param stdClass $attempt
+ * @return stdClass attempt object with uniqueid and id set.
+ */
+function quiz_attempt_save_not_started(question_usage_by_activity $quba, stdClass $attempt): stdClass {
+    global $DB;
+    // Save the attempt in the database.
+    question_engine::save_questions_usage_by_activity($quba);
+    $attempt->uniqueid = $quba->get_id();
+    $attempt->state = quiz_attempt::NOT_STARTED;
+    $attempt->id = $DB->insert_record('quiz_attempts', $attempt);
     di::get(hook\manager::class)->dispatch(new attempt_state_changed(null, $attempt));
     return $attempt;
+}
    /*
     * Each database handles updates with inner joins differently:
     *  - mysql does not allow a FROM clause
-    *  - postgres and mssql allow FROM but handle table aliases differently
-    *  - oracle requires a subquery
+    *  - postgres and mssql allow FROM but handle table aliases differently
+    *
     * Different code for each database.
     */
                         FROM {quiz_attempts} quiza
                         JOIN {quiz} quiz ON quiz.id = quiza.quiz
                         JOIN ( $quizausersql ) quizauser ON quizauser.id = quiza.id
                        WHERE $attemptselect";
     } else {
-        // oracle, sqlite and others
-        $updatesql = "UPDATE {quiz_attempts} quiza
-                         SET timecheckstate = (
-                           SELECT $timecheckstatesql
-                             FROM {quiz} quiz, ( $quizausersql ) quizauser
+        throw new \core\exception\coding_exception("Unsupported database family: {$dbfamily}");
-                            WHERE quiz.id = quiza.quiz
-                              AND quizauser.id = quiza.id
-                         )
-                         WHERE $attemptselect";
+    }
     $DB->execute($updatesql, $params);
  * @param string $state one of the state constants like {@see quiz_attempt::IN_PROGRESS}.
  * @return string The lang string to describe that state.
  */
 function quiz_attempt_state_name($state) {
     switch ($state) {
+        case quiz_attempt::NOT_STARTED:
+            return get_string('statenotstarted', 'quiz');
         case quiz_attempt::IN_PROGRESS:
             return get_string('stateinprogress', 'quiz');
         case quiz_attempt::OVERDUE:
             return get_string('stateoverdue', 'quiz');
+        case quiz_attempt::SUBMITTED:
+            return get_string('statesubmitted', 'quiz');
         case quiz_attempt::FINISHED:
             return get_string('statefinished', 'quiz');
         case quiz_attempt::ABANDONED:
             return get_string('stateabandoned', 'quiz');
         default:
+    }
     $a = new stdClass();
     // Course info.
     $a->courseid        = $course->id;
-    $a->coursename      = $course->fullname;
+    $a->coursename      = format_string($course->fullname, true, ['context' => $context]);
-    $a->courseshortname = $course->shortname;
+    $a->courseshortname = format_string($course->shortname, true, ['context' => $context]);
     // Quiz info.
-    $a->quizname        = $quiz->name;
+    $a->quizname        = format_string($quiz->name, true, ['context' => $context]);
     $a->quizreporturl   = $CFG->wwwroot . '/mod/quiz/report.php?id=' . $cm->id;
-    $a->quizreportlink  = '<a href="' . $a->quizreporturl . '">' .
-            format_string($quiz->name) . ' report</a>';
+    $a->quizreportlink  = '<a href="' . $a->quizreporturl . '">' . $a->quizname . ' report</a>';
     $a->quizurl         = $CFG->wwwroot . '/mod/quiz/view.php?id=' . $cm->id;
-    $a->quizlink        = '<a href="' . $a->quizurl . '">' . format_string($quiz->name) . '</a>';
+    $a->quizlink        = '<a href="' . $a->quizurl . '">' . $a->quizname . '</a>';
     $a->quizid          = $quiz->id;
     $a->quizcmid        = $cm->id;
     // Attempt info.
     $a->submissiontime  = userdate($attempt->timefinish);
     $a->timetaken       = format_time($attempt->timefinish - $attempt->timestart);
     $a->quizreviewurl   = $CFG->wwwroot . '/mod/quiz/review.php?attempt=' . $attempt->id;
-    $a->quizreviewlink  = '<a href="' . $a->quizreviewurl . '">' .
-            format_string($quiz->name) . ' review</a>';
+    $a->quizreviewlink  = '<a href="' . $a->quizreviewurl . '">' . $a->quizname . ' review</a>';
     $a->attemptid       = $attempt->id;
     // Student who sat the quiz info.
     $a->studentidnumber = $submitter->idnumber;
     $a->studentname     = fullname($submitter);
  * @param bool $showquestiontext If true (default), show question text after question name.
  *       If false, show only question name.
  * @param bool $showidnumber If true, show the question's idnumber, if any. False by default.
  * @param core_tag_tag[]|bool $showtags if array passed, show those tags. Else, if true, get and show tags,
  *       else, don't show tags (which is the default).
+ * @param bool $displaytaglink Indicates whether the tag should be displayed as a link.
  * @return string HTML fragment.
  */
 function quiz_question_tostring($question, $showicon = false, $showquestiontext = true,
-        $showidnumber = false, $showtags = false) {
+        $showidnumber = false, $showtags = false, $displaytaglink = true) {
     global $OUTPUT;
     $result = '';
     // Question name.
         $tags = core_tag_tag::get_item_tags('core_question', 'question', $question->id);
     } else {
         $tags = [];
+    }
     if ($tags) {
-        $result .= $OUTPUT->tag_list($tags, null, 'd-inline', 0, null, true);
+        $result .= $OUTPUT->tag_list($tags, null, 'd-inline', 0, null, true, $displaytaglink);
+    }
     // Question text.
     if ($showquestiontext) {
         throw new coding_exception(
                 'Adding "random" questions via quiz_add_quiz_question() is deprecated. Please use quiz_add_random_questions().'
         );
+    }
+    // If the question type is invalid, we cannot add it to the quiz. It shouldn't be possible to get to this
+    // point without fiddling with the DOM so we can just throw an exception.
+    if (!\question_bank::is_qtype_installed($questiontype)) {
+        throw new coding_exception('Invalid question type: ' . $questiontype);
+    }
     $trans = $DB->start_delegated_transaction();
     $sql = "SELECT qbe.id
     // Look for an existing attempt.
     $attempts = quiz_get_user_attempts($quizobj->get_quizid(), $USER->id, 'all', true);
     $lastattempt = end($attempts);
+    $attemptnumber = null;
-    $attemptnumber = null;
+    if (
-    // If an in-progress attempt exists, check password then redirect to it.
+        $lastattempt
+        && in_array($lastattempt->state, [quiz_attempt::NOT_STARTED, quiz_attempt::IN_PROGRESS, quiz_attempt::OVERDUE])
-    if ($lastattempt && ($lastattempt->state == quiz_attempt::IN_PROGRESS ||
+    ) {
-            $lastattempt->state == quiz_attempt::OVERDUE)) {
+        // If an in-progress or not-started attempt exists, check password then redirect to it.
+        $currentattemptid = $lastattempt->id;
         $currentattemptid = $lastattempt->id;
         $messages = $accessmanager->prevent_access();
     quiz_delete_previews($quizobj->get_quiz(), $userid);
     $quba = question_engine::make_questions_usage_by_activity('mod_quiz', $quizobj->get_context());
+    $quba->set_preferred_behaviour($quizobj->get_quiz()->preferredbehaviour);
+    $attempt = $DB->get_record(
+        'quiz_attempts',
+        [
+            'quiz' => $quizobj->get_quizid(),
+            'userid' => $userid,
+            'preview' => 0,
+            'state' => quiz_attempt::NOT_STARTED,
+        ],
-    $quba->set_preferred_behaviour($quizobj->get_quiz()->preferredbehaviour);
+    );
+    if (!$attempt) {
-    // Create the new attempt and initialize the question sessions
+        // Create the new attempt and initialize the question sessions.
-    $timenow = time(); // Update time now, in case the server is running really slowly.
+        $timenow = time(); // Update time now, in case the server is running really slowly.
-    $attempt = quiz_create_attempt($quizobj, $attemptnumber, $lastattempt, $timenow, $ispreviewuser, $userid);
+        $attempt = quiz_create_attempt($quizobj, $attemptnumber, $lastattempt, $timenow, $ispreviewuser, $userid);
+        if (!($quizobj->get_quiz()->attemptonlast && $lastattempt)) {
+            $attempt = quiz_start_new_attempt(
+                $quizobj,
+                $quba,
+                $attempt,
-    if (!($quizobj->get_quiz()->attemptonlast && $lastattempt)) {
+                $attemptnumber,
+                $timenow,
+                $forcedrandomquestions,
-        $attempt = quiz_start_new_attempt($quizobj, $quba, $attempt, $attemptnumber, $timenow,
+                $forcedvariants,
-                $forcedrandomquestions, $forcedvariants);
+            );
+        } else {
-    } else {
+            $attempt = quiz_start_attempt_built_on_last($quba, $attempt, $lastattempt);
         $attempt = quiz_start_attempt_built_on_last($quba, $attempt, $lastattempt);
+    }

Proyectos de Subversion Moodle

(root)/mod/quiz/locallib.php – Rev 1 → 1441