WebSVN – Moodle – Diff – /mod/quiz/classes/output/edit_renderer.php

  */
 namespace mod_quiz\output;
 use core_question\local\bank\question_version_status;
-use mod_quiz\question\bank\qbank_helper;
+use core_question\local\bank\question_version_status;
 use \mod_quiz\structure;
+use \html_writer;
-use \html_writer;
+use qbank_previewquestion\question_preview_options;
-use qbank_previewquestion\question_preview_options;
+use question_bank;
 use renderable;
      * @param \core_question\local\bank\question_edit_contexts $contexts the relevant question bank contexts.
      * @param \moodle_url $pageurl the canonical URL of this page.
      * @param array $pagevars the variables from {@link question_edit_setup()}.
      * @return string HTML to output.
      */
+    public function edit_page(
-    public function edit_page(\mod_quiz\quiz_settings $quizobj, structure $structure,
+        \mod_quiz\quiz_settings $quizobj,
+        structure $structure,
-        \core_question\local\bank\question_edit_contexts $contexts, \moodle_url $pageurl, array $pagevars) {
+        \core_question\local\bank\question_edit_contexts $contexts,
+        \moodle_url $pageurl,
+        array $pagevars,
+    ) {
         $output = '';
         // Page title.
         // Include the contents of any other popups required.
         if ($structure->can_be_edited()) {
             $thiscontext = $contexts->lowest();
             $this->page->requires->js_call_amd('mod_quiz/modal_quiz_question_bank', 'init', [
+                $thiscontext->id,
+                $quizobj->get_cm()->id,
-                $thiscontext->id
+                $quizobj->get_cm()->id,
             ]);
+            $this->page->requires->js_call_amd('mod_quiz/modal_add_random_question', 'init', [
-            $this->page->requires->js_call_amd('mod_quiz/modal_add_random_question', 'init', [
+                $thiscontext->id,
-                $thiscontext->id,
+                $quizobj->get_cm()->id,
                 $pagevars['cat'],
                 $pageurl->out_as_local_url(true),
                 $pageurl->param('cmid'),
         $output .= html_writer::tag('label', get_string('maximumgrade') . ' ',
                 ['for' => 'inputmaxgrade', 'class' => 'd-inline-block w-auto mb-0']);
         $output .= html_writer::empty_tag('input', ['type' => 'text', 'id' => 'inputmaxgrade',
                 'name' => 'maxgrade', 'size' => ($structure->get_decimal_places_for_grades() + 2),
                 'value' => $structure->formatted_quiz_grade(),
-                'class' => 'form-control d-inline-block align-middle w-auto ml-1']);
+                'class' => 'form-control d-inline-block align-middle w-auto ms-1']);
-        $output .= html_writer::empty_tag('input', ['type' => 'submit', 'class' => 'btn btn-secondary ml-1 d-inline-block w-auto ',
+        $output .= html_writer::empty_tag('input', ['type' => 'submit', 'class' => 'btn btn-secondary ms-1 d-inline-block w-auto ',
                 'name' => 'savechanges', 'value' => get_string('save', 'quiz')]);
         $output .= html_writer::end_tag('fieldset');
         $output .= html_writer::end_tag('form');
         $output .= html_writer::end_tag('div');
         return $output;
         $buttonoptions = [
             'type'  => 'submit',
             'name'  => 'repaginate',
             'id'    => 'repaginatecommand',
             'value' => get_string('repaginatecommand', 'quiz'),
-            'class' => 'btn btn-secondary mr-1',
+            'class' => 'btn btn-secondary me-1',
             'data-header' => $header,
             'data-form'   => $form,
         ];
         if (!$structure->can_be_repaginated()) {
             $buttonoptions['disabled'] = 'disabled';
         $hiddenurl = clone($pageurl);
         $hiddenurl->param('sesskey', sesskey());
         $select = html_writer::select($perpage, 'questionsperpage',
-                $structure->get_questions_per_page(), false, ['class' => 'custom-select']);
+                $structure->get_questions_per_page(), false, ['class' => 'form-select']);
         $buttonattributes = [
             'type' => 'submit',
             'name' => 'repaginate',
             'value' => get_string('go'),
-            'class' => 'btn btn-secondary ml-1'
+            'class' => 'btn btn-secondary ms-1'
         ];
         if ($section->heading) {
             $sectionheadingtext = format_string($section->heading);
             $sectionheading = html_writer::span($sectionheadingtext, 'instancesection');
         } else {
-            // Use a sr-only default section heading, so we don't end up with an empty section heading.
+            // Use a visually-hidden default section heading, so we don't end up with an empty section heading.
             $sectionheadingtext = get_string('sectionnoname', 'quiz');
-            $sectionheading = html_writer::span($sectionheadingtext, 'instancesection sr-only');
+            $sectionheading = html_writer::span($sectionheadingtext, 'instancesection visually-hidden');
+        }
         $output .= html_writer::start_tag('li', ['id' => 'section-'.$section->id,
         $output = '';
         foreach ($structure->get_slots_in_section($section->id) as $slot) {
             $output .= $this->question_row($structure, $slot, $contexts, $pagevars, $pageurl);
+        }
         $this->page->requires->js_call_amd('mod_quiz/question_slot', 'init');
         return html_writer::tag('ul', $output, ['class' => 'section img-text']);
+    }
      * @param int $slot the first slot on the page we are outputting.
      * @param \moodle_url $pageurl the canonical URL of this page.
      * @return string HTML to output.
      */
     public function question(structure $structure, int $slot, \moodle_url $pageurl) {
+        global $DB;
         // Get the data required by the question_slot template.
         $slotid = $structure->get_slot_id_for_slot($slot);
+        $question = $structure->get_question_in_slot($slot);
+        $bank = $structure->get_source_bank($slot);
+        if ($bank?->issharedbank && question_has_capability_on($question, 'view')) {
+            $bankurl = (new \moodle_url('/question/edit.php',
+                [
+                    'cmid' => $bank->cminfo->id,
+                    'cat' => "{$question->category},{$question->contextid}",
+                ]
+            ))->out(false);
+        } else {
+            $bankurl = '';
+        }
         $output = '';
         $output .= html_writer::start_tag('div');
             'questionname' => $this->get_question_name_for_slot($structure, $slot, $pageurl),
             'questionicons' => $this->get_action_icon($structure, $slot, $pageurl),
             'questiondependencyicon' => ($structure->can_be_edited() ? $this->question_dependency_icon($structure, $slot) : ''),
             'versionselection' => false,
             'draftversion' => $structure->get_question_in_slot($slot)->status == question_version_status::QUESTION_STATUS_DRAFT,
+            'bankname' => $bank?->cminfo->get_formatted_name(),
+            'issharedbank' => $bank?->issharedbank,
+            'bankurl' => $bankurl,
         ];
         $data['versionoptions'] = [];
         if ($structure->get_slot_by_number($slot)->qtype !== 'random') {
             $data['versionselection'] = true;
-            $data['versionoption'] = $structure->get_version_choices_for_slot($slot);
-            $this->page->requires->js_call_amd('mod_quiz/question_slot', 'init', [$slotid]);
+            $data['versionoption'] = $structure->get_version_choices_for_slot($slot);
+        }
+            [
                 'id' => 'selectquestion-' . $slot,
                 'name' => 'selectquestion[]',
                 'classes' => 'select-multiple-checkbox',
                 'label' => get_string('selectquestionslot', 'quiz', $questionslot),
-                'labelclasses' => 'sr-only',
+                'labelclasses' => 'visually-hidden',
             ]);
         return $this->render($checkbox);
     public function get_action_icon(structure $structure, int $slot, \moodle_url $pageurl): string {
         // Action icons.
         $qtype = $structure->get_question_type_for_slot($slot);
         $slotinfo = $structure->get_slot_by_number($slot);
         $questionicons = '';
-        if ($qtype !== 'random') {
+        if ($qtype !== 'random' && question_bank::is_qtype_usable($qtype)) {
             $questionicons .= $this->question_preview_icon($structure->get_quiz(),
                     $structure->get_question_in_slot($slot),
                     null, null, $slotinfo->requestedversion ?: question_preview_options::ALWAYS_LATEST);
+        }
         if ($structure->can_be_edited() && $structure->has_use_capability($slot)) {
      * @param int $restartversion version to use when restarting the preview
      * @return string HTML to output.
      */
     public function question_preview_icon($quiz, $questiondata, $label = null, $variant = null, $restartversion = null) {
         $question = clone($questiondata);
+        if (!question_bank::is_qtype_usable($question->qtype)) {
+            return '';
+        }
         if (isset($question->questionid)) {
             $question->id = $question->questionid;
                 'returnurl' => $pageurl->out_as_local_url(),
                 'cmid' => $structure->get_cmid(), 'id' => $question->questionid]);
         $instancename = quiz_question_tostring($question);
-        $qtype = \question_bank::get_qtype($question->qtype, false);
+        $qtype = question_bank::get_qtype($question->qtype, false);
         $namestr = $qtype->local_name();
         $icon = $this->pix_icon('icon', $namestr, $qtype->plugin_name(), ['title' => $namestr,
                 'class' => 'activityicon', 'alt' => $namestr]);
+        $editicon = $this->pix_icon('t/edit', '', 'moodle', ['title' => '']);
+        // Need plain question name without html tags for link title.
+        $title = shorten_text(format_string($question->name), 100);
+        // If the question is invalid, don't show the link as it won't work.
+        if (!question_bank::is_qtype_usable($question->qtype)) {
+            $output .= html_writer::span($title);
+            $output .= html_writer::span(
+                get_string('invalidquestiontype', 'question', $question->originalqtype),
-        $editicon = $this->pix_icon('t/edit', '', 'moodle', ['title' => '']);
+                'badge bg-danger text-white ms-3'
+            );
+        } else {
+            $canedit = question_has_capability_on($question->questionid, 'edit');
+            $instancename = $canedit ? $editicon . $instancename : $instancename;
+            // Display the link, if the user has permission to edit. Otherwise, just display the name and icon.
-        // Need plain question name without html tags for link title.
+            $questionname = $icon . html_writer::tag('span', $instancename, ['class' => 'instancename']);
+            if ($canedit) {
+                $output .= html_writer::link(
+                    $editurl,
+                    $questionname,
+                    [
+                        'title' => get_string('editquestion', 'quiz') . ' ' . $title,
-        $title = shorten_text(format_string($question->name), 100);
+                    ],
                 );
-        // Display the link itself.
+            } else {
      * @return string HTML to output.
      */
     public function random_question(structure $structure, $slotnumber, $pageurl) {
         $question = $structure->get_question_in_slot($slotnumber);
         $slot = $structure->get_slot_by_number($slotnumber);
-        $editurl = new \moodle_url('/mod/quiz/editrandom.php',
-                ['returnurl' => $pageurl->out_as_local_url(), 'slotid' => $slot->id]);
         $temp = clone($question);
         $temp->questiontext = '';
-        $temp->name = qbank_helper::describe_random_question($slot);
+        $temp->name = $structure->describe_random_slot($slot->id);
+        $instancename = quiz_question_tostring($temp);
+        if (strpos($instancename, structure::MISSING_QUESTION_CATEGORY_PLACEHOLDER) !== false) {
+            $label = html_writer::span(
+                get_string('missingcategory', 'mod_quiz'),
+                'badge bg-danger text-white h-50'
+            );
+            $instancename = str_replace(structure::MISSING_QUESTION_CATEGORY_PLACEHOLDER, $label, $instancename);
         $instancename = quiz_question_tostring($temp);
         $configuretitle = get_string('configurerandomquestion', 'quiz');
-        $qtype = \question_bank::get_qtype($question->qtype, false);
+        $qtype = question_bank::get_qtype($question->qtype, false);
         $namestr = $qtype->local_name();
         $icon = $this->pix_icon('icon', $namestr, $qtype->plugin_name(), ['class' => 'icon activityicon']);
         $editicon = $this->pix_icon('t/edit', $configuretitle, 'moodle', ['title' => '']);
         $qbankurlparams = [
-            'cmid' => $structure->get_cmid(),
-            'cat' => $slot->category . ',' . $slot->contextid,
-        ];
-        $slottags = [];
-        if (isset($slot->randomtags)) {
-            $slottags = $slot->randomtags;
-        }
-        foreach ($slottags as $index => $slottag) {
-            $slottag = explode(',', $slottag);
+            'cmid' => $structure->get_source_bank($slotnumber)->cminfo->id,
-            $qbankurlparams["qtagids[{$index}]"] = $slottag[0];
+            'filter' => json_encode($slot->filtercondition['filter']),
         ];
         // If this is a random question, display a link to show the questions
+        // selected from in the question bank.
+        $qbankurl = new \moodle_url('/question/edit.php', $qbankurlparams);
+        $qbanklink = ' ' . \html_writer::link($qbankurl,
+                        get_string('seequestions', 'quiz'), ['class' => 'mod_quiz_random_qbank_link']);
-        // selected from in the question bank.
+        $editlink = html_writer::link(
+            $pageurl->out(),
+            $icon . $editicon,
+            [
+                'title' => $configuretitle,
-        $qbankurl = new \moodle_url('/question/edit.php', $qbankurlparams);
+                'data-action' => 'editrandomquestion',
-        $qbanklink = ' ' . \html_writer::link($qbankurl,
+                'data-slotid' => $slot->id,
-                        get_string('seequestions', 'quiz'), ['class' => 'mod_quiz_random_qbank_link']);
+                'data-header' => get_string('randomediting', 'mod_quiz'),
             ],
-        return html_writer::link($editurl, $icon . $editicon, ['title' => $configuretitle]) .
+        );
                 'questiondependencyfree',
                 'questiondependencyremove',
                 'questiondependsonprevious',
         ], 'quiz');
-        foreach (\question_bank::get_all_qtypes() as $qtype => $notused) {
+        foreach (question_bank::get_all_qtypes() as $qtype => $notused) {
             $this->page->requires->string_for_js('pluginname', 'qtype_' . $qtype);
+        }

Proyectos de Subversion Moodle

(root)/mod/quiz/classes/output/edit_renderer.php – Rev 1 → 1441