WebSVN – Moodle – Diff – /lib/tests/questionlib_test.php

 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+namespace core;
-namespace core;
+use core_question\local\bank\question_bank_helper;
 use mod_quiz\quiz_settings;
 use question_bank;
  * @package    core
  * @category   test
  * @copyright  2006 The Open University
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class questionlib_test extends \advanced_testcase {
+final class questionlib_test extends \advanced_testcase {
     /**
      * Test set up.
+     *
      * This is executed before running any test in this file.
      */
+    public function setUp(): void {
-    public function setUp(): void {
+        parent::setUp();
         $this->resetAfterTest();
+    }
+    /**
+     * Generate a course and question bank module instance for use in test cases, and return the bank context.
+     * @return \core\context\module
+     */
+    protected function create_course_and_question_bank(): \core\context\module {
+        $course = self::getDataGenerator()->create_course();
+        $qbank = self::getDataGenerator()->create_module('qbank', ['course' => $course->id]);
+        return \context_module::instance($qbank->cmid);
+    }
     /**
-     * Setup a course, a quiz, a question category and a question for testing.
      * Setup a course, a quiz, a question category and a question for testing.
      * @param string $type The type of question category to create.
      * @return array The created data objects
      */
-    public function setup_quiz_and_questions($type = 'module') {
+    public function setup_quiz_and_questions() {
         // Create course category.
         $category = $this->getDataGenerator()->create_category();
         $quiz = $this->getDataGenerator()->create_module('quiz', $options);
         /** @var \core_question_generator $qgen */
-        $qgen = $this->getDataGenerator()->get_plugin_generator('core_question');
-        switch ($type) {
-            case 'course':
-                $context = \context_course::instance($course->id);
-                break;
-            case 'category':
-                $context = \context_coursecat::instance($category->id);
-                break;
-            case 'system':
-                $context = \context_system::instance();
-                break;
+        $qgen = $this->getDataGenerator()->get_plugin_generator('core_question');
-            default:
-                $context = \context_module::instance($quiz->cmid);
                 break;
         $context = \context_module::instance($quiz->cmid);
         global $CFG, $DB;
         // Set to admin user.
         $this->setAdminUser();
-        // Create two course categories - we are going to delete one of these later and will expect
+        // Create 2 qbank instances - we are going to delete one of these later and will expect
+        // all the questions belonging to the deleted module to be moved.
+        $coursecat1 = $this->getDataGenerator()->create_category();
-        // all the questions belonging to the course in the deleted category to be moved.
+        $course1 = $this->getDataGenerator()->create_course(['category' => $coursecat1->id]);
+        $modqbank1 = $this->getDataGenerator()->create_module('qbank', ['course' => $course1->id]);
+        $coursecat2 = $this->getDataGenerator()->create_category();
-        $coursecat1 = $this->getDataGenerator()->create_category();
+        $course2 = $this->getDataGenerator()->create_course(['category' => $coursecat2->id]);
-        $coursecat2 = $this->getDataGenerator()->create_category();
+        $modqbank2 = $this->getDataGenerator()->create_module('qbank', ['course' => $course2->id]);
         // Create a couple of categories and questions.
-        $context1 = \context_coursecat::instance($coursecat1->id);
+        $context1 = \context_module::instance($modqbank1->cmid);
-        $context2 = \context_coursecat::instance($coursecat2->id);
+        $context2 = \context_module::instance($modqbank2->cmid);
-        /** @var \core_question_generator $questiongenerator */
-        $questiongenerator = $this->getDataGenerator()->get_plugin_generator('core_question');
+        /** @var \core_question_generator $questiongenerator */
-        $questioncat1 = $questiongenerator->create_question_category(array('contextid' =>
-            $context1->id));
+        $questiongenerator = $this->getDataGenerator()->get_plugin_generator('core_question');
-        $questioncat2 = $questiongenerator->create_question_category(array('contextid' =>
+        $questioncat1 = question_get_default_category($context1->id);
-            $context2->id));
+        $questioncat2 = question_get_default_category($context2->id);
-        $question1 = $questiongenerator->create_question('shortanswer', null, array('category' => $questioncat1->id));
+        $question1 = $questiongenerator->create_question('shortanswer', null, ['category' => $questioncat1->id]);
-        $question2 = $questiongenerator->create_question('shortanswer', null, array('category' => $questioncat1->id));
+        $question2 = $questiongenerator->create_question('shortanswer', null, ['category' => $questioncat1->id]);
-        $question3 = $questiongenerator->create_question('shortanswer', null, array('category' => $questioncat2->id));
+        $question3 = $questiongenerator->create_question('shortanswer', null, ['category' => $questioncat2->id]);
-        $question4 = $questiongenerator->create_question('shortanswer', null, array('category' => $questioncat2->id));
+        $question4 = $questiongenerator->create_question('shortanswer', null, ['category' => $questioncat2->id]);
         // Now lets tag these questions.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $context1, array('tag 1', 'tag 2'));
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $context1, array('tag 3', 'tag 4'));
-        \core_tag_tag::set_item_tags('core_question', 'question', $question3->id, $context2, array('tag 5', 'tag 6'));
-        \core_tag_tag::set_item_tags('core_question', 'question', $question4->id, $context2, array('tag 7', 'tag 8'));
-        // Test moving the questions to another category.
-        question_move_questions_to_category(array($question1->id, $question2->id), $questioncat2->id);
-        // Test that all tag_instances belong to one context.
-        $this->assertEquals(8, $DB->count_records('tag_instance', array('component' => 'core_question',
-            'contextid' => $questioncat2->contextid)));
-        // Test moving them back.
-        question_move_questions_to_category(array($question1->id, $question2->id), $questioncat1->id);
-        // Test that all tag_instances are now reset to how they were initially.
-        $this->assertEquals(4, $DB->count_records('tag_instance', array('component' => 'core_question',
+        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $context1, ['tag 1', 'tag 2']);
-            'contextid' => $questioncat1->contextid)));
+        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $context1, ['tag 3', 'tag 4']);
-        $this->assertEquals(4, $DB->count_records('tag_instance', array('component' => 'core_question',
+        \core_tag_tag::set_item_tags('core_question', 'question', $question3->id, $context2, ['tag 5', 'tag 6']);
-            'contextid' => $questioncat2->contextid)));
+        \core_tag_tag::set_item_tags('core_question', 'question', $question4->id, $context2, ['tag 7', 'tag 8']);
-        // Now test moving a whole question category to another context.
+        // Test moving a whole question category to another context.
         question_move_category_to_context($questioncat1->id, $questioncat1->contextid, $questioncat2->contextid);
         // Test that all tag_instances belong to one context.
-        $this->assertEquals(8, $DB->count_records('tag_instance', array('component' => 'core_question',
+        $this->assertEquals(8, $DB->count_records('tag_instance', ['component' => 'core_question',
-            'contextid' => $questioncat2->contextid)));
+            'contextid' => $questioncat2->contextid]));
-        // Now test moving them back.
-        question_move_category_to_context($questioncat1->id, $questioncat2->contextid,
-            \context_coursecat::instance($coursecat1->id)->id);
-        // Test that all tag_instances are now reset to how they were initially.
-        $this->assertEquals(4, $DB->count_records('tag_instance', array('component' => 'core_question',
-            'contextid' => $questioncat1->contextid)));
-        $this->assertEquals(4, $DB->count_records('tag_instance', array('component' => 'core_question',
+        // Now test moving them back.
-            'contextid' => $questioncat2->contextid)));
+        question_move_category_to_context($questioncat1->id, $questioncat2->contextid,
             \context_module::instance($modqbank1->cmid)->id);
-        // Now we want to test deleting the course category and moving the questions to another category.
+        // Test that all tag_instances are now reset to how they were initially.
-        question_delete_course_category($coursecat1, $coursecat2);
+        $this->assertEquals(4, $DB->count_records('tag_instance', ['component' => 'core_question',
+            'contextid' => $questioncat1->contextid]));
-        // Test that all tag_instances belong to one context.
+        $this->assertEquals(4, $DB->count_records('tag_instance', ['component' => 'core_question',
-        $this->assertEquals(8, $DB->count_records('tag_instance', array('component' => 'core_question',
+            'contextid' => $questioncat2->contextid]));
             'contextid' => $questioncat2->contextid)));
+        // Create a course.
-        // Create a course.
+        $course = $this->getDataGenerator()->create_course();
-        $course = $this->getDataGenerator()->create_course();
+        $modqbank3 = $this->getDataGenerator()->create_module('qbank', ['course' => $course->id]);
         // Create some question categories and questions in this course.
         $rc = new \restore_controller('test-restore-course', $course2->id, \backup::INTERACTIVE_NO,
             \backup::MODE_GENERAL, 2, \backup::TARGET_NEW_COURSE);
         $rc->execute_precheck();
         $rc->execute_plan();
+        $modinfo = get_fast_modinfo($course2);
+        $qbanks = $modinfo->get_instances_of('qbank');
+        $qbankids = array_column($qbanks, 'instance');
+        $qbankrecords = $DB->get_records_list('qbank', 'id', $qbankids, '', 'id, type');
+        $qbanks = array_filter($qbanks, static function($bank) use ($qbankrecords) {
+            if (isset($qbankrecords[$bank->instance])) {
+                return $qbankrecords[$bank->instance]->type === question_bank_helper::TYPE_STANDARD;
+            }
+            return false;
+        });
+        $qbank = reset($qbanks);
         // Get the created question category.
         $restoredcategory = $DB->get_record_select('question_categories', 'contextid = ? AND parent <> 0',
-                array(\context_course::instance($course2->id)->id), '*', MUST_EXIST);
+                [$qbank->context->id, '*', MUST_EXIST]);
         // Check that there are two questions in the restored to course's context.
         $this->assertEquals(2, $DB->get_record_sql('SELECT COUNT(q.id) as questioncount
      */
     public function test_question_delete_question(): void {
         global $DB;
         // Setup.
-        $context = \context_system::instance();
+        $context = $this->create_course_and_question_bank();
         /** @var \core_question_generator $qgen */
         $qgen = $this->getDataGenerator()->get_plugin_generator('core_question');
         $qcat = $qgen->create_question_category(array('contextid' => $context->id));
         $q1 = $qgen->create_question('shortanswer', null, array('category' => $qcat->id));
      */
     public function test_question_delete_question_broken_data(): void {
         global $DB;
         // Setup.
-        $context = \context_system::instance();
+        $context = $this->create_course_and_question_bank();
         /** @var \core_question_generator $qgen */
         $qgen = $this->getDataGenerator()->get_plugin_generator('core_question');
         $qcat = $qgen->create_question_category(array('contextid' => $context->id));
      * Test deleting a broken question whose category refers to a missing context
      */
     public function test_question_delete_question_missing_context(): void {
         global $DB;
-        $coursecategory = $this->getDataGenerator()->create_category();
-        $context = $coursecategory->get_context();
+        $context = $this->create_course_and_question_bank();
         /** @var \core_question_generator $generator */
         $generator = $this->getDataGenerator()->get_plugin_generator('core_question');
             'files, tags, are not cleaned up.');
         $this->assertFalse($DB->record_exists('question', ['id' => $question->id]));
+    }
+    /**
+     * Test parameters for calling question_category_delete_safe
+     *
+     * @return array
+     */
+    public static function delete_category_parameters(): array {
+        return [
+            'Delete category' => [
+                'coursedeletion' => false,
+            ],
+            'Delete category with course' => [
+                'coursedeletion' => true,
+            ],
+        ];
+    }
     /**
+     * This function tests the question_category_delete_safe function.
+     *
+     * @param bool $coursedeletion If true, simulate calling question_category_delete_safe as part of deletion of the whole course.
+     * @dataProvider delete_category_parameters
-     * This function tests the question_category_delete_safe function.
+     * @covers ::question_category_delete_safe
      */
-    public function test_question_category_delete_safe(): void {
+    public function test_question_category_delete_safe(bool $coursedeletion): void {
         global $DB;
         $this->resetAfterTest(true);
         $this->setAdminUser();
+        [, $course, , $qcat, $questions] = $this->setup_quiz_and_questions();
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions();
+        $targetcourseid = $coursedeletion ? SITEID : $course->id;
-        question_category_delete_safe($qcat);
+        question_category_delete_safe($qcat, $coursedeletion);
         // Verify category deleted.
-        $criteria = array('id' => $qcat->id);
+        $criteria = ['id' => $qcat->id];
         $this->assertEquals(0, $DB->count_records('question_categories', $criteria));
+        // Verify questions deleted or moved.
+        $this->assert_category_contains_questions($qcat->id, 0);
+        // Verify question not deleted.
+        $criteria = ['id' => $questions[0]->id];
+        $savedquestion = $DB->get_record_sql(
+            "SELECT q.*, qbe.questioncategoryid
+               FROM {question} q
+                    JOIN {question_versions} qv ON qv.questionid = q.id
+                    JOIN {question_bank_entries} qbe ON qv.questionbankentryid = qbe.id",
+            $criteria
+        );
+        $this->assertNotEmpty($savedquestion);
+        // Verify question now sits in a system qbank in the target course.
+        $this->assertNotEquals($qcat->id, $savedquestion->id);
+        $newcategory = $DB->get_record('question_categories', ['id' => $savedquestion->questioncategoryid], strictness: MUST_EXIST);
-        // Verify questions deleted or moved.
+        $newcategorycontext = context::instance_by_id($newcategory->contextid);
-        $this->assert_category_contains_questions($qcat->id, 0);
+        $this->assertEquals(\context_module::LEVEL, $newcategorycontext->contextlevel);
         [$newcourse, $newcm] = get_course_and_cm_from_cmid($newcategorycontext->instanceid);
-        // Verify question not deleted.
+        $this->assertEquals($newcm->modname, 'qbank');
         $this->assert_category_contains_questions($qcat->id, 0);
+    }
     /**
+     * This function tests the question_delete_context function.
+     *
-     * This function tests the question_delete_context function.
+     * @covers ::question_delete_context()
      */
     public function test_question_delete_context(): void {
         global $DB;
         $this->resetAfterTest(true);
         // Get the module context id.
         $result = question_delete_context($qcat->contextid);
-        // Verify category deleted.
-        $criteria = array('id' => $qcat->id);
-        $this->assertEquals(0, $DB->count_records('question_categories', $criteria));
-        // Verify questions deleted or moved.
-        $this->assert_category_contains_questions($qcat->id, 0);
-    }
-    /**
-     * This function tests the question_delete_course function.
-     */
-    public function test_question_delete_course(): void {
-        global $DB;
-        $this->resetAfterTest(true);
-        $this->setAdminUser();
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('course');
-        // Test the deletion.
-        question_delete_course($course);
         // Verify category deleted.
-        $criteria = array('id' => $qcat->id);
+        $criteria = ['id' => $qcat->id];
         $this->assertEquals(0, $DB->count_records('question_categories', $criteria));
         // Verify questions deleted or moved.
-        $this->assert_category_contains_questions($qcat->id, 0);
-    }
-    /**
-     * This function tests the question_delete_course_category function.
-     */
-    public function test_question_delete_course_category(): void {
-        global $DB;
-        $this->resetAfterTest(true);
-        $this->setAdminUser();
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('category');
-        // Test that the feedback works.
-        question_delete_course_category($category, null);
-        // Verify category deleted.
-        $criteria = array('id' => $qcat->id);
-        $this->assertEquals(0, $DB->count_records('question_categories', $criteria));
-        // Verify questions deleted or moved.
-        $this->assert_category_contains_questions($qcat->id, 0);
-    }
-    /**
-     * This function tests the question_delete_course_category function when it is supposed to move question categories.
-     */
-    public function test_question_delete_course_category_move_qcats(): void {
-        global $DB;
-        $this->resetAfterTest(true);
-        $this->setAdminUser();
-        list($category1, $course1, $quiz1, $qcat1, $questions1) = $this->setup_quiz_and_questions('category');
-        list($category2, $course2, $quiz2, $qcat2, $questions2) = $this->setup_quiz_and_questions('category');
-        $questionsinqcat1 = count($questions1);
-        $questionsinqcat2 = count($questions2);
-        // Test the delete.
-        question_delete_course_category($category1, $category2);
-        // Verify category not deleted.
-        $criteria = array('id' => $qcat1->id);
-        $this->assertEquals(1, $DB->count_records('question_categories', $criteria));
-        // Verify questions are moved.
-        $params = array($qcat2->contextid);
-        $actualquestionscount = $DB->count_records_sql("SELECT COUNT(*)
-                                                              FROM {question} q
-                                                              JOIN {question_versions} qv ON qv.questionid = q.id
-                                                              JOIN {question_bank_entries} qbe ON qbe.id = qv.questionbankentryid
-                                                              JOIN {question_categories} qc ON qc.id = qbe.questioncategoryid
-                                                             WHERE qc.contextid = ?", $params);
-        $this->assertEquals($questionsinqcat1 + $questionsinqcat2, $actualquestionscount);
-        // Verify there is just a single top-level category.
-        $criteria = array('contextid' => $qcat2->contextid, 'parent' => 0);
-        $this->assertEquals(1, $DB->count_records('question_categories', $criteria));
-        // Verify there is no question category in previous context.
-        $criteria = array('contextid' => $qcat1->contextid);
-        $this->assertEquals(0, $DB->count_records('question_categories', $criteria));
+        $this->assert_category_contains_questions($qcat->id, 0);
+    }
+    /**
      * This function tests the question_save_from_deletion function when it is supposed to make a new category and
-    /**
+     * move question categories to that new category.
      * This function tests the question_save_from_deletion function when it is supposed to make a new category and
-     * move question categories to that new category.
+     * @covers ::question_save_from_deletion()
      */
     public function test_question_save_from_deletion(): void {
+        global $DB;
+        $this->resetAfterTest(true);
-        global $DB;
+        $this->setAdminUser();
-        $this->resetAfterTest(true);
-        $this->setAdminUser();
         [$category, $course, $quiz, $qcat, $questions] = $this->setup_quiz_and_questions();
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions();
+        $qbank = self::getDataGenerator()->create_module('qbank', ['course' => $course->id]);
         $qbankcontext = \context_module::instance($qbank->cmid);
+    }
     /**
      * This function tests the question_save_from_deletion function when it is supposed to make a new category and
+     * move question categories to that new category when quiz name is very long but less than 256 characters.
+     *
-     * move question categories to that new category when quiz name is very long but less than 256 characters.
+     * @covers ::question_save_from_deletion()
      */
     public function test_question_save_from_deletion_quiz_with_long_name(): void {
         global $DB;
         $this->resetAfterTest(true);
         $this->setAdminUser();
+        [$category, $course, $quiz, $qcat, $questions] = $this->setup_quiz_and_questions();
         $qbank = self::getDataGenerator()->create_module('qbank', ['course' => $course->id]);
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions();
+        $qbankcontext = \context_module::instance($qbank->cmid);
         // Moodle doesn't allow you to enter a name longer than 255 characters.
         $quiz->name = shorten_text(str_repeat('123456789 ', 26), 255);
         $DB->update_record('quiz', $quiz);
         $DB->update_record('quiz', $quiz);
         $context = \context::instance_by_id($qcat->contextid);
         $this->assertEquals(1, $DB->count_records('question_categories', ['contextid' => $qcat->contextid, 'parent' => 0]));
+    }
     /**
+     * get_question_options should add the category object to the given question.
+     *
-     * get_question_options should add the category object to the given question.
+     * @covers ::get_question_options()
      */
     public function test_get_question_options_includes_category_object_single_question(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('category');
+        [$category, $course, $quiz, $qcat, $questions] = $this->setup_quiz_and_questions();
         $question = array_shift($questions);
         get_question_options($question);
         $this->assertEquals($qcat, $question->categoryobject);
+    }
+    /**
      * get_question_options should add the category object to all of the questions in
-    /**
+     * the given list.
-     * get_question_options should add the category object to all of the questions in
+     *
-     * the given list.
+     * @covers ::get_question_options()
      */
     public function test_get_question_options_includes_category_object_multiple_questions(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('category');
+        [$category, $course, $quiz, $qcat, $questions] = $this->setup_quiz_and_questions();
         get_question_options($questions);
+        foreach ($questions as $question) {
+            $this->assertEquals($qcat, $question->categoryobject);
         foreach ($questions as $question) {
             $this->assertEquals($qcat, $question->categoryobject);
-        }
     /**
      * get_question_options includes the tags for all questions in the list.
     /**
-     * get_question_options includes the tags for all questions in the list.
+     * @covers ::get_question_options()
             sort($tags);
             sort($actualtagobjects);
             // The question should have a full set of each tag object.
-            $this->assertEquals($tags, $actualtagobjects);
-            // The question should not have any course tags.
-            $this->assertEmpty($question->coursetagobjects);
-        }
-    }
-    /**
-     * get_question_options includes the course tags for all questions in the list.
-     */
-    public function test_get_question_options_includes_course_tags(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('category');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $coursecontext = \context_course::instance($course->id);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $coursecontext, ['foo', 'bar']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $coursecontext, ['baz', 'bop']);
-        get_question_options($questions, true);
-        foreach ($questions as $question) {
-            $tags = \core_tag_tag::get_item_tags('core_question', 'question', $question->id);
-            $expectedcoursetags = [];
-            $actualcoursetags = $question->coursetags;
-            foreach ($tags as $tag) {
-                $expectedcoursetags[$tag->id] = $tag->get_display_name();
-            }
-            // The question should have a coursetags property populated with each tag id
-            // and display name as a key vale pair.
-            $this->assertEquals($expectedcoursetags, $actualcoursetags);
-            $actualcoursetagobjects = $question->coursetagobjects;
-            sort($tags);
-            sort($actualcoursetagobjects);
-            // The question should have a full set of the course tag objects.
-            $this->assertEquals($tags, $actualcoursetagobjects);
-            // The question should not have any other tags.
-            $this->assertEmpty($question->tagobjects);
-            $this->assertEmpty($question->tags);
-        }
-    }
-    /**
-     * get_question_options only categorises a tag as a course tag if it is in a
-     * course context that is different from the question context.
-     */
-    public function test_get_question_options_course_tags_in_course_question_context(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('course');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $coursecontext = \context_course::instance($course->id);
-        // Create course level tags in the course context that matches the question
-        // course context.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $coursecontext, ['foo', 'bar']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $coursecontext, ['baz', 'bop']);
-        get_question_options($questions, true);
-        foreach ($questions as $question) {
-            $tags = \core_tag_tag::get_item_tags('core_question', 'question', $question->id);
-            $actualtagobjects = $question->tagobjects;
-            sort($tags);
-            sort($actualtagobjects);
-            // The tags should not be considered course tags because they are in
-            // the same context as the question. That makes them question tags.
-            $this->assertEmpty($question->coursetagobjects);
-            // The course context tags should be returned in the regular tag object
-            // list.
-            $this->assertEquals($tags, $actualtagobjects);
-        }
-    }
-    /**
-     * get_question_options includes the tags and course tags for all questions in the list
-     * if each question has course and question level tags.
-     */
-    public function test_get_question_options_includes_question_and_course_tags(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('category');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $qcontext = \context::instance_by_id($qcat->contextid);
-        $coursecontext = \context_course::instance($course->id);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $qcontext, ['foo', 'bar']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $coursecontext, ['cfoo', 'cbar']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $qcontext, ['baz', 'bop']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $coursecontext, ['cbaz', 'cbop']);
-        get_question_options($questions, true);
-        foreach ($questions as $question) {
-            $alltags = \core_tag_tag::get_item_tags('core_question', 'question', $question->id);
-            $tags = array_filter($alltags, function($tag) use ($qcontext) {
-                return $tag->taginstancecontextid == $qcontext->id;
-            });
-            $coursetags = array_filter($alltags, function($tag) use ($coursecontext) {
-                return $tag->taginstancecontextid == $coursecontext->id;
-            });
-            $expectedtags = [];
-            $actualtags = $question->tags;
-            foreach ($tags as $tag) {
-                $expectedtags[$tag->id] = $tag->get_display_name();
-            }
-            // The question should have a tags property populated with each tag id
-            // and display name as a key vale pair.
-            $this->assertEquals($expectedtags, $actualtags);
-            $actualtagobjects = $question->tagobjects;
-            sort($tags);
-            sort($actualtagobjects);
-            // The question should have a full set of each tag object.
-            $this->assertEquals($tags, $actualtagobjects);
-            $actualcoursetagobjects = $question->coursetagobjects;
-            sort($coursetags);
-            sort($actualcoursetagobjects);
-            // The question should have a full set of course tag objects.
-            $this->assertEquals($coursetags, $actualcoursetagobjects);
+            $this->assertEquals($tags, $actualtagobjects);
+        }
+    }
     /**
      * get_question_options should update the context id to the question category
+     * context id for any non-course context tag that isn't in the question category
+     * context.
      * context id for any non-course context tag that isn't in the question category
-     * context.
+     * @covers ::get_question_options()
      */
     public function test_get_question_options_normalises_question_tags(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('category');
+        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions();
         $question1 = $questions[0];
         $question2 = $questions[1];
+            }
+        }
+    }
-    /**
-     * get_question_options if the question is a course level question then tags
-     * in that context should not be consdered course tags, they are question tags.
-     */
-    public function test_get_question_options_includes_course_context_question_tags(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('course');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $coursecontext = \context_course::instance($course->id);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $coursecontext, ['foo', 'bar']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $coursecontext, ['baz', 'bop']);
-        get_question_options($questions, true);
-        foreach ($questions as $question) {
-            $tags = \core_tag_tag::get_item_tags('core_question', 'question', $question->id);
-            // Tags in a course context that matches the question context should
-            // not be considered course tags.
-            $this->assertEmpty($question->coursetagobjects);
-            $this->assertEmpty($question->coursetags);
-            $actualtagobjects = $question->tagobjects;
-            sort($tags);
-            sort($actualtagobjects);
-            // The tags should be considered question tags not course tags.
-            $this->assertEquals($tags, $actualtagobjects);
-        }
-    }
-    /**
-     * get_question_options should return tags from all course contexts by default.
-     */
-    public function test_get_question_options_includes_multiple_courses_tags(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('category');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $coursecontext = \context_course::instance($course->id);
-        // Create a sibling course.
-        $siblingcourse = $this->getDataGenerator()->create_course(['category' => $course->category]);
-        $siblingcoursecontext = \context_course::instance($siblingcourse->id);
-        // Create course tags.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $coursecontext, ['c1']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $coursecontext, ['c1']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $siblingcoursecontext, ['c2']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $siblingcoursecontext, ['c2']);
-        get_question_options($questions, true);
-        foreach ($questions as $question) {
-            $this->assertCount(2, $question->coursetagobjects);
-            foreach ($question->coursetagobjects as $tag) {
-                if ($tag->name == 'c1') {
-                    $this->assertEquals($coursecontext->id, $tag->taginstancecontextid);
-                } else {
-                    $this->assertEquals($siblingcoursecontext->id, $tag->taginstancecontextid);
-                }
-            }
-        }
-    }
-    /**
-     * get_question_options should filter the course tags by the given list of courses.
-     */
-    public function test_get_question_options_includes_filter_course_tags(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('category');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $coursecontext = \context_course::instance($course->id);
-        // Create a sibling course.
-        $siblingcourse = $this->getDataGenerator()->create_course(['category' => $course->category]);
-        $siblingcoursecontext = \context_course::instance($siblingcourse->id);
-        // Create course tags.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $coursecontext, ['foo']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $coursecontext, ['bar']);
-        // Create sibling course tags. These should be filtered out.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $siblingcoursecontext, ['filtered1']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $siblingcoursecontext, ['filtered2']);
-        // Ask to only receive course tags from $course (ignoring $siblingcourse tags).
-        get_question_options($questions, true, [$course]);
-        foreach ($questions as $question) {
-            foreach ($question->coursetagobjects as $tag) {
-                // We should only be seeing course tags from $course. The tags from
-                // $siblingcourse should have been filtered out.
-                $this->assertEquals($coursecontext->id, $tag->taginstancecontextid);
-            }
-        }
-    }
-    /**
-     * question_move_question_tags_to_new_context should update all of the
-     * question tags contexts when they are moving down (from system to course
-     * category context).
-     */
-    public function test_question_move_question_tags_to_new_context_system_to_course_cat_qtags(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('system');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $qcontext = \context::instance_by_id($qcat->contextid);
-        $newcontext = \context_coursecat::instance($category->id);
-        foreach ($questions as $question) {
-            $question->contextid = $qcat->contextid;
-        }
-        // Create tags in the system context.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $qcontext, ['foo', 'bar']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $qcontext, ['foo', 'bar']);
-        question_move_question_tags_to_new_context($questions, $newcontext);
-        foreach ($questions as $question) {
-            $tags = \core_tag_tag::get_item_tags('core_question', 'question', $question->id);
-            // All of the tags should have their context id set to the new context.
-            foreach ($tags as $tag) {
-                $this->assertEquals($newcontext->id, $tag->taginstancecontextid);
-            }
-        }
-    }
-    /**
-     * question_move_question_tags_to_new_context should update all of the question tags
-     * contexts when they are moving down (from system to course category context)
-     * but leave any tags in the course context where they are.
-     */
-    public function test_question_move_question_tags_to_new_context_system_to_course_cat_qtags_and_course_tags(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('system');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $qcontext = \context::instance_by_id($qcat->contextid);
-        $coursecontext = \context_course::instance($course->id);
-        $newcontext = \context_coursecat::instance($category->id);
-        foreach ($questions as $question) {
-            $question->contextid = $qcat->contextid;
-        }
-        // Create tags in the system context.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $qcontext, ['foo']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $qcontext, ['foo']);
-        // Create tags in the course context.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $coursecontext, ['ctag']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $coursecontext, ['ctag']);
-        question_move_question_tags_to_new_context($questions, $newcontext);
-        foreach ($questions as $question) {
-            $tags = \core_tag_tag::get_item_tags('core_question', 'question', $question->id);
-            foreach ($tags as $tag) {
-                if ($tag->name == 'ctag') {
-                    // Course tags should remain in the course context.
-                    $this->assertEquals($coursecontext->id, $tag->taginstancecontextid);
-                } else {
-                    // Other tags should be updated.
-                    $this->assertEquals($newcontext->id, $tag->taginstancecontextid);
-                }
-            }
-        }
-    }
-    /**
-     * question_move_question_tags_to_new_context should update all of the question
-     * contexts tags when they are moving up (from course category to system context).
-     */
-    public function test_question_move_question_tags_to_new_context_course_cat_to_system_qtags(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('category');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $qcontext = \context::instance_by_id($qcat->contextid);
-        $newcontext = \context_system::instance();
-        foreach ($questions as $question) {
-            $question->contextid = $qcat->contextid;
-        }
-        // Create tags in the course category context.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $qcontext, ['foo', 'bar']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $qcontext, ['foo', 'bar']);
-        question_move_question_tags_to_new_context($questions, $newcontext);
-        foreach ($questions as $question) {
-            $tags = \core_tag_tag::get_item_tags('core_question', 'question', $question->id);
-            // All of the tags should have their context id set to the new context.
-            foreach ($tags as $tag) {
-                $this->assertEquals($newcontext->id, $tag->taginstancecontextid);
-            }
-        }
-    }
-    /**
-     * question_move_question_tags_to_new_context should update all of the question
-     * tags contexts when they are moving up (from course category context to system
-     * context) but leave any tags in the course context where they are.
-     */
-    public function test_question_move_question_tags_to_new_context_course_cat_to_system_qtags_and_course_tags(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('category');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $qcontext = \context::instance_by_id($qcat->contextid);
-        $coursecontext = \context_course::instance($course->id);
-        $newcontext = \context_system::instance();
-        foreach ($questions as $question) {
-            $question->contextid = $qcat->contextid;
-        }
-        // Create tags in the system context.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $qcontext, ['foo']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $qcontext, ['foo']);
-        // Create tags in the course context.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $coursecontext, ['ctag']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $coursecontext, ['ctag']);
-        question_move_question_tags_to_new_context($questions, $newcontext);
-        foreach ($questions as $question) {
-            $tags = \core_tag_tag::get_item_tags('core_question', 'question', $question->id);
-            foreach ($tags as $tag) {
-                if ($tag->name == 'ctag') {
-                    // Course tags should remain in the course context.
-                    $this->assertEquals($coursecontext->id, $tag->taginstancecontextid);
-                } else {
-                    // Other tags should be updated.
-                    $this->assertEquals($newcontext->id, $tag->taginstancecontextid);
-                }
-            }
-        }
-    }
-    /**
-     * question_move_question_tags_to_new_context should merge all tags into the course
-     * context when moving down from course category context into course context.
-     */
-    public function test_question_move_question_tags_to_new_context_course_cat_to_coures_qtags_and_course_tags(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('category');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $qcontext = \context::instance_by_id($qcat->contextid);
-        $coursecontext = \context_course::instance($course->id);
-        $newcontext = $coursecontext;
-        foreach ($questions as $question) {
-            $question->contextid = $qcat->contextid;
-        }
-        // Create tags in the system context.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $qcontext, ['foo']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $qcontext, ['foo']);
-        // Create tags in the course context.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $coursecontext, ['ctag']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $coursecontext, ['ctag']);
-        question_move_question_tags_to_new_context($questions, $newcontext);
-        foreach ($questions as $question) {
-            $tags = \core_tag_tag::get_item_tags('core_question', 'question', $question->id);
-            // Each question should have 2 tags.
-            $this->assertCount(2, $tags);
-            foreach ($tags as $tag) {
-                // All tags should be updated to the course context and merged in.
-                $this->assertEquals($newcontext->id, $tag->taginstancecontextid);
-            }
-        }
-    }
-    /**
-     * question_move_question_tags_to_new_context should delete all of the tag
-     * instances from sibling courses when moving the context of a question down
-     * from a course category into a course context because the other courses will
-     * no longer have access to the question.
-     */
-    public function test_question_move_question_tags_to_new_context_remove_other_course_tags(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('category');
-        // Create a sibling course.
-        $siblingcourse = $this->getDataGenerator()->create_course(['category' => $course->category]);
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $qcontext = \context::instance_by_id($qcat->contextid);
-        $coursecontext = \context_course::instance($course->id);
-        $siblingcoursecontext = \context_course::instance($siblingcourse->id);
-        $newcontext = $coursecontext;
-        foreach ($questions as $question) {
-            $question->contextid = $qcat->contextid;
-        }
-        // Create tags in the system context.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $qcontext, ['foo']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $qcontext, ['foo']);
-        // Create tags in the target course context.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $coursecontext, ['ctag']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $coursecontext, ['ctag']);
-        // Create tags in the sibling course context. These should be deleted as
-        // part of the move.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $siblingcoursecontext, ['stag']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $siblingcoursecontext, ['stag']);
-        question_move_question_tags_to_new_context($questions, $newcontext);
-        foreach ($questions as $question) {
-            $tags = \core_tag_tag::get_item_tags('core_question', 'question', $question->id);
-            // Each question should have 2 tags, 'foo' and 'ctag'.
-            $this->assertCount(2, $tags);
-            foreach ($tags as $tag) {
-                $tagname = $tag->name;
-                // The 'stag' should have been deleted because it's in a sibling
-                // course context.
-                $this->assertContains($tagname, ['foo', 'ctag']);
-                // All tags should be in the course context now.
-                $this->assertEquals($coursecontext->id, $tag->taginstancecontextid);
-            }
-        }
-    }
-    /**
-     * question_move_question_tags_to_new_context should update all of the question
-     * tags to be the course category context when moving the tags from a course
-     * context to a course category context.
-     */
-    public function test_question_move_question_tags_to_new_context_course_to_course_cat(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('course');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $qcontext = \context::instance_by_id($qcat->contextid);
-        // Moving up into the course category context.
-        $newcontext = \context_coursecat::instance($category->id);
-        foreach ($questions as $question) {
-            $question->contextid = $qcat->contextid;
-        }
-        // Create tags in the course context.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $qcontext, ['foo']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $qcontext, ['foo']);
-        question_move_question_tags_to_new_context($questions, $newcontext);
-        foreach ($questions as $question) {
-            $tags = \core_tag_tag::get_item_tags('core_question', 'question', $question->id);
-            // All of the tags should have their context id set to the new context.
-            foreach ($tags as $tag) {
-                $this->assertEquals($newcontext->id, $tag->taginstancecontextid);
-            }
-        }
-    }
-    /**
-     * question_move_question_tags_to_new_context should update all of the
-     * question tags contexts when they are moving down (from system to course
-     * category context).
-     */
-    public function test_question_move_question_tags_to_new_context_orphaned_tag_contexts(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('system');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $othercategory = $this->getDataGenerator()->create_category();
-        $qcontext = \context::instance_by_id($qcat->contextid);
-        $newcontext = \context_coursecat::instance($category->id);
-        $othercategorycontext = \context_coursecat::instance($othercategory->id);
-        foreach ($questions as $question) {
-            $question->contextid = $qcat->contextid;
-        }
-        // Create tags in the system context.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $qcontext, ['foo']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $qcontext, ['foo']);
-        // Create tags in the other course category context. These should be
-        // update to the next context id because they represent erroneous data
-        // from a time before context id was mandatory in the tag API.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $othercategorycontext, ['bar']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $othercategorycontext, ['bar']);
-        question_move_question_tags_to_new_context($questions, $newcontext);
-        foreach ($questions as $question) {
-            $tags = \core_tag_tag::get_item_tags('core_question', 'question', $question->id);
-            // Each question should have two tags, 'foo' and 'bar'.
-            $this->assertCount(2, $tags);
-            // All of the tags should have their context id set to the new context
-            // (course category context).
-            foreach ($tags as $tag) {
-                $this->assertEquals($newcontext->id, $tag->taginstancecontextid);
-            }
-        }
-    }
     /**
-     * When moving from a course category context down into an activity context
-     * all question context tags and course tags (where the course is a parent of
-     * the activity) should move into the new context.
-     */
-    public function test_question_move_question_tags_to_new_context_course_cat_to_activity_qtags_and_course_tags(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('category');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $qcontext = \context::instance_by_id($qcat->contextid);
-        $coursecontext = \context_course::instance($course->id);
-        $newcontext = \context_module::instance($quiz->cmid);
-        foreach ($questions as $question) {
-            $question->contextid = $qcat->contextid;
-        }
-        // Create tags in the course category context.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $qcontext, ['foo']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $qcontext, ['foo']);
-        // Move the questions to the activity context which is a child context of
-        // $coursecontext.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $coursecontext, ['ctag']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $coursecontext, ['ctag']);
-        question_move_question_tags_to_new_context($questions, $newcontext);
-        foreach ($questions as $question) {
-            $tags = \core_tag_tag::get_item_tags('core_question', 'question', $question->id);
-            // Each question should have 2 tags.
-            $this->assertCount(2, $tags);
-            foreach ($tags as $tag) {
-                $this->assertEquals($newcontext->id, $tag->taginstancecontextid);
-            }
-        }
-    }
-    /**
-     * When moving from a course category context down into an activity context
-     * all question context tags and course tags (where the course is a parent of
-     * the activity) should move into the new context. Tags in course contexts
-     * that are not a parent of the activity context should be deleted.
-     */
-    public function test_question_move_question_tags_to_new_context_course_cat_to_activity_orphaned_tags(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('category');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $qcontext = \context::instance_by_id($qcat->contextid);
-        $coursecontext = \context_course::instance($course->id);
-        $newcontext = \context_module::instance($quiz->cmid);
-        $othercourse = $this->getDataGenerator()->create_course();
-        $othercoursecontext = \context_course::instance($othercourse->id);
-        foreach ($questions as $question) {
-            $question->contextid = $qcat->contextid;
-        }
-        // Create tags in the course category context.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $qcontext, ['foo']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $qcontext, ['foo']);
-        // Create tags in the course context.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $coursecontext, ['ctag']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $coursecontext, ['ctag']);
-        // Create tags in the other course context. These should be deleted.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $othercoursecontext, ['delete']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $othercoursecontext, ['delete']);
-        // Move the questions to the activity context which is a child context of
-        // $coursecontext.
-        question_move_question_tags_to_new_context($questions, $newcontext);
-        foreach ($questions as $question) {
-            $tags = \core_tag_tag::get_item_tags('core_question', 'question', $question->id);
-            // Each question should have 2 tags.
-            $this->assertCount(2, $tags);
-            foreach ($tags as $tag) {
-                // Make sure we don't have any 'delete' tags.
-                $this->assertContains($tag->name, ['foo', 'ctag']);
-                $this->assertEquals($newcontext->id, $tag->taginstancecontextid);
-            }
-        }
-    }
-    /**
-     * When moving from a course context down into an activity context all of the
-     * course tags should move into the activity context.
+     * When moving all tags from one activity context into another activity context.
-     */
-    public function test_question_move_question_tags_to_new_context_course_to_activity_qtags(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('course');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $qcontext = \context::instance_by_id($qcat->contextid);
-        $newcontext = \context_module::instance($quiz->cmid);
-        foreach ($questions as $question) {
-            $question->contextid = $qcat->contextid;
-        }
-        // Create tags in the course context.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $qcontext, ['foo']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $qcontext, ['foo']);
+     *
-        question_move_question_tags_to_new_context($questions, $newcontext);
-        foreach ($questions as $question) {
-            $tags = \core_tag_tag::get_item_tags('core_question', 'question', $question->id);
-            foreach ($tags as $tag) {
-                $this->assertEquals($newcontext->id, $tag->taginstancecontextid);
-            }
-        }
-    }
-    /**
-     * When moving from a course context down into an activity context all of the
-     * course tags should move into the activity context.
+     * @covers ::question_move_question_tags_to_new_context()
      */
-    public function test_question_move_question_tags_to_new_context_activity_to_course_qtags(): void {
+    public function test_question_move_question_tags_to_new_context_activity_to_activity_qtags(): void {
+        [$category, $course, $quiz, $qcat, $questions] = $this->setup_quiz_and_questions();
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions();
+        $qbank = self::getDataGenerator()->create_module('qbank', ['course' => $course->id]);
         $question1 = $questions[0];
         $question2 = $questions[1];
         $qcontext = \context::instance_by_id($qcat->contextid);
-        $newcontext = \context_course::instance($course->id);
+        $newcontext = \context_module::instance($qbank->cmid);
         foreach ($questions as $question) {
             $question->contextid = $qcat->contextid;
+        }
-        // Create tags in the activity context.
+        // Create tags in the quiz context.
+            }
+        }
+    }
-    /**
-     * question_move_question_tags_to_new_context should update all of the
-     * question tags contexts when they are moving down (from system to course
-     * category context).
-     *
-     * Course tags within the new category context should remain while any course
-     * tags in course contexts that can no longer access the question should be
-     * deleted.
-     */
-    public function test_question_move_question_tags_to_new_context_system_to_course_cat_with_orphaned_tags(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('system');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $othercategory = $this->getDataGenerator()->create_category();
-        $othercourse = $this->getDataGenerator()->create_course(['category' => $othercategory->id]);
-        $qcontext = \context::instance_by_id($qcat->contextid);
-        $newcontext = \context_coursecat::instance($category->id);
-        $othercategorycontext = \context_coursecat::instance($othercategory->id);
-        $coursecontext = \context_course::instance($course->id);
-        $othercoursecontext = \context_course::instance($othercourse->id);
-        foreach ($questions as $question) {
-            $question->contextid = $qcat->contextid;
-        }
-        // Create tags in the system context.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $qcontext, ['foo']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $qcontext, ['foo']);
-        // Create tags in the child course context of the new context.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $coursecontext, ['bar']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $coursecontext, ['bar']);
-        // Create tags in the other course context. These should be deleted when
-        // the question moves to the new course category context because this
-        // course belongs to a different category, which means it will no longer
-        // have access to the question.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $othercoursecontext, ['delete']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $othercoursecontext, ['delete']);
-        question_move_question_tags_to_new_context($questions, $newcontext);
-        foreach ($questions as $question) {
-            $tags = \core_tag_tag::get_item_tags('core_question', 'question', $question->id);
-            // Each question should have two tags, 'foo' and 'bar'.
-            $this->assertCount(2, $tags);
-            // All of the tags should have their context id set to the new context
-            // (course category context).
-            foreach ($tags as $tag) {
-                $this->assertContains($tag->name, ['foo', 'bar']);
-                if ($tag->name == 'foo') {
-                    $this->assertEquals($newcontext->id, $tag->taginstancecontextid);
-                } else {
-                    $this->assertEquals($coursecontext->id, $tag->taginstancecontextid);
-                }
-            }
-        }
-    }
     /**
      * question_sort_tags() includes the tags for all questions in the list.
      */
     public function test_question_sort_tags_includes_question_tags(): void {
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('category');
+        [$category, $course, $quiz, $qcat, $questions] = $this->setup_quiz_and_questions();
         $question1 = $questions[0];
         $question2 = $questions[1];
             sort($tags);
             sort($actualtagobjects);
             // The question should have a full set of each tag object.
-            $this->assertEquals($tags, $actualtagobjects);
-            // The question should not have any course tags.
-            $this->assertEmpty($tagobjects->coursetagobjects);
-        }
-    }
-    /**
-     * question_sort_tags() includes course tags for all questions in the list.
-     */
-    public function test_question_sort_tags_includes_question_course_tags(): void {
-        global $DB;
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('category');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $coursecontext = \context_course::instance($course->id);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $coursecontext, ['foo', 'bar']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $coursecontext, ['baz', 'bop']);
-        foreach ($questions as $question) {
-            $tags = \core_tag_tag::get_item_tags('core_question', 'question', $question->id);
-            $tagobjects = question_sort_tags($tags, $qcat);
-            $expectedtags = [];
-            $actualtags = $tagobjects->coursetags;
-            foreach ($actualtags as $coursetagid => $coursetagname) {
-                $expectedtags[$coursetagid] = $coursetagname;
-            }
-            // The question should have a tags property populated with each tag id
-            // and display name as a key vale pair.
-            $this->assertEquals($expectedtags, $actualtags);
-            $actualtagobjects = $tagobjects->coursetagobjects;
-            sort($tags);
-            sort($actualtagobjects);
-            // The question should have a full set of each tag object.
-            $this->assertEquals($tags, $actualtagobjects);
-            // The question should not have any course tags.
-            $this->assertEmpty($tagobjects->tagobjects);
-        }
-    }
-    /**
-     * question_sort_tags() should return tags from all course contexts by default.
-     */
-    public function test_question_sort_tags_includes_multiple_courses_tags(): void {
-        global $DB;
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('category');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $coursecontext = \context_course::instance($course->id);
-        // Create a sibling course.
-        $siblingcourse = $this->getDataGenerator()->create_course(['category' => $course->category]);
-        $siblingcoursecontext = \context_course::instance($siblingcourse->id);
-        // Create course tags.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $coursecontext, ['c1']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $coursecontext, ['c1']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $siblingcoursecontext, ['c2']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $siblingcoursecontext, ['c2']);
-        foreach ($questions as $question) {
-            $tags = \core_tag_tag::get_item_tags('core_question', 'question', $question->id);
-            $tagobjects = question_sort_tags($tags, $qcat);
-            $this->assertCount(2, $tagobjects->coursetagobjects);
-            foreach ($tagobjects->coursetagobjects as $tag) {
-                if ($tag->name == 'c1') {
-                    $this->assertEquals($coursecontext->id, $tag->taginstancecontextid);
-                } else {
-                    $this->assertEquals($siblingcoursecontext->id, $tag->taginstancecontextid);
-                }
-            }
-        }
-    }
-    /**
-     * question_sort_tags() should filter the course tags by the given list of courses.
-     */
-    public function test_question_sort_tags_includes_filter_course_tags(): void {
-        global $DB;
-        list($category, $course, $quiz, $qcat, $questions) = $this->setup_quiz_and_questions('category');
-        $question1 = $questions[0];
-        $question2 = $questions[1];
-        $coursecontext = \context_course::instance($course->id);
-        // Create a sibling course.
-        $siblingcourse = $this->getDataGenerator()->create_course(['category' => $course->category]);
-        $siblingcoursecontext = \context_course::instance($siblingcourse->id);
-        // Create course tags.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $coursecontext, ['foo']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $coursecontext, ['bar']);
-        // Create sibling course tags. These should be filtered out.
-        \core_tag_tag::set_item_tags('core_question', 'question', $question1->id, $siblingcoursecontext, ['filtered1']);
-        \core_tag_tag::set_item_tags('core_question', 'question', $question2->id, $siblingcoursecontext, ['filtered2']);
-        foreach ($questions as $question) {
-            $tags = \core_tag_tag::get_item_tags('core_question', 'question', $question->id);
-            $tagobjects = question_sort_tags($tags, $qcat, [$course]);
-            foreach ($tagobjects->coursetagobjects as $tag) {
-                // We should only be seeing course tags from $course. The tags from
-                // $siblingcourse should have been filtered out.
-                $this->assertEquals($coursecontext->id, $tag->taginstancecontextid);
             $this->assertEquals($tags, $actualtagobjects);
+        }
+    }
     /**
      * Data provider for tests of question_has_capability_on_context and question_require_capability_on_context.
+     *
      * @return  array
      */
-    public function question_capability_on_question_provider() {
+    public static function question_capability_on_question_provider(): array {
         return [
             'Unrelated capability which is present' => [
                 'capabilities' => [
                     'moodle/question:config' => CAP_ALLOW,
                 ],
-                'testcapability' => 'config',
+                'capability' => 'config',
                 'isowner' => true,
                 'expect' => true,
             ],
             'Unrelated capability which is present (not owner)' => [
                 'capabilities' => [
                     'moodle/question:config' => CAP_ALLOW,
                 ],
-                'testcapability' => 'config',
+                'capability' => 'config',
                 'isowner' => false,
                 'expect' => true,
             ],
             'Unrelated capability which is not set' => [
                 'capabilities' => [
                 ],
-                'testcapability' => 'config',
+                'capability' => 'config',
                 'isowner' => true,
                 'expect' => false,
             ],
             'Unrelated capability which is not set (not owner)' => [
                 'capabilities' => [
                 ],
-                'testcapability' => 'config',
+                'capability' => 'config',
                 'isowner' => false,
                 'expect' => false,
             ],
             'Unrelated capability which is prevented' => [
                 'capabilities' => [
                     'moodle/question:config' => CAP_PREVENT,
                 ],
-                'testcapability' => 'config',
+                'capability' => 'config',
                 'isowner' => true,
                 'expect' => false,
             ],
             'Unrelated capability which is prevented (not owner)' => [
                 'capabilities' => [
                     'moodle/question:config' => CAP_PREVENT,
                 ],
-                'testcapability' => 'config',
+                'capability' => 'config',
                 'isowner' => false,
                 'expect' => false,
             ],
             'Related capability which is not set' => [
                 'capabilities' => [
                 ],
-                'testcapability' => 'edit',
+                'capability' => 'edit',
                 'isowner' => true,
                 'expect' => false,
             ],
             'Related capability which is not set (not owner)' => [
                 'capabilities' => [
                 ],
-                'testcapability' => 'edit',
+                'capability' => 'edit',
                 'isowner' => false,
                 'expect' => false,
             ],
             'Related capability which is allowed at all, unset at mine' => [
                 'capabilities' => [
                     'moodle/question:editall' => CAP_ALLOW,
                 ],
-                'testcapability' => 'edit',
+                'capability' => 'edit',
                 'isowner' => true,
                 'expect' => true,
             ],
             'Related capability which is allowed at all, unset at mine (not owner)' => [
                 'capabilities' => [
                     'moodle/question:editall' => CAP_ALLOW,
                 ],
-                'testcapability' => 'edit',
+                'capability' => 'edit',
                 'isowner' => false,
                 'expect' => true,
             ],
             'Related capability which is allowed at all, prevented at mine' => [
                 'capabilities' => [
                     'moodle/question:editall' => CAP_ALLOW,
                     'moodle/question:editmine' => CAP_PREVENT,
                 ],
-                'testcapability' => 'edit',
+                'capability' => 'edit',
                 'isowner' => true,
                 'expect' => true,
             ],
             'Related capability which is allowed at all, prevented at mine (not owner)' => [
                 'capabilities' => [
                     'moodle/question:editall' => CAP_ALLOW,
                     'moodle/question:editmine' => CAP_PREVENT,
                 ],
-                'testcapability' => 'edit',
+                'capability' => 'edit',
                 'isowner' => false,
                 'expect' => true,
             ],
             'Related capability which is unset all, allowed at mine' => [
                 'capabilities' => [
                     'moodle/question:editall' => CAP_PREVENT,
                     'moodle/question:editmine' => CAP_ALLOW,
                 ],
-                'testcapability' => 'edit',
+                'capability' => 'edit',
                 'isowner' => true,
                 'expect' => true,
             ],
             'Related capability which is unset all, allowed at mine (not owner)' => [
                 'capabilities' => [
                     'moodle/question:editall' => CAP_PREVENT,
                     'moodle/question:editmine' => CAP_ALLOW,
                 ],
-                'testcapability' => 'edit',
+                'capability' => 'edit',
                 'isowner' => false,
                 'expect' => false,
             ],
         // Create the test data.
         $generator = $this->getDataGenerator();
          /** @var \core_question_generator $questiongenerator */
          $questiongenerator = $generator->get_plugin_generator('core_question');
-        $category = $generator->create_category();
-        $context = \context_coursecat::instance($category->id);
+        $context = $this->create_course_and_question_bank();
         $questioncat = $questiongenerator->create_question_category([
             'contextid' => $context->id,
         ]);
         // Create a cloze question.
-        $question = $questiongenerator->create_question('multianswer', null, [
+        $question = $questiongenerator->create_question('ddwtos', null, [
             'category' => $questioncat->id,
         ]);
         // Now, break the question.
-        $DB->delete_records('question_multianswer', ['question' => $question->id]);
+        $DB->delete_records('question_ddwtos', ['questionid' => $question->id]);
         /** @var \core_question_generator $questiongenerator */
         $questiongenerator = $generator->get_plugin_generator('core_question');
         $user = $generator->create_user();
         $otheruser = $generator->create_user();
         $roleid = $generator->create_role();
-        $category = $generator->create_category();
-        $context = \context_coursecat::instance($category->id);
+        $context = $this->create_course_and_question_bank();
         $questioncat = $questiongenerator->create_question_category([
             'contextid' => $context->id,
         ]);
         /** @var \core_question_generator $questiongenerator */
         $questiongenerator = $generator->get_plugin_generator('core_question');
         $user = $generator->create_user();
         $otheruser = $generator->create_user();
         $roleid = $generator->create_role();
-        $category = $generator->create_category();
-        $context = \context_coursecat::instance($category->id);
+        $context = $this->create_course_and_question_bank();
         $questioncat = $questiongenerator->create_question_category([
             'contextid' => $context->id,
         ]);
         /** @var \core_question_generator $questiongenerator */
         $questiongenerator = $generator->get_plugin_generator('core_question');
         $user = $generator->create_user();
         $otheruser = $generator->create_user();
         $roleid = $generator->create_role();
-        $category = $generator->create_category();
-        $context = \context_coursecat::instance($category->id);
+        $context = $this->create_course_and_question_bank();
         $questioncat = $questiongenerator->create_question_category([
             'contextid' => $context->id,
         ]);
         /** @var \core_question_generator $questiongenerator */
         $questiongenerator = $generator->get_plugin_generator('core_question');
         $user = $generator->create_user();
         $otheruser = $generator->create_user();
         $roleid = $generator->create_role();
-        $category = $generator->create_category();
+        $context = $this->create_course_and_question_bank();
-        $context = \context_coursecat::instance($category->id);
+        $coursecontext = $context->get_course_context();
         $questioncat = $questiongenerator->create_question_category([
             'contextid' => $context->id,
         ]);
-        $newcategory = $generator->create_category();
+        $qbank2 = $generator->create_module('qbank', ['course' => $coursecontext->instanceid]);
-        $newcontext = \context_coursecat::instance($newcategory->id);
+        $newcontext = \context_module::instance($qbank2->cmid);
         $newquestioncat = $questiongenerator->create_question_category([
             'contextid' => $newcontext->id,
         ]);
         /** @var \core_question_generator $questiongenerator */
         $questiongenerator = $generator->get_plugin_generator('core_question');
         $user = $generator->create_user();
         $otheruser = $generator->create_user();
         $roleid = $generator->create_role();
-        $category = $generator->create_category();
-        $context = \context_coursecat::instance($category->id);
+        $context = $this->create_course_and_question_bank();
         $questioncat = $questiongenerator->create_question_category([
             'contextid' => $context->id,
         ]);
         $generator = $this->getDataGenerator();
         /** @var \core_question_generator $questiongenerator */
         $questiongenerator = $generator->get_plugin_generator('core_question');
         $user = $generator->create_user();
-        $category = $generator->create_category();
-        $context = \context_coursecat::instance($category->id);
+        $context = $this->create_course_and_question_bank();
         $questioncat = $questiongenerator->create_question_category([
             'contextid' => $context->id,
         ]);
         // Create a category tree.
         /** @var \core_question_generator $questiongenerator */
         $questiongenerator = $this->getDataGenerator()->get_plugin_generator('core_question');
         // Create a Course.
-        $course = $this->getDataGenerator()->create_course();
-        $coursecontext = \context_course::instance($course->id);
+        $context = $this->create_course_and_question_bank();
-        $top = question_get_top_category($coursecontext->id, true);
+        $top = question_get_top_category($context->id, true);
-        $cat1 = $questiongenerator->create_question_category(['parent' => $top->id]);
+        $cat1 = question_get_default_category($context->id);
         $sub11 = $questiongenerator->create_question_category(['parent' => $cat1->id]);
         $sub12 = $questiongenerator->create_question_category(['parent' => $cat1->id]);
     public function test_question_categorylist_bad_data(): void {
         $this->resetAfterTest();
         // Create a category tree.
+        $course = $this->getDataGenerator()->create_course();
-        $course = $this->getDataGenerator()->create_course();
+        $qbank1 = self::getDataGenerator()->create_module('qbank', ['course' => $course->id]);
+        $bank1context = \context_module::instance($qbank1->cmid);
-        $coursecontext = \context_course::instance($course->id);
+        $qbank2 = self::getDataGenerator()->create_module('qbank', ['course' => $course->id]);
         /** @var \core_question_generator $questiongenerator */
         $questiongenerator = $this->getDataGenerator()->get_plugin_generator('core_question');
-        $context = \context_system::instance();
+        $wrongcontext = \context_module::instance($qbank2->cmid);
-        $top = question_get_top_category($coursecontext->id, true);
+        $top = question_get_top_category($bank1context->id, true);
-        $cat1 = $questiongenerator->create_question_category(['parent' => $top->id]);
+        $cat1 = question_get_default_category($bank1context->id);
         $sub11 = $questiongenerator->create_question_category(['parent' => $cat1->id]);
         $sub12 = $questiongenerator->create_question_category(['parent' => $cat1->id]);
-        $cat2 = $questiongenerator->create_question_category(['parent' => $top->id, 'contextid' => $context->id]);
+        $cat2 = $questiongenerator->create_question_category(['parent' => $top->id, 'contextid' => $wrongcontext->id]);
         $sub22 = $questiongenerator->create_question_category(['parent' => $cat2->id]);
     public function test_question_categorylist_parents(): void {
         $this->resetAfterTest();
         $generator = $this->getDataGenerator();
         /** @var \core_question_generator $questiongenerator */
         $questiongenerator = $generator->get_plugin_generator('core_question');
-        $category = $generator->create_category();
-        $context = \context_coursecat::instance($category->id);
+        $context = $this->create_course_and_question_bank();
         // Create a top category.
         $cat0 = question_get_top_category($context->id, true);
         // Add sub-categories.
         $cat1 = $questiongenerator->create_question_category(['parent' => $cat0->id]);
         $cat2 = $questiongenerator->create_question_category(['parent' => $cat1->id]);
     public function test_question_categorylist_parents_bad_data(): void {
         $this->resetAfterTest();
         $generator = $this->getDataGenerator();
         /** @var \core_question_generator $questiongenerator */
         $questiongenerator = $generator->get_plugin_generator('core_question');
+        $bank1context = $this->create_course_and_question_bank();
-        $category = $generator->create_category();
+        $coursecontext = $bank1context->get_course_context();
+        $qbank2 = self::getDataGenerator()->create_module('qbank', ['course' => $coursecontext->instanceid]);
-        $context = \context_coursecat::instance($category->id);
+        $bank2context = \context_module::instance($qbank2->cmid);
         // Create a top category.
-        $cat0 = question_get_top_category($context->id, true);
+        $cat0 = question_get_top_category($bank1context->id, true);
         // Add sub-categories - but in a different context.
         $cat1 = $questiongenerator->create_question_category(
-            ['parent' => $cat0->id, 'contextid' => \context_system::instance()->id]);
+            ['parent' => $cat0->id, 'contextid' => $bank2context->id]);
         $cat2 = $questiongenerator->create_question_category(
-            ['parent' => $cat1->id, 'contextid' => \context_system::instance()->id]);
+            ['parent' => $cat1->id, 'contextid' => $bank2context->id]);
         // Test the 'get parents' function only returns categories in the same context.
         $this->assertEquals([$cat1->id], question_categorylist_parents($cat2->id));
+    }
     /**
      * Get test cases for test_core_question_find_next_unused_idnumber.
+     *
      * @return array test cases.
      */
-    public function find_next_unused_idnumber_cases(): array {
+    public static function find_next_unused_idnumber_cases(): array {
         return [
             [null, null],
             ['id', null],
      */
     public function test_delete_question_bank_entry(): void {
         global $DB;
         $this->resetAfterTest();
         // Setup.
-        $context = \context_system::instance();
+        $context = $this->create_course_and_question_bank();
         /** @var \core_question_generator $qgen */
         $qgen = $this->getDataGenerator()->get_plugin_generator('core_question');
         $qcat = $qgen->create_question_category(array('contextid' => $context->id));
         $q1 = $qgen->create_question('shortanswer', null, array('category' => $qcat->id));
         // Make sure there is an entry in the entry table.
      */
     public function test_get_question_bank_entry(): void {
         global $DB;
         $this->resetAfterTest();
         // Setup.
-        $context = \context_system::instance();
+        $context = $this->create_course_and_question_bank();
         /** @var \core_question_generator $qgen */
         $qgen = $this->getDataGenerator()->get_plugin_generator('core_question');
         $qcat = $qgen->create_question_category(array('contextid' => $context->id));
         $q1 = $qgen->create_question('shortanswer', null, array('category' => $qcat->id));
         // Make sure there is an entry in the entry table.
      */
     public function test_get_question_version(): void {
         global $DB;
         $this->resetAfterTest();
         // Setup.
-        $context = \context_system::instance();
+        $context = $this->create_course_and_question_bank();
         /** @var \core_question_generator $qgen */
         $qgen = $this->getDataGenerator()->get_plugin_generator('core_question');
         $qcat = $qgen->create_question_category(array('contextid' => $context->id));
         $q1 = $qgen->create_question('shortanswer', null, array('category' => $qcat->id));
         // Make sure there is an entry in the entry table.
      */
     public function test_get_next_version(): void {
         global $DB;
         $this->resetAfterTest();
         // Setup.
-        $context = \context_system::instance();
+        $context = $this->create_course_and_question_bank();
         /** @var \core_question_generator $qgen */
         $qgen = $this->getDataGenerator()->get_plugin_generator('core_question');
         $qcat = $qgen->create_question_category(array('contextid' => $context->id));
         $q1 = $qgen->create_question('shortanswer', null, array('category' => $qcat->id));
         // Make sure there is an entry in the entry table.
         $this->assertEquals(1, $record->version);
         $nextversion = get_next_version($record->id);
         $this->assertEquals(2, $nextversion);
+    }
+    /**
+     * Test moving a question category from one context to another
+     *
+     * @covers ::question_move_category_to_context
+     */
+    public function test_question_move_category_to_context(): void {
+        global $CFG, $DB;
+        $this->setAdminUser();
+        // Create a course.
+        $course = self::getDataGenerator()->create_course();
+        // Create a quiz activity to store our question in at the start.
+        $quiz1 = $this->getDataGenerator()->create_module('quiz', [
+            'course' => $course->id,
+        ]);
+        // And then create another one to move the category to.
+        $quiz2 = $this->getDataGenerator()->create_module('quiz', [
+            'course' => $course->id,
+        ]);
+        // Get the question generator and the context of the activities.
+        $generator = self::getDataGenerator()->get_plugin_generator('core_question');
+        $context1 = \context_module::instance($quiz1->cmid);
+        $context2 = \context_module::instance($quiz2->cmid);
+        // Create a question category within our first quiz activity.
+        $category = $generator->create_question_category(['contextid' => $context1->id]);
+        // And create a question within that.
+        // We will use `truefalse` but it could be any type.
+        $question = $generator->create_question('truefalse', null, ['category' => $category->id]);
+        $areas = [
+            'questiontext' => '1.jpg',
+            'generalfeedback' => '2.jpg',
+        ];
+        // Add file records to each of the file areas, for our first quiz activity.
+        foreach ($areas as $area => $img) {
+            $fs = get_file_storage();
+            $filerecord = new \stdClass();
+            $filerecord->contextid = $context1->id;
+            $filerecord->component = 'question';
+            $filerecord->filearea = $area;
+            $filerecord->itemid = $question->id;
+            $filerecord->filepath = '/';
+            $filerecord->filename = $img;
+            $fs->create_file_from_pathname($filerecord, $CFG->dirroot .
+                '/lib/tests/fixtures/' . $img);
+        }
+        // Firstly, confirm that the file records exist and there were no problems creating them.
+        // We don't care in this test about the actual files in the data dir.
+        $files = $DB->get_records('files', [
+            'component' => 'question',
+            'itemid' => $question->id,
+            'contextid' => $context1->id,
+            'mimetype' => 'image/jpeg',
+        ]);
+        $this->assertCount(2, $files);
+        // Move the question category to another context.
+        question_move_category_to_context(
+            $category->id,
+            $context1->id,
+            $context2->id,
+        );
+        // Now check that the files have been moved to the new category.
+        $files = $DB->get_records('files', [
+            'component' => 'question',
+            'itemid' => $question->id,
+            'contextid' => $context2->id,
+            'mimetype' => 'image/jpeg',
+        ]);
+        $this->assertCount(2, $files);
+    }
+    /**
+     * Update the context for a set reference, keeping the original category.
+     *
+     * @covers ::move_question_set_references()
+     */
+    public function test_move_question_set_references_context(): void {
+        $this->setAdminUser();
+        // Create a course with a quiz containing a random question from a qbank context.
+        $randomcourse = self::getDataGenerator()->create_course(['shortname' => 'Random']);
+        $qbank1 = self::getDataGenerator()->get_plugin_generator('mod_qbank')->create_instance(['course' => $randomcourse->id]);
+        $context1 = \context_module::instance($qbank1->cmid);
+        $qbank2 = self::getDataGenerator()->get_plugin_generator('mod_qbank')->create_instance(['course' => $randomcourse->id]);
+        $context2 = \context_module::instance($qbank2->cmid);
+        $topcategory = question_get_top_category($context1->id, true);
+        $randomcategory = self::getDataGenerator()->get_plugin_generator('core_question')->create_question_category(
+            ['parent' => $topcategory->id],
+        );
+        $randomquiz = self::getDataGenerator()->get_plugin_generator('mod_quiz')->create_instance(
+            [
+                'course' => $randomcourse->id,
+                'grade' => 100.0,
+                'sumgrades' => 2,
+                'layout' => '1,0',
+            ],
+        );
+        $randomquizsettings = quiz_settings::create($randomquiz->id);
+        $structure = $randomquizsettings->get_structure();
+        $filtercondition = [
+            'filter' => [
+                'category' => [
+                    'jointype' => \core_question\local\bank\condition::JOINTYPE_DEFAULT,
+                    'values' => [$randomcategory->id],
+                    'filteroptions' => ['includesubcategories' => true],
+                ],
+            ],
+        ];
+        $structure->add_random_questions(1, 1, $filtercondition);
+        $structure = $randomquizsettings->get_structure();
+        $randomquestion = $structure->get_question_in_slot(1);
+        $this->assertEquals($randomquestion->contextid, $context1->id);
+        $this->assertEquals($randomquestion->filtercondition['filter']['category']['values'][0], $randomcategory->id);
+        move_question_set_references($randomcategory->id, $randomcategory->id, $context1->id, $context2->id);
+        $structure = $randomquizsettings->get_structure();
+        $randomquestion = $structure->get_question_in_slot(1);
+        $this->assertEquals($randomquestion->contextid, $context2->id);
+        $this->assertEquals($randomquestion->filtercondition['filter']['category']['values'][0], $randomcategory->id);
+    }
+    /**
+     * Update the context and category for a set reference.
+     *
+     * @covers ::move_question_set_references()
+     */
+    public function test_move_question_set_references_category(): void {
+        $this->setAdminUser();
+        // Create a course with a quiz containing a random question from a qbank context.
+        $randomcourse = self::getDataGenerator()->create_course(['shortname' => 'Random']);
+        $qbank1 = self::getDataGenerator()->get_plugin_generator('mod_qbank')->create_instance(['course' => $randomcourse->id]);
+        $context1 = \context_module::instance($qbank1->cmid);
+        $qbank2 = self::getDataGenerator()->get_plugin_generator('mod_qbank')->create_instance(['course' => $randomcourse->id]);
+        $context2 = \context_module::instance($qbank2->cmid);
+        $topcategory1 = question_get_top_category($context1->id, true);
+        $topcategory2 = question_get_top_category($context2->id, true);
+        $randomquiz = self::getDataGenerator()->get_plugin_generator('mod_quiz')->create_instance(
+            [
+                'course' => $randomcourse->id,
+                'grade' => 100.0,
+                'sumgrades' => 2,
+                'layout' => '1,0',
+            ],
+        );
+        $randomquizsettings = quiz_settings::create($randomquiz->id);
+        $structure = $randomquizsettings->get_structure();
+        $filtercondition = [
+            'filter' => [
+                'category' => [
+                    'jointype' => \core_question\local\bank\condition::JOINTYPE_DEFAULT,
+                    'values' => [$topcategory1->id],
+                    'filteroptions' => ['includesubcategories' => true],
+                ],
+            ],
+        ];
+        $structure->add_random_questions(1, 1, $filtercondition);
+        $structure = $randomquizsettings->get_structure();
+        $randomquestion = $structure->get_question_in_slot(1);
+        $this->assertEquals($randomquestion->contextid, $context1->id);
+        $this->assertEquals($randomquestion->filtercondition['filter']['category']['values'][0], $topcategory1->id);
+        move_question_set_references($topcategory1->id, $topcategory2->id, $context1->id, $context2->id);
+        $structure = $randomquizsettings->get_structure();
+        $randomquestion = $structure->get_question_in_slot(1);
+        $this->assertEquals($randomquestion->contextid, $context2->id);
+        $this->assertEquals($randomquestion->filtercondition['filter']['category']['values'][0], $topcategory2->id);
+    }

Proyectos de Subversion Moodle

(root)/lib/tests/questionlib_test.php – Rev 11 → 1441