WebSVN – Moodle – Diff – /lib/tests/plugininfo/editor_test.php

  * @package     core
  * @covers      \core\plugininfo\editor
  * @copyright   2023 Andrew Lyons <andrew@nicols.co.uk>
  * @license     http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class editor_test extends advanced_testcase {
+final class editor_test extends advanced_testcase {
     /**
      * Test that editor::get_enabled_plugins() returns the correct list of enabled plugins.
      */
     /**
      * Data provider for the get_sorted_plugins tests.
+     *
      * @return array
      */
-    public function get_sorted_plugins_provider(): array {
+    public static function get_sorted_plugins_provider(): array {
         $pluginmanager = \core_plugin_manager::instance();
         $allplugins = array_keys($pluginmanager->get_plugins_of_type('editor'));
         // Disabled editors are listed alphabetically at the end.
+     *
      * @dataProvider change_plugin_order_provider
      * @param string $texteditors
      * @param string $pluginname
      * @param int $direction
-     * @param array $neworder
+     * @param array $expected
      * @param string $newtexteditors
      */
     public function test_change_plugin_order(
         string $texteditors,
         string $pluginname,
         int $direction,
-        array $neworder,
+        array $expected,
         string $newtexteditors,
     ): void {
         global $CFG;
         $this->resetAfterTest(true);
         $CFG->texteditors = $texteditors;
         editor::change_plugin_order($pluginname, $direction);
         $this->assertSame(
-            $neworder,
+            $expected,
             array_keys(editor::get_sorted_plugins()),
         );
         $this->assertSame($newtexteditors, $CFG->texteditors);
+    }
     /**
      * Data provider fro the change_plugin_order() tests.
      *
      * @return array
      */
-    public function change_plugin_order_provider(): array {
+    public static function change_plugin_order_provider(): array {
         $pluginmanager = \core_plugin_manager::instance();
             ],
+            [
                 'texteditors' => 'textarea,tiny',
                 'pluginname' => 'atto',
                 'direction' => base::MOVE_DOWN,
-                // Atto is not enabled. No change expected.
+                // Atto is not available. No change expected.
                 'expected' => $getorder([
                     'textarea',
                     'tiny',
                 ]),
                 'newtexteditors' => 'textarea,tiny',
             ],
+            [
                 'texteditors' => 'textarea,tiny',
                 'pluginname' => 'atto',
                 'direction' => base::MOVE_UP,
-                // Atto is not enabled. No change expected.
+                // Atto is not available. No change expected.
-                'expected' => $getorder([
-                    'textarea',
-                    'tiny',
-                ]),
-                'newtexteditors' => 'textarea,tiny',
-            ],
-            [
-                'texteditors' => 'textarea,tiny',
-                'pluginname' => 'atto',
-                'direction' => base::MOVE_UP,
-                // Atto is not enabled. No change expected.
                 'expected' => $getorder([
                     'textarea',
                     'tiny',
                 ]),
                 'newtexteditors' => 'textarea,tiny',

Proyectos de Subversion Moodle

(root)/lib/tests/plugininfo/editor_test.php – Rev 1 → 1441