WebSVN – Moodle – Diff – /lib/tests/accesslib_test.php

 /**
  * Functional test for accesslib.php
+ *
  * Note: execution may take many minutes especially on slower servers.
  */
-class accesslib_test extends advanced_testcase {
+final class accesslib_test extends advanced_testcase {
     /**
      * Setup.
      */
         $user = $this->getDataGenerator()->create_and_enrol($course);
         $this->setup_fake_plugin('access');
         // For now we have deprecated fake/access:fakecapability.
+        $capinfo = get_deprecated_capability_info('fake/access:fakecapability');
-        $capinfo = get_deprecated_capability_info('fake/access:fakecapability');
+        $this->assertNotNull(get_capability_info('fake/access:existingcapability'));
         $this->assertNotEmpty($capinfo);
         $this->assertEquals("The capability 'fake/access:fakecapability' is"
             . " deprecated.This capability should not be used anymore.", $capinfo['fullmessage']);
     /**
      * Specific use case for deprecated capabilities
+     *
      * @return array
      */
-    public function deprecated_capabilities_use_cases() {
+    public static function deprecated_capabilities_use_cases(): array {
         return [
             'capability missing' => [
                 'fake/access:missingcapability',
+                [
                     "Capability \"fake/access:missingcapability\" was not found! This has to be fixed in code."
             ],
         ];
+    }
+    /**
+     * Test get_deprecated_capability_info() with an invalid component.
+     *
+     * @covers get_deprecated_capability_info
+     */
+    public function test_get_deprecated_capability_info_invalid_component(): void {
+        global $DB;
+        $this->resetAfterTest();
+        // Set up a fake plugin.
+        $this->setup_fake_plugin('access');
+        // Add a plugin for an unrelated fake component.
+        $DB->insert_record('capabilities', [
+            'name' => 'mod/fake:addinstance',
+            'captype' => 'write',
+            'contextlevel' => CONTEXT_COURSE,
+            'component' => 'mod_fake',
+            'riskbitmask' => 4,
+        ]);
+        // Purge the cache.
+        cache::make('core', 'capabilities')->purge();
+        // For now we have deprecated fake/access:fakecapability.
+        $this->assertNotEmpty($DB->get_record('capabilities', ['component' => 'mod_fake']));
+        $info = get_deprecated_capability_info('fake/access:fakecapability');
+        $this->assertIsArray($info);
+        $this->assertDebuggingNotCalled();
+    }
     /**
      * Test that assigning a fake cap does not return.
+     *
      * @covers ::get_users_by_capability
      * @covers ::get_with_capability_join
         role_assign($teacherrole->id, $teacher->id, $coursecontext);
         $admin = $DB->get_record('user', array('username' => 'admin'));
         $this->expectException('coding_exception');
         $this->expectExceptionMessage("Capability '{$capability}' was not found! This has to be fixed in code.");
-        unassign_capability($capability, CAP_ALLOW, $teacherrole->id, $coursecontext);
+        unassign_capability($capability, $teacherrole->id, $coursecontext);
+    }
     /**
         $this->assertCount(1, $user4groupusers);
         $this->assertArrayHasKey($user1->id, $user4groupusers);
         $this->assertEquals(1, count_enrolled_users($coursecontext, '', $groupids));
+    }
-    public function get_enrolled_sql_provider() {
+    public static function get_enrolled_sql_provider(): array {
         return array(
             array(
                 // Two users who are enrolled.
                 'users' => array(
         assign_capability('moodle/site:accessallgroups', CAP_INHERIT, $allroles['teacher'], $frontpagecontext);
         $rc = $DB->get_record('role_capabilities', array('contextid'=>$frontpagecontext->id, 'roleid'=>$allroles['teacher'], 'capability'=>'moodle/site:accessallgroups'));
         $this->assertFalse($rc);
         assign_capability('moodle/site:accessallgroups', CAP_ALLOW, $allroles['teacher'], $frontpagecontext);
-        unassign_capability('moodle/site:accessallgroups', $allroles['teacher'], $frontpagecontext, true);
+        unassign_capability('moodle/site:accessallgroups', $allroles['teacher'], $frontpagecontext);
         $rc = $DB->get_record('role_capabilities', array('contextid'=>$frontpagecontext->id, 'roleid'=>$allroles['teacher'], 'capability'=>'moodle/site:accessallgroups'));
         $this->assertFalse($rc);
-        unassign_capability('moodle/site:accessallgroups', $allroles['teacher'], $frontpagecontext->id, true);
+        unassign_capability('moodle/site:accessallgroups', $allroles['teacher'], $frontpagecontext->id);
         unset($rc);
             $this->assertEquals($prevsize, context_inspection::check_context_cache_size());
+        }
         context_user::instance($testusers[102]);
         $this->assertEquals($prevsize + 1, context_inspection::check_context_cache_size());
         unset($testusers);
-        // Test basic test of legacy functions.
-        // Note: watch out, the fake site might be pretty borked already.
-        $this->assertEquals(get_system_context(), context_system::instance());
-        $this->assertDebuggingCalled('get_system_context() is deprecated, please use context_system::instance() instead.', DEBUG_DEVELOPER);
-        foreach ($DB->get_records('context') as $contextid => $record) {
-            $context = context::instance_by_id($contextid);
-            $this->assertEquals($context, get_context_instance($record->contextlevel, $record->instanceid));
-            $this->assertDebuggingCalled('get_context_instance() is deprecated, please use context_xxxx::instance() instead.', DEBUG_DEVELOPER);
-        }
-        // Make sure a debugging is thrown.
-        get_context_instance($record->contextlevel, $record->instanceid);
-        $this->assertDebuggingCalled('get_context_instance() is deprecated, please use context_xxxx::instance() instead.', DEBUG_DEVELOPER);
-        get_system_context();
-        $this->assertDebuggingCalled('get_system_context() is deprecated, please use context_system::instance() instead.', DEBUG_DEVELOPER);
+    }
     /**
      * Helper that verifies a list of capabilities, as returned by
     public function test_context_module_caps_returned_by_get_capabilities_in_sys_context(): void {
         $actual = context_system::instance()->get_capabilities();
         // Just test a few representative capabilities.
         $expectedcapabilities = ['moodle/site:accessallgroups', 'moodle/site:viewfullnames',
-                'repository/upload:view', 'atto/recordrtc:recordaudio'];
+                'repository/upload:view', 'tiny/recordrtc:recordaudio'];
         $this->assert_capability_list_contains($expectedcapabilities, $actual);
         $actual = context_coursecat::instance($cat->id)->get_capabilities();
         // Just test a few representative capabilities.
         $expectedcapabilities = ['moodle/site:accessallgroups', 'moodle/site:viewfullnames',
-                'repository/upload:view', 'atto/recordrtc:recordaudio'];
+                'repository/upload:view', 'tiny/recordrtc:recordaudio'];
         $actual = context_course::instance($course->id)->get_capabilities();
         // Just test a few representative capabilities.
         $expectedcapabilities = ['moodle/site:accessallgroups', 'moodle/site:viewfullnames',
-                'repository/upload:view', 'atto/recordrtc:recordaudio'];
+                'repository/upload:view', 'tiny/recordrtc:recordaudio'];
         $actual = context_module::instance($page->cmid)->get_capabilities();
         // Just test a few representative capabilities.
         $expectedcapabilities = ['moodle/site:accessallgroups', 'moodle/site:viewfullnames',
-                'repository/upload:view', 'atto/recordrtc:recordaudio'];
+                'repository/upload:view', 'tiny/recordrtc:recordaudio'];
+        }
         $this->assertEquals($perms1, $perms2);
+    }
-    /**
-     * Checks install performance in update_capabilities.
-     *
-     * @covers ::update_capabilities()
-     */
-    public function test_update_capabilities_install_performance(): void {
-        global $DB;
-        $this->resetAfterTest();
-        // Get rid of all the capabilities for forum.
-        $testmodule = 'forum';
-        $DB->delete_records_select('capabilities', 'name LIKE ?', ['mod/' . $testmodule . ':%']);
-        $beforeq = $DB->perf_get_queries();
-        update_capabilities('mod_' . $testmodule);
-        $afterq = $DB->perf_get_queries();
-        // In my testing there are currently 237 queries; there were 373 before a performance
-        // fix. This test confirms performance doesn't degrade to near the previous level.
-        $this->assertLessThan(300, $afterq - $beforeq);
-    }
-    /**
-     * Checks install performance in update_capabilities when a new capability is cloned.
-     *
-     * This only has impact if there are a significant number of overrides of the existing
-     * capability.
-     *
-     * @covers ::update_capabilities()
-     */
-    public function test_update_capabilities_clone_performance(): void {
-        global $DB;
-        $this->resetAfterTest();
-        // Create a bunch of activities in a course. In each one, override so manager doesn't have
-        // moodle/course:manageactivities.
-        $generator = $this->getDataGenerator();
-        $course = $generator->create_course();
-        $roleid = $DB->get_field('role', 'id', ['shortname' => 'manager']);
-        for ($i = 0; $i < 100; $i++) {
-            $page = $generator->create_module('page', ['course' => $course->id]);
-            $contextid = context_module::instance($page->cmid)->id;
-            assign_capability('moodle/course:manageactivities', CAP_PREVENT, $roleid, $contextid);
-        }
-        // Get rid of one of the capabilities for forum, which clones moodle/course:manageactivities.
-        $DB->delete_records('capabilities', ['name' => 'mod/forum:addinstance']);
-        // Clear the context cache to simulate a realistic situation where we don't already have
-        // all those contexts in the cache.
-        accesslib_clear_all_caches_for_unit_testing();
-        $beforeq = $DB->perf_get_queries();
-        update_capabilities('mod_forum');
-        $afterq = $DB->perf_get_queries();
-        // In my testing there are currently 214 queries after performance was improved for cloning,
-        // compared to 414 before. This test confirms performance doesn't degrade to near the
-        // previous level.
-        $this->assertLessThan(300, $afterq - $beforeq);
-    }
     /**
      * Tests update_capabilities when a capability is cloned, but there are existing settings
      * for that capability.
+     *
      * Under normal circumstances this shouldn't happen as it is only used for new capabilities,
      * that they are capabilities which the Student roles has by default, but the
      * authenticated suser role does not.
+     *
      * @return array
      */
-    public function get_get_with_capability_join_override_cases() {
+    public static function get_get_with_capability_join_override_cases(): array {
         return [
                 'no overrides' => [true, []],
                 'one override' => [true, ['moodle/course:viewscales']],
                 'both overrides' => [false, ['moodle/course:viewscales', 'moodle/question:flag']],
         ];
     /**
      * Data provider for is_parent_of context checks.
+     *
      * @return  array
      */
-    public function is_parent_of_provider(): array {
+    public static function is_parent_of_provider(): array {
         $provideboth = function(string $desc, string $contextpath, string $testpath, bool $expected): array {
             return [
                 "includeself: true; {$desc}" => [
                     $contextpath,
                     $testpath,
     /**
      * Data provider for is_child_of context checks.
+     *
      * @return  array
      */
-    public function is_child_of_provider(): array {
+    public static function is_child_of_provider(): array {
         $provideboth = function(string $desc, string $contextpath, string $testpath, bool $expected): array {
             return [
                 "includeself: true; {$desc}" => [
                     $contextpath,
                     $testpath,
+    }
     /**
      * Test get_navigation_filter_context.
      *
-     * @covers ::get_navigation_filter_context
+     * @covers \core\context_helper::get_navigation_filter_context
      */
     public function test_get_navigation_filter_context(): void {
         $this->resetAfterTest();
         $course = $this->getDataGenerator()->create_course();
         $filtercontext = context_helper::get_navigation_filter_context(null);
         $this->assertInstanceOf('\context_system', $filtercontext);
         $filtercontext = context_helper::get_navigation_filter_context($coursecontext);
         $this->assertInstanceOf('\context_system', $filtercontext);
+    }
+    /**
+     * Test access APIs when dealing with deprecated plugin types.
+     *
+     * Note: this injects a mocked plugin type into core_component and is a slow test that must be run in isolation.
+     *
+     * @covers ::has_capability
+     * @runInSeparateProcess
+     */
+    public function test_capabilities_deprecated_plugintype(): void {
+        $this->resetAfterTest();
+        global $CFG;
+        $this->add_mocked_plugintype('fake', "{$CFG->dirroot}/lib/tests/fixtures/fakeplugins/fake", true);
+        $this->add_mocked_plugin('fake', 'fullfeatured', "{$CFG->dirroot}/lib/tests/fixtures/fakeplugins/fake/fullfeatured");
+        update_capabilities('fake_fullfeatured');
+        $this->assertTrue(\core_component::is_deprecated_plugin_type('fake'));
+        $user = $this->getDataGenerator()->create_user();
+        $this->assertNotEmpty(get_capability_info('fake/fullfeatured:fakecapability'));
+        $this->assertTrue(has_capability('fake/fullfeatured:fakecapability', \core\context\system::instance(), $user));
+        $this->assertEquals('Fullfeatured capability description', get_capability_string('fake/fullfeatured:fakecapability'));
+    }
+    /**
+     * Test get_deprecated_capability_info() debugging messages.
+     *
+     * @covers ::get_deprecated_capability_info
+     */
+    public function test_get_deprecated_capability_info_debugging(): void {
+        $this->resetAfterTest();
+        $course = $this->getDataGenerator()->create_course();
+        $this->getDataGenerator()->create_and_enrol($course);
+        $this->setup_fake_plugin('access');
+        // Debugging messages should not be called with valid capability.
+        get_capability_info('fake/access:existingcapability');
+        $this->assertDebuggingNotCalled();
+        // Debugging messages should be called with invalid capability.
+        get_capability_info('fake/access:fakecapability');
+        $this->assertDebuggingCalled("The capability 'fake/access:fakecapability' is"
+            . " deprecated.This capability should not be used anymore.");
+        // Debugging messages should not be called with invalid capability with suppression param supplied.
+        get_capability_info('fake/access:fakecapability', false);
+        $this->assertDebuggingNotCalled();
+    }
+}
 /**
  * Context caching fixture

Proyectos de Subversion Moodle

(root)/lib/tests/accesslib_test.php – Rev 11 → 1441