WebSVN – Moodle – Diff – /lib/accesslib.php

  * Unassign a capability from a role.
+ *
  * @param string $capability the name of the capability
  * @param int $roleid the role id
  * @param int|context $contextid null means all contexts
+ * @param bool $showdebug if true, will show debugging messages
  * @return boolean true or exception
  */
-function unassign_capability($capability, $roleid, $contextid = null) {
+function unassign_capability($capability, $roleid, $contextid = null, bool $showdebug = true) {
     global $DB, $USER;
     // Capability must exist.
-    if (!$capinfo = get_capability_info($capability)) {
+    if (!get_capability_info($capability, $showdebug)) {
         throw new coding_exception("Capability '{$capability}' was not found! This has to be fixed in code.");
+    }
                         array_key_exists($cachedcap->name, $newcapdef) === false) {
                 // Delete from roles.
                 if ($roles = get_roles_with_capability($cachedcap->name)) {
+                    foreach ($roles as $role) {
-                    foreach ($roles as $role) {
+                        if (!unassign_capability(
+                            capability: $cachedcap->name,
+                            roleid: $role->id,
+                            showdebug: false, // Suppress debugging messages in the get_capability_info().
-                        if (!unassign_capability($cachedcap->name, $role->id)) {
+                        )) {
                             throw new \moodle_exception('cannotunassigncap', 'error', '',
                                 (object)array('cap' => $cachedcap->name, 'role' => $role->name));
+                        }
+                    }
+}
 /**
  * Returns capability information (cached)
  *
+ * @param string $capabilityname the capability name.
- * @param string $capabilityname
+ * @param bool $showdebug if true, will show debugging messages.
  * @return ?stdClass object or null if capability not found
  */
-function get_capability_info($capabilityname) {
+function get_capability_info(string $capabilityname, bool $showdebug = true): ?stdClass {
     $caps = get_all_capabilities();
     // Check for deprecated capability.
     if ($deprecatedinfo = get_deprecated_capability_info($capabilityname)) {
         if (!empty($deprecatedinfo['replacement'])) {
             // Let's try again with this capability if it exists.
             if (isset($caps[$deprecatedinfo['replacement']])) {
+                $capabilityname = $deprecatedinfo['replacement'];
-                $capabilityname = $deprecatedinfo['replacement'];
+            } else {
-            } else {
+                if ($showdebug) {
+                    debugging("Capability '{$capabilityname}' was supposed to be replaced with ".
-                debugging("Capability '{$capabilityname}' was supposed to be replaced with ".
+                        "'{$deprecatedinfo['replacement']}', which does not exist !");
                     "'{$deprecatedinfo['replacement']}', which does not exist !");
+            }
+        }
-            }
-        }
+        if ($showdebug) {
+            $fullmessage = $deprecatedinfo['fullmessage'];
-        $fullmessage = $deprecatedinfo['fullmessage'];
+            debugging($fullmessage, DEBUG_DEVELOPER);
         debugging($fullmessage, DEBUG_DEVELOPER);
+    }
     if (!isset($caps[$capabilityname])) {
         $components = [];
         $alldeprecatedcaps = [];
         foreach ($allcaps as $cap) {
             if (!in_array($cap['component'], $components)) {
                 $components[] = $cap['component'];
-                $defpath = core_component::get_component_directory($cap['component']).'/db/access.php';
+                $componentdir = core_component::get_component_directory($cap['component']);
+                if ($componentdir === null) {
+                    continue;
+                }
+                $defpath = "{$componentdir}/db/access.php";
                 if (file_exists($defpath)) {
                     $deprecatedcapabilities = [];
                     require($defpath);
                     if (!empty($deprecatedcapabilities)) {
                         foreach ($deprecatedcapabilities as $cname => $cdef) {
  *       use role_get_names() if you need role names.
+ *
  * @param context $context optional context for course role name aliases
  * @return array of role records with optional coursealias property
  */
-function get_all_roles(context $context = null) {
+function get_all_roles(?context $context = null) {
     global $DB;
     if (!$context or !$coursecontext = $context->get_course_context(false)) {
         $coursecontext = null;
     if (!isset($USER->access)) {
         load_all_capabilities();
-    }
-    // Make sure that course index is refreshed.
-    if ($coursecontext = $context->get_course_context()) {
-        core_courseformat\base::session_cache_reset(get_course($coursecontext->instanceid));
+    }
     // Add the switch RA
     if ($roleid == 0) {
         unset($USER->access['rsw'][$context->path]);
         return true;
+    }
+    $USER->access['rsw'][$context->path] = $roleid;
+    // Dispatch the hook for post user switch.
+    $hook = new \core\hook\access\after_role_switched(
             context: $context,
             roleid: $roleid
-    $USER->access['rsw'][$context->path] = $roleid;
+        );
     \core\di::get(\core\hook\manager::class)->dispatch($hook);
  * @param array of role objects with a ->localname field containing the context-specific role name.
  * @param int $rolenamedisplay
  * @param bool $returnmenu true means id=>localname, false means id=>rolerecord
  * @return array Array of context-specific role names, or role objects with a ->localname field added.
  */
-function role_get_names(context $context = null, $rolenamedisplay = ROLENAME_ALIAS, $returnmenu = null) {
+function role_get_names(?context $context = null, $rolenamedisplay = ROLENAME_ALIAS, $returnmenu = null) {
     return role_fix_names(get_all_roles($context), $context, $rolenamedisplay, $returnmenu);
+}
 /**
  * @param context $context the context, null means system context
  * @param int $rolenamedisplay
  * @param bool $returnmenu null means keep the same format as $roleoptions, true means id=>localname, false means id=>rolerecord
  * @return array Array of context-specific role names, or role objects with a ->localname field added.
  */
-function role_fix_names($roleoptions, context $context = null, $rolenamedisplay = ROLENAME_ALIAS, $returnmenu = null) {
+function role_fix_names($roleoptions, ?context $context = null, $rolenamedisplay = ROLENAME_ALIAS, $returnmenu = null) {
     global $DB;
     if (empty($roleoptions)) {
         return array();

Proyectos de Subversion Moodle

(root)/lib/accesslib.php – Rev 11 → 1441