WebSVN – Moodle – Diff – /enrol/manual/lib.php

         $icons = array();
         if (has_capability('enrol/manual:enrol', $context) or has_capability('enrol/manual:unenrol', $context)) {
             $managelink = new moodle_url("/enrol/manual/manage.php", array('enrolid'=>$instance->id));
             $icons[] = $OUTPUT->action_icon($managelink, new pix_icon('t/enrolusers', get_string('enrolusers', 'enrol_manual'), 'core', array('class'=>'iconsmall')));
+        }
+        if (has_any_capability(['enrol/manual:config', 'moodle/course:editcoursewelcomemessage'], $context)) {
+            $linkparams = [
+                'courseid' => $instance->courseid,
+                'id' => $instance->id,
+                'type' => $instance->enrol,
+            ];
-        $parenticons = parent::get_action_icons($instance);
+            $editlink = new moodle_url('/enrol/editinstance.php', $linkparams);
+            $icon = new pix_icon('t/edit', get_string('edit'), 'core', ['class' => 'iconsmall']);
-        $icons = array_merge($icons, $parenticons);
+            $icons[] = $OUTPUT->action_icon($editlink, $icon);
+        }
         return $icons;
+    }
      * Add new instance of enrol plugin.
      * @param stdClass $course
      * @param array instance fields
      * @return int id of new instance, null if can not be created
      */
-    public function add_instance($course, array $fields = NULL) {
+    public function add_instance($course, ?array $fields = NULL) {
         global $DB;
         if ($DB->record_exists('enrol', array('courseid'=>$course->id, 'enrol'=>'manual'))) {
             // only one instance allowed, sorry
                     $this->delete_instance($anotherinstance);
+                }
+            }
+        }
+        // This method is used when configuring the enrolment method, and when only updating the welcome message.
+        // The 'expirynotify' property won't be set when updating the welcome message.
+        if (isset($data->expirynotify)) {
+            $data->notifyall = $data->expirynotify == 2 ? 1 : 0;
         $data->notifyall = $data->expirynotify == 2 ? 1 : 0;
         return parent::update_instance($instance, $data);
      * @param context $context
      * @return bool
      */
     public function edit_instance_form($instance, MoodleQuickForm $mform, $context) {
+        // Main fields.
+        if (has_capability('enrol/manual:config', $context)) {
-        $options = $this->get_status_options();
+            $options = $this->get_status_options();
-        $mform->addElement('select', 'status', get_string('status', 'enrol_manual'), $options);
+            $mform->addElement('select', 'status', get_string('status', 'enrol_manual'), $options);
-        $mform->addHelpButton('status', 'status', 'enrol_manual');
+            $mform->addHelpButton('status', 'status', 'enrol_manual');
-        $mform->setDefault('status', $this->get_config('status'));
+            $mform->setDefault('status', $this->get_config('status'));
-        $roles = $this->get_roleid_options($instance, $context);
+            $roles = $this->get_roleid_options($instance, $context);
-        $mform->addElement('select', 'roleid', get_string('defaultrole', 'role'), $roles);
+            $mform->addElement('select', 'roleid', get_string('defaultrole', 'role'), $roles);
-        $mform->setDefault('roleid', $this->get_config('roleid'));
+            $mform->setDefault('roleid', $this->get_config('roleid'));
-        $options = array('optional' => true, 'defaultunit' => 86400);
+            $options = ['optional' => true, 'defaultunit' => 86400];
-        $mform->addElement('duration', 'enrolperiod', get_string('defaultperiod', 'enrol_manual'), $options);
+            $mform->addElement('duration', 'enrolperiod', get_string('defaultperiod', 'enrol_manual'), $options);
-        $mform->setDefault('enrolperiod', $this->get_config('enrolperiod'));
+            $mform->setDefault('enrolperiod', $this->get_config('enrolperiod'));
-        $mform->addHelpButton('enrolperiod', 'defaultperiod', 'enrol_manual');
+            $mform->addHelpButton('enrolperiod', 'defaultperiod', 'enrol_manual');
-        $options = $this->get_expirynotify_options();
+            $options = $this->get_expirynotify_options();
-        $mform->addElement('select', 'expirynotify', get_string('expirynotify', 'core_enrol'), $options);
+            $mform->addElement('select', 'expirynotify', get_string('expirynotify', 'core_enrol'), $options);
-        $mform->addHelpButton('expirynotify', 'expirynotify', 'core_enrol');
+            $mform->addHelpButton('expirynotify', 'expirynotify', 'core_enrol');
-        $options = array('optional' => false, 'defaultunit' => 86400);
+            $options = ['optional' => false, 'defaultunit' => 86400];
-        $mform->addElement('duration', 'expirythreshold', get_string('expirythreshold', 'core_enrol'), $options);
+            $mform->addElement('duration', 'expirythreshold', get_string('expirythreshold', 'core_enrol'), $options);
-        $mform->addHelpButton('expirythreshold', 'expirythreshold', 'core_enrol');
+            $mform->addHelpButton('expirythreshold', 'expirythreshold', 'core_enrol');
+            $mform->disabledIf('expirythreshold', 'expirynotify', 'eq', 0);
         $mform->disabledIf('expirythreshold', 'expirynotify', 'eq', 0);
+        // Course welcome message.
-        // Course welcome message.
+        if (has_any_capability(['enrol/manual:config', 'moodle/course:editcoursewelcomemessage'], $context)) {
-        $mform->addElement(
+            $mform->addElement(
-            'select',
+                'select',
+                'customint1',
+                get_string(
+                    identifier: 'sendcoursewelcomemessage',
+                    component: 'core_enrol',
+                ),
+                enrol_send_welcome_email_options(),
+            );
-            'customint1',
+            $mform->addHelpButton(
-            get_string(
+                elementname: 'customint1',
                 identifier: 'sendcoursewelcomemessage',
-                component: 'core_enrol',
-            ),
-            enrol_send_welcome_email_options(),
-        );
-        $mform->addHelpButton(
-            elementname: 'customint1',
-            identifier: 'sendcoursewelcomemessage',
-            component: 'core_enrol',
-        );
-        $options = [
-            'cols' => '60',
-            'rows' => '8',
-        ];
-        $mform->addElement(
-            'textarea',
-            'customtext1',
-            get_string(
-                identifier: 'customwelcomemessage',
-                component: 'core_enrol',
-            ),
-            $options,
-        );
-        $mform->setDefault('customtext1', get_string('customwelcomemessageplaceholder', 'core_enrol'));
-        $mform->hideIf(
-            elementname: 'customtext1',
-            dependenton: 'customint1',
-            condition: 'eq',
+                component: 'core_enrol',
+            );
+            $options = [
+                'cols' => '60',
+                'rows' => '8',
+            ];
+            $mform->addElement(
+                'textarea',
+                'customtext1',
+                get_string(
+                    identifier: 'customwelcomemessage',
+                    component: 'core_enrol',
+                ),
+                $options,
+            );
+            $mform->setDefault('customtext1', get_string('customwelcomemessageplaceholder', 'core_enrol'));
+            $mform->hideIf(
+                elementname: 'customtext1',
+                dependenton: 'customint1',
+                condition: 'eq',
-            value: ENROL_DO_NOT_SEND_EMAIL,
+                value: ENROL_DO_NOT_SEND_EMAIL,
-        );
+            );
-        // Static form elements cannot be hidden by hideIf() so we need to add a dummy group.
+            // Static form elements cannot be hidden by hideIf() so we need to add a dummy group.
-        // See: https://tracker.moodle.org/browse/MDL-66251.
+            // See: https://tracker.moodle.org/browse/MDL-66251.
-        $group[] = $mform->createElement(
+            $group[] = $mform->createElement(
-            'static',
+                'static',
-            'customwelcomemessage_extra_help',
+                'customwelcomemessage_extra_help',
-            null,
+                null,
-            get_string(
+                get_string(
-                identifier: 'customwelcomemessage_help',
+                    identifier: 'customwelcomemessage_help',
-                component: 'core_enrol',
+                    component: 'core_enrol',
-            ),
+                ),
-        );
+            );
-        $mform->addGroup($group, 'group_customwelcomemessage_extra_help', '', ' ', false);
+            $mform->addGroup($group, 'group_customwelcomemessage_extra_help', '', ' ', false);
-        $mform->hideIf(
+            $mform->hideIf(
-            elementname: 'group_customwelcomemessage_extra_help',
+                elementname: 'group_customwelcomemessage_extra_help',
+                dependenton: 'customint1',
-            dependenton: 'customint1',
+                condition: 'eq',
+                value: ENROL_DO_NOT_SEND_EMAIL,
-            condition: 'eq',
+            );
             value: ENROL_DO_NOT_SEND_EMAIL,
         );
         // Enrolment changes warning.
-        if (enrol_accessing_via_instance($instance)) {
+        if (has_capability('enrol/manual:config', $context) && enrol_accessing_via_instance($instance)) {
      * @return void
      */
     public function edit_instance_validation($data, $files, $instance, $context) {
         $errors = array();
+        // This method is used when configuring the enrolment method, and when only updating the welcome message.
+        // The 'expirynotify' key won't be set when updating the welcome message.
-        if ($data['expirynotify'] > 0 and $data['expirythreshold'] < 86400) {
+        if (isset($data['expirynotify']) && $data['expirynotify'] > 0 && $data['expirythreshold'] < DAYSECS) {
             $errors['expirythreshold'] = get_string('errorthresholdlow', 'core_enrol');
+        }

Proyectos de Subversion Moodle

(root)/enrol/manual/lib.php – Rev 1 → 1441