WebSVN – Moodle – Diff – /customfield/tests/field_controller_test.php

+ *
  * @package    core_customfield
  * @category   test
  * @copyright  2018 Ruslan Kabalin
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ * @covers \core_customfield\field_controller
  */
-class field_controller_test extends \advanced_testcase {
+final class field_controller_test extends \advanced_testcase {
     /**
      * Get generator.
+     *
      * @return core_customfield_generator
      */
         // Retrieve fields by id.
         $this->assertInstanceOf(customfield_checkbox\field_controller::class, field_controller::create($field0->get('id')));
         $this->assertInstanceOf(customfield_date\field_controller::class, field_controller::create($field1->get('id')));
+        // Retrieve field by id and category.
-        // Retrieve field by id and category.
+        $this->assertInstanceOf(
-        $this->assertInstanceOf(customfield_select\field_controller::class,
+            customfield_select\field_controller::class,
+            field_controller::create($field2->get('id'), null, $category0)
-            field_controller::create($field2->get('id'), null, $category0));
+        );
         // Retrieve fields by record without category.
         $fieldrecord = $DB->get_record(\core_customfield\field::TABLE, ['id' => $field3->get('id')], '*', MUST_EXIST);
         $this->assertInstanceOf(customfield_text\field_controller::class, field_controller::create(0, $fieldrecord));
+        // Retrieve fields by record with category.
-        // Retrieve fields by record with category.
+        $fieldrecord = $DB->get_record(\core_customfield\field::TABLE, ['id' => $field4->get('id')], '*', MUST_EXIST);
+        $this->assertInstanceOf(
+            customfield_textarea\field_controller::class,
+            field_controller::create(0, $fieldrecord, $category0)
+        );
+    }
+    /**
+     * Test creation of field instance from pre-defined object
+     */
+    public function test_constructor_from_record(): void {
+        $this->resetAfterTest();
+        // Create field object that matches the persistent/schema definition.
+        $category = $this->get_generator()->create_category();
+        $field = field_controller::create(0, (object) [
+            'name' => 'Test',
+            'shortname' => 'test',
+            'type' => 'text',
+            'description' => null,
+            'descriptionformat' => null,
+            'sortorder' => null,
+            'configdata' => null,
+        ], $category);
+        // Saving the field will validate the persistent internally.
-        $fieldrecord = $DB->get_record(\core_customfield\field::TABLE, ['id' => $field4->get('id')], '*', MUST_EXIST);
+        $field->save();
         $this->assertInstanceOf(customfield_textarea\field_controller::class,
-            field_controller::create(0, $fieldrecord, $category0));
+        $this->assertInstanceOf(\customfield_text\field_controller::class, $field);
+    }
         // Both id and record give warning.
         $field = field_controller::create($fieldrecord->id, $fieldrecord);
         $debugging = $this->getDebuggingMessages();
+        $this->assertEquals(1, count($debugging));
-        $this->assertEquals(1, count($debugging));
+        $this->assertEquals(
-        $this->assertEquals('Too many parameters, either id need to be specified or a record, but not both.',
+            'Too many parameters, either id need to be specified or a record, but not both.',
+            $debugging[0]->message
-            $debugging[0]->message);
+        );
         $this->resetDebugging();
         $this->assertInstanceOf(customfield_text\field_controller::class, $field);
         // Retrieve non-existing field.
         try {
             field_controller::create($fieldrecord->id + 1);
             $this->fail('Expected exception');
-        } catch (\moodle_exception $e) {
-            $this->assertEquals('Field not found', $e->getMessage());
+        } catch (\moodle_exception $e) {
-            $this->assertEquals(\moodle_exception::class, get_class($e));
+            $this->assertEquals('Field not found', $e->getMessage());
+        }
         // Retrieve without id and without type.
         try {
             field_controller::create(0, (object)['name' => 'a'], $category);
             $this->fail('Expected exception');
-        } catch (\coding_exception $e) {
-            $this->assertEquals('Coding error detected, it must be fixed by a programmer: Not enough parameters to ' .
+        } catch (\coding_exception $e) {
-                'initialise field_controller - unknown field type', $e->getMessage());
+            $this->assertEquals('Coding error detected, it must be fixed by a programmer: Not enough parameters to ' .
-            $this->assertEquals(\coding_exception::class, get_class($e));
+                'initialise field_controller - unknown field type', $e->getMessage());
+        }
         // Missing category id.
         try {
             field_controller::create(0, (object)['type' => 'text']);
-            $this->fail('Expected exception');
-        } catch (\coding_exception $e) {
+            $this->fail('Expected exception');
-            $this->assertEquals('Coding error detected, it must be fixed by a programmer: Not enough parameters ' .
+        } catch (\coding_exception $e) {
-                'to initialise field_controller - unknown category', $e->getMessage());
+            $this->assertEquals('Coding error detected, it must be fixed by a programmer: Not enough parameters ' .
-            $this->assertEquals(\coding_exception::class, get_class($e));
+                'to initialise field_controller - unknown category', $e->getMessage());
+        }
         // Mismatching category id.
         try {
-            field_controller::create(0, (object)['type' => 'text', 'categoryid' => $category->get('id') + 1], $category);
-            $this->fail('Expected exception');
+            field_controller::create(0, (object)['type' => 'text', 'categoryid' => $category->get('id') + 1], $category);
-        } catch (\coding_exception $e) {
+            $this->fail('Expected exception');
-            $this->assertEquals('Coding error detected, it must be fixed by a programmer: Category of the field ' .
+        } catch (\coding_exception $e) {
-                'does not match category from the parameter', $e->getMessage());
+            $this->assertEquals('Coding error detected, it must be fixed by a programmer: Category of the field ' .
-            $this->assertEquals(\coding_exception::class, get_class($e));
+                'does not match category from the parameter', $e->getMessage());
+        }
-        // Non-existing type.
-        try {
+        // Non-existing type.
-            field_controller::create(0, (object)['type' => 'nonexisting'], $category);
+        try {
-            $this->fail('Expected exception');
+            field_controller::create(0, (object)['type' => 'nonexisting'], $category);
-        } catch (\moodle_exception $e) {
+            $this->fail('Expected exception');
         $category = $lpg->create_category();
         $fields = $DB->get_records(\core_customfield\field::TABLE, ['categoryid' => $category->get('id')]);
         $this->assertCount(0, $fields);
         // Create field using generator.
-        $field1 = $lpg->create_field(array('categoryid' => $category->get('id')));
+        $field1 = $lpg->create_field(['categoryid' => $category->get('id')]);
-        $field2 = $lpg->create_field(array('categoryid' => $category->get('id')));
+        $field2 = $lpg->create_field(['categoryid' => $category->get('id')]);
         $fields = $DB->get_records(\core_customfield\field::TABLE, ['categoryid' => $category->get('id')]);
         $this->assertCount(2, $fields);

Proyectos de Subversion Moodle

(root)/customfield/tests/field_controller_test.php – Rev 11 → 1441