WebSVN – Moodle – Diff – /course/tests/courselib_test.php

  * @package    core_course
  * @category   test
  * @copyright  2012 Petr Skoda {@link http://skodak.org}
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class courselib_test extends advanced_testcase {
+final class courselib_test extends advanced_testcase {
     /**
      * Load required libraries and fixtures.
      */
     public static function setUpBeforeClass(): void {
         global $CFG;
+        require_once($CFG->dirroot . '/course/tests/fixtures/course_capability_assignment.php');
-        require_once($CFG->dirroot . '/course/tests/fixtures/course_capability_assignment.php');
+        require_once($CFG->dirroot . '/enrol/imsenterprise/tests/imsenterprise_test.php');
-        require_once($CFG->dirroot . '/enrol/imsenterprise/tests/imsenterprise_test.php');
+        parent::setUpBeforeClass();
+    }
     /**
      * Data provider for course_delete module
+     *
      * @return array An array of arrays contain test data
      */
-    public function provider_course_delete_module() {
+    public static function provider_course_delete_module(): array {
         $data = array();
         $data['assign'] = array('assign', array('duedate' => time()));
+    }
     /**
      * Relative dates mode settings provider for course creation.
      */
-    public function create_course_relative_dates_provider() {
+    public static function create_course_relative_dates_provider(): array {
         return [
             [0, 0, 0],
             [0, 1, 0],
             [1, 0, 0],
         // Trash modinfo.
         rebuild_course_cache($course->id, true);
+        // Create some cms for testing.
         $mods = $DB->get_records('modules');
-        // Create some cms for testing.
+        $mod = reset($mods);
         $cmids = array();
         for ($i=0; $i<4; $i++) {
-            $cmids[$i] = $DB->insert_record('course_modules', array('course' => $course->id));
+            $cmids[$i] = $DB->insert_record('course_modules', ['course' => $course->id, 'module' => $mod->id]);
         }
         // Add it to section that exists.
-        course_add_cm_to_section($course, $cmids[0], 1);
+        course_add_cm_to_section($course, $cmids[0], 1, null, $mod->name);
         // Check it got added to sequence.
         $sequence = $DB->get_field('course_sections', 'sequence', array('course' => $course->id, 'section' => 1));
         $this->assertEquals($cmids[0], $sequence);
         // Add a second, this time using courseid variant of parameters.
         $coursecacherev = $DB->get_field('course', 'cacherev', array('id' => $course->id));
-        course_add_cm_to_section($course->id, $cmids[1], 1);
+        course_add_cm_to_section($course->id, $cmids[1], 1, null, $mod->name);
         $sequence = $DB->get_field('course_sections', 'sequence', array('course' => $course->id, 'section' => 1));
         $this->assertEquals($cmids[0] . ',' . $cmids[1], $sequence);
         // Check that modinfo cache was reset but not rebuilt (important for performance if calling repeatedly).
         $newcacherev = $DB->get_field('course', 'cacherev', ['id' => $course->id]);
         $this->assertGreaterThan($coursecacherev, $newcacherev);
         $this->assertEmpty(cache::make('core', 'coursemodinfo')->get_versioned($course->id, $newcacherev));
         // Add one to section that doesn't exist (this might rebuild modinfo).
-        course_add_cm_to_section($course, $cmids[2], 2);
+        course_add_cm_to_section($course, $cmids[2], 2, null, $mod->name);
         $this->assertEquals(3, $DB->count_records('course_sections', array('course' => $course->id)));
         $sequence = $DB->get_field('course_sections', 'sequence', array('course' => $course->id, 'section' => 2));
+        $this->assertEquals($cmids[2], $sequence);
+        // Add using the 'before' option.
+        course_add_cm_to_section($course, $cmids[3], 2, $cmids[2], $mod->name);
+        $this->assertEquals(3, $DB->count_records('course_sections', array('course' => $course->id)));
+        $sequence = $DB->get_field('course_sections', 'sequence', array('course' => $course->id, 'section' => 2));
+        $this->assertEquals($cmids[3] . ',' . $cmids[2], $sequence);
+    }
+    /**
+     * Module types that have FEATURE_CAN_DISPLAY flag set to false cannot be in any section other than 0.
+     *
+     * @return void
+     * @covers ::course_add_cm_to_section()
+     */
+    public function test_add_non_display_types_to_cm_section(): void {
+        global $DB;
+        $this->resetAfterTest(true);
+        $generator = self::getDataGenerator();
+        // Create course with 1 section.
+        $course = self::getDataGenerator()->create_course(
+            [
+                'shortname' => 'GrowingCourse',
+                'fullname' => 'Growing Course',
+                'numsections' => 1,
+            ],
+            ['createsections' => true]
+        );
+        // Create the module and assert in section 0.
+        $sectionzero = $DB->get_record('course_sections', ['course' => $course->id, 'section' => 0], '*', MUST_EXIST);
+        $module = $generator->create_module('qbank', ['course' => $course, 'section' => $sectionzero->section]);
+        // Try to add to section 1.
+        $this->expectExceptionMessage("Modules with FEATURE_CAN_DISPLAY set to false can not be moved from section 0");
+        try {
-        $this->assertEquals($cmids[2], $sequence);
+            course_add_cm_to_section($course, $module->cmid, 1, null, 'qbank');
         } finally {
-        // Add using the 'before' option.
+            // Assert still in section 0.
-        course_add_cm_to_section($course, $cmids[3], 2, $cmids[2]);
+            $cm = $DB->get_record('course_modules', ['id' => $module->cmid]);
         $newsection = $DB->get_record('course_sections', array('id' => $newsection->id));
         $newsequences = explode(',', $newsection->sequence);
         $this->assertTrue(in_array($cm->id, $newsequences));
+    }
+    /**
+     * Ensure that qbank module which has feature flag FEATURE_CAN_DISPLAY set to false cannot be moved from section 0.
+     *
+     * @return void
+     * @covers ::moveto_module()
+     */
+    public function test_move_feature_cannot_display(): void {
+        $this->resetAfterTest(true);
+        // Setup fixture.
+        $course = $this->getDataGenerator()->create_course(['numsections' => 5], ['createsections' => true]);
+        $qbank = $this->getDataGenerator()->create_module('qbank', ['course' => $course->id]);
+        $qbankcms = get_fast_modinfo($course)->get_instances_of('qbank');
+        $qbankcm = reset($qbankcms);
+        // Check that mods with FEATURE_CAN_DISPLAY set to false cannot be moved from section 0.
+        $newsection = get_fast_modinfo($course)->get_section_info(3);
+        $codingerror = "/ .* Modules with FEATURE_CAN_DISPLAY set to false can not be moved from section 0/";
+        // Try to perform the move.
+        $this->expectExceptionMessageMatches($codingerror);
+        try {
+            moveto_module($qbankcm, $newsection);
+        } finally {
+            $qbankcms = get_fast_modinfo($course)->get_instances_of('qbank');
+            $qbankcm = reset($qbankcms);
+            $this->assertEquals(0, $qbankcm->sectionnum);
+        }
+    }
     public function test_module_visibility(): void {
         $this->setAdminUser();
         $this->resetAfterTest(true);
         delete_course($course);
         ob_end_clean();
         // Create the XML file we want to use.
+        $course->category = (array)$course->category;
+        // Note: this is a violation of component communication principles.
-        $course->category = (array)$course->category;
+        // TODO MDL-83789.
-        $imstestcase = new imsenterprise_test();
+        $imstestcase = new imsenterprise_test('courselib_imsenterprise_test');
         $imstestcase->imsplugin = enrol_get_plugin('imsenterprise');
         $imstestcase->set_test_config();
         $imstestcase->set_xml_file(false, array($course));
         $newoverrides = $DB->get_records('role_assignments', ['contextid' => $newcmcontext->id]);
         $this->assertEquals(count($overrides), count($newoverrides));
+    }
+    /**
+     * Ensure that modules with the feature flag FEATURE_CAN_DISPLAY set to false cannot be duplicated into a section other than 0.
+     * @covers ::duplicate_module()
+     */
+    public function test_duplicate_cannot_display_mods(): void {
+        self::setAdminUser();
+        $this->resetAfterTest();
+        $course = self::getDataGenerator()->create_course(['numsections' => 2], ['createsections' => true]);
+        $res = self::getDataGenerator()->create_module('qbank', ['course' => $course]);
+        $cm = get_coursemodule_from_id('qbank', $res->cmid, 0, false, MUST_EXIST);
+        $sectionid = get_fast_modinfo($course)->get_section_info(1)->id;
+        $this->expectExceptionMessage("Modules with FEATURE_CAN_DISPLAY set to false can not be moved from section 0");
+        duplicate_module($course, $cm, $sectionid);
+    }
     /**
      * Tests that when creating or updating a module, if the availability settings
      * are present but set to an empty tree, availability is set to null in
      * database.
      */
     /**
      * Provider for test_course_enddate.
+     *
      * @return array
      */
-    public function course_enddate_provider() {
+    public static function course_enddate_provider(): array {
         // Each provided example contains startdate, enddate and the expected exception error code if there is any.
         return [
+            [
 ,
 ,
     /**
      * Provider for test_course_dates_reset.
+     *
      * @return array
      */
-    public function course_dates_reset_provider() {
+    public static function course_dates_reset_provider(): array {
         // Each example contains the following:
         // - course startdate
         // - course enddate
                 $time + DAYSECS,
                 $time + WEEKSECS,
                 $time + YEARSECS,
                 $time + WEEKSECS,
                 $time + YEARSECS
-            ]
+            ],
+            // Time shift is between exact times, not midnight(s) (MDL-65233).
+            [
+                $time + HOURSECS,
+                $time + DAYSECS,
+                $time + WEEKSECS + HOURSECS,
+                false,
+                $time + WEEKSECS + HOURSECS,
+                $time + WEEKSECS + DAYSECS,
+            ],
         ];
+    }
     /**
+    }
     /**
      * Test cases for the course_classify_courses_for_timeline test.
      */
-    public function get_course_classify_courses_for_timeline_test_cases() {
+    public static function get_course_classify_courses_for_timeline_test_cases(): array {
         $now = time();
         $day = 86400;
+    }
     /**
      * Test the course_classify_courses_for_timeline function.
      *
-     * @dataProvider get_course_classify_courses_for_timeline_test_cases()
+     * @dataProvider get_course_classify_courses_for_timeline_test_cases
      * @param array $coursesdata Courses to create
      * @param array $expected Expected test results.
      */
     public function test_course_classify_courses_for_timeline($coursesdata, $expected): void {
+    }
     /**
      * Test cases for the course_get_enrolled_courses_for_logged_in_user tests.
      */
-    public function get_course_get_enrolled_courses_for_logged_in_user_test_cases() {
+    public static function get_course_get_enrolled_courses_for_logged_in_user_test_cases(): array {
         $buildexpectedresult = function($limit, $offset) {
             $result = [];
             for ($i = $offset; $i < $offset + $limit; $i++) {
                 $result[] = "testcourse{$i}";
+    }
     /**
      * Test the course_get_enrolled_courses_for_logged_in_user function.
      *
-     * @dataProvider get_course_get_enrolled_courses_for_logged_in_user_test_cases()
+     * @dataProvider get_course_get_enrolled_courses_for_logged_in_user_test_cases
      * @param int $dbquerylimit Number of records to load per DB request
      * @param int $totalcourses Number of courses to create
      * @param int $limit Maximum number of results to get.
      * @param int $offset Skip this number of results from the start of the result set.
+    }
     /**
      * Test cases for the course_filter_courses_by_timeline_classification tests.
      */
-    public function get_course_filter_courses_by_timeline_classification_test_cases() {
+    public static function get_course_filter_courses_by_timeline_classification_test_cases(): array {
         $now = time();
         $day = 86400;
+    }
     /**
      * Test the course_filter_courses_by_timeline_classification function.
      *
-     * @dataProvider get_course_filter_courses_by_timeline_classification_test_cases()
+     * @dataProvider get_course_filter_courses_by_timeline_classification_test_cases
      * @param array $coursedata Course test data to create.
      * @param string $classification Timeline classification.
      * @param int $limit Maximum number of results to return.
      * @param int $offset Results to skip at the start of the result set.
+    }
     /**
      * Test cases for the course_filter_courses_by_timeline_classification tests.
      */
-    public function get_course_filter_courses_by_customfield_test_cases() {
+    public static function get_course_filter_courses_by_customfield_test_cases(): array {
         global $CFG;
         require_once($CFG->dirroot.'/blocks/myoverview/lib.php');
         $coursedata = [
+            [
+    }
     /**
      * Test the course_filter_courses_by_customfield function.
      *
-     * @dataProvider get_course_filter_courses_by_customfield_test_cases()
+     * @dataProvider get_course_filter_courses_by_customfield_test_cases
      * @param array $coursedata Course test data to create.
      * @param string $customfield Shortname of the customfield.
      * @param string $customfieldvalue the value to filter by.
      * @param int $limit Maximum number of results to return.
+    }
     /**
      * Test cases for the course_filter_courses_by_timeline_classification w/ hidden courses tests.
      */
-    public function get_course_filter_courses_by_timeline_classification_hidden_courses_test_cases() {
+    public static function get_course_filter_courses_by_timeline_classification_hidden_courses_test_cases(): array {
         $now = time();
         $day = 86400;
+    }
     /**
      * Test the course_filter_courses_by_timeline_classification function hidden courses.
      *
-     * @dataProvider get_course_filter_courses_by_timeline_classification_hidden_courses_test_cases()
+     * @dataProvider get_course_filter_courses_by_timeline_classification_hidden_courses_test_cases
      * @param array $coursedata Course test data to create.
      * @param string $classification Timeline classification.
      * @param int $limit Maximum number of results to return.
      * @param int $offset Results to skip at the start of the result set.
     /**
      * Data provider for test_course_get_recent_courses_sort_validation().
+     *
      * @return array
      */
-    function course_get_recent_courses_sort_validation_provider() {
+    public static function course_get_recent_courses_sort_validation_provider(): array {
         return [
             'Invalid sort format (SQL injection attempt)' =>
+                [
                     'shortname DESC LIMIT 1--',
                     'Invalid structure of the sort parameter, allowed structure: fieldname [ASC|DESC].',
+    }
     /**
      * Test cases for the course_get_course_dates_for_user_ids tests.
      */
-    public function get_course_get_course_dates_for_user_ids_test_cases() {
+    public static function get_course_get_course_dates_for_user_ids_test_cases(): array {
         $now = time();
         $pastcoursestart = $now - 100;
         $futurecoursestart = $now + 100;
+    }
     /**
      * Test the course_get_course_dates_for_user_ids function.
      *
-     * @dataProvider get_course_get_course_dates_for_user_ids_test_cases()
+     * @dataProvider get_course_get_course_dates_for_user_ids_test_cases
      * @param bool $relativedatemode Set the course to relative dates mode
      * @param int $coursestart Course start date
      * @param int $usercount Number of users to create
      * @param array $enrolmentmethods Enrolment methods to set for the course
     /**
      * Data provider for test_course_modules_pending_deletion.
+     *
      * @return array An array of arrays contain test data
      */
-    public function provider_course_modules_pending_deletion() {
+    public static function provider_course_modules_pending_deletion(): array {
         return [
             'Non-gradable activity, check all'              => [['forum'], 0, false, true],
             'Gradable activity, check all'                  => [['assign'], 0, false, true],
             'Non-gradable activity, check gradables'        => [['forum'], 0, true, false],
             'Gradable activity, check gradables'            => [['assign'], 0, true, true],
         $this->assertInstanceOf('\core\event\section_viewed', $event);
         $this->assertEquals(context_course::instance($course->id), $event->get_context());
         $this->assertEquals('course_sections', $event->objecttable);
         $this->assertEquals($section->id, $event->objectid);
+    }
+    /**
+     * Tests get_sorted_course_formats returns plugins in cases where plugins are
+     * installed previously but no longer exist, or not installed yet.
+     *
+     * @covers ::get_sorted_course_formats()
+     */
+    public function test_get_sorted_course_formats_installed_or_not(): void {
+        global $DB;
+        $this->resetAfterTest();
+        // If there is an extra format installed that no longer exists, include in list (at end).
+        $DB->insert_record('config_plugins', [
+            'plugin' => 'format_frogs',
+            'name' => 'version',
+            'value' => '20240916',
+        ]);
+        \core\plugin_manager::reset_caches();
+        $formats = get_sorted_course_formats();
+        $this->assertContains('frogs', $formats);
+        // If one of the formats is not installed yet, we still return it.
+        $DB->delete_records('config_plugins', ['plugin' => 'format_weeks']);
+        \core\plugin_manager::reset_caches();
+        $formats = get_sorted_course_formats();
+        $this->assertContains('weeks', $formats);
+    }
+}

Proyectos de Subversion Moodle

(root)/course/tests/courselib_test.php – Rev 11 → 1441