WebSVN – Moodle – Diff – /course/modlib.php

         core_tag_tag::set_item_tags('core', 'course_modules', $moduleinfo->coursemodule, $modcontext, $moduleinfo->tags);
+    }
     // Course_modules and course_sections each contain a reference to each other.
     // So we have to update one of them twice.
+    $sectionid = course_add_cm_to_section(
+        $course,
+        $moduleinfo->coursemodule,
+        $moduleinfo->section,
+        $moduleinfo->beforemod,
+        $moduleinfo->modulename
-    $sectionid = course_add_cm_to_section($course, $moduleinfo->coursemodule, $moduleinfo->section, $moduleinfo->beforemod);
+    );
     // Trigger event based on the action we did.
     // Api create_from_cm expects modname and id property, and we don't want to modify $moduleinfo since we are returning it.
         // If regrading will be slow, and this is happening in response to front-end UI...
         if (!empty($moduleinfo->frontend) && grade_needs_regrade_progress_bar($course->id)) {
             // And if it actually needs regrading...
             $courseitem = grade_item::fetch_course_item($course->id);
             if ($courseitem->needsupdate) {
-                // Then don't do it as part of this form save, do it on an extra web request with a
-                // progress bar.
+                // Queue an asynchronous regrade.
-                $moduleinfo->needsfrontendregrade = true;
+                grade_regrade_final_grades($course->id, async: true);
+            }
         } else {
             // Regrade now.
-            grade_regrade_final_grades($course->id);
+            $result = grade_regrade_final_grades($course->id);
+            if (is_array($result)) {
+                foreach ($result as $error) {
+                    \core\notification::add($error, \core\output\notification::NOTIFY_ERROR);
+                }
+            }
+        }
+    }
     // Allow plugins to extend the course module form.
             $adhocktask->set_component('course');
             \core\task\manager::queue_adhoc_task($adhocktask, true);
+        }
+    }
+    if (plugin_supports('mod', $moduleinfo->modulename, FEATURE_USES_QUESTIONS) && empty($moduleinfo->skipdefaultcategory)) {
+        // Create the default question category.
+        question_get_default_category($modcontext->id, true);
+    }
     return $moduleinfo;
+}
     if (!isset($moduleinfo->downloadcontent)) {
         $moduleinfo->downloadcontent = DOWNLOAD_COURSE_CONTENT_ENABLED;
+    }
+    // Module types with this flag set to false must always be in section number 0.
+    if (!course_modinfo::is_mod_type_visible_on_course($moduleinfo->modulename)) {
+        $moduleinfo->section = 0;
+    }
     return $moduleinfo;
+}
+    }
     if (!empty($CFG->enableavailability)) {
         // This code is used both when submitting the form, which uses a long
         // name to avoid clashes, and by unit test code which uses the real
         // name in the table.
+        $newavailability = $cm->availability;
         if (property_exists($moduleinfo, 'availabilityconditionsjson')) {
             if ($moduleinfo->availabilityconditionsjson !== '') {
-                $cm->availability = $moduleinfo->availabilityconditionsjson;
+                $newavailability = $moduleinfo->availabilityconditionsjson;
             } else {
-                $cm->availability = null;
+                $newavailability = null;
+            }
         } else if (property_exists($moduleinfo, 'availability')) {
-            $cm->availability = $moduleinfo->availability;
+            $newavailability = $moduleinfo->availability;
+        }
+        if ($cm->availability != $newavailability) {
+            $cm->availability = $newavailability;
+        }
         // If there is any availability data, verify it.
         if ($cm->availability) {
             $tree = new \core_availability\tree(json_decode($cm->availability));
             // Save time and database space by setting null if the only data
  * @param  string $modulename  module name
  * @param  int $section section number
  * @param  string $suffix the suffix to add to the name of the completion rules.
  * @return array module information about other required data
  * @since  Moodle 3.2
+ * @throws coding_exception if you try to set a section other than 0 on a module type that has feature flag FEATURE_CAN_DISPLAY
+ * set to false.
  */
 function prepare_new_moduleinfo_data($course, $modulename, $section, string $suffix = '') {
     global $CFG;
+    // Module types with this flag set to false must always be in section number 0.
+    if ($section != 0 && !course_modinfo::is_mod_type_visible_on_course($modulename)) {
+        throw new coding_exception("Modules with feature flag FEATURE_CAN_DISPLAY set to false can only be in section 0");
+    }
     list($module, $context, $cw) = can_add_moduleinfo($course, $modulename, $section);
             $formfield = 'advancedgradingmethod_'.$areaname;
             $data->{$formfield} = '';
+        }
+    }
+    if (plugin_supports('mod', $data->modulename, FEATURE_QUICKCREATE)) {
+        if (get_string_manager()->string_exists('quickcreatename', "mod_{$data->modulename}")) {
+            $data->name = get_string("quickcreatename", "mod_{$data->modulename}");
+        }
+    }
     return array($module, $context, $cw, $cm, $data);

Proyectos de Subversion Moodle

(root)/course/modlib.php – Rev 1 → 1441