WebSVN – Moodle – Diff – /course/format/classes/stateactions.php

      * @param stateupdates $updates the affected course elements track
      * @param stdClass $course the course object
      * @param int[] $ids the list of affected course module ids
      * @param int $targetsectionid optional target section id
      * @param int $targetcmid optional target cm id
+     * @throws moodle_exception
      */
     public function cm_move(
         stateupdates $updates,
         stdClass $course,
         array $ids,
             // An updated $modinfo is needed on every loop as activities list change.
             $modinfo = get_fast_modinfo($course);
             $cm = $modinfo->get_cm($cmid);
             $currentsectionid = $cm->section;
             $targetsection = $modinfo->get_section_info_by_id($targetsectionid, MUST_EXIST);
+            if ($targetsection->is_delegated() && $cm->get_delegated_section_info()) {
+                throw new moodle_exception('subsectionmoveerror', 'core');
+            }
             $beforecm = (!empty($beforecmdid)) ? $modinfo->get_cm($beforecmdid) : null;
             if ($beforecm === null || $beforecm->id != $cmid) {
                 moveto_module($cm, $targetsection, $beforecm);
+            }
             $beforecmdid = $cm->id;
         usort($cmids, $sortfunction);
         return $cmids;
+    }
-    /**
-     * Move course sections to another location in the same course.
     /**
-     * @deprecated since Moodle 4.4 MDL-77038.
-     * @todo MDL-80116 This will be deleted in Moodle 4.8.
-     * @param stateupdates $updates the affected course elements track
-     * @param stdClass $course the course object
-     * @param int[] $ids the list of affected course module ids
-     * @param int $targetsectionid optional target section id
-     * @param int $targetcmid optional target cm id
+     * @deprecated since Moodle 4.4 MDL-77038.
+     */
+    #[\core\attribute\deprecated(
+        replacement: 'stateactions::section_move_after',
+        since: '4.4',
+        mdl: 'MDL-77038',
+        final: true,
-     */
+    )]
     public function section_move(
         stateupdates $updates,
         stdClass $course,
         array $ids,
         ?int $targetsectionid = null,
         ?int $targetcmid = null
-    ): void {
-        debugging(
-            'The method stateactions::section_move() has been deprecated, please use stateactions::section_move_after() instead.',
-            DEBUG_DEVELOPER
-        );
-        // Validate target elements.
-        if (!$targetsectionid) {
-            throw new moodle_exception("Action cm_move requires targetsectionid");
-        }
+    ): void {
-        $this->validate_sections($course, $ids, __FUNCTION__);
-        $coursecontext = context_course::instance($course->id);
-        require_capability('moodle/course:movesections', $coursecontext);
-        $modinfo = get_fast_modinfo($course);
-        // Target section.
-        $this->validate_sections($course, [$targetsectionid], __FUNCTION__);
-        $targetsection = $modinfo->get_section_info_by_id($targetsectionid, MUST_EXIST);
-        $affectedsections = [$targetsection->section => true];
-        $sections = $this->get_section_info($modinfo, $ids);
-        foreach ($sections as $section) {
-            $affectedsections[$section->section] = true;
-            move_section_to($course, $section->section, $targetsection->section);
-        }
-        // Use section_state to return the section and activities updated state.
-        $this->section_state($updates, $course, $ids, $targetsectionid);
-        // All course sections can be renamed because of the resort.
-        $allsections = $modinfo->get_section_info_all();
-        foreach ($allsections as $section) {
-            // Ignore the affected sections because they are already in the updates.
-            if (isset($affectedsections[$section->section])) {
-                continue;
-            }
-            $updates->add_section_put($section->id);
-        }
-        // The section order is at a course level.
-        $updates->add_course_put();
+        \core\deprecation::emit_deprecation([self::class, __FUNCTION__]);
+    }
     /**
         $format = course_get_format($course->id);
         $lastsectionnumber = $format->get_last_section_number();
         $maxsections = $format->get_max_sections();
         if ($lastsectionnumber >= $maxsections) {
-            throw new moodle_exception('maxsectionslimit', 'moodle', $maxsections);
+            throw new moodle_exception('maxsectionslimit', 'moodle', '', $maxsections);
+        }
         foreach ($ids as $sectionid) {
             // We need to get the latest modinfo on each iteration because the section numbers change.
             $modinfo = get_fast_modinfo($course);
+            $section = $modinfo->get_section_info_by_id($sectionid, MUST_EXIST);
+            if (!course_can_delete_section($course, $section)) {
+                continue;
             $section = $modinfo->get_section_info_by_id($sectionid, MUST_EXIST);
             // Send all activity deletions.
             if (!empty($modinfo->sections[$section->section])) {
                 foreach ($modinfo->sections[$section->section] as $modnumber) {
                     $cm = $modinfo->cms[$modnumber];
         $this->validate_cms(
             $course,
             $ids,
             __FUNCTION__,
-            ['moodle/course:manageactivities', 'moodle/course:activityvisibility']
+            ['moodle/course:activityvisibility']
         );
             course_module_updated::create_from_cm($cm, $modcontext)->trigger();
+        }
         course_modinfo::purge_course_modules_cache($course->id, $ids);
         rebuild_course_cache($course->id, false, true);
         $delegatedsections = [];
         foreach ($cms as $cm) {
+            $updates->add_cm_put($cm->id);
+            if (!$delegatedsection = $cm->get_delegated_section_info()) {
+                continue;
+            }
+            if (!in_array($delegatedsection->id, $delegatedsections)) {
+                $delegatedsections[] = $delegatedsection->id;
+            }
+        }
+        foreach ($delegatedsections as $sectionid => $section) {
-            $updates->add_cm_put($cm->id);
+            $updates->add_section_put($sectionid);
+        }
+    }
     ): void {
         $this->validate_cms(
             $course,
             $ids,
             __FUNCTION__,
-            ['moodle/course:manageactivities', 'moodle/backup:backuptargetimport', 'moodle/restore:restoretargetimport']
+            ['moodle/backup:backuptargetimport', 'moodle/restore:restoretargetimport'],
+            false
         );
         $modinfo = get_fast_modinfo($course);
         global $DB;
         $this->validate_cms($course, $ids, __FUNCTION__, ['moodle/course:manageactivities']);
         $modinfo = get_fast_modinfo($course);
+        $cms = $this->get_cm_info($modinfo, $ids);
+        $cms = $this->filter_cms_with_section_delegate($cms);
+        if (empty($cms)) {
+            return;
         $cms = $this->get_cm_info($modinfo, $ids);
         list($insql, $inparams) = $DB->get_in_or_equal(array_keys($cms), SQL_PARAMS_NAMED);
         $DB->set_field_select('course_modules', 'indent', $indent, "id $insql", $inparams);
         rebuild_course_cache($course->id, false, true);
         foreach ($cms as $cm) {
             $this->section_state($updates, $course, $sectionids);
+        }
+    }
+    /**
+     * Remove course modules with section delegate from a list.
+     *
+     * @param cm_info[] $cms the list of course modules to filter.
+     * @return cm_info[] the filtered list of course modules indexed by id.
+     */
+    protected function filter_cms_with_section_delegate(array $cms): array {
+        $filtered = [];
+        $modules = [];
+        foreach ($cms as $cm) {
+            if (!isset($modules[$cm->module])) {
+                $modules[$cm->module] = sectiondelegate::has_delegate_class('mod_' . $cm->modname);
+            }
+            if (!$modules[$cm->module]) {
+                $filtered[$cm->id] = $cm;
+            }
+        }
+        return $filtered;
+    }
     /**
      * Checks related to sections: course format support them, all given sections exist and topic 0 is not included.
+     *
      * @param stdClass $course The course where given $sectionids belong.
      * @param array $sectionids List of sections to validate.
      * Checks related to course modules: all given cm exist and the user has the required capabilities.
+     *
      * @param stdClass $course The course where given $cmids belong.
      * @param array $cmids List of course module ids to validate.
      * @param string $info additional information in case of error.
-     * @param array $capabilities optional capabilities checks per each cm context.
+     * @param array $capabilities optional capabilities checks to require.
+     * @param bool $usemodcontext whether to use each module context, or the course context
      * @throws moodle_exception if any id is not valid
      */
-    protected function validate_cms(stdClass $course, array $cmids, ?string $info = null, array $capabilities = []): void {
+    protected function validate_cms(
+        stdClass $course,
+        array $cmids,
+        ?string $info = null,
+        array $capabilities = [],
+        bool $usemodcontext = true,
+    ): void {
         if (empty($cmids)) {
             throw new moodle_exception('emptycmids', 'core', null, $info);
+        }
         $moduleinfo = get_fast_modinfo($course->id);
         $intersect = array_intersect($cmids, array_keys($moduleinfo->get_cms()));
         if (count($cmids) != count($intersect)) {
+            throw new moodle_exception('unexistingcmid', 'core', null, $info);
             throw new moodle_exception('unexistingcmid', 'core', null, $info);
-        }
+        if (!empty($capabilities)) {
-        if (!empty($capabilities)) {
+            if ($usemodcontext) {
-            foreach ($cmids as $cmid) {
+                foreach ($cmids as $cmid) {
+                    $modcontext = context_module::instance($cmid);
+                    require_all_capabilities($capabilities, $modcontext);
+                }
+            } else {
-                $modcontext = context_module::instance($cmid);
+                $coursecontext = context_course::instance($course->id);
-                require_all_capabilities($capabilities, $modcontext);
+                require_all_capabilities($capabilities, $coursecontext);
+            }
+        }
+    }
+    /**
+     * Create a course module.
+     *
+     * @deprecated since Moodle 5.0, use new_module instead.
+     * @todo MDL-83851: final deprecation of this method in Moodle 6.0.
+     * @param stateupdates $updates the affected course elements track
+     * @param stdClass $course the course object
+     * @param string $modname the module name
+     * @param int $targetsectionnum target section number
+     * @param int|null $targetcmid optional target cm id
+     */
+    #[\core\attribute\deprecated(
+        replacement: 'new_module',
+        since: '5.0',
+        mdl: 'MDL-83469',
+    )]
+    public function create_module(
+        stateupdates $updates,
+        stdClass $course,
+        string $modname,
+        int $targetsectionnum,
+        ?int $targetcmid = null
+    ): void {
+        global $CFG;
+        require_once($CFG->dirroot . '/course/modlib.php');
+        \core\deprecation::emit_deprecation([self::class, __FUNCTION__]);
+        $coursecontext = context_course::instance($course->id);
+        require_capability('moodle/course:update', $coursecontext);
+        // Method "can_add_moduleinfo" called in "prepare_new_moduleinfo_data" will handle the capability checks.
+        [, , , , $moduleinfo] = prepare_new_moduleinfo_data($course, $modname, $targetsectionnum);
+        $moduleinfo->beforemod = $targetcmid;
+        create_module((object) $moduleinfo);
+        // Adding module affects section structure, and if the module has a delegated section even the course structure.
+        $this->course_state($updates, $course);
+    }
+    /**
+     * Create a new course module.
+     *
+     * @param stateupdates $updates the affected course elements track
+     * @param stdClass $course the course object
+     * @param string $modname the module name
+     * @param int $targetsectionid target section id
+     * @param int|null $targetcmid optional target cm id
+     */
+    public function new_module(
+        stateupdates $updates,
+        stdClass $course,
+        string $modname,
+        int $targetsectionid,
+        ?int $targetcmid = null
+    ): void {
+        global $CFG;
+        require_once($CFG->dirroot . '/course/modlib.php');
+        $coursecontext = context_course::instance($course->id);
+        require_capability('moodle/course:update', $coursecontext);
+        $modinfo = get_fast_modinfo($course);
+        $section = $modinfo->get_section_info_by_id($targetsectionid, MUST_EXIST);
+        // Method "can_add_moduleinfo" called in "prepare_new_moduleinfo_data" will handle the capability checks.
+        [, , , , $moduleinfo] = prepare_new_moduleinfo_data($course, $modname, $section->sectionnum);
+        $moduleinfo->beforemod = $targetcmid;
+        create_module((object) $moduleinfo);
+        // Adding module affects section structure, and if the module has a delegated section even the course structure.
         $this->course_state($updates, $course);

Proyectos de Subversion Moodle

(root)/course/format/classes/stateactions.php – Rev 1 → 1441