WebSVN – Moodle – Diff – /badges/tests/badgeslib_test.php

             '"targetCode":"%s"}]}';
         $this->assertion2->issuer = '{"name":"%s","url":"%s","email":"%s",' .
             '"@context":"https:\/\/w3id.org\/openbadges\/v2","id":"%s","type":"Issuer"}';
+    }
-    public function test_create_badge() {
+    public function test_create_badge(): void {
         $badge = new badge($this->badgeid);
         $this->assertInstanceOf('badge', $badge);
         $this->assertEquals($this->badgeid, $badge->id);
+    }
-    public function test_clone_badge() {
+    public function test_clone_badge(): void {
         $badge = new badge($this->badgeid);
         $this->assertEquals($badge->imageauthorname, $clonedbadge->imageauthorname);
         $this->assertEquals($badge->imageauthoremail, $clonedbadge->imageauthoremail);
         $this->assertEquals($badge->imageauthorurl, $clonedbadge->imageauthorurl);
+    }
-    public function test_badge_status() {
+    public function test_badge_status(): void {
         $badge = new badge($this->badgeid);
         $old_status = $badge->status;
         $badge->set_status(BADGE_STATUS_ACTIVE);
         $this->assertNotEquals($old_status, $badge->status);
         $this->assertEquals(BADGE_STATUS_ACTIVE, $badge->status);
     }
-    public function test_delete_badge() {
+    public function test_delete_badge(): void {
         $badge = new badge($this->badgeid);
         $badge->delete();
         // We don't actually delete badges. We archive them.
         $this->assertEquals(BADGE_STATUS_ARCHIVED, $badge->status);
+    }
     /**
      * Really delete the badge.
      */
-    public function test_delete_badge_for_real() {
+    public function test_delete_badge_for_real(): void {
         global $DB;
         // Confirm that the tag instance of the badge has been removed.
         $this->assertFalse($DB->record_exists('tag_instance', ['itemid' => $this->badgeid]));
     }
-    public function test_create_badge_criteria() {
+    public function test_create_badge_criteria(): void {
         $badge = new badge($this->badgeid);
         $criteria_overall = award_criteria::build(array('criteriatype' => BADGE_CRITERIA_TYPE_OVERALL, 'badgeid' => $badge->id));
         $criteria_profile->save($params);
         $this->assertCount(2, $badge->get_criteria());
     }
-    public function test_add_badge_criteria_description() {
+    public function test_add_badge_criteria_description(): void {
         $criteriaoverall = award_criteria::build(array('criteriatype' => BADGE_CRITERIA_TYPE_OVERALL, 'badgeid' => $this->badgeid));
         $criteriaoverall->save(array(
                 'agg' => BADGE_CRITERIA_AGGREGATION_ALL,
         $badge = new badge($this->badgeid);
         $this->assertEquals('Overall description', $badge->criteria[BADGE_CRITERIA_TYPE_OVERALL]->description);
         $this->assertEquals('Description', $badge->criteria[BADGE_CRITERIA_TYPE_PROFILE]->description);
+    }
-    public function test_delete_badge_criteria() {
+    public function test_delete_badge_criteria(): void {
         $criteria_overall = award_criteria::build(array('criteriatype' => BADGE_CRITERIA_TYPE_OVERALL, 'badgeid' => $this->badgeid));
         $criteria_overall->save(array('agg' => BADGE_CRITERIA_AGGREGATION_ALL));
         $badge = new badge($this->badgeid);
         $this->assertInstanceOf('award_criteria_overall', $badge->criteria[BADGE_CRITERIA_TYPE_OVERALL]);
         $badge->criteria[BADGE_CRITERIA_TYPE_OVERALL]->delete();
         $this->assertEmpty($badge->get_criteria());
+    }
-    public function test_badge_awards() {
+    public function test_badge_awards(): void {
+    }
     /**
      * Test the {@link badges_get_user_badges()} function in lib/badgeslib.php
      */
-    public function test_badges_get_user_badges() {
+    public function test_badges_get_user_badges(): void {
         global $DB;
+    }
     /**
      * @dataProvider data_for_message_from_template
      */
-    public function test_badge_message_from_template($message, $params, $result) {
+    public function test_badge_message_from_template($message, $params, $result): void {
         $this->assertEquals(badge_message_from_template($message, $params), $result);
+    }
     /**
      * Test for working around the 61 tables join limit of mysql in award_criteria_activity in combination with the scheduled task.
+     *
      * @covers \core_badges\badge::review_all_criteria
      */
-    public function test_badge_activity_criteria_with_a_huge_number_of_coursemodules() {
+    public function test_badge_activity_criteria_with_a_huge_number_of_coursemodules(): void {
         global $CFG;
         require_once($CFG->dirroot.'/completion/criteria/completion_criteria_activity.php');
+    }
     /**
      * Test badges observer when course module completion event id fired.
      */
-    public function test_badges_observer_course_module_criteria_review() {
+    public function test_badges_observer_course_module_criteria_review(): void {
         $this->preventResetByRollback(); // Messaging is not compatible with transactions.
         $badge = new badge($this->coursebadge);
         $this->assertFalse($badge->is_issued($this->user->id));
+    }
     /**
      * Test badges observer when course_completed event is fired.
      */
-    public function test_badges_observer_course_criteria_review() {
+    public function test_badges_observer_course_criteria_review(): void {
         $this->preventResetByRollback(); // Messaging is not compatible with transactions.
         $badge = new badge($this->coursebadge);
         $this->assertFalse($badge->is_issued($this->user->id));
+    }
     /**
      * Test badges observer when user_updated event is fired.
      */
-    public function test_badges_observer_profile_criteria_review() {
+    public function test_badges_observer_profile_criteria_review(): void {
         global $CFG, $DB;
         require_once($CFG->dirroot.'/user/profile/lib.php');
     /**
      * Test badges observer when cohort_member_added event is fired and user required to belong to any cohort.
+     *
      * @covers \award_criteria_cohort
      */
-    public function test_badges_observer_any_cohort_criteria_review() {
+    public function test_badges_observer_any_cohort_criteria_review(): void {
         global $CFG;
         require_once("$CFG->dirroot/cohort/lib.php");
         // cohort, there are no other users that can award this badge.
         $this->assertSame(0, $badge->review_all_criteria()); // Verify award_criteria_cohort->get_completed_criteria_sql().
+    }
+    /**
+     * Test badges observer when user_updated event is fired.
+     * @covers \award_criteria_courseset
+     */
+    public function test_badges_observer_courseset_criteria_review(): void {
+        $this->preventResetByRollback(); // Messaging is not compatible with transactions.
+        $badge = new badge($this->coursebadge);
+        $this->assertFalse($badge->is_issued($this->user->id));
+        $additionalcourse = $this->getDataGenerator()->create_course(['enablecompletion' => true]);
+        $this->getDataGenerator()->enrol_user($this->user->id, $additionalcourse->id);
+        $criteriaoverall = award_criteria::build(['criteriatype' => BADGE_CRITERIA_TYPE_OVERALL, 'badgeid' => $badge->id]);
+        $criteriaoverall->save(['agg' => BADGE_CRITERIA_AGGREGATION_ANY]);
+        $criteriaoverall1 = award_criteria::build(['criteriatype' => BADGE_CRITERIA_TYPE_COURSESET, 'badgeid' => $badge->id]);
+        $criteriaoverall1->save(['agg' => BADGE_CRITERIA_AGGREGATION_ANY, 'course_' . $this->course->id => $this->course->id,
+            'course_' . $additionalcourse->id => $additionalcourse->id]);
+        $ccompletion = new completion_completion(['course' => $this->course->id, 'userid' => $this->user->id]);
+        $ccompletion2 = new completion_completion(['course' => $additionalcourse->id, 'userid' => $this->user->id]);
+        // Assert the badge will not be issued to the user as is.
+        $badge = new badge($this->coursebadge);
+        $badge->review_all_criteria();
+        $this->assertFalse($badge->is_issued($this->user->id));
+        // Mark course as complete.
+        $sink = $this->redirectMessages();
+        $ccompletion->mark_complete();
+        $ccompletion2->mark_complete();
+        // Thee messages are generated: Two for the course completed and the other one for the badge awarded.
+        $messages = $sink->get_messages();
+        $this->assertCount(3, $messages);
+        $this->assertEquals('badgerecipientnotice', $messages[0]->eventtype);
+        $this->assertEquals('coursecompleted', $messages[1]->eventtype);
+        $sink->close();
+        // Check if badge is awarded.
+        $this->assertDebuggingCalled('Error baking badge image!');
+        $this->assertTrue($badge->is_issued($this->user->id));
+    }
+    /**
+     * Test the criteria review method for courseset
+     * @covers \award_criteria_courseset::review
+     */
+    public function test_badges_courseset_criteria_review_empty_courseset(): void {
+        $this->preventResetByRollback(); // Messaging is not compatible with transactions.
+        $badge = new badge($this->coursebadge);
+        $this->assertFalse($badge->is_issued($this->user->id));
+        $criteriaoverall = award_criteria::build(['criteriatype' => BADGE_CRITERIA_TYPE_OVERALL, 'badgeid' => $badge->id]);
+        $criteriaoverall->save(['agg' => BADGE_CRITERIA_AGGREGATION_ANY]);
+        $criteriaoverall1 = award_criteria::build(['criteriatype' => BADGE_CRITERIA_TYPE_COURSESET, 'badgeid' => $badge->id]);
+        $criteriaoverall1->save();
+        // Assert the badge will not be issued to the user as is.
+        $badge = new badge($this->coursebadge);
+        $badge->review_all_criteria();
+        $this->assertFalse($badge->is_issued($this->user->id));
+    }
     /**
      * Test badges observer when cohort_member_added event is fired and user required to belong to multiple (all) cohorts.
+     *
      * @covers \award_criteria_cohort
      */
-    public function test_badges_observer_all_cohort_criteria_review() {
+    public function test_badges_observer_all_cohort_criteria_review(): void {
         global $CFG;
+    }
     /**
      * Test badges assertion generated when a badge is issued.
      */
-    public function test_badges_assertion() {
+    public function test_badges_assertion(): void {
         $this->preventResetByRollback(); // Messaging is not compatible with transactions.
         $badge = new badge($this->coursebadge);
         $this->assertFalse($badge->is_issued($this->user->id));
+    }
     /**
      * Tests the core_badges_myprofile_navigation() function.
      */
-    public function test_core_badges_myprofile_navigation() {
+    public function test_core_badges_myprofile_navigation(): void {
         // Set up the test.
         $tree = new \core_user\output\myprofile\tree();
         $this->setAdminUser();
         $badge = new badge($this->badgeid);
+    }
     /**
      * Tests the core_badges_myprofile_navigation() function with badges disabled..
      */
-    public function test_core_badges_myprofile_navigation_badges_disabled() {
+    public function test_core_badges_myprofile_navigation_badges_disabled(): void {
         // Set up the test.
         $tree = new \core_user\output\myprofile\tree();
         $this->setAdminUser();
         $badge = new badge($this->badgeid);
+    }
     /**
      * Tests the core_badges_myprofile_navigation() function with a course badge.
      */
-    public function test_core_badges_myprofile_navigation_with_course_badge() {
+    public function test_core_badges_myprofile_navigation_with_course_badge(): void {
         // Set up the test.
         $tree = new \core_user\output\myprofile\tree();
         $this->setAdminUser();
         $badge = new badge($this->coursebadge);
+    }
     /**
      * Test insert and update endorsement with a site badge.
      */
-    public function test_badge_endorsement() {
+    public function test_badge_endorsement(): void {
         $badge = new badge($this->badgeid);
         // Insert Endorsement.
+    }
     /**
      * Test insert and delete related badge with a site badge.
      */
-    public function test_badge_related() {
+    public function test_badge_related(): void {
         $badge = new badge($this->badgeid);
         $newid1 = $badge->make_clone();
         $newid2 = $badge->make_clone();
+    }
     /**
      * Test insert, update, delete alignment with a site badge.
      */
-    public function test_alignments() {
+    public function test_alignments(): void {
         $badge = new badge($this->badgeid);
         // Insert a alignment.
      * @dataProvider save_backpack_credentials_provider
      * @param  bool $addbackpack True if backpack data has to be created; false otherwise (empty data will be used then).
      * @param  string|null  $mail  Backpack mail address.
      * @param  string|null  $password  Backpack password.
      */
-    public function test_save_backpack_credentials(bool $addbackpack = true, ?string $mail = null, ?string $password = null) {
+    public function test_save_backpack_credentials(bool $addbackpack = true, ?string $mail = null, ?string $password = null): void {
         global $DB;
         $this->resetAfterTest();
      * @dataProvider badges_save_external_backpack_provider
      * @param  array $data  Backpack data to save.
      * @param  bool $adduser True if a real user has to be used for creating the backpack; false otherwise.
      * @param  bool $duplicates True if duplicates has to be tested too; false otherwise.
      */
-    public function test_badges_save_external_backpack(array $data, bool $adduser, bool $duplicates) {
+    public function test_badges_save_external_backpack(array $data, bool $adduser, bool $duplicates): void {
         global $DB;
         $this->resetAfterTest();
+     *
      * @param boolean $isadmin
      * @param boolean $updatetest
      * @dataProvider badges_create_site_backpack_provider
      */
-    public function test_badges_create_site_backpack($isadmin, $updatetest) {
+    public function test_badges_create_site_backpack($isadmin, $updatetest): void {
         global $DB;
         $this->resetAfterTest();
         $data = [
+    }
     /**
      * Test the badges_open_badges_backpack_api with different backpacks
      */
-    public function test_badges_open_badges_backpack_api() {
+    public function test_badges_open_badges_backpack_api(): void {
         $this->resetAfterTest();
         $data = [
+    }
     /**
      * Test the badges_get_site_backpack function
      */
-    public function test_badges_get_site_backpack() {
+    public function test_badges_get_site_backpack(): void {
         $this->resetAfterTest();
         $user = $this->getDataGenerator()->create_user();
         $data = [
             'apiversion' => '2',
+    }
     /**
      * Test the badges_get_user_backpack function
      */
-    public function test_badges_get_user_backpack() {
+    public function test_badges_get_user_backpack(): void {
         $this->resetAfterTest();
         $user = $this->getDataGenerator()->create_user();
         $data = [
             'apiversion' => '2',
      * Test the badges_get_site_primary_backpack function
+     *
      * @param boolean $withauth Testing with authentication or not.
      * @dataProvider badges_get_site_primary_backpack_provider
      */
-    public function test_badges_get_site_primary_backpack($withauth) {
+    public function test_badges_get_site_primary_backpack($withauth): void {
         $data = [
             'apiversion' => '2',
             'backpackapiurl' => 'https://api.ca.badgr.io/v2',
             'backpackweburl' => 'https://ca.badgr.io',
             'sortorder' => '2',
+     *
      * @param mixed $type Type corresponding to the badge entites
      * @param string $expected Expected string result
      * @dataProvider badgr_open_url_generator
      */
-    public function test_badges_generate_badgr_open_url($type, $expected) {
+    public function test_badges_generate_badgr_open_url($type, $expected): void {
         $data = [
             'apiversion' => '2',
             'backpackapiurl' => 'https://api.ca.badgr.io/v2',
             'backpackweburl' => 'https://ca.badgr.io',
             'backpackemail' => 'test@test.com',
      * @param mixed $expected The expected result from the function
      * @param string|null $field The field we are passing to the function. Null if we don't want to pass anything.ss
+     *
      * @dataProvider badges_external_get_mapping_provider
      */
-    public function test_badges_external_get_mapping($internalid, $externalid, $expected, $field = null) {
+    public function test_badges_external_get_mapping($internalid, $externalid, $expected, $field = null): void {
         $data = [
             'apiversion' => '2',
             'backpackapiurl' => 'https://api.ca.badgr.io/v2',
             'backpackweburl' => 'https://ca.badgr.io',
             'backpackemail' => 'test@test.com',
     /**
      * Testing function test_badge_get_tagged_badges - search tagged badges
+     *
      * @covers ::badge_get_tagged_badges
      */
-    public function test_badge_get_tagged_badges() {
+    public function test_badge_get_tagged_badges(): void {
         $this->resetAfterTest();
         $this->setAdminUser();
         // Setup test data.

Proyectos de Subversion Moodle

(root)/badges/tests/badgeslib_test.php – Rev 1 → 11