WebSVN – Moodle – Diff – /analytics/tests/manager_test.php

 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+namespace core_analytics;
-namespace core_analytics;
+use core_analytics\tests\mlbackend_helper_trait;
 defined('MOODLE_INTERNAL') || die();
  * @package   core_analytics
  * @copyright 2017 David Monllaó {@link http://www.davidmonllao.com}
  * @license   http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  * @covers    \core_analytics\manager
  */
-class manager_test extends \advanced_testcase {
+final class manager_test extends \advanced_testcase {
+    use mlbackend_helper_trait;
     /**
      * test_deleted_context
      */
     public function test_deleted_context(): void {
+        global $DB;
+        if (!self::is_mlbackend_python_configured()) {
+            $this->markTestSkipped('mlbackend_python is not configured.');
         global $DB;
         $this->resetAfterTest(true);
+        $this->setAdminuser();
+        set_config('enabled_stores', 'logstore_standard', 'tool_log');
+        // Create some courses.
-        $this->setAdminuser();
+        $this->generate_courses(2, ['visible' => 0]);
-        set_config('enabled_stores', 'logstore_standard', 'tool_log');
+        $this->generate_courses(2, ['visible' => 1]);
         $target = \core_analytics\manager::get_target('test_target_course_level_shortname');
-        $indicators = array('test_indicator_max', 'test_indicator_min', 'test_indicator_fullname');
+        $indicators = ['test_indicator_max', 'test_indicator_min', 'test_indicator_fullname'];
         foreach ($indicators as $key => $indicator) {
             $indicators[$key] = \core_analytics\manager::get_indicator($indicator);
-        }
-        $model = \core_analytics\model::create($target, $indicators);
-        $modelobj = $model->get_model_obj();
         $coursepredict1 = $this->getDataGenerator()->create_course(array('visible' => 0));
         $coursepredict2 = $this->getDataGenerator()->create_course(array('visible' => 0));
-        $coursetrain1 = $this->getDataGenerator()->create_course(array('visible' => 1));
+        $model = \core_analytics\model::create($target, $indicators);
-        $coursetrain2 = $this->getDataGenerator()->create_course(array('visible' => 1));
+        $modelobj = $model->get_model_obj();
         $model->enable('\core\analytics\time_splitting\no_splitting');
         $model->train();
         $model->predict();
         // Generate a prediction action to confirm that it is deleted when there is an important update.
+        $predictions = $DB->get_records('analytics_predictions');
-        $predictions = $DB->get_records('analytics_predictions');
+        $prediction = reset($predictions);
+        $prediction = new \core_analytics\prediction($prediction, ['whatever' => 'not used']);
-        $prediction = reset($predictions);
+        $prediction->action_executed(\core_analytics\prediction::ACTION_USEFUL, $model->get_target());
         $prediction = new \core_analytics\prediction($prediction, array('whatever' => 'not used'));
-        $prediction->action_executed(\core_analytics\prediction::ACTION_USEFUL, $model->get_target());
+        $predictioncontextid = $prediction->get_prediction_data()->contextid;
+        $npredictions = $DB->count_records('analytics_predictions', ['contextid' => $predictioncontextid]);
-        $predictioncontextid = $prediction->get_prediction_data()->contextid;
+        $npredictionactions = $DB->count_records(
+            'analytics_prediction_actions',
+            ['predictionid' => $prediction->get_prediction_data()->id]
+        );
-        $npredictions = $DB->count_records('analytics_predictions', array('contextid' => $predictioncontextid));
+        $nindicatorcalc = $DB->count_records('analytics_indicator_calc', ['contextid' => $predictioncontextid]);
-        $npredictionactions = $DB->count_records('analytics_prediction_actions',
+        \core_analytics\manager::cleanup();
-            array('predictionid' => $prediction->get_prediction_data()->id));
+        // Nothing is incorrectly deleted.
+        $this->assertEquals($npredictions, $DB->count_records(
-        $nindicatorcalc = $DB->count_records('analytics_indicator_calc', array('contextid' => $predictioncontextid));
+            'analytics_predictions',
             ['contextid' => $predictioncontextid]
-        \core_analytics\manager::cleanup();
+        ));
         $this->assertEquals($npredictionactions, $DB->count_records(
-        // Nothing is incorrectly deleted.
+            'analytics_prediction_actions',
-        $this->assertEquals($npredictions, $DB->count_records('analytics_predictions',
+            ['predictionid' => $prediction->get_prediction_data()->id]
+        ));
-            array('contextid' => $predictioncontextid)));
+        $this->assertEquals($nindicatorcalc, $DB->count_records(
+            'analytics_indicator_calc',
-        $this->assertEquals($npredictionactions, $DB->count_records('analytics_prediction_actions',
+            ['contextid' => $predictioncontextid]
-            array('predictionid' => $prediction->get_prediction_data()->id)));
+        ));
         $this->assertEquals($nindicatorcalc, $DB->count_records('analytics_indicator_calc',
-            array('contextid' => $predictioncontextid)));
+        // Now we delete a context, the course predictions and prediction actions should be deleted.
      * test_deleted_analysable
      */
     public function test_deleted_analysable(): void {
         global $DB;
+        if (!self::is_mlbackend_python_configured()) {
+            $this->markTestSkipped('mlbackend_python is not configured.');
+        }
         $this->resetAfterTest(true);
         $this->setAdminuser();
         set_config('enabled_stores', 'logstore_standard', 'tool_log');
         $target = \core_analytics\manager::get_target('test_target_course_level_shortname');
-        $indicators = array('test_indicator_max', 'test_indicator_min', 'test_indicator_fullname');
+        $indicators = ['test_indicator_max', 'test_indicator_min', 'test_indicator_fullname'];
         foreach ($indicators as $key => $indicator) {
             $indicators[$key] = \core_analytics\manager::get_indicator($indicator);
+        }
         $model = \core_analytics\model::create($target, $indicators);
         $modelobj = $model->get_model_obj();
-        $coursepredict1 = $this->getDataGenerator()->create_course(array('visible' => 0));
+        $coursepredict1 = $this->getDataGenerator()->create_course(['visible' => 0]);
-        $coursepredict2 = $this->getDataGenerator()->create_course(array('visible' => 0));
+        $coursepredict2 = $this->getDataGenerator()->create_course(['visible' => 0]);
-        $coursetrain1 = $this->getDataGenerator()->create_course(array('visible' => 1));
+        $coursetrain1 = $this->getDataGenerator()->create_course(['visible' => 1]);
         $deletedcontext = \context_course::instance($coursepredict1->id);
         delete_course($coursepredict1, false);
         \core_analytics\manager::cleanup();
-        $this->assertEmpty($DB->count_records('analytics_predict_samples', array('analysableid' => $coursepredict1->id)));
+        $this->assertEmpty($DB->count_records('analytics_predict_samples', ['analysableid' => $coursepredict1->id]));
-        $this->assertEmpty($DB->count_records('analytics_train_samples', array('analysableid' => $coursepredict1->id)));
+        $this->assertEmpty($DB->count_records('analytics_train_samples', ['analysableid' => $coursepredict1->id]));
-        $this->assertEmpty($DB->count_records('analytics_used_analysables', array('analysableid' => $coursepredict1->id)));
+        $this->assertEmpty($DB->count_records('analytics_used_analysables', ['analysableid' => $coursepredict1->id]));
      */
     public function test_validate_models_declaration(): void {
         $this->resetAfterTest();
         // This is expected to run without an exception.
-        $models = $this->load_models_from_fixture_file('no_teaching');
+        $models = self::load_models_from_fixture_file('no_teaching');
         \core_analytics\manager::validate_models_declaration($models);
+    }
     /**
      * Data provider for the {@link self::test_validate_models_declaration_exceptions()}.
+     *
      * @return array of (string)testcase => [(array)models, (string)expected exception message]
      */
-    public function validate_models_declaration_exceptions_provider() {
+    public static function validate_models_declaration_exceptions_provider(): array {
         return [
             'missing_target' => [
-                $this->load_models_from_fixture_file('missing_target'),
+                self::load_models_from_fixture_file('missing_target'),
                 'Missing target declaration',
             ],
             'invalid_target' => [
-                $this->load_models_from_fixture_file('invalid_target'),
+                self::load_models_from_fixture_file('invalid_target'),
                 'Invalid target classname',
             ],
             'missing_indicators' => [
-                $this->load_models_from_fixture_file('missing_indicators'),
+                self::load_models_from_fixture_file('missing_indicators'),
                 'Missing indicators declaration',
             ],
             'invalid_indicators' => [
-                $this->load_models_from_fixture_file('invalid_indicators'),
+                self::load_models_from_fixture_file('invalid_indicators'),
                 'Invalid indicator classname',
             ],
             'invalid_time_splitting' => [
-                $this->load_models_from_fixture_file('invalid_time_splitting'),
+                self::load_models_from_fixture_file('invalid_time_splitting'),
                 'Invalid time splitting classname',
             ],
             'invalid_time_splitting_fq' => [
-                $this->load_models_from_fixture_file('invalid_time_splitting_fq'),
+                self::load_models_from_fixture_file('invalid_time_splitting_fq'),
                 'Expecting fully qualified time splitting classname',
             ],
             'invalid_enabled' => [
-                $this->load_models_from_fixture_file('invalid_enabled'),
+                self::load_models_from_fixture_file('invalid_enabled'),
                 'Cannot enable a model without time splitting method specified',
             ],
         ];
+    }
      * Loads models as declared in the given fixture file.
+     *
      * @param string $filename
      * @return array
      */
-    protected function load_models_from_fixture_file(string $filename) {
+    protected static function load_models_from_fixture_file(string $filename) {
         global $CFG;
         $models = null;
-        require($CFG->dirroot.'/analytics/tests/fixtures/db_analytics_php/'.$filename.'.php');
+        require("{$CFG->dirroot}/analytics/tests/fixtures/db_analytics_php/{$filename}.php");
     /**
      * Test the implementation of the {@link \core_analytics\manager::model_declaration_identifier()}.
      */
     public function test_model_declaration_identifier(): void {
-        $noteaching1 = $this->load_models_from_fixture_file('no_teaching');
+        $noteaching1 = self::load_models_from_fixture_file('no_teaching');
-        $noteaching2 = $this->load_models_from_fixture_file('no_teaching');
+        $noteaching2 = self::load_models_from_fixture_file('no_teaching');
-        $noteaching3 = $this->load_models_from_fixture_file('no_teaching');
+        $noteaching3 = self::load_models_from_fixture_file('no_teaching');
         // Same model declaration should always lead to same identifier.
         $this->assertEquals(
      * Tests for the {@link \core_analytics\manager::get_declared_target_and_indicators_instances()}.
      */
     public function test_get_declared_target_and_indicators_instances(): void {
         $this->resetAfterTest();
-        $definition = $this->load_models_from_fixture_file('no_teaching');
+        $definition = self::load_models_from_fixture_file('no_teaching');
-        list($target, $indicators) = \core_analytics\manager::get_declared_target_and_indicators_instances($definition[0]);
+        [$target, $indicators] = \core_analytics\manager::get_declared_target_and_indicators_instances($definition[0]);
         $this->assertTrue($target instanceof \core_analytics\local\target\base);

Proyectos de Subversion Moodle

(root)/analytics/tests/manager_test.php – Rev 11 → 1441