Proyectos de Subversion Moodle

Rev

Rev 11 | | Comparar con el anterior | Ultima modificación | Ver Log |

Rev Autor Línea Nro. Línea
1 efrain 1
<?php
2
// This file is part of Moodle - http://moodle.org/
3
//
4
// Moodle is free software: you can redistribute it and/or modify
5
// it under the terms of the GNU General Public License as published by
6
// the Free Software Foundation, either version 3 of the License, or
7
// (at your option) any later version.
8
//
9
// Moodle is distributed in the hope that it will be useful,
10
// but WITHOUT ANY WARRANTY; without even the implied warranty of
11
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
12
// GNU General Public License for more details.
13
//
14
// You should have received a copy of the GNU General Public License
15
// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
16
 
17
/**
18
 * Forum search unit tests.
19
 *
20
 * @package     mod_forum
21
 * @category    test
22
 * @copyright   2015 David Monllao {@link http://www.davidmonllao.com}
23
 * @license     http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
24
 */
25
 
26
namespace mod_forum\search;
27
 
28
defined('MOODLE_INTERNAL') || die();
29
 
30
global $CFG;
31
require_once($CFG->dirroot . '/search/tests/fixtures/testable_core_search.php');
32
require_once($CFG->dirroot . '/mod/forum/tests/generator/lib.php');
33
require_once($CFG->dirroot . '/mod/forum/lib.php');
34
 
35
/**
36
 * Provides the unit tests for forum search.
37
 *
38
 * @package     mod_forum
39
 * @category    test
40
 * @copyright   2015 David Monllao {@link http://www.davidmonllao.com}
41
 * @license     http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
42
 */
1441 ariadna 43
final class search_test extends \advanced_testcase {
1 efrain 44
 
45
    /**
46
     * @var string Area id
47
     */
48
    protected $forumpostareaid = null;
49
 
50
    public function setUp(): void {
1441 ariadna 51
        parent::setUp();
1 efrain 52
        $this->resetAfterTest(true);
53
        set_config('enableglobalsearch', true);
54
 
55
        $this->forumpostareaid = \core_search\manager::generate_areaid('mod_forum', 'post');
56
 
57
        // Set \core_search::instance to the mock_search_engine as we don't require the search engine to be working to test this.
58
        $search = \testable_core_search::instance();
59
    }
60
 
61
    /**
62
     * Availability.
63
     *
64
     * @return void
65
     */
11 efrain 66
    public function test_search_enabled(): void {
1 efrain 67
 
68
        $searcharea = \core_search\manager::get_search_area($this->forumpostareaid);
69
        list($componentname, $varname) = $searcharea->get_config_var_name();
70
 
71
        // Enabled by default once global search is enabled.
72
        $this->assertTrue($searcharea->is_enabled());
73
 
74
        set_config($varname . '_enabled', 0, $componentname);
75
        $this->assertFalse($searcharea->is_enabled());
76
 
77
        set_config($varname . '_enabled', 1, $componentname);
78
        $this->assertTrue($searcharea->is_enabled());
79
    }
80
 
81
    /**
82
     * Indexing mod forum contents.
83
     *
84
     * @return void
85
     */
11 efrain 86
    public function test_posts_indexing(): void {
1 efrain 87
        global $DB;
88
 
89
        // Returns the instance as long as the area is supported.
90
        $searcharea = \core_search\manager::get_search_area($this->forumpostareaid);
91
        $this->assertInstanceOf('\mod_forum\search\post', $searcharea);
92
 
93
        $user1 = self::getDataGenerator()->create_user();
94
        $user2 = self::getDataGenerator()->create_user();
95
 
96
        $course1 = self::getDataGenerator()->create_course();
97
        $course2 = self::getDataGenerator()->create_course();
98
 
99
        $this->getDataGenerator()->enrol_user($user1->id, $course1->id, 'student');
100
        $this->getDataGenerator()->enrol_user($user2->id, $course1->id, 'student');
101
 
102
        $record = new \stdClass();
103
        $record->course = $course1->id;
104
 
105
        // Available for both student and teacher.
106
        $forum1 = self::getDataGenerator()->create_module('forum', $record);
107
 
108
        // Create discussion1.
109
        $record = new \stdClass();
110
        $record->course = $course1->id;
111
        $record->userid = $user1->id;
112
        $record->forum = $forum1->id;
113
        $record->message = 'discussion';
114
        $discussion1 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_discussion($record);
115
 
116
        // Create post1 in discussion1.
117
        $record = new \stdClass();
118
        $record->discussion = $discussion1->id;
119
        $record->parent = $discussion1->firstpost;
120
        $record->userid = $user2->id;
121
        $record->message = 'post2';
122
        $discussion1reply1 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_post($record);
123
 
124
        // All records.
125
        $recordset = $searcharea->get_recordset_by_timestamp(0);
126
        $this->assertTrue($recordset->valid());
127
        $nrecords = 0;
128
        foreach ($recordset as $record) {
129
            $this->assertInstanceOf('stdClass', $record);
130
            $doc = $searcharea->get_document($record);
131
            $this->assertInstanceOf('\core_search\document', $doc);
132
 
133
            // Static caches are working.
134
            $dbreads = $DB->perf_get_reads();
135
            $doc = $searcharea->get_document($record);
136
            $this->assertEquals($dbreads, $DB->perf_get_reads());
137
            $this->assertInstanceOf('\core_search\document', $doc);
138
            $nrecords++;
139
        }
140
        // If there would be an error/failure in the foreach above the recordset would be closed on shutdown.
141
        $recordset->close();
142
        $this->assertEquals(2, $nrecords);
143
 
144
        // The +2 is to prevent race conditions.
145
        $recordset = $searcharea->get_recordset_by_timestamp(time() + 2);
146
 
147
        // No new records.
148
        $this->assertFalse($recordset->valid());
149
        $recordset->close();
150
 
151
        // Context test: create another forum with 1 post.
152
        $forum2 = self::getDataGenerator()->create_module('forum', ['course' => $course1->id]);
153
        $record = new \stdClass();
154
        $record->course = $course1->id;
155
        $record->userid = $user1->id;
156
        $record->forum = $forum2->id;
157
        $record->message = 'discussion';
158
        self::getDataGenerator()->get_plugin_generator('mod_forum')->create_discussion($record);
159
 
160
        // Test indexing with each forum then combined course context.
161
        $rs = $searcharea->get_document_recordset(0, \context_module::instance($forum1->cmid));
162
        $this->assertEquals(2, iterator_count($rs));
163
        $rs->close();
164
        $rs = $searcharea->get_document_recordset(0, \context_module::instance($forum2->cmid));
165
        $this->assertEquals(1, iterator_count($rs));
166
        $rs->close();
167
        $rs = $searcharea->get_document_recordset(0, \context_course::instance($course1->id));
168
        $this->assertEquals(3, iterator_count($rs));
169
        $rs->close();
170
    }
171
 
172
    /**
173
     * Document contents.
174
     *
175
     * @return void
176
     */
11 efrain 177
    public function test_posts_document(): void {
1 efrain 178
        global $DB;
179
 
180
        // Returns the instance as long as the area is supported.
181
        $searcharea = \core_search\manager::get_search_area($this->forumpostareaid);
182
        $this->assertInstanceOf('\mod_forum\search\post', $searcharea);
183
 
184
        $user = self::getDataGenerator()->create_user();
185
        $course1 = self::getDataGenerator()->create_course();
186
        $this->getDataGenerator()->enrol_user($user->id, $course1->id, 'teacher');
187
 
188
        $record = new \stdClass();
189
        $record->course = $course1->id;
190
        $forum1 = self::getDataGenerator()->create_module('forum', $record);
191
 
192
        // Teacher only.
193
        $forum2 = self::getDataGenerator()->create_module('forum', $record);
194
        set_coursemodule_visible($forum2->cmid, 0);
195
 
196
        // Create discussion1.
197
        $record = new \stdClass();
198
        $record->course = $course1->id;
199
        $record->userid = $user->id;
200
        $record->forum = $forum1->id;
201
        $record->message = 'discussion';
202
        $record->groupid = 0;
203
        $discussion1 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_discussion($record);
204
 
205
        // Create post1 in discussion1.
206
        $record = new \stdClass();
207
        $record->discussion = $discussion1->id;
208
        $record->parent = $discussion1->firstpost;
209
        $record->userid = $user->id;
210
        $record->subject = 'subject1';
211
        $record->message = 'post1';
212
        $record->groupid = -1;
213
        $discussion1reply1 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_post($record);
214
 
215
        $post1 = $DB->get_record('forum_posts', array('id' => $discussion1reply1->id));
216
        $post1->forumid = $forum1->id;
217
        $post1->courseid = $forum1->course;
218
        $post1->groupid = -1;
219
 
220
        $doc = $searcharea->get_document($post1);
221
        $this->assertInstanceOf('\core_search\document', $doc);
222
        $this->assertEquals($discussion1reply1->id, $doc->get('itemid'));
223
        $this->assertEquals($this->forumpostareaid . '-' . $discussion1reply1->id, $doc->get('id'));
224
        $this->assertEquals($course1->id, $doc->get('courseid'));
225
        $this->assertEquals($user->id, $doc->get('userid'));
226
        $this->assertEquals($discussion1reply1->subject, $doc->get('title'));
227
        $this->assertEquals($discussion1reply1->message, $doc->get('content'));
228
    }
229
 
230
    /**
231
     * Group support for forum posts.
232
     */
11 efrain 233
    public function test_posts_group_support(): void {
1 efrain 234
        // Get the search area and test generators.
235
        $searcharea = \core_search\manager::get_search_area($this->forumpostareaid);
236
        $generator = $this->getDataGenerator();
237
        $forumgenerator = $generator->get_plugin_generator('mod_forum');
238
 
239
        // Create a course, a user, and two groups.
240
        $course = $generator->create_course();
241
        $user = $generator->create_user();
242
        $generator->enrol_user($user->id, $course->id, 'teacher');
243
        $group1 = $generator->create_group(['courseid' => $course->id]);
244
        $group2 = $generator->create_group(['courseid' => $course->id]);
245
 
246
        // Separate groups forum.
247
        $forum = self::getDataGenerator()->create_module('forum', ['course' => $course->id,
248
                'groupmode' => SEPARATEGROUPS]);
249
 
250
        // Create discussion with each group and one for all groups. One has a post in.
251
        $discussion1 = $forumgenerator->create_discussion(['course' => $course->id,
252
                'userid' => $user->id, 'forum' => $forum->id, 'message' => 'd1',
253
                'groupid' => $group1->id]);
254
        $forumgenerator->create_discussion(['course' => $course->id,
255
                'userid' => $user->id, 'forum' => $forum->id, 'message' => 'd2',
256
                'groupid' => $group2->id]);
257
        $forumgenerator->create_discussion(['course' => $course->id,
258
                'userid' => $user->id, 'forum' => $forum->id, 'message' => 'd3']);
259
 
260
        // Create a reply in discussion1.
261
        $forumgenerator->create_post(['discussion' => $discussion1->id, 'parent' => $discussion1->firstpost,
262
                'userid' => $user->id, 'message' => 'p1']);
263
 
264
        // Do the indexing of all 4 posts.
265
        $rs = $searcharea->get_recordset_by_timestamp(0);
266
        $results = [];
267
        foreach ($rs as $rec) {
268
            $results[$rec->message] = $rec;
269
        }
270
        $rs->close();
271
        $this->assertCount(4, $results);
272
 
273
        // Check each document has the correct groupid.
274
        $doc = $searcharea->get_document($results['d1']);
275
        $this->assertTrue($doc->is_set('groupid'));
276
        $this->assertEquals($group1->id, $doc->get('groupid'));
277
        $doc = $searcharea->get_document($results['d2']);
278
        $this->assertTrue($doc->is_set('groupid'));
279
        $this->assertEquals($group2->id, $doc->get('groupid'));
280
        $doc = $searcharea->get_document($results['d3']);
281
        $this->assertFalse($doc->is_set('groupid'));
282
        $doc = $searcharea->get_document($results['p1']);
283
        $this->assertTrue($doc->is_set('groupid'));
284
        $this->assertEquals($group1->id, $doc->get('groupid'));
285
 
286
        // While we're here, also test that the search area requests restriction by group.
287
        $modinfo = get_fast_modinfo($course);
288
        $this->assertTrue($searcharea->restrict_cm_access_by_group($modinfo->get_cm($forum->cmid)));
289
 
290
        // In visible groups mode, it won't request restriction by group.
291
        set_coursemodule_groupmode($forum->cmid, VISIBLEGROUPS);
292
        $modinfo = get_fast_modinfo($course);
293
        $this->assertFalse($searcharea->restrict_cm_access_by_group($modinfo->get_cm($forum->cmid)));
294
    }
295
 
296
    /**
297
     * Document accesses.
298
     *
299
     * @return void
300
     */
11 efrain 301
    public function test_posts_access(): void {
1 efrain 302
        global $DB;
303
 
304
        // Returns the instance as long as the area is supported.
305
        $searcharea = \core_search\manager::get_search_area($this->forumpostareaid);
306
 
307
        $user1 = self::getDataGenerator()->create_user();
308
        $user2 = self::getDataGenerator()->create_user();
309
 
310
        $course1 = self::getDataGenerator()->create_course();
311
        $course2 = self::getDataGenerator()->create_course();
312
 
313
        $this->getDataGenerator()->enrol_user($user1->id, $course1->id, 'teacher');
314
        $this->getDataGenerator()->enrol_user($user2->id, $course1->id, 'student');
315
 
316
        $record = new \stdClass();
317
        $record->course = $course1->id;
318
 
319
        // Available for both student and teacher.
320
        $forum1 = self::getDataGenerator()->create_module('forum', $record);
321
 
322
        // Teacher only.
323
        $forum2 = self::getDataGenerator()->create_module('forum', $record);
324
        set_coursemodule_visible($forum2->cmid, 0);
325
 
326
        // Create discussion1.
327
        $record = new \stdClass();
328
        $record->course = $course1->id;
329
        $record->userid = $user1->id;
330
        $record->forum = $forum1->id;
331
        $record->message = 'discussion';
332
        $discussion1 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_discussion($record);
333
 
334
        // Create post1 in discussion1.
335
        $record = new \stdClass();
336
        $record->discussion = $discussion1->id;
337
        $record->parent = $discussion1->firstpost;
338
        $record->userid = $user2->id;
339
        $record->message = 'post1';
340
        $discussion1reply1 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_post($record);
341
 
342
        // Create discussion2 only visible to teacher.
343
        $record = new \stdClass();
344
        $record->course = $course1->id;
345
        $record->userid = $user1->id;
346
        $record->forum = $forum2->id;
347
        $record->message = 'discussion';
348
        $discussion2 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_discussion($record);
349
 
350
        // Create post2 in discussion2.
351
        $record = new \stdClass();
352
        $record->discussion = $discussion2->id;
353
        $record->parent = $discussion2->firstpost;
354
        $record->userid = $user1->id;
355
        $record->message = 'post2';
356
        $discussion2reply1 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_post($record);
357
 
358
        $this->setUser($user2);
359
        $this->assertEquals(\core_search\manager::ACCESS_GRANTED, $searcharea->check_access($discussion1reply1->id));
360
        $this->assertEquals(\core_search\manager::ACCESS_DENIED, $searcharea->check_access($discussion2reply1->id));
361
    }
362
 
363
    /**
364
     * Test for post attachments.
365
     *
366
     * @return void
367
     */
11 efrain 368
    public function test_attach_files(): void {
1 efrain 369
        global $DB;
370
 
371
        $fs = get_file_storage();
372
 
373
        // Returns the instance as long as the area is supported.
374
        $searcharea = \core_search\manager::get_search_area($this->forumpostareaid);
375
        $this->assertInstanceOf('\mod_forum\search\post', $searcharea);
376
 
377
        $user1 = self::getDataGenerator()->create_user();
378
        $user2 = self::getDataGenerator()->create_user();
379
 
380
        $course1 = self::getDataGenerator()->create_course();
381
 
382
        $this->getDataGenerator()->enrol_user($user1->id, $course1->id, 'student');
383
        $this->getDataGenerator()->enrol_user($user2->id, $course1->id, 'student');
384
 
385
        $record = new \stdClass();
386
        $record->course = $course1->id;
387
 
388
        $forum1 = self::getDataGenerator()->create_module('forum', $record);
389
 
390
        // Create discussion1.
391
        $record = new \stdClass();
392
        $record->course = $course1->id;
393
        $record->userid = $user1->id;
394
        $record->forum = $forum1->id;
395
        $record->message = 'discussion';
396
        $record->attachemt = 1;
397
        $discussion1 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_discussion($record);
398
 
399
        // Attach 2 file to the discussion post.
400
        $post = $DB->get_record('forum_posts', array('discussion' => $discussion1->id));
401
        $filerecord = array(
402
            'contextid' => \context_module::instance($forum1->cmid)->id,
403
            'component' => 'mod_forum',
404
            'filearea'  => 'attachment',
405
            'itemid'    => $post->id,
406
            'filepath'  => '/',
407
            'filename'  => 'myfile1'
408
        );
409
        $file1 = $fs->create_file_from_string($filerecord, 'Some contents 1');
410
        $filerecord['filename'] = 'myfile2';
411
        $file2 = $fs->create_file_from_string($filerecord, 'Some contents 2');
412
 
413
        // Create post1 in discussion1.
414
        $record = new \stdClass();
415
        $record->discussion = $discussion1->id;
416
        $record->parent = $discussion1->firstpost;
417
        $record->userid = $user2->id;
418
        $record->message = 'post2';
419
        $record->attachemt = 1;
420
        $discussion1reply1 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_post($record);
421
 
422
        $filerecord['itemid'] = $discussion1reply1->id;
423
        $filerecord['filename'] = 'myfile3';
424
        $file3 = $fs->create_file_from_string($filerecord, 'Some contents 3');
425
 
426
        // Create post2 in discussion1.
427
        $record = new \stdClass();
428
        $record->discussion = $discussion1->id;
429
        $record->parent = $discussion1->firstpost;
430
        $record->userid = $user2->id;
431
        $record->message = 'post3';
432
        $discussion1reply2 = self::getDataGenerator()->get_plugin_generator('mod_forum')->create_post($record);
433
 
434
        // Now get all the posts and see if they have the right files attached.
435
        $searcharea = \core_search\manager::get_search_area($this->forumpostareaid);
436
        $recordset = $searcharea->get_recordset_by_timestamp(0);
437
        $nrecords = 0;
438
        foreach ($recordset as $record) {
439
            $doc = $searcharea->get_document($record);
440
            $searcharea->attach_files($doc);
441
            $files = $doc->get_files();
442
            // Now check that each doc has the right files on it.
443
            switch ($doc->get('itemid')) {
444
                case ($post->id):
445
                    $this->assertCount(2, $files);
446
                    $this->assertEquals($file1->get_id(), $files[$file1->get_id()]->get_id());
447
                    $this->assertEquals($file2->get_id(), $files[$file2->get_id()]->get_id());
448
                    break;
449
                case ($discussion1reply1->id):
450
                    $this->assertCount(1, $files);
451
                    $this->assertEquals($file3->get_id(), $files[$file3->get_id()]->get_id());
452
                    break;
453
                case ($discussion1reply2->id):
454
                    $this->assertCount(0, $files);
455
                    break;
456
                default:
457
                    $this->fail('Unexpected post returned');
458
                    break;
459
            }
460
            $nrecords++;
461
        }
462
        $recordset->close();
463
        $this->assertEquals(3, $nrecords);
464
    }
465
 
466
    /**
467
     * Tests that reindexing works in order starting from the forum with most recent discussion.
468
     */
11 efrain 469
    public function test_posts_get_contexts_to_reindex(): void {
1 efrain 470
        global $DB;
471
 
472
        $generator = $this->getDataGenerator();
473
        $adminuser = get_admin();
474
 
475
        $course1 = $generator->create_course();
476
        $course2 = $generator->create_course();
477
 
478
        $time = time() - 1000;
479
 
480
        // Create 3 forums (two in course 1, one in course 2 - doesn't make a difference).
481
        $forum1 = $generator->create_module('forum', ['course' => $course1->id]);
482
        $forum2 = $generator->create_module('forum', ['course' => $course1->id]);
483
        $forum3 = $generator->create_module('forum', ['course' => $course2->id]);
484
        $forum4 = $generator->create_module('forum', ['course' => $course2->id]);
485
 
486
        // Hack added time for the course_modules entries. These should not be used (they would
487
        // be used by the base class implementation). We are setting this so that the order would
488
        // be 4, 3, 2, 1 if this ordering were used (newest first).
489
        $DB->set_field('course_modules', 'added', $time + 100, ['id' => $forum1->cmid]);
490
        $DB->set_field('course_modules', 'added', $time + 110, ['id' => $forum2->cmid]);
491
        $DB->set_field('course_modules', 'added', $time + 120, ['id' => $forum3->cmid]);
492
        $DB->set_field('course_modules', 'added', $time + 130, ['id' => $forum4->cmid]);
493
 
494
        $forumgenerator = $generator->get_plugin_generator('mod_forum');
495
 
496
        // Create one discussion in forums 1 and 3, three in forum 2, and none in forum 4.
497
        $forumgenerator->create_discussion(['course' => $course1->id,
498
                'forum' => $forum1->id, 'userid' => $adminuser->id, 'timemodified' => $time + 20]);
499
 
500
        $forumgenerator->create_discussion(['course' => $course1->id,
501
                'forum' => $forum2->id, 'userid' => $adminuser->id, 'timemodified' => $time + 10]);
502
        $forumgenerator->create_discussion(['course' => $course1->id,
503
                'forum' => $forum2->id, 'userid' => $adminuser->id, 'timemodified' => $time + 30]);
504
        $forumgenerator->create_discussion(['course' => $course1->id,
505
                'forum' => $forum2->id, 'userid' => $adminuser->id, 'timemodified' => $time + 11]);
506
 
507
        $forumgenerator->create_discussion(['course' => $course2->id,
508
                'forum' => $forum3->id, 'userid' => $adminuser->id, 'timemodified' => $time + 25]);
509
 
510
        // Get the contexts in reindex order.
511
        $area = \core_search\manager::get_search_area($this->forumpostareaid);
512
        $contexts = iterator_to_array($area->get_contexts_to_reindex(), false);
513
 
514
        // We expect them in order of newest discussion. Forum 4 is not included at all (which is
515
        // correct because it has no content).
516
        $expected = [
517
            \context_module::instance($forum2->cmid),
518
            \context_module::instance($forum3->cmid),
519
            \context_module::instance($forum1->cmid)
520
        ];
521
        $this->assertEquals($expected, $contexts);
522
    }
523
}