Proyectos de Subversion Moodle

Rev

Rev 1 | | Comparar con el anterior | Ultima modificación | Ver Log |

Rev Autor Línea Nro. Línea
1 efrain 1
<?php
2
// This file is part of Moodle - http://moodle.org/
3
//
4
// Moodle is free software: you can redistribute it and/or modify
5
// it under the terms of the GNU General Public License as published by
6
// the Free Software Foundation, either version 3 of the License, or
7
// (at your option) any later version.
8
//
9
// Moodle is distributed in the hope that it will be useful,
10
// but WITHOUT ANY WARRANTY; without even the implied warranty of
11
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
12
// GNU General Public License for more details.
13
//
14
// You should have received a copy of the GNU General Public License
15
// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
16
 
17
namespace mod_feedback\external;
18
 
19
use core_external\external_api;
20
use externallib_advanced_testcase;
21
use feedback_item_multichoice;
22
use mod_feedback_external;
23
use moodle_exception;
24
 
25
defined('MOODLE_INTERNAL') || die();
26
 
27
global $CFG;
28
 
29
require_once($CFG->dirroot . '/webservice/tests/helpers.php');
30
require_once($CFG->dirroot . '/mod/feedback/lib.php');
31
 
32
/**
33
 * Feedback module external functions tests
34
 *
35
 * @package    mod_feedback
36
 * @category   external
37
 * @copyright  2017 Juan Leyva <juan@moodle.com>
38
 * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
39
 * @since      Moodle 3.3
40
 * @covers     \mod_feedback_external
41
 */
11 efrain 42
final class external_test extends externallib_advanced_testcase {
1 efrain 43
 
44
    // TODO These should be removed.
45
    // Testcase classes should not have any properties or store state.
46
    protected $course;
47
    protected $feedback;
48
    protected $context;
49
    protected $cm;
50
    protected $student;
51
    protected $teacher;
52
    protected $studentrole;
53
    protected $teacherrole;
54
 
55
    /**
56
     * Set up for every test
57
     */
58
    public function setUp(): void {
59
        global $DB;
60
        $this->resetAfterTest();
61
        $this->setAdminUser();
62
 
63
        // Setup test data.
64
        $this->course = $this->getDataGenerator()->create_course();
65
        $this->feedback = $this->getDataGenerator()->create_module('feedback',
66
            array('course' => $this->course->id, 'email_notification' => 1));
67
        $this->context = \context_module::instance($this->feedback->cmid);
68
        $this->cm = get_coursemodule_from_instance('feedback', $this->feedback->id);
69
 
70
        // Create users.
71
        $this->student = self::getDataGenerator()->create_user();
72
        $this->teacher = self::getDataGenerator()->create_user();
73
 
74
        // Users enrolments.
75
        $this->studentrole = $DB->get_record('role', array('shortname' => 'student'));
76
        $this->teacherrole = $DB->get_record('role', array('shortname' => 'editingteacher'));
77
        $this->getDataGenerator()->enrol_user($this->student->id, $this->course->id, $this->studentrole->id, 'manual');
78
        $this->getDataGenerator()->enrol_user($this->teacher->id, $this->course->id, $this->teacherrole->id, 'manual');
79
    }
80
 
81
    /**
82
     * Helper method to add items to an existing feedback.
83
     *
84
     * @param \stdClass $feedback feedback instance
85
     * @param integer $pagescount the number of pages we want in the feedback
86
     * @return array list of items created
87
     */
88
    public function populate_feedback($feedback, $pagescount = 1) {
89
        $feedbackgenerator = $this->getDataGenerator()->get_plugin_generator('mod_feedback');
90
        $itemscreated = [];
91
 
92
        // Create at least one page.
93
        $itemscreated[] = $feedbackgenerator->create_item_label($feedback);
94
        $itemscreated[] = $feedbackgenerator->create_item_info($feedback);
95
        $itemscreated[] = $feedbackgenerator->create_item_numeric($feedback);
96
 
97
        // Check if we want more pages.
98
        for ($i = 1; $i < $pagescount; $i++) {
99
            $itemscreated[] = $feedbackgenerator->create_item_pagebreak($feedback);
100
            $itemscreated[] = $feedbackgenerator->create_item_multichoice($feedback);
101
            $itemscreated[] = $feedbackgenerator->create_item_multichoicerated($feedback);
102
            $itemscreated[] = $feedbackgenerator->create_item_textarea($feedback);
103
            $itemscreated[] = $feedbackgenerator->create_item_textfield($feedback);
104
            $itemscreated[] = $feedbackgenerator->create_item_numeric($feedback);
105
        }
106
        return $itemscreated;
107
    }
108
 
109
 
110
    /**
111
     * Test test_mod_feedback_get_feedbacks_by_courses
112
     */
11 efrain 113
    public function test_mod_feedback_get_feedbacks_by_courses(): void {
1 efrain 114
 
115
        // Create additional course.
116
        $course2 = self::getDataGenerator()->create_course();
117
 
118
        // Second feedback.
119
        $record = new \stdClass();
120
        $record->course = $course2->id;
121
        $feedback2 = self::getDataGenerator()->create_module('feedback', $record);
122
 
123
        // Execute real Moodle enrolment as we'll call unenrol() method on the instance later.
124
        $enrol = enrol_get_plugin('manual');
125
        $enrolinstances = enrol_get_instances($course2->id, true);
126
        $instance2 = (object) [];
127
        foreach ($enrolinstances as $courseenrolinstance) {
128
            if ($courseenrolinstance->enrol == "manual") {
129
                $instance2 = $courseenrolinstance;
130
                break;
131
            }
132
        }
133
 
134
        $enrol->enrol_user($instance2, $this->student->id, $this->studentrole->id);
135
 
136
        self::setUser($this->student);
137
 
138
        $returndescription = mod_feedback_external::get_feedbacks_by_courses_returns();
139
 
140
        // Create what we expect to be returned when querying the two courses.
141
        // First for the student user.
142
        $expectedfields = array('id', 'coursemodule', 'course', 'name', 'intro', 'introformat', 'introfiles', 'lang', 'anonymous',
143
            'multiple_submit', 'autonumbering', 'page_after_submitformat', 'publish_stats', 'completionsubmit');
144
 
145
        $properties = feedback_summary_exporter::read_properties_definition();
146
 
147
        // Add expected coursemodule and data.
148
        $feedback1 = $this->feedback;
149
        $feedback1->coursemodule = $feedback1->cmid;
150
        $feedback1->introformat = 1;
151
        $feedback1->introfiles = [];
152
        $feedback1->lang = '';
153
 
154
        $feedback2->coursemodule = $feedback2->cmid;
155
        $feedback2->introformat = 1;
156
        $feedback2->introfiles = [];
157
        $feedback2->lang = '';
158
 
159
        foreach ($expectedfields as $field) {
160
            if (!empty($properties[$field]) && $properties[$field]['type'] == PARAM_BOOL) {
161
                $feedback1->{$field} = (bool) $feedback1->{$field};
162
                $feedback2->{$field} = (bool) $feedback2->{$field};
163
            }
164
            $expected1[$field] = $feedback1->{$field};
165
            $expected2[$field] = $feedback2->{$field};
166
        }
167
 
168
        $expectedfeedbacks = array($expected2, $expected1);
169
 
170
        // Call the external function passing course ids.
171
        $result = mod_feedback_external::get_feedbacks_by_courses(array($course2->id, $this->course->id));
172
        $result = external_api::clean_returnvalue($returndescription, $result);
173
 
174
        $this->assertEquals($expectedfeedbacks, $result['feedbacks']);
175
        $this->assertCount(0, $result['warnings']);
176
 
177
        // Call the external function without passing course id.
178
        $result = mod_feedback_external::get_feedbacks_by_courses();
179
        $result = external_api::clean_returnvalue($returndescription, $result);
180
        $this->assertEquals($expectedfeedbacks, $result['feedbacks']);
181
        $this->assertCount(0, $result['warnings']);
182
 
183
        // Unenrol user from second course and alter expected feedbacks.
184
        $enrol->unenrol_user($instance2, $this->student->id);
185
        array_shift($expectedfeedbacks);
186
 
187
        // Call the external function without passing course id.
188
        $result = mod_feedback_external::get_feedbacks_by_courses();
189
        $result = external_api::clean_returnvalue($returndescription, $result);
190
        $this->assertEquals($expectedfeedbacks, $result['feedbacks']);
191
 
192
        // Call for the second course we unenrolled the user from, expected warning.
193
        $result = mod_feedback_external::get_feedbacks_by_courses(array($course2->id));
194
        $this->assertCount(1, $result['warnings']);
195
        $this->assertEquals('1', $result['warnings'][0]['warningcode']);
196
        $this->assertEquals($course2->id, $result['warnings'][0]['itemid']);
197
 
198
        // Now, try as a teacher for getting all the additional fields.
199
        self::setUser($this->teacher);
200
 
201
        $additionalfields = array('email_notification', 'site_after_submit', 'page_after_submit', 'timeopen', 'timeclose',
202
            'timemodified', 'pageaftersubmitfiles');
203
 
204
        $feedback1->pageaftersubmitfiles = [];
205
 
206
        foreach ($additionalfields as $field) {
207
            if (!empty($properties[$field]) && $properties[$field]['type'] == PARAM_BOOL) {
208
                $feedback1->{$field} = (bool) $feedback1->{$field};
209
            }
210
            $expectedfeedbacks[0][$field] = $feedback1->{$field};
211
        }
212
        $expectedfeedbacks[0]['page_after_submitformat'] = 1;
213
 
214
        $result = mod_feedback_external::get_feedbacks_by_courses();
215
        $result = external_api::clean_returnvalue($returndescription, $result);
216
        $this->assertEquals($expectedfeedbacks, $result['feedbacks']);
217
 
218
        // Admin also should get all the information.
219
        self::setAdminUser();
220
 
221
        $result = mod_feedback_external::get_feedbacks_by_courses(array($this->course->id));
222
        $result = external_api::clean_returnvalue($returndescription, $result);
223
        $this->assertEquals($expectedfeedbacks, $result['feedbacks']);
224
    }
225
 
226
    /**
227
     * Test get_feedback_access_information function with basic defaults for student.
228
     */
11 efrain 229
    public function test_get_feedback_access_information_student(): void {
1 efrain 230
 
231
        self::setUser($this->student);
232
        $result = mod_feedback_external::get_feedback_access_information($this->feedback->id);
233
        $result = external_api::clean_returnvalue(mod_feedback_external::get_feedback_access_information_returns(), $result);
234
 
235
        $this->assertFalse($result['canviewanalysis']);
236
        $this->assertFalse($result['candeletesubmissions']);
237
        $this->assertFalse($result['canviewreports']);
238
        $this->assertFalse($result['canedititems']);
239
        $this->assertTrue($result['cancomplete']);
240
        $this->assertTrue($result['cansubmit']);
241
        $this->assertTrue($result['isempty']);
242
        $this->assertTrue($result['isopen']);
243
        $this->assertTrue($result['isanonymous']);
244
        $this->assertFalse($result['isalreadysubmitted']);
245
    }
246
 
247
    /**
248
     * Test get_feedback_access_information function with basic defaults for teacher.
249
     */
11 efrain 250
    public function test_get_feedback_access_information_teacher(): void {
1 efrain 251
 
252
        self::setUser($this->teacher);
253
        $result = mod_feedback_external::get_feedback_access_information($this->feedback->id);
254
        $result = external_api::clean_returnvalue(mod_feedback_external::get_feedback_access_information_returns(), $result);
255
 
256
        $this->assertTrue($result['canviewanalysis']);
257
        $this->assertTrue($result['canviewreports']);
258
        $this->assertTrue($result['canedititems']);
259
        $this->assertTrue($result['candeletesubmissions']);
260
        $this->assertFalse($result['cancomplete']);
261
        $this->assertTrue($result['cansubmit']);
262
        $this->assertTrue($result['isempty']);
263
        $this->assertTrue($result['isopen']);
264
        $this->assertTrue($result['isanonymous']);
265
        $this->assertFalse($result['isalreadysubmitted']);
266
 
267
        // Add some items to the feedback and check is not empty any more.
268
        self::populate_feedback($this->feedback);
269
        $result = mod_feedback_external::get_feedback_access_information($this->feedback->id);
270
        $result = external_api::clean_returnvalue(mod_feedback_external::get_feedback_access_information_returns(), $result);
271
        $this->assertFalse($result['isempty']);
272
    }
273
 
274
    /**
275
     * Test view_feedback invalid id.
276
     */
11 efrain 277
    public function test_view_feedback_invalid_id(): void {
1 efrain 278
        // Test invalid instance id.
279
        $this->expectException(moodle_exception::class);
280
        mod_feedback_external::view_feedback(0);
281
    }
282
    /**
283
     * Test view_feedback not enrolled user.
284
     */
11 efrain 285
    public function test_view_feedback_not_enrolled_user(): void {
1 efrain 286
        $usernotenrolled = self::getDataGenerator()->create_user();
287
        $this->setUser($usernotenrolled);
288
        $this->expectException(moodle_exception::class);
289
        mod_feedback_external::view_feedback(0);
290
    }
291
    /**
292
     * Test view_feedback no capabilities.
293
     */
11 efrain 294
    public function test_view_feedback_no_capabilities(): void {
1 efrain 295
        // Test user with no capabilities.
296
        // We need a explicit prohibit since this capability is allowed for students by default.
297
        assign_capability('mod/feedback:view', CAP_PROHIBIT, $this->studentrole->id, $this->context->id);
298
        accesslib_clear_all_caches_for_unit_testing();
299
        $this->expectException(moodle_exception::class);
300
        mod_feedback_external::view_feedback(0);
301
    }
302
    /**
303
     * Test view_feedback.
304
     */
11 efrain 305
    public function test_view_feedback(): void {
1 efrain 306
        // Test user with full capabilities.
307
        $this->setUser($this->student);
308
        // Trigger and capture the event.
309
        $sink = $this->redirectEvents();
310
        $result = mod_feedback_external::view_feedback($this->feedback->id);
311
        $result = external_api::clean_returnvalue(mod_feedback_external::view_feedback_returns(), $result);
312
        $events = $sink->get_events();
313
        $this->assertCount(1, $events);
314
        $event = array_shift($events);
315
        // Checking that the event contains the expected values.
316
        $this->assertInstanceOf('\mod_feedback\event\course_module_viewed', $event);
317
        $this->assertEquals($this->context, $event->get_context());
318
        $moodledata = new \moodle_url('/mod/feedback/view.php', array('id' => $this->cm->id));
319
        $this->assertEquals($moodledata, $event->get_url());
320
        $this->assertEventContextNotUsed($event);
321
        $this->assertNotEmpty($event->get_name());
322
    }
323
 
324
    /**
325
     * Test get_current_completed_tmp.
326
     */
11 efrain 327
    public function test_get_current_completed_tmp(): void {
1 efrain 328
        global $DB;
329
 
330
        // Force non anonymous.
331
        $DB->set_field('feedback', 'anonymous', FEEDBACK_ANONYMOUS_NO, array('id' => $this->feedback->id));
332
        // Add a completed_tmp record.
333
        $record = [
334
            'feedback' => $this->feedback->id,
335
            'userid' => $this->student->id,
336
            'guestid' => '',
337
            'timemodified' => time() - DAYSECS,
338
            'random_response' => 0,
339
            'anonymous_response' => FEEDBACK_ANONYMOUS_NO,
340
            'courseid' => $this->course->id,
341
        ];
342
        $record['id'] = $DB->insert_record('feedback_completedtmp', (object) $record);
343
 
344
        // Test user with full capabilities.
345
        $this->setUser($this->student);
346
 
347
        $result = mod_feedback_external::get_current_completed_tmp($this->feedback->id);
348
        $result = external_api::clean_returnvalue(mod_feedback_external::get_current_completed_tmp_returns(), $result);
349
        $this->assertEquals($record['id'], $result['feedback']['id']);
350
    }
351
 
352
    /**
353
     * Test get_items.
354
     */
11 efrain 355
    public function test_get_items(): void {
1 efrain 356
        // Test user with full capabilities.
357
        $this->setUser($this->student);
358
 
359
        // Add questions to the feedback, we are adding 2 pages of questions.
360
        $itemscreated = self::populate_feedback($this->feedback, 2);
361
 
362
        $result = mod_feedback_external::get_items($this->feedback->id);
363
        $result = external_api::clean_returnvalue(mod_feedback_external::get_items_returns(), $result);
364
        $this->assertCount(count($itemscreated), $result['items']);
365
        $index = 1;
366
        foreach ($result['items'] as $key => $item) {
367
            if (is_numeric($itemscreated[$key])) {
368
                continue; // Page break.
369
            }
370
            // Cannot compare directly the exporter and the db object (exporter have more fields).
371
            $this->assertEquals($itemscreated[$key]->id, $item['id']);
372
            $this->assertEquals($itemscreated[$key]->typ, $item['typ']);
373
            $this->assertEquals($itemscreated[$key]->name, $item['name']);
374
            $this->assertEquals($itemscreated[$key]->label, $item['label']);
375
 
376
            if ($item['hasvalue']) {
377
                $this->assertEquals($index, $item['itemnumber']);
378
                $index++;
379
            }
380
        }
381
    }
382
 
383
    /**
384
     * Test get_items, to confirm validation is done too.
385
     *
386
     * @dataProvider items_provider
387
     * @param string $role Whether the current user should be a student or a teacher.
388
     * @param array $info Settings to create the feedback.
389
     * @param string|null $warning The warning message to display or null if warnings result is empty.
390
     */
391
    public function test_get_items_validation(string $role, array $info, ?string $warning): void {
392
        global $DB;
393
 
394
        // Test user with full capabilities.
395
        if ($role === 'teacher') {
396
            $this->setUser($this->teacher);
397
        } else {
398
            $this->setUser($this->student);
399
        }
400
 
401
        // Create the feedback.
402
        $data = ['course' => $this->course->id];
403
        if (array_key_exists('closed', $info) && $info['closed']) {
404
            $data['timeopen'] = time() + DAYSECS;
405
        }
406
        $feedback = $this->getDataGenerator()->create_module('feedback', $data);
407
 
408
        $empty = true;
409
        if (!array_key_exists('empty', $info) || !$info['empty']) {
410
            $empty = false;
411
            /** @var \mod_feedback_generator $feedbackgenerator */
412
            $feedbackgenerator = $this->getDataGenerator()->get_plugin_generator('mod_feedback');
413
            // Add,at least, one item to the feedback.
414
            $feedbackgenerator->create_item_label($feedback);
415
        }
416
 
417
        if (array_key_exists('complete', $info) && !$info['complete']) {
418
            $studentrole = $DB->get_record('role', array('shortname' => 'student'));
419
            $coursecontext = \context_course::instance($this->course->id);
420
            assign_capability('mod/feedback:complete', CAP_PROHIBIT, $studentrole->id, $coursecontext->id);
421
            // Empty all the caches that may be affected by this change.
422
            accesslib_clear_all_caches_for_unit_testing();
423
            \course_modinfo::clear_instance_cache();
424
        }
425
 
426
        $result = mod_feedback_external::get_items($feedback->id);
427
        $result = external_api::clean_returnvalue(mod_feedback_external::get_items_returns(), $result);
428
        if ($warning) {
429
            $this->assertEmpty($result['items']);
430
            $this->assertCount(1, $result['warnings']);
431
            $resultwarning = reset($result['warnings']);
432
            if ($warning == 'required_capability_exception') {
433
                $this->assertStringContainsString('error/nopermission', $resultwarning['message']);
434
            } else {
435
                $this->assertEquals($warning, $resultwarning['message']);
436
            }
437
        } else {
438
            if ($empty) {
439
                $this->assertEmpty($result['items']);
440
            } else {
441
                $this->assertCount(1, $result['items']);
442
            }
443
            $this->assertEmpty($result['warnings']);
444
        }
445
    }
446
 
447
    /**
448
     * Data provider for test_get_items_validation() and test_get_page_items_validation().
449
     *
450
     * @return array
451
     */
11 efrain 452
    public static function items_provider(): array {
1 efrain 453
        return [
454
            'Valid feedback (as student)' => [
455
                'role' => 'student',
456
                'info' => [],
457
                'warning' => null,
458
            ],
459
            'Closed feedback (as student)' => [
460
                'role' => 'student',
461
                'info' => ['closed' => true],
462
                'warning' => get_string('feedback_is_not_open', 'feedback'),
463
            ],
464
            'Empty feedback (as student)' => [
465
                'role' => 'student',
466
                'info' => ['empty' => true],
467
                'warning' => get_string('no_items_available_yet', 'feedback'),
468
            ],
469
            'Cannot complete feedback (as student)' => [
470
                'role' => 'student',
471
                'info' => ['complete' => false],
472
                'warning' => 'required_capability_exception',
473
            ],
474
            'Valid feedback (as teacher)' => [
475
                'role' => 'teacher',
476
                'info' => [],
477
                'warning' => null,
478
            ],
479
            'Closed feedback (as teacher)' => [
480
                'role' => 'teacher',
481
                'info' => ['closed' => true],
482
                'warning' => null,
483
            ],
484
            'Empty feedback (as teacher)' => [
485
                'role' => 'teacher',
486
                'info' => ['empty' => true],
487
                'warning' => null,
488
            ],
489
            'Cannot complete feedback (as teacher)' => [
490
                'role' => 'teacher',
491
                'info' => ['complete' => false],
492
                'warning' => null,
493
            ],
494
        ];
495
    }
496
 
497
    /**
498
     * Test launch_feedback.
499
     */
11 efrain 500
    public function test_launch_feedback(): void {
1 efrain 501
        global $DB;
502
 
503
        // Test user with full capabilities.
504
        $this->setUser($this->student);
505
 
506
        // Add questions to the feedback, we are adding 2 pages of questions.
507
        $itemscreated = self::populate_feedback($this->feedback, 2);
508
 
509
        // First try a feedback we didn't attempt.
510
        $result = mod_feedback_external::launch_feedback($this->feedback->id);
511
        $result = external_api::clean_returnvalue(mod_feedback_external::launch_feedback_returns(), $result);
512
        $this->assertEquals(0, $result['gopage']);
513
 
514
        // Now, try a feedback that we attempted.
515
        // Force non anonymous.
516
        $DB->set_field('feedback', 'anonymous', FEEDBACK_ANONYMOUS_NO, array('id' => $this->feedback->id));
517
        // Add a completed_tmp record.
518
        $record = [
519
            'feedback' => $this->feedback->id,
520
            'userid' => $this->student->id,
521
            'guestid' => '',
522
            'timemodified' => time() - DAYSECS,
523
            'random_response' => 0,
524
            'anonymous_response' => FEEDBACK_ANONYMOUS_NO,
525
            'courseid' => $this->course->id,
526
        ];
527
        $record['id'] = $DB->insert_record('feedback_completedtmp', (object) $record);
528
 
529
        // Add a response to the feedback for each question type with possible values.
530
        $response = [
531
            'course_id' => $this->course->id,
532
            'item' => $itemscreated[1]->id, // First item is the info question.
533
            'completed' => $record['id'],
534
            'tmp_completed' => $record['id'],
535
            'value' => 'A',
536
        ];
537
        $DB->insert_record('feedback_valuetmp', (object) $response);
538
        $response = [
539
            'course_id' => $this->course->id,
540
            'item' => $itemscreated[2]->id, // Second item is the numeric question.
541
            'completed' => $record['id'],
542
            'tmp_completed' => $record['id'],
543
            'value' => 5,
544
        ];
545
        $DB->insert_record('feedback_valuetmp', (object) $response);
546
 
547
        $result = mod_feedback_external::launch_feedback($this->feedback->id);
548
        $result = external_api::clean_returnvalue(mod_feedback_external::launch_feedback_returns(), $result);
549
        $this->assertEquals(1, $result['gopage']);
550
    }
551
 
552
    /**
553
     * Test get_page_items.
554
     */
11 efrain 555
    public function test_get_page_items(): void {
1 efrain 556
        // Test user with full capabilities.
557
        $this->setUser($this->student);
558
 
559
        // Add questions to the feedback, we are adding 2 pages of questions.
560
        $itemscreated = self::populate_feedback($this->feedback, 2);
561
 
562
        // Retrieve first page.
563
        $result = mod_feedback_external::get_page_items($this->feedback->id, 0);
564
        $result = external_api::clean_returnvalue(mod_feedback_external::get_page_items_returns(), $result);
565
        $this->assertCount(3, $result['items']);    // The first page has 3 items.
566
        $this->assertTrue($result['hasnextpage']);
567
        $this->assertFalse($result['hasprevpage']);
568
 
569
        // Retrieve second page.
570
        $result = mod_feedback_external::get_page_items($this->feedback->id, 1);
571
        $result = external_api::clean_returnvalue(mod_feedback_external::get_page_items_returns(), $result);
572
        $this->assertCount(5, $result['items']);    // The second page has 5 items (page break doesn't count).
573
        $this->assertFalse($result['hasnextpage']);
574
        $this->assertTrue($result['hasprevpage']);
575
    }
576
 
577
    /**
578
     * Test get_page_items, to confirm validation is done too.
579
     *
580
     * @dataProvider items_provider
581
     * @param string $role Whether the current user should be a student or a teacher.
582
     * @param array $info Settings to create the feedback.
583
     * @param string|null $warning The warning message to display or null if warnings result is empty.
584
     */
585
    public function test_get_page_items_validation(string $role, array $info, ?string $warning): void {
586
        global $DB;
587
 
588
        // Test user with full capabilities.
589
        if ($role === 'teacher') {
590
            $this->setUser($this->teacher);
591
        } else {
592
            $this->setUser($this->student);
593
        }
594
 
595
        // Create the feedback.
596
        $data = ['course' => $this->course->id];
597
        if (array_key_exists('closed', $info) && $info['closed']) {
598
            $data['timeopen'] = time() + DAYSECS;
599
        }
600
        $feedback = $this->getDataGenerator()->create_module('feedback', $data);
601
 
602
        $empty = true;
603
        if (!array_key_exists('empty', $info) || !$info['empty']) {
604
            $empty = false;
605
            /** @var \mod_feedback_generator $feedbackgenerator */
606
            $feedbackgenerator = $this->getDataGenerator()->get_plugin_generator('mod_feedback');
607
            // Add,at least, one item to the feedback.
608
            $feedbackgenerator->create_item_label($feedback);
609
        }
610
 
611
        if (array_key_exists('complete', $info) && !$info['complete']) {
612
            $studentrole = $DB->get_record('role', array('shortname' => 'student'));
613
            $coursecontext = \context_course::instance($this->course->id);
614
            assign_capability('mod/feedback:complete', CAP_PROHIBIT, $studentrole->id, $coursecontext->id);
615
            // Empty all the caches that may be affected by this change.
616
            accesslib_clear_all_caches_for_unit_testing();
617
            \course_modinfo::clear_instance_cache();
618
        }
619
 
620
        $result = mod_feedback_external::get_page_items($feedback->id, 0);
621
        $result = external_api::clean_returnvalue(mod_feedback_external::get_items_returns(), $result);
622
        if ($warning) {
623
            $this->assertEmpty($result['items']);
624
            $this->assertCount(1, $result['warnings']);
625
            $resultwarning = reset($result['warnings']);
626
            if ($warning == 'required_capability_exception') {
627
                $this->assertStringContainsString('error/nopermission', $resultwarning['message']);
628
            } else {
629
                $this->assertEquals($warning, $resultwarning['message']);
630
            }
631
        } else {
632
            if ($empty) {
633
                $this->assertEmpty($result['items']);
634
            } else {
635
                $this->assertCount(1, $result['items']);
636
            }
637
            $this->assertEmpty($result['warnings']);
638
        }
639
    }
640
 
641
    /**
642
     * Test process_page.
643
     */
11 efrain 644
    public function test_process_page(): void {
1 efrain 645
        global $DB;
646
 
647
        // Test user with full capabilities.
648
        $this->setUser($this->student);
649
        $pagecontents = 'You finished it!';
650
        $DB->set_field('feedback', 'page_after_submit', $pagecontents, array('id' => $this->feedback->id));
651
 
652
        // Add questions to the feedback, we are adding 2 pages of questions.
653
        $itemscreated = self::populate_feedback($this->feedback, 2);
654
 
655
        $data = [];
656
        foreach ($itemscreated as $item) {
657
 
658
            if (empty($item->hasvalue)) {
659
                continue;
660
            }
661
 
662
            switch ($item->typ) {
663
                case 'textarea':
664
                case 'textfield':
665
                    $value = 'Lorem ipsum';
666
                    break;
667
                case 'numeric':
668
                    $value = 5;
669
                    break;
670
                case 'multichoice':
671
                    $value = '1';
672
                    break;
673
                case 'multichoicerated':
674
                    $value = '1';
675
                    break;
676
                case 'info':
677
                    $value = format_string($this->course->shortname, true, array('context' => $this->context));
678
                    break;
679
                default:
680
                    $value = '';
681
            }
682
            $data[] = ['name' => $item->typ . '_' . $item->id, 'value' => $value];
683
        }
684
 
685
        // Process first page.
686
        $firstpagedata = [$data[0], $data[1]];
687
        $result = mod_feedback_external::process_page($this->feedback->id, 0, $firstpagedata);
688
        $result = external_api::clean_returnvalue(mod_feedback_external::process_page_returns(), $result);
689
        $this->assertEquals(1, $result['jumpto']);
690
        $this->assertFalse($result['completed']);
691
 
692
        // Now, process the second page. But first we are going back to the first page.
693
        $secondpagedata = [$data[2], $data[3], $data[4], $data[5], $data[6]];
694
        $result = mod_feedback_external::process_page($this->feedback->id, 1, $secondpagedata, true);
695
        $result = external_api::clean_returnvalue(mod_feedback_external::process_page_returns(), $result);
696
        $this->assertFalse($result['completed']);
697
        $this->assertEquals(0, $result['jumpto']);  // We jumped to the first page.
698
        // Check the values were correctly saved.
699
        $tmpitems = $DB->get_records('feedback_valuetmp');
700
        $this->assertCount(7, $tmpitems);   // 2 from the first page + 5 from the second page.
701
 
702
        // Go forward again (sending the same data).
703
        $result = mod_feedback_external::process_page($this->feedback->id, 0, $firstpagedata);
704
        $result = external_api::clean_returnvalue(mod_feedback_external::process_page_returns(), $result);
705
        $this->assertEquals(1, $result['jumpto']);
706
        $this->assertFalse($result['completed']);
707
        $tmpitems = $DB->get_records('feedback_valuetmp');
708
        $this->assertCount(7, $tmpitems);   // 2 from the first page + 5 from the second page.
709
 
710
        // And finally, save everything! We are going to modify one previous recorded value.
711
        $messagessink = $this->redirectMessages();
712
        $data[2]['value'] = 2; // 2 is value of the option 'b'.
713
        $secondpagedata = [$data[2], $data[3], $data[4], $data[5], $data[6]];
714
        $result = mod_feedback_external::process_page($this->feedback->id, 1, $secondpagedata);
715
        $result = external_api::clean_returnvalue(mod_feedback_external::process_page_returns(), $result);
716
        $this->assertTrue($result['completed']);
717
        $this->assertTrue(strpos($result['completionpagecontents'], $pagecontents) !== false);
718
        // Check all the items were saved.
719
        $items = $DB->get_records('feedback_value');
720
        $this->assertCount(7, $items);
721
        // Check if the one we modified was correctly saved.
722
        $itemid = $itemscreated[4]->id;
723
        $itemsaved = $DB->get_field('feedback_value', 'value', array('item' => $itemid));
724
        $mcitem = new feedback_item_multichoice();
725
        $itemval = $mcitem->get_printval($itemscreated[4], (object) ['value' => $itemsaved]);
726
        $this->assertEquals('b', $itemval);
727
 
728
        // Check that the answers are saved for course 0.
729
        foreach ($items as $item) {
730
            $this->assertEquals(0, $item->course_id);
731
        }
732
        $completed = $DB->get_record('feedback_completed', []);
733
        $this->assertEquals(0, $completed->courseid);
734
 
735
        // Test notifications sent.
736
        $messages = $messagessink->get_messages();
737
        $messagessink->close();
738
        // Test customdata.
739
        $customdata = json_decode($messages[0]->customdata);
740
        $this->assertEquals($this->feedback->id, $customdata->instance);
741
        $this->assertEquals($this->feedback->cmid, $customdata->cmid);
742
        $this->assertObjectHasProperty('notificationiconurl', $customdata);
743
    }
744
 
745
    /**
746
     * Test process_page for a site feedback.
747
     */
11 efrain 748
    public function test_process_page_site_feedback(): void {
1 efrain 749
        global $DB;
750
        $pagecontents = 'You finished it!';
751
        $this->feedback = $this->getDataGenerator()->create_module('feedback',
752
            array('course' => SITEID, 'page_after_submit' => $pagecontents));
753
 
754
        // Test user with full capabilities.
755
        $this->setUser($this->student);
756
 
757
        // Add questions to the feedback, we are adding 2 pages of questions.
758
        $itemscreated = self::populate_feedback($this->feedback, 2);
759
 
760
        $data = [];
761
        foreach ($itemscreated as $item) {
762
 
763
            if (empty($item->hasvalue)) {
764
                continue;
765
            }
766
 
767
            switch ($item->typ) {
768
                case 'textarea':
769
                case 'textfield':
770
                    $value = 'Lorem ipsum';
771
                    break;
772
                case 'numeric':
773
                    $value = 5;
774
                    break;
775
                case 'multichoice':
776
                    $value = '1';
777
                    break;
778
                case 'multichoicerated':
779
                    $value = '1';
780
                    break;
781
                case 'info':
782
                    $value = format_string($this->course->shortname, true, array('context' => $this->context));
783
                    break;
784
                default:
785
                    $value = '';
786
            }
787
            $data[] = ['name' => $item->typ . '_' . $item->id, 'value' => $value];
788
        }
789
 
790
        // Process first page.
791
        $firstpagedata = [$data[0], $data[1]];
792
        $result = mod_feedback_external::process_page($this->feedback->id, 0, $firstpagedata, false, $this->course->id);
793
        $result = external_api::clean_returnvalue(mod_feedback_external::process_page_returns(), $result);
794
        $this->assertEquals(1, $result['jumpto']);
795
        $this->assertFalse($result['completed']);
796
 
797
        // Process second page.
798
        $data[2]['value'] = 2; // 2 is value of the option 'b';
799
        $secondpagedata = [$data[2], $data[3], $data[4], $data[5], $data[6]];
800
        $result = mod_feedback_external::process_page($this->feedback->id, 1, $secondpagedata, false, $this->course->id);
801
        $result = external_api::clean_returnvalue(mod_feedback_external::process_page_returns(), $result);
802
        $this->assertTrue($result['completed']);
803
        $this->assertTrue(strpos($result['completionpagecontents'], $pagecontents) !== false);
804
        // Check all the items were saved.
805
        $items = $DB->get_records('feedback_value');
806
        $this->assertCount(7, $items);
807
        // Check if the one we modified was correctly saved.
808
        $itemid = $itemscreated[4]->id;
809
        $itemsaved = $DB->get_field('feedback_value', 'value', array('item' => $itemid));
810
        $mcitem = new feedback_item_multichoice();
811
        $itemval = $mcitem->get_printval($itemscreated[4], (object) ['value' => $itemsaved]);
812
        $this->assertEquals('b', $itemval);
813
 
814
        // Check that the answers are saved for the correct course.
815
        foreach ($items as $item) {
816
            $this->assertEquals($this->course->id, $item->course_id);
817
        }
818
        $completed = $DB->get_record('feedback_completed', []);
819
        $this->assertEquals($this->course->id, $completed->courseid);
820
    }
821
 
822
    /**
823
     * Test get_analysis.
824
     */
11 efrain 825
    public function test_get_analysis(): void {
1 efrain 826
        // Test user with full capabilities.
827
        $this->setUser($this->student);
828
 
829
        // Create a very simple feedback.
830
        $feedbackgenerator = $this->getDataGenerator()->get_plugin_generator('mod_feedback');
831
        $numericitem = $feedbackgenerator->create_item_numeric($this->feedback);
832
        $textfielditem = $feedbackgenerator->create_item_textfield($this->feedback);
833
 
834
        $pagedata = [
835
            ['name' => $numericitem->typ .'_'. $numericitem->id, 'value' => 5],
836
            ['name' => $textfielditem->typ .'_'. $textfielditem->id, 'value' => 'abc'],
837
        ];
838
        // Process the feedback, there is only one page so the feedback will be completed.
839
        $result = mod_feedback_external::process_page($this->feedback->id, 0, $pagedata);
840
        $result = external_api::clean_returnvalue(mod_feedback_external::process_page_returns(), $result);
841
        $this->assertTrue($result['completed']);
842
 
843
        // Retrieve analysis.
844
        $this->setUser($this->teacher);
845
        $result = mod_feedback_external::get_analysis($this->feedback->id);
846
        $result = external_api::clean_returnvalue(mod_feedback_external::get_analysis_returns(), $result);
847
        $this->assertEquals(1, $result['completedcount']);  // 1 feedback completed.
848
        $this->assertEquals(2, $result['itemscount']);  // 2 items in the feedback.
849
        $this->assertCount(2, $result['itemsdata']);
850
        $this->assertCount(1, $result['itemsdata'][0]['data']); // There are 1 response per item.
851
        $this->assertCount(1, $result['itemsdata'][1]['data']);
852
        // Check we receive the info the students filled.
853
        foreach ($result['itemsdata'] as $data) {
854
            if ($data['item']['id'] == $numericitem->id) {
855
                $this->assertEquals(5, $data['data'][0]);
856
            } else {
857
                $this->assertEquals('abc', $data['data'][0]);
858
            }
859
        }
860
 
861
        // Create another user / response.
862
        $anotherstudent = self::getDataGenerator()->create_user();
863
        $this->getDataGenerator()->enrol_user($anotherstudent->id, $this->course->id, $this->studentrole->id, 'manual');
864
        $this->setUser($anotherstudent);
865
 
866
        // Process the feedback, there is only one page so the feedback will be completed.
867
        $result = mod_feedback_external::process_page($this->feedback->id, 0, $pagedata);
868
        $result = external_api::clean_returnvalue(mod_feedback_external::process_page_returns(), $result);
869
        $this->assertTrue($result['completed']);
870
 
871
        // Retrieve analysis.
872
        $this->setUser($this->teacher);
873
        $result = mod_feedback_external::get_analysis($this->feedback->id);
874
        $result = external_api::clean_returnvalue(mod_feedback_external::get_analysis_returns(), $result);
875
        $this->assertEquals(2, $result['completedcount']);  // 2 feedback completed.
876
        $this->assertEquals(2, $result['itemscount']);
877
        $this->assertCount(2, $result['itemsdata'][0]['data']); // There are 2 responses per item.
878
        $this->assertCount(2, $result['itemsdata'][1]['data']);
879
    }
880
 
881
    /**
882
     * Test get_unfinished_responses.
883
     */
11 efrain 884
    public function test_get_unfinished_responses(): void {
1 efrain 885
        // Test user with full capabilities.
886
        $this->setUser($this->student);
887
 
888
        // Create a very simple feedback.
889
        $feedbackgenerator = $this->getDataGenerator()->get_plugin_generator('mod_feedback');
890
        $numericitem = $feedbackgenerator->create_item_numeric($this->feedback);
891
        $textfielditem = $feedbackgenerator->create_item_textfield($this->feedback);
892
        $feedbackgenerator->create_item_pagebreak($this->feedback);
893
        $labelitem = $feedbackgenerator->create_item_label($this->feedback);
894
        $numericitem2 = $feedbackgenerator->create_item_numeric($this->feedback);
895
 
896
        $pagedata = [
897
            ['name' => $numericitem->typ .'_'. $numericitem->id, 'value' => 5],
898
            ['name' => $textfielditem->typ .'_'. $textfielditem->id, 'value' => 'abc'],
899
        ];
900
        // Process the feedback, there are two pages so the feedback will be unfinished yet.
901
        $result = mod_feedback_external::process_page($this->feedback->id, 0, $pagedata);
902
        $result = external_api::clean_returnvalue(mod_feedback_external::process_page_returns(), $result);
903
        $this->assertFalse($result['completed']);
904
 
905
        // Retrieve the unfinished responses.
906
        $result = mod_feedback_external::get_unfinished_responses($this->feedback->id);
907
        $result = external_api::clean_returnvalue(mod_feedback_external::get_unfinished_responses_returns(), $result);
908
        // Check that ids and responses match.
909
        foreach ($result['responses'] as $r) {
910
            if ($r['item'] == $numericitem->id) {
911
                $this->assertEquals(5, $r['value']);
912
            } else {
913
                $this->assertEquals($textfielditem->id, $r['item']);
914
                $this->assertEquals('abc', $r['value']);
915
            }
916
        }
917
    }
918
 
919
    /**
920
     * Test get_finished_responses.
921
     */
11 efrain 922
    public function test_get_finished_responses(): void {
1 efrain 923
        // Test user with full capabilities.
924
        $this->setUser($this->student);
925
 
926
        // Create a very simple feedback.
927
        $feedbackgenerator = $this->getDataGenerator()->get_plugin_generator('mod_feedback');
928
        $numericitem = $feedbackgenerator->create_item_numeric($this->feedback);
929
        $textfielditem = $feedbackgenerator->create_item_textfield($this->feedback);
930
 
931
        $pagedata = [
932
            ['name' => $numericitem->typ .'_'. $numericitem->id, 'value' => 5],
933
            ['name' => $textfielditem->typ .'_'. $textfielditem->id, 'value' => 'abc'],
934
        ];
935
 
936
        // Process the feedback, there is only one page so the feedback will be completed.
937
        $result = mod_feedback_external::process_page($this->feedback->id, 0, $pagedata);
938
        $result = external_api::clean_returnvalue(mod_feedback_external::process_page_returns(), $result);
939
        $this->assertTrue($result['completed']);
940
 
941
        // Retrieve the responses.
942
        $result = mod_feedback_external::get_finished_responses($this->feedback->id);
943
        $result = external_api::clean_returnvalue(mod_feedback_external::get_finished_responses_returns(), $result);
944
        // Check that ids and responses match.
945
        foreach ($result['responses'] as $r) {
946
            if ($r['item'] == $numericitem->id) {
947
                $this->assertEquals(5, $r['value']);
948
            } else {
949
                $this->assertEquals($textfielditem->id, $r['item']);
950
                $this->assertEquals('abc', $r['value']);
951
            }
952
        }
953
    }
954
 
955
    /**
956
     * Test get_non_respondents (student trying to get this information).
957
     */
11 efrain 958
    public function test_get_non_respondents_no_permissions(): void {
1 efrain 959
        $this->setUser($this->student);
960
        $this->expectException(moodle_exception::class);
961
        mod_feedback_external::get_non_respondents($this->feedback->id);
962
    }
963
 
964
    /**
965
     * Test get_non_respondents from an anonymous feedback.
966
     */
11 efrain 967
    public function test_get_non_respondents_from_anonymous_feedback(): void {
1 efrain 968
        $this->setUser($this->student);
969
        $this->expectException(moodle_exception::class);
970
        $this->expectExceptionMessage(get_string('anonymous', 'feedback'));
971
        mod_feedback_external::get_non_respondents($this->feedback->id);
972
    }
973
 
974
    /**
975
     * Test get_non_respondents.
976
     */
11 efrain 977
    public function test_get_non_respondents(): void {
1 efrain 978
        global $DB;
979
 
980
        // Force non anonymous.
981
        $DB->set_field('feedback', 'anonymous', FEEDBACK_ANONYMOUS_NO, array('id' => $this->feedback->id));
982
 
983
        // Create another student.
984
        $anotherstudent = self::getDataGenerator()->create_user();
985
        $this->getDataGenerator()->enrol_user($anotherstudent->id, $this->course->id, $this->studentrole->id, 'manual');
986
        $this->setUser($anotherstudent);
987
 
988
        // Test user with full capabilities.
989
        $this->setUser($this->student);
990
 
991
        // Create a very simple feedback.
992
        $feedbackgenerator = $this->getDataGenerator()->get_plugin_generator('mod_feedback');
993
        $numericitem = $feedbackgenerator->create_item_numeric($this->feedback);
994
 
995
        $pagedata = [
996
            ['name' => $numericitem->typ .'_'. $numericitem->id, 'value' => 5],
997
        ];
998
 
999
        // Process the feedback, there is only one page so the feedback will be completed.
1000
        $result = mod_feedback_external::process_page($this->feedback->id, 0, $pagedata);
1001
        $result = external_api::clean_returnvalue(mod_feedback_external::process_page_returns(), $result);
1002
        $this->assertTrue($result['completed']);
1003
 
1004
        // Retrieve the non-respondent users.
1005
        $this->setUser($this->teacher);
1006
        $result = mod_feedback_external::get_non_respondents($this->feedback->id);
1007
        $result = external_api::clean_returnvalue(mod_feedback_external::get_non_respondents_returns(), $result);
1008
        $this->assertCount(0, $result['warnings']);
1009
        $this->assertCount(1, $result['users']);
1010
        $this->assertEquals($anotherstudent->id, $result['users'][0]['userid']);
1011
 
1012
        // Create another student.
1013
        $anotherstudent2 = self::getDataGenerator()->create_user();
1014
        $this->getDataGenerator()->enrol_user($anotherstudent2->id, $this->course->id, $this->studentrole->id, 'manual');
1015
        $this->setUser($anotherstudent2);
1016
        $this->setUser($this->teacher);
1017
        $result = mod_feedback_external::get_non_respondents($this->feedback->id);
1018
        $result = external_api::clean_returnvalue(mod_feedback_external::get_non_respondents_returns(), $result);
1019
        $this->assertCount(0, $result['warnings']);
1020
        $this->assertCount(2, $result['users']);
1021
 
1022
        // Test pagination.
1023
        $result = mod_feedback_external::get_non_respondents($this->feedback->id, 0, 'lastaccess', 0, 1);
1024
        $result = external_api::clean_returnvalue(mod_feedback_external::get_non_respondents_returns(), $result);
1025
        $this->assertCount(0, $result['warnings']);
1026
        $this->assertCount(1, $result['users']);
1027
    }
1028
 
1029
    /**
1030
     * Helper function that completes the feedback for two students.
1031
     */
1032
    protected function complete_basic_feedback() {
1033
        global $DB;
1034
 
1035
        $generator = $this->getDataGenerator();
1036
        // Create separated groups.
1037
        $DB->set_field('course', 'groupmode', SEPARATEGROUPS);
1038
        $DB->set_field('course', 'groupmodeforce', 1);
1039
        assign_capability('moodle/site:accessallgroups', CAP_PROHIBIT, $this->teacherrole->id, $this->context);
1040
        accesslib_clear_all_caches_for_unit_testing();
1041
 
1042
        $group1 = $generator->create_group(array('courseid' => $this->course->id));
1043
        $group2 = $generator->create_group(array('courseid' => $this->course->id));
1044
 
1045
        // Create another students.
1046
        $anotherstudent1 = self::getDataGenerator()->create_user();
1047
        $anotherstudent2 = self::getDataGenerator()->create_user();
1048
        $generator->enrol_user($anotherstudent1->id, $this->course->id, $this->studentrole->id, 'manual');
1049
        $generator->enrol_user($anotherstudent2->id, $this->course->id, $this->studentrole->id, 'manual');
1050
 
1051
        $generator->create_group_member(array('groupid' => $group1->id, 'userid' => $this->student->id));
1052
        $generator->create_group_member(array('groupid' => $group1->id, 'userid' => $this->teacher->id));
1053
        $generator->create_group_member(array('groupid' => $group1->id, 'userid' => $anotherstudent1->id));
1054
        $generator->create_group_member(array('groupid' => $group2->id, 'userid' => $anotherstudent2->id));
1055
 
1056
        // Test user with full capabilities.
1057
        $this->setUser($this->student);
1058
 
1059
        // Create a very simple feedback.
1060
        $feedbackgenerator = $generator->get_plugin_generator('mod_feedback');
1061
        $numericitem = $feedbackgenerator->create_item_numeric($this->feedback);
1062
        $textfielditem = $feedbackgenerator->create_item_textfield($this->feedback);
1063
 
1064
        $pagedata = [
1065
            ['name' => $numericitem->typ .'_'. $numericitem->id, 'value' => 5],
1066
            ['name' => $textfielditem->typ .'_'. $textfielditem->id, 'value' => 'abc'],
1067
        ];
1068
 
1069
        // Process the feedback, there is only one page so the feedback will be completed.
1070
        $result = mod_feedback_external::process_page($this->feedback->id, 0, $pagedata);
1071
        $result = external_api::clean_returnvalue(mod_feedback_external::process_page_returns(), $result);
1072
        $this->assertTrue($result['completed']);
1073
 
1074
        $this->setUser($anotherstudent1);
1075
 
1076
        $pagedata = [
1077
            ['name' => $numericitem->typ .'_'. $numericitem->id, 'value' => 10],
1078
            ['name' => $textfielditem->typ .'_'. $textfielditem->id, 'value' => 'def'],
1079
        ];
1080
 
1081
        $result = mod_feedback_external::process_page($this->feedback->id, 0, $pagedata);
1082
        $result = external_api::clean_returnvalue(mod_feedback_external::process_page_returns(), $result);
1083
        $this->assertTrue($result['completed']);
1084
 
1085
        $this->setUser($anotherstudent2);
1086
 
1087
        $pagedata = [
1088
            ['name' => $numericitem->typ .'_'. $numericitem->id, 'value' => 10],
1089
            ['name' => $textfielditem->typ .'_'. $textfielditem->id, 'value' => 'def'],
1090
        ];
1091
 
1092
        $result = mod_feedback_external::process_page($this->feedback->id, 0, $pagedata);
1093
        $result = external_api::clean_returnvalue(mod_feedback_external::process_page_returns(), $result);
1094
        $this->assertTrue($result['completed']);
1095
    }
1096
 
1097
    /**
1098
     * Test get_responses_analysis for anonymous feedback.
1099
     */
11 efrain 1100
    public function test_get_responses_analysis_anonymous(): void {
1 efrain 1101
        self::complete_basic_feedback();
1102
 
1103
        // Retrieve the responses analysis.
1104
        $this->setUser($this->teacher);
1105
        $result = mod_feedback_external::get_responses_analysis($this->feedback->id);
1106
        $result = external_api::clean_returnvalue(mod_feedback_external::get_responses_analysis_returns(), $result);
1107
        $this->assertCount(0, $result['warnings']);
1108
        $this->assertEquals(0, $result['totalattempts']);
1109
        $this->assertEquals(2, $result['totalanonattempts']);   // Only see my groups.
1110
 
1111
        foreach ($result['attempts'] as $attempt) {
1112
            $this->assertEmpty($attempt['userid']); // Is anonymous.
1113
        }
1114
    }
1115
 
1116
    /**
1117
     * Test get_responses_analysis for non-anonymous feedback.
1118
     */
11 efrain 1119
    public function test_get_responses_analysis_non_anonymous(): void {
1 efrain 1120
        global $DB;
1121
 
1122
        // Force non anonymous.
1123
        $DB->set_field('feedback', 'anonymous', FEEDBACK_ANONYMOUS_NO, array('id' => $this->feedback->id));
1124
 
1125
        self::complete_basic_feedback();
1126
        // Retrieve the responses analysis.
1127
        $this->setUser($this->teacher);
1128
        $result = mod_feedback_external::get_responses_analysis($this->feedback->id);
1129
        $result = external_api::clean_returnvalue(mod_feedback_external::get_responses_analysis_returns(), $result);
1130
        $this->assertCount(0, $result['warnings']);
1131
        $this->assertEquals(2, $result['totalattempts']);
1132
        $this->assertEquals(0, $result['totalanonattempts']);   // Only see my groups.
1133
 
1134
        foreach ($result['attempts'] as $attempt) {
1135
            $this->assertNotEmpty($attempt['userid']);  // Is not anonymous.
1136
        }
1137
    }
1138
 
1139
    /**
1140
     * Test get_last_completed for feedback anonymous not completed.
1141
     */
11 efrain 1142
    public function test_get_last_completed_anonymous_not_completed(): void {
1 efrain 1143
        global $DB;
1144
 
1145
        // Force anonymous.
1146
        $DB->set_field('feedback', 'anonymous', FEEDBACK_ANONYMOUS_YES, array('id' => $this->feedback->id));
1147
 
1148
        // Test user with full capabilities that didn't complete the feedback.
1149
        $this->setUser($this->student);
1150
 
1151
        $this->expectExceptionMessage(get_string('anonymous', 'feedback'));
1152
        $this->expectException(moodle_exception::class);
1153
        mod_feedback_external::get_last_completed($this->feedback->id);
1154
    }
1155
 
1156
    /**
1157
     * Test get_last_completed for feedback anonymous and completed.
1158
     */
11 efrain 1159
    public function test_get_last_completed_anonymous_completed(): void {
1 efrain 1160
        global $DB;
1161
 
1162
        // Force anonymous.
1163
        $DB->set_field('feedback', 'anonymous', FEEDBACK_ANONYMOUS_YES, array('id' => $this->feedback->id));
1164
        // Add one completion record..
1165
        $record = [
1166
            'feedback' => $this->feedback->id,
1167
            'userid' => $this->student->id,
1168
            'timemodified' => time() - DAYSECS,
1169
            'random_response' => 0,
1170
            'anonymous_response' => FEEDBACK_ANONYMOUS_YES,
1171
            'courseid' => $this->course->id,
1172
        ];
1173
        $record['id'] = $DB->insert_record('feedback_completed', (object) $record);
1174
 
1175
        // Test user with full capabilities.
1176
        $this->setUser($this->student);
1177
 
1178
        $this->expectExceptionMessage(get_string('anonymous', 'feedback'));
1179
        $this->expectException(moodle_exception::class);
1180
        mod_feedback_external::get_last_completed($this->feedback->id);
1181
    }
1182
 
1183
    /**
1184
     * Test get_last_completed for feedback not anonymous and completed.
1185
     */
11 efrain 1186
    public function test_get_last_completed_not_anonymous_completed(): void {
1 efrain 1187
        global $DB;
1188
 
1189
        // Force non anonymous.
1190
        $DB->set_field('feedback', 'anonymous', FEEDBACK_ANONYMOUS_NO, array('id' => $this->feedback->id));
1191
        // Add one completion record..
1192
        $record = [
1193
            'feedback' => $this->feedback->id,
1194
            'userid' => $this->student->id,
1195
            'timemodified' => time() - DAYSECS,
1196
            'random_response' => 0,
1197
            'anonymous_response' => FEEDBACK_ANONYMOUS_NO,
1198
            'courseid' => $this->course->id,
1199
        ];
1200
        $record['id'] = $DB->insert_record('feedback_completed', (object) $record);
1201
 
1202
        // Test user with full capabilities.
1203
        $this->setUser($this->student);
1204
        $result = mod_feedback_external::get_last_completed($this->feedback->id);
1205
        $result = external_api::clean_returnvalue(mod_feedback_external::get_last_completed_returns(), $result);
1206
        $this->assertEquals($record, $result['completed']);
1207
    }
1208
 
1209
    /**
1210
     * Test get_last_completed for feedback not anonymous and not completed.
1211
     */
11 efrain 1212
    public function test_get_last_completed_not_anonymous_not_completed(): void {
1 efrain 1213
        global $DB;
1214
 
1215
        // Force anonymous.
1216
        $DB->set_field('feedback', 'anonymous', FEEDBACK_ANONYMOUS_NO, array('id' => $this->feedback->id));
1217
 
1218
        // Test user with full capabilities that didn't complete the feedback.
1219
        $this->setUser($this->student);
1220
 
1221
        $this->expectExceptionMessage(get_string('not_completed_yet', 'feedback'));
1222
        $this->expectException(moodle_exception::class);
1223
        mod_feedback_external::get_last_completed($this->feedback->id);
1224
    }
1225
 
1226
    /**
1227
     * Test get_feedback_access_information for site feedback.
1228
     */
11 efrain 1229
    public function test_get_feedback_access_information_for_site_feedback(): void {
1 efrain 1230
 
1231
        $sitefeedback = $this->getDataGenerator()->create_module('feedback', array('course' => SITEID));
1232
        $this->setUser($this->student);
1233
        // Access the site feedback via the site activity.
1234
        $result = mod_feedback_external::get_feedback_access_information($sitefeedback->id);
1235
        $result = external_api::clean_returnvalue(mod_feedback_external::get_feedback_access_information_returns(), $result);
1236
        $this->assertTrue($result['cancomplete']);
1237
        $this->assertTrue($result['cansubmit']);
1238
 
1239
        // Access the site feedback via course where I'm enrolled.
1240
        $result = mod_feedback_external::get_feedback_access_information($sitefeedback->id, $this->course->id);
1241
        $result = external_api::clean_returnvalue(mod_feedback_external::get_feedback_access_information_returns(), $result);
1242
        $this->assertTrue($result['cancomplete']);
1243
        $this->assertTrue($result['cansubmit']);
1244
 
1245
        // Access the site feedback via course where I'm not enrolled.
1246
        $othercourse = $this->getDataGenerator()->create_course();
1247
 
1248
        $this->expectException(moodle_exception::class);
1249
        mod_feedback_external::get_feedback_access_information($sitefeedback->id, $othercourse->id);
1250
    }
1251
 
1252
    /**
1253
     * Test get_feedback_access_information for site feedback mapped.
1254
     */
11 efrain 1255
    public function test_get_feedback_access_information_for_site_feedback_mapped(): void {
1 efrain 1256
        global $DB;
1257
 
1258
        $sitefeedback = $this->getDataGenerator()->create_module('feedback', array('course' => SITEID));
1259
        $this->setUser($this->student);
1260
        $DB->insert_record('feedback_sitecourse_map', array('feedbackid' => $sitefeedback->id, 'courseid' => $this->course->id));
1261
 
1262
        // Access the site feedback via course where I'm enrolled and mapped.
1263
        $result = mod_feedback_external::get_feedback_access_information($sitefeedback->id, $this->course->id);
1264
        $result = external_api::clean_returnvalue(mod_feedback_external::get_feedback_access_information_returns(), $result);
1265
        $this->assertTrue($result['cancomplete']);
1266
        $this->assertTrue($result['cansubmit']);
1267
 
1268
        // Access the site feedback via course where I'm enrolled but not mapped.
1269
        $othercourse = $this->getDataGenerator()->create_course();
1270
        $this->getDataGenerator()->enrol_user($this->student->id, $othercourse->id, $this->studentrole->id, 'manual');
1271
 
1272
        $this->expectException(moodle_exception::class);
1273
        $this->expectExceptionMessage(get_string('cannotaccess', 'mod_feedback'));
1274
        mod_feedback_external::get_feedback_access_information($sitefeedback->id, $othercourse->id);
1275
    }
1276
}