Proyectos de Subversion Moodle

Rev

Rev 11 | | Comparar con el anterior | Ultima modificación | Ver Log |

Rev Autor Línea Nro. Línea
1 efrain 1
<?php
2
// This file is part of Moodle - http://moodle.org/
3
//
4
// Moodle is free software: you can redistribute it and/or modify
5
// it under the terms of the GNU General Public License as published by
6
// the Free Software Foundation, either version 3 of the License, or
7
// (at your option) any later version.
8
//
9
// Moodle is distributed in the hope that it will be useful,
10
// but WITHOUT ANY WARRANTY; without even the implied warranty of
11
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
12
// GNU General Public License for more details.
13
//
14
// You should have received a copy of the GNU General Public License
15
// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
16
 
17
namespace core_grades;
18
 
19
use grade_item;
20
 
21
/**
22
 * Tests grade_import_lib functions.
23
 *
24
 * @package   core_grades
25
 * @category  test
26
 * @copyright 2015 Adrian Greeve <adrian@moodle.com>
27
 * @license   http://www.gnu.org/copyleft/gpl.html GNU Public License
28
 */
1441 ariadna 29
final class importlib_test extends \advanced_testcase {
1 efrain 30
 
31
    /**
32
     * Load required test libraries
33
     */
34
    public static function setUpBeforeClass(): void {
35
        global $CFG;
36
        require_once("{$CFG->dirroot}/grade/import/lib.php");
1441 ariadna 37
        parent::setUpBeforeClass();
1 efrain 38
    }
39
 
40
    /**
41
     * Import grades into 'grade_import_values' table. This is done differently in the various import plugins,
42
     * so there is no direct API to call.
43
     *
44
     * @param array $data Information to be inserted into the table.
45
     * @return int The insert ID of the sql statement.
46
     */
47
    private function import_grades($data) {
48
        global $DB, $USER;
49
        $graderecord = new \stdClass();
50
        $graderecord->importcode = $data['importcode'];
51
        if (isset($data['itemid'])) {
52
            $graderecord->itemid = $data['itemid'];
53
        }
54
        $graderecord->userid = $data['userid'];
55
        if (isset($data['importer'])) {
56
            $graderecord->importer = $data['importer'];
57
        } else {
58
            $graderecord->importer = $USER->id;
59
        }
60
        if (isset($data['finalgrade'])) {
61
            $graderecord->finalgrade = $data['finalgrade'];
62
        } else {
63
            $graderecord->finalgrade = rand(0, 100);
64
        }
65
        if (isset($data['feedback'])) {
66
            $graderecord->feedback = $data['feedback'];
67
        }
68
        if (isset($data['importonlyfeedback'])) {
69
            $graderecord->importonlyfeedback = $data['importonlyfeedback'];
70
        } else {
71
            $graderecord->importonlyfeedback = false;
72
        }
73
        if (isset($data['newgradeitem'])) {
74
            $graderecord->newgradeitem = $data['newgradeitem'];
75
        }
76
        return $DB->insert_record('grade_import_values', $graderecord);
77
    }
78
 
79
    /**
80
     * Tests for importing grades from an external source.
81
     *
82
     * @covers ::grade_import_commit
83
     */
11 efrain 84
    public function test_grade_import_commit(): void {
1 efrain 85
        global $USER, $DB, $CFG;
86
        $this->resetAfterTest();
87
 
88
        $importcode = get_new_importcode();
89
        $user1 = $this->getDataGenerator()->create_user();
90
        $user2 = $this->getDataGenerator()->create_user();
91
 
92
        $course = $this->getDataGenerator()->create_course();
93
        $assign = $this->getDataGenerator()->create_module('assign', array('course' => $course->id));
94
        $itemname = $assign->name;
95
        $modulecontext = \context_module::instance($assign->cmid);
96
        // The generator returns a dummy object, lets get the real assign object.
97
        $assign = new \assign($modulecontext, false, false);
98
        $cm = $assign->get_course_module();
99
 
100
        // Enrol users in the course.
101
        $this->getDataGenerator()->enrol_user($user1->id, $course->id);
102
        $this->getDataGenerator()->enrol_user($user2->id, $course->id);
103
 
104
        // Enter a new grade into an existing grade item.
105
        $gradeitem = \grade_item::fetch(array('courseid' => $course->id, 'itemtype' => 'mod'));
106
 
107
        // Keep this value around for a test further down.
108
        $originalgrade = 55;
109
        $this->import_grades(array(
110
            'importcode' => $importcode,
111
            'itemid' => $gradeitem->id,
112
            'userid' => $user1->id,
113
            'finalgrade' => $originalgrade
114
        ));
115
 
116
        $status = grade_import_commit($course->id, $importcode, false, false);
117
        $this->assertTrue($status);
118
 
119
        // Get imported grade_grade.
120
        $gradegrade = \grade_grade::fetch(array('itemid' => $gradeitem->id, 'userid' => $user1->id));
121
        $this->assertEquals($originalgrade, $gradegrade->finalgrade);
122
        // Overriden field will be a timestamp and will evaluate out to true.
123
        $this->assertTrue($gradegrade->is_overridden());
124
 
125
        // Create a new grade item and import into that.
126
        $importcode = get_new_importcode();
127
        $record = new \stdClass();
128
        $record->itemname = 'New grade item';
129
        $record->importcode = $importcode;
130
        $record->importer = $USER->id;
131
        $insertid = $DB->insert_record('grade_import_newitem', $record);
132
 
133
        $finalgrade = 75;
134
        $this->import_grades(array(
135
            'importcode' => $importcode,
136
            'userid' => $user1->id,
137
            'finalgrade' => $finalgrade,
138
            'newgradeitem' => $insertid
139
        ));
140
 
141
        $status = grade_import_commit($course->id, $importcode, false, false);
142
        $this->assertTrue($status);
143
        // Check that we have a new \grade_item.
144
        $gradeitem = \grade_item::fetch(array('courseid' => $course->id, 'itemtype' => 'manual'));
145
        $this->assertEquals($record->itemname, $gradeitem->itemname);
146
        // Grades were imported.
147
        $gradegrade = \grade_grade::fetch(array('itemid' => $gradeitem->id, 'userid' => $user1->id));
148
        $this->assertEquals($finalgrade, $gradegrade->finalgrade);
149
        // As this is a new item the grade has not been overridden.
150
        $this->assertFalse($gradegrade->is_overridden());
151
 
152
        // Import feedback only.
153
        $importcode = get_new_importcode();
154
        $gradeitem = \grade_item::fetch(array('courseid' => $course->id, 'itemtype' => 'mod'));
155
 
156
        $originalfeedback = 'feedback can be useful';
157
        $this->import_grades(array(
158
            'importcode' => $importcode,
159
            'userid' => $user1->id,
160
            'itemid' => $gradeitem->id,
161
            'feedback' => $originalfeedback,
162
            'importonlyfeedback' => true
163
        ));
164
 
165
        $status = grade_import_commit($course->id, $importcode, true, false);
166
        $this->assertTrue($status);
167
        $gradegrade = \grade_grade::fetch(array('itemid' => $gradeitem->id, 'userid' => $user1->id));
168
        // The final grade should be the same as the first record further up. We are only altering the feedback.
169
        $this->assertEquals($originalgrade, $gradegrade->finalgrade);
170
        $this->assertTrue($gradegrade->is_overridden());
171
 
172
        // Import grades only.
173
        $importcode = get_new_importcode();
174
        $gradeitem = \grade_item::fetch(array('courseid' => $course->id, 'itemtype' => 'mod'));
175
 
176
        $finalgrade = 60;
177
        $this->import_grades(array(
178
            'importcode' => $importcode,
179
            'userid' => $user1->id,
180
            'itemid' => $gradeitem->id,
181
            'finalgrade' => $finalgrade,
182
            'feedback' => 'feedback can still be useful'
183
        ));
184
 
185
        $status = grade_import_commit($course->id, $importcode, false, false);
186
        $this->assertTrue($status);
187
        $gradegrade = \grade_grade::fetch(array('itemid' => $gradeitem->id, 'userid' => $user1->id));
188
        $this->assertEquals($finalgrade, $gradegrade->finalgrade);
189
        // The final feedback should not have changed.
190
        $this->assertEquals($originalfeedback, $gradegrade->feedback);
191
        $this->assertTrue($gradegrade->is_overridden());
192
 
193
        // Check that printing of import status is correct.
194
        $importcode = get_new_importcode();
195
        $gradeitem = \grade_item::fetch(array('courseid' => $course->id, 'itemtype' => 'mod'));
196
 
197
        $this->import_grades(array(
198
            'importcode' => $importcode,
199
            'userid' => $user1->id,
200
            'itemid' => $gradeitem->id
201
        ));
202
 
203
        ob_start();
204
        $status = grade_import_commit($course->id, $importcode);
205
        $output = ob_get_contents();
206
        ob_end_clean();
207
        $this->assertTrue($status);
208
        $this->assertStringContainsString("++ Grade import success ++", $output);
209
    }
210
 
211
    /**
212
     * Test grade import commit for users who aren't enrolled on the target course
213
     *
214
     * @covers ::grade_import_commit
215
     */
216
    public function test_grade_import_commit_unenrolled_user(): void {
217
        $this->resetAfterTest();
218
 
219
        $course = $this->getDataGenerator()->create_course();
220
        $assign = $this->getDataGenerator()->create_module('assign', ['course' => $course->id]);
221
        $user = $this->getDataGenerator()->create_user(['firstname' => 'Lionel', 'lastname' => 'Doe']);
222
 
223
        // Enter a new grade into an existing grade item.
224
        $gradeitem = grade_item::fetch(['courseid' => $course->id, 'itemtype' => 'mod']);
225
 
226
        $importcode = get_new_importcode();
227
        $this->import_grades([
228
            'importcode' => $importcode,
229
            'itemid' => $gradeitem->id,
230
            'userid' => $user->id,
231
            'finalgrade' => 10,
232
        ]);
233
 
234
        ob_start();
235
        $status = grade_import_commit($course->id, $importcode);
236
        $output = ob_get_contents();
237
        ob_end_clean();
238
 
239
        // Assert commit succeeded and we didn't receive debugging about lack of name fields.
240
        $this->assertTrue($status);
241
        $this->assertStringContainsString('This import included the following grades for users not currently' .
242
            ' enrolled in this course', $output);
243
        $this->assertStringContainsString('User ' . fullname($user), $output);
244
        $this->assertDebuggingNotCalled();
245
    }
246
 
247
    /**
248
     * Test retrieving users included in impoty who aren't enrolled on the target course
249
     *
250
     * @covers ::get_unenrolled_users_in_import
251
     */
252
    public function test_get_unenrolled_users_in_import(): void {
253
        $this->resetAfterTest();
254
 
255
        $course = $this->getDataGenerator()->create_course();
256
        $assign = $this->getDataGenerator()->create_module('assign', ['course' => $course->id, 'idnumber' => 'gid101']);
257
        $user = $this->getDataGenerator()->create_user(['idnumber' => 'uid101']);
258
 
259
        // Enter a new grade into an existing grade item.
260
        $gradeitem = grade_item::fetch(['courseid' => $course->id, 'itemtype' => 'mod']);
261
 
262
        $importcode = get_new_importcode();
263
        $importgradeid = $this->import_grades([
264
            'importcode' => $importcode,
265
            'itemid' => $gradeitem->id,
266
            'userid' => $user->id,
267
            'finalgrade' => 10,
268
        ]);
269
 
270
        $unenrolledusers = get_unenrolled_users_in_import($importcode, $course->id);
271
        $this->assertCount(1, $unenrolledusers);
272
 
273
        $unenrolleduser = reset($unenrolledusers);
274
        $this->assertEquals((object) [
275
            'id' => $importgradeid,
276
            'firstnamephonetic' => $user->firstnamephonetic,
277
            'lastnamephonetic' => $user->lastnamephonetic,
278
            'middlename' => $user->middlename,
279
            'alternatename' => $user->alternatename,
280
            'firstname' => $user->firstname,
281
            'lastname' => $user->lastname,
282
            'useridnumber' => 'uid101',
283
            'gradeidnumber' => 'gid101',
284
        ], $unenrolleduser);
285
    }
286
}